Commit Graph

83 Commits

Author SHA1 Message Date
Gijs Kruitbosch
94e799935c Bug 1880899 - add lint rule that prevents adding more browser.js globals, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D202804
2024-03-16 15:14:07 +00:00
Mark Banner
0a0c3c6972 Bug 1884623 - Cleanup jsm references in ESLint files. r=mossop,devtools-reviewers,omc-reviewers,ochameau,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204180
2024-03-11 15:26:27 +00:00
Mark Banner
e012a72f1c Bug 1878848 - Remove ESLint support for .jsm.js extensions. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D200771
2024-02-06 13:32:52 +00:00
Gregory Pappas
8e0ae3e9ae Bug 1872922 - Replace last few uses of XPCOMUtils.defineLazyGetter with ChromeUtils.defineLazyGetter and add linter error for XPCOMUtils.defineLazyGetter r=extension-reviewers,credential-management-reviewers,devtools-reviewers,Standard8,arai,robwu,Gijs,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D198677
2024-01-17 15:54:00 +00:00
Gijs Kruitbosch
9547bd9ce0 Bug 1780071 - add eslint rule for misuse of assignments or conditions inside ok(), r=linter-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D198593
2024-01-17 15:04:34 +00:00
Mark Banner
220a28fd3e Bug 1872674 - Add an ESLint rule to reject new uses of Console.sys.mjs/Log.sys.mjs. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D197504
2024-01-16 13:37:07 +00:00
ogiorgis
00d806ae5e Bug 1749473 - fix quotes in js code-block r=sylvestre,firefox-source-docs-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D196076
2023-12-11 17:42:34 +00:00
Mark Banner
8d310687e0 Bug 1858148 - Change ESLint rule reject-importGlobalProperties to reject all imports in sjs files. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D190760
2023-11-04 09:29:27 +00:00
Gijs Kruitbosch
f6a49dc94e Bug 1790354 - stop using individual inclusions for toctree by moving all eslint rules things to a subdir, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D192213
2023-10-30 15:29:47 +00:00
Gijs Kruitbosch
27a249fb7d Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-30 15:29:47 +00:00
Cristian Tuns
1aaded69b3 Backed out changeset c66fc23f71d5 (bug 1790354) for causing doc-generate failures. CLOSED TREE 2023-10-27 13:06:04 -04:00
Gijs Kruitbosch
253e6660f0 Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-27 15:02:09 +00:00
Mark Banner
86632e686f Bug 1860427 - Add a new environment to ESLint for testharness.js and automatically use it for html files including the harness. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191581
2023-10-23 15:37:18 +00:00
Mark Banner
3fc24054c0 Bug 1774888 - Remove XPCOMUtils.defineLazyModuleGetter. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189722
2023-10-02 09:48:01 +00:00
Mark Banner
781ccaba98 Bug 1854948 - Remove support for Cu.import and XPCOMUtils.defineLazyModuleGetter from most of ESLint. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D189132
2023-09-25 14:26:43 +00:00
Tooru Fujisawa
599bc39f65 Bug 1843797 - Add ESLint rule to reject ChromeUtils.import. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D183696
2023-07-31 21:03:44 +00:00
Barret Rennie
54cd87cca0 Bug 1776480 - Remove OS.File et al. r=Gijs,webidl,smaug
This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543
2023-05-12 18:34:28 +00:00
Sandor Molnar
f257c0e512 Backed out changeset 987d013caf11 (bug 1776480) for causing xpc failures in toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js CLOSED TREE 2023-05-11 22:36:59 +03:00
Barret Rennie
2d861190b5 Bug 1776480 - Remove OS.File et al. r=Gijs,webidl,smaug
This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543
2023-05-11 17:49:27 +00:00
Norisz Fay
7c0cf07847 Backed out changeset 3d766d94945d (bug 1776480) for causing multiple xpcshell and bc failures CLOSED TREE 2023-04-28 06:55:03 +03:00
Barret Rennie
947671cb5a Bug 1776480 - Remove OS.File et al. r=Gijs
This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543
2023-04-28 02:35:13 +00:00
Butkovits Atila
90be13a92b Backed out changeset fc8a2b80e9f6 (bug 1776480) for causing Gecko Decision bustage. CLOSED TREE 2023-04-28 04:31:36 +03:00
Barret Rennie
a3f5bdb54c Bug 1776480 - Remove OS.File et al. r=Gijs
This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543
2023-04-28 01:10:56 +00:00
Tooru Fujisawa
413511fdbe Bug 1827163 - Support ChromeUtils.defineLazyGetter in ESLint rules. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175081
2023-04-14 00:18:11 +00:00
Gijs Kruitbosch
c5fb0c246a Bug 1795255 - add no-redeclare-with-import-autofix eslint rule to deal with duplicate imports in tests, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D166177
2023-01-31 11:48:40 +00:00
Sylvestre Ledru
61ec47700d Bug 1806331 - doc: use ChromeUtils.importESM instead of ChromeUtils.importESModule r=Standard8 DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165815
2023-01-03 18:47:59 +00:00
Mark Banner
e4276619d3 Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
2022-11-29 23:07:42 +00:00
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures.
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
2022-11-30 00:28:42 +02:00
Mark Banner
2f30acd85c Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
2022-11-29 21:21:28 +00:00
Mark Banner
17403914cb Bug 1795880 - Add an ESLint rule to enforce using static imports where possible. r=arai,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D160131
2022-10-26 09:37:46 +00:00
Mark Banner
38be40d5b9 Bug 1795322 - Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D160036
2022-10-26 08:06:37 +00:00
Csoregi Natalia
5edbe31601 Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
Mark Banner
1ad6baaea2 Bug 1795322 - Update toolkit modules references in remaining places. r=mossop,zeid,geckoview-reviewers,calu
Differential Revision: https://phabricator.services.mozilla.com/D160036
2022-10-25 19:49:28 +00:00
Simon Friedberger
4d45a5962c Bug 1788671 - Document how to add Services to eslint. r=Standard8 DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D158753
2022-10-07 18:11:17 +00:00
Mathew Hodson
52287e7f89 Bug 1776578 - Make no-addtask-setup eslint rule check for init tasks. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D150333
2022-09-26 13:58:49 +00:00
Alexandre Poirot
90ddca703f Bug 1791828 - [devtools] Remove eslint support for DevTools's lazyImporter. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158004
2022-09-26 10:48:05 +00:00
Mark Banner
dd194ee451 Bug 1479515 - Add an ESLint rule to check for valid property accesses on Services. r=Gijs
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156426
2022-09-12 16:38:44 +00:00
Mark Banner
74f27058b3 Bug 1479515 - Extend the ESLint rule for checking Ci properties to check for unknown interfaces as well. r=Gijs,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156425
2022-09-12 16:38:44 +00:00
Mark Banner
418607ec92 Bug 1479515 - Add an ESLint rule to check for unknown property accesses on Ci. r=Gijs
This is manually run and requires a full build. MOZ_OBJDIR needs to be set to point to the object directory.

Differential Revision: https://phabricator.services.mozilla.com/D156424
2022-09-12 16:38:43 +00:00
Kagami Sascha Rosylight
a37cf7833d Bug 1695435 - Part 2: Add more words to the chrome script heuristic in use-isInstance r=preferences-reviewers,Gijs,webdriver-reviewers,whimboo,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D110932
2022-08-24 22:47:42 +00:00
Kagami Sascha Rosylight
a88716cc34 Bug 1695435 - Part 1: Use isInstance in XUL files r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D154841
2022-08-22 18:34:44 +00:00
Tooru Fujisawa
5892446859 Bug 1779988 - Part 2: Add ESLint rule that rejects multiple ChromeUtils.defineESModuleGetters call on the same object. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152880
2022-07-28 00:54:20 +00:00
Tooru Fujisawa
11e740e6e6 Bug 1780543 - Part 11: Update document for environment. r=Standard8
Depends on D152648

Differential Revision: https://phabricator.services.mozilla.com/D152649
2022-07-26 02:46:32 +00:00
Mark Banner
f9d637e4c5 Bug 1779989 - Explicitly disallow ES modules in ESLint import-globals-from statements. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D152002
2022-07-19 05:57:15 +00:00
Tooru Fujisawa
cda8cbecfe Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D150903
2022-07-11 12:41:54 +00:00
Mark Banner
76af8b0f69 Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D151083
2022-07-06 08:35:59 +00:00
Tooru Fujisawa
e1538f8276 Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop
Depends on D150935

Differential Revision: https://phabricator.services.mozilla.com/D150936
2022-07-05 01:01:35 +00:00
Mark Banner
f733d566c8 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag
Differential Revision: https://phabricator.services.mozilla.com/D150353
2022-06-29 22:37:57 +00:00
Kagami Sascha Rosylight
e29a0027f8 Bug 1773740 - Part 3: Cover js files including ChromeUtils r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D148938
2022-06-27 20:31:33 +00:00
Tooru Fujisawa
f141eb6bc3 Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D149867
2022-06-24 11:03:53 +00:00