Norisz Fay
fe5c1d2b6e
Backed out changeset 3d3e86a6d3fc (bug 1908908) for causing multiple failures CLOSED TREE
2024-08-20 01:50:37 +03:00
Nikki Sharpley
875fb65856
Bug 1908908 - Preserve sidebar width on close in session store. r=sidebar-reviewers,sessionstore-reviewers,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D219238
2024-08-19 20:53:47 +00:00
Noemi Erli
add41c1a33
Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE
2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba
Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7
Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures
2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26
Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15
Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE
2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2
Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b
Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE
2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121
Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 18:32:38 +00:00
Sarah Clements
7ea40f53e4
Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
...
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Joel Maher
d70349f2c5
Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Jonathan Sudiaman
fec725412b
Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements
...
The toggle was there to begin with, but this commit actually gets it working to spec.
Differential Revision: https://phabricator.services.mozilla.com/D214181
2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908
Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D212285
2024-06-27 19:34:08 +00:00
Emilio Cobos Álvarez
f16ff34d47
Bug 1902315 - Remove CHROME_WINDOW_{LOWERED,RAISED}. r=arai,extension-reviewers,sessionstore-reviewers,dao,zombie
...
These did nothing at the OS level on most OSes (see previous patch), and
were only used on tests, so just remove them.
Note that these were different from the alwaysontop feature, which
remains and is used for stuff like picture-in-picture.
Differential Revision: https://phabricator.services.mozilla.com/D214091
2024-06-19 07:47:37 +00:00
Dão Gottwald
5d53c6acf7
Bug 1900002 - Move tabbrowser tests into a browser/ folder. r=frontend-codestyle-reviewers,dwalker
...
See https://phabricator.services.mozilla.com/D211509#inline-1171035
Differential Revision: https://phabricator.services.mozilla.com/D212250
2024-06-04 13:20:52 +00:00
Cosmin Sabou
945f1508e6
Bug 1848488 - Disable browser_should_restore_tab.js on linux 18.04 debug for frequent failures. r=intermittent-reviewers,jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D211658
2024-05-26 03:13:27 +00:00
Dão Gottwald
c4167a3cc6
Bug 1898197 - Move tabs tests into browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D211190
2024-05-23 12:54:24 +00:00
Nikki Sharpley
b43107b445
Bug 1885894 - Remove sidebar persistence from XULStore r=sessionstore-reviewers,backup-reviewers,sidebar-reviewers,Gijs,mconley,sfoster,sclements
...
Since we are moving away from XUL for the revamped sidebar, remove persistence off of XULstore.
For now, this involves moving persistence of "sidebar-command" and "positionend" to SessionStore.
A follow up bug 1892033 for moving the style attribute to SessionStore has been filed. This is slightly more involved,
hence the separate patch.
Differential Revision: https://phabricator.services.mozilla.com/D207048
2024-05-06 15:11:20 +00:00
Joel Maher
bedfa83025
Bug 1859204 - adjust linux asan browser-chrome tests to be more balanced, skip extremely long tests, run on xlarge instances. r=aryx,sessionstore-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D206822
2024-04-09 19:43:23 +00:00
Yi Xiong Wong
bef11a2dc2
Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur
...
Differential Revision: https://phabricator.services.mozilla.com/D206197
2024-04-08 17:21:01 +00:00
Sam Foster
e3765221a6
Bug 1886659 - Remove the FX_SESSION_RESTORE_CLOSED_TABS_NOT_SAVED probe. r=sessionstore-reviewers,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D206717
2024-04-05 22:13:48 +00:00
Nika Layzell
690b246be7
Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
...
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.
The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.
Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-05 16:42:51 +00:00
Nika Layzell
c3d35082ee
Bug 1886892 - Part 2: Remove non-SHIP cases from SessionStore tests, r=sessionstore-reviewers,sfoster
...
These cases will no longer be run, as SHIP is always on for desktop firefox, so
can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D205480
2024-04-05 16:42:51 +00:00
Yi Xiong Wong
3df27d805a
Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer
...
Differential Revision: https://phabricator.services.mozilla.com/D205529
2024-04-03 10:32:27 +00:00
Butkovits Atila
8311343a9f
Backed out 3 changesets (bug 1887029, bug 1886892) for causing failures at browser_all_files_referenced.js. CLOSED TREE
...
Backed out changeset 07f554ea4869 (bug 1887029)
Backed out changeset daa5f2355675 (bug 1886892)
Backed out changeset 389163cbd649 (bug 1886892)
2024-04-01 21:50:42 +03:00
Nika Layzell
c261303179
Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
...
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.
The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.
Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-01 17:11:23 +00:00
Nika Layzell
96ca20b192
Bug 1886892 - Part 2: Remove non-SHIP cases from SessionStore tests, r=sessionstore-reviewers,sfoster
...
These cases will no longer be run, as SHIP is always on for desktop firefox, so
can be removed.
Differential Revision: https://phabricator.services.mozilla.com/D205480
2024-04-01 17:11:22 +00:00
Dave Townsend
d6abef5db6
Bug 1864896: Autofix unused function arguments (browser/components/sessionstore). r=sessionstore-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D202953
2024-03-19 09:36:34 +00:00
Sarah Clements
d53556f858
Bug 1861555 - Change browser.sessionstore.max_windows_undo limit to 5 r=sessionstore-reviewers,sfoster,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D201230
2024-03-18 15:52:31 +00:00
Emilio Cobos Álvarez
1c20c25eda
Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
...
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.
Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
Marco Bonardo
f0bd48ca5b
Bug 1876743 - Enable cross-container Tab Search in Nightly. r=mseibert
...
Fixes code to properly run tests with the feature enabled.
Fixes code not considering payload.userContextId is set to -1 for private
windows.
Fixes a bug in the _openTabs Map where multiple open tabs to the same url are
not properly counted.
Differential Revision: https://phabricator.services.mozilla.com/D200036
2024-02-07 09:29:32 +00:00
Tom Marble
a42a175006
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c
Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE
2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
Joel Maher
3662d84cd4
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96
Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures.
2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Mark Banner
e2e80f646d
Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D197489
2024-01-05 09:22:34 +00:00
Tom Marble
4b00b49e47
Bug 1859908 - convert .ini manifests to .toml: batch 20 marionette.ini r=jmaher,webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,bytesized,kershaw,whimboo,dao,jesup,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D197206
2024-01-02 15:31:51 +00:00
Sarah Clements
090c1c7036
Bug 1868526 - Add event listener and promise for window resize r=sfoster,sessionstore-reviewers
...
* Update test_restore_manually marionette test to account for intermittent failure on linux
Differential Revision: https://phabricator.services.mozilla.com/D196426
2023-12-19 12:17:31 +00:00
Sarah Clements
e761c059e2
Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao
...
* add new marionette test
Differential Revision: https://phabricator.services.mozilla.com/D195006
2023-12-05 10:54:20 +00:00
Noemi Erli
8b8bc7d73b
Backed out changeset e1a0d895f3a9 (bug 1863692) for causing failures in test_restore_manually.py
2023-12-04 14:52:24 +02:00
Sarah Clements
f32c50299f
Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao
...
* add new marionette test
Differential Revision: https://phabricator.services.mozilla.com/D195006
2023-12-04 11:28:16 +00:00
Mark Banner
537f7b6e1b
Bug 1866720 - Clean up more imports to import ES modules directly. r=arai,extension-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,dao,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D194723
2023-11-29 10:00:27 +00:00
Sarah Clements
caa49c9563
Bug 1848459 - add telemetry to count closed tabs lost in session restore r=sfoster,sessionstore-reviewers
...
* Add histogram to sessionrestore code to count how often and the number of
closed tabs that aren't saved on window close due to no open saveable tabs
* Add test coverage
Differential Revision: https://phabricator.services.mozilla.com/D193055
2023-11-23 13:38:06 +00:00
Anna Yeddi
8c5259f5e5
Bug 1864751 - Pt.2. Remove fail-if notations for a11y_checks of one-off-items in Search and Address Bar and Session Restore. r=adw,Jamie,sessionstore-reviewers,sclements
...
With the AccessibilityUtils tests updated in D193591 to pass a11y_checks for for keyboard focusable URL bar's `.searchbar-engine-one-off-item` buttons and `.urlbarView-row-inner` results options that are purposefully made focusable with arrow keys only (instead of a Tab that would create more tiring, cumbersome experience navigating Awesomebar for keyboard-only users), we could now remove the `fail-if` notations from a series of tests that were previously failing. Also, there are 12 tests that would also be affected, but they have other elements that are throwing warning or failing a11y_checks besides the one-off controls, thus we'd be keeping them to expect to fail until these items are resolved separately.
These tests were `fail-if`ed by bug 1854660 and bug 1854528, before the investigation in the meta bug 1854661 and bug 1854529.
Differential Revision: https://phabricator.services.mozilla.com/D193849
2023-11-21 18:42:51 +00:00
Joel Maher
33fa84a382
Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Cosmin Sabou
0d51f8165a
Backed out changeset 0d228f1cfc6f (bug 1848459) for failures on browser_closed_tabs_closed_windows. CLOSED TREE
2023-11-21 17:05:42 +02:00