Niklas Baumgardner
0e39bf8f0c
Bug 1894516 - Make screenshots face focusable via the keyboard. r=sfoster,desktop-theme-reviewers,fluent-reviewers,bolsson,ayeddi
...
Differential Revision: https://phabricator.services.mozilla.com/D213100
2024-07-29 16:59:14 +00:00
Norisz Fay
57a529f668
Backed out changeset 41d7f0b670ae (bug 1894516) for causing bc failures on browser_screenshots_focus_test.js CLOSED TREE
2024-07-25 23:50:34 +03:00
Niklas Baumgardner
68f4030f56
Bug 1894516 - Make screenshots face focusable via the keyboard. r=sfoster,desktop-theme-reviewers,fluent-reviewers,bolsson,ayeddi
...
Differential Revision: https://phabricator.services.mozilla.com/D213100
2024-07-25 14:32:27 +00:00
Niklas Baumgardner
e0f484f1b4
Bug 1893680 - Offset screenshots overlay when scrollMin is negative. r=sfoster,desktop-theme-reviewers,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D208769
2024-05-04 19:41:59 +00:00
Niklas Baumgardner
63c3e2d93a
Bug 1873862 - Add border to screenshots selection size text. r=sfoster,kcochrane,desktop-theme-reviewers,jules
...
Differential Revision: https://phabricator.services.mozilla.com/D208408
2024-04-26 18:48:15 +00:00
Anna Yeddi
0a5285917b
Bug 1890802 - Update overlay.css in Screenshots to use forced-colors instead of prefers-contrast where appropriate. r=niklas,morgan,desktop-theme-reviewers,dao
...
As part of the [HCM and Increased Contrast Support in FX project](https://docs.google.com/document/d/1x37hxRrP9B2c3luy7sz748PCuVygvD3REsluQRQpfYE/edit?usp=sharing ), the Accessibility team is auditing existing `prefers-contrast` media query blocks in mozilla-central. For each block with `prefers-contrast` media we want to convert it to `forced-colors` where appropriate.
Refer to the [bug 1877780 #c0](https://bugzilla.mozilla.org/show_bug.cgi?id=1877780#c0 ) for more information about the project.
Differential Revision: https://phabricator.services.mozilla.com/D207468
2024-04-19 16:56:04 +00:00
Niklas Baumgardner
1abddd1c95
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-03 23:51:56 +00:00
Cristian Tuns
83896edc65
Backed out changeset d41d18cecc78 (bug 1864038) for causing bc failures in browser_screenshots_drag_scroll_test.js CLOSED TREE
2024-04-02 12:41:01 -04:00
Niklas Baumgardner
c7874fdeb6
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-02 15:53:57 +00:00
Norisz Fay
61257b3d08
Backed out changeset 13111643fbf4 (bug 1864038) for causing bc failures on browser_screenshots_drag_scroll_test.js CLOSED TREE
2024-04-02 05:04:20 +03:00
Niklas Baumgardner
70450dd2d1
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 22:33:12 +00:00
Narcis Beleuzu
8e1286070a
Backed out changeset 4bcd94d558a6 (bug 1864038) for bc failure on browser_screenshots_drag_scroll_test.js
2024-04-01 17:29:08 +03:00
Niklas Baumgardner
9be70cc492
Bug 1864038 - Add keyboard shortcuts for screenshots overlay. r=sfoster,fluent-reviewers,bolsson,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D193847
2024-04-01 13:51:16 +00:00
Niklas Baumgardner
fff104a363
Bug 1878121 - Hide screenshots preview face in HCM. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D204921
2024-03-20 14:10:35 +00:00
Niklas Baumgardner
e3ec3bb64a
Bug 1879563 - Create z-index variables for screenshots overlay. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D205097
2024-03-20 14:09:51 +00:00
Niklas Baumgardner
4a088b2a9e
Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-02-14 15:16:12 +00:00
Iulian Moraru
0f47785cac
Backed out changeset 4726abbc0c2c (bug 1874026) for causing multiple frequent bc failures. CLOSED TREE
2024-02-02 21:23:59 +02:00
Niklas Baumgardner
6b3e9794e8
Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-02-02 14:16:53 +00:00
Niklas Baumgardner
1b14ee1867
Bug 1874380 - Fix HCM for screenshots initial state. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D198868
2024-02-01 22:10:12 +00:00
Niklas Baumgardner
bbdd7059c2
Bug 1874671 - Change screenshot mover color in HCM. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D199354
2024-02-01 22:09:38 +00:00
Cristian Tuns
e2d969d64e
Backed out changeset e1b248076131 (bug 1874026) for causing bc failures in browser_test_resize.js CLOSED TREE
2024-01-30 17:16:32 -05:00
Niklas Baumgardner
3f4770864a
Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
...
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-01-30 21:30:04 +00:00
Niklas Baumgardner
cfe93676db
Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D192109
2023-12-01 16:07:25 +00:00
Stanca Serban
64e390b1b0
Backed out changeset 87051213c0bc (bug 1801954) for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX. CLOSED TREE
2023-12-01 03:44:32 +02:00
Niklas Baumgardner
1b10dae70a
Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D192109
2023-11-30 22:11:53 +00:00
Niklas Baumgardner
f9babae778
Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D191349
2023-11-02 18:06:38 +00:00
Niklas Baumgardner
8331e6faf7
Bug 1855313 - Show current selection size in screenshots overlay. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D189312
2023-10-20 23:25:37 +00:00
Niklas Baumgardner
6ec1dd524f
Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D190491
2023-10-19 02:11:48 +00:00
Cosmin Sabou
059db96270
Backed out changeset 08bb959c7dca (Bug 1857946) for being partially backed out by merge back commit.
2023-10-19 07:47:11 +03:00
Sandor Molnar
f8ed820f86
Backed out changeset b4a0f8afc02e (bug 1857946) for causing bc failures at browser/components/screenshots/tests/browser/browser_screenshots_short_page_test.js
2023-10-19 03:33:17 +03:00
Niklas Baumgardner
03bdb6d702
Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D190491
2023-10-18 20:33:53 +00:00
Emilio Cobos Álvarez
cf3158e57e
Bug 1858752 - Explicitly z-sort bghighlight. r=niklas
...
Before bug 1799036, this was not an issue because the background and the
highlight ended up in different containing blocks.
Depends on D191137
Differential Revision: https://phabricator.services.mozilla.com/D191138
2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
66cd465db8
Bug 1858752 - Simplify screenshots component markup. r=niklas
...
This doesn't fix the issue at hand, but makes stuff easier to reason about.
Differential Revision: https://phabricator.services.mozilla.com/D191137
2023-10-17 17:24:22 +00:00
Niklas Baumgardner
153c4392df
Bug 1855061 - Screenshots overlay buttons should be centered vertically. r=sfoster,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D189159
2023-09-28 15:33:08 +00:00
Niklas Baumgardner
8464bcdbb9
Bug 1844171 - Refactor screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-27 16:15:02 +00:00
Sebastian Hengst
945cff3a90
Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE
...
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
2023-07-26 21:24:18 +02:00
Niklas Baumgardner
51b2d1bafb
Bug 1844171 - Refactor screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D183313
2023-07-26 15:37:45 +00:00
Niklas Baumgardner
1f9eb86c84
Bug 1827977 - Use in-content styles for screenshots component. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D183423
2023-07-17 18:39:08 +00:00
Emilio Cobos Álvarez
c8d2c23403
Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
...
Subtle things:
* We now have shadow trees in NAC, inception! Only a couple lines of
code in the style system had to be changed to match :host rules and
so properly.
* Had to make highlighters.css contentaccessible, because otherwise we
can't load it from the shadow tree. I don't think it's a big deal.
* I removed some of the code from highlighters.css that claimed that
stuff inherited from the html element. That's just no longer true.
* Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
This is needed because CSSOM from chrome code bypasses CSP (as
AnonymousContent did), but setAttribute() doesn't, see bug 1424474.
Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-09 11:34:05 +00:00
Stanca Serban
27c720052b
Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE
2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez
8053b896a6
Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
...
Subtle things:
* We now have shadow trees in NAC, inception! Only a couple lines of
code in the style system had to be changed to match :host rules and
so properly.
* Had to make highlighters.css contentaccessible, because otherwise we
can't load it from the shadow tree. I don't think it's a big deal.
* I removed some of the code from highlighters.css that claimed that
stuff inherited from the html element. That's just no longer true.
* Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
This is needed because CSSOM from chrome code bypasses CSP (as
AnonymousContent did), but setAttribute() doesn't, see bug 1424474.
Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 21:59:44 +00:00
Cosmin Sabou
20fa44fbeb
Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE
...
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez
b1433254b6
Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe
...
Subtle things:
* We now have shadow trees in NAC, inception! Only a couple lines of
code in the style system had to be changed to match :host rules and
so properly.
* Had to make highlighters.css contentaccessible, because otherwise we
can't load it from the shadow tree. I don't think it's a big deal.
* I removed some of the code from highlighters.css that claimed that
stuff inherited from the html element. That's just no longer true.
* Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
This is needed because CSSOM from chrome code bypasses CSP (as
AnonymousContent did), but setAttribute() doesn't, see bug 1424474.
Differential Revision: https://phabricator.services.mozilla.com/D173998
2023-07-05 18:21:31 +00:00
Gijs Kruitbosch
6641241811
Bug 1508369 - clean up browser CSS to pass basic stylelint rules, r=desktop-theme-reviewers,webcompat-reviewers,extension-reviewers,devtools-reviewers,nchevobbe,denschub,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D177476
2023-05-09 17:12:50 +00:00
Niklas Baumgardner
f0190facaa
Bug 1824430 - Update screenshots buttons styling. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 15:30:21 +00:00
Niklas Baumgardner
b418549f7e
Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 15:30:21 +00:00
Iulian Moraru
7237840464
Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE
...
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
2023-03-30 04:44:53 +03:00
Niklas Baumgardner
5ea1b4a087
Bug 1824430 - Update screenshots buttons styling. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D173708
2023-03-30 00:36:32 +00:00
Niklas Baumgardner
28fe1e62b1
Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D172043
2023-03-30 00:36:31 +00:00
Niklas Baumgardner
b7a9cc4439
Bug 1799215 - Screenshots overlay buttons should have focus states. r=cmkm
...
Differential Revision: https://phabricator.services.mozilla.com/D167583
2023-01-31 16:20:48 +00:00