Norisz Fay
ea6558d555
Backed out changeset 440770be9e5e (bug 1870687) for causing bc failures on browser_searchModeSwitcher_basic.js CLOSED TREE
2024-08-19 22:04:53 +03:00
Moritz Beier
8ea05e5b29
Bug 1870687 - Investigate removing the _locale and _extensionID options from within AppProvidedSearchEngine. r=Standard8,urlbar-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218684
2024-08-19 15:39:57 +00:00
Moritz Beier
12220c0dde
Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D216047
2024-07-15 11:15:22 +00:00
Moritz Beier
9d7c26eff8
Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett
...
Differential Revision: https://phabricator.services.mozilla.com/D214240
2024-06-26 16:03:23 +00:00
Rob Wu
1373c52a41
Bug 1900033 - Stop running extension xpcshell tests with condprof r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D212259
2024-05-31 19:16:42 +00:00
Luca Greco
dcc3c52b77
Bug 1771328 - Persist WebExtensions menus across sessions for extensions with a non-persistent background context. r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D207311
2024-05-23 09:21:45 +00:00
Mark Banner
bb7cb93cc2
Bug 1836804 - Remove support for {moz:locale} parameter replacements in search URLs. r=search-reviewers,daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D209972
2024-05-13 22:10:30 +00:00
Mark Banner
f65518c3c0
Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D203026
2024-03-13 14:51:06 +00:00
mcheang
3ccb2b1975
Bug 1870685 - Ensure tests outside of search pass with the new search configuration enabled. r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D202637
2024-03-11 17:07:12 +00:00
Dave Townsend
8ca92a1c30
Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D202999
2024-03-05 14:21:14 +00:00
mcheang
e5231f8e93
Bug 1870684 - Ensure test that are using custom engine configs and manifest data from data directory are passing for search-config-v2. r=Standard8,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D201938
2024-02-23 01:38:28 +00:00
Karandeep
c394e93376
Bug 1855958 - Remove the experimental urlbar API (first patch). r=mak,extension-reviewers,desktop-theme-reviewers,robwu
...
ext-urlbar.js is unused but will be removed in a separate
patch to avoid test failures in condprof tests. Condprof tests may use
an outdated profile directory that still references ext-urlbar.js in
startupcache files, which triggers a test-only test failure in
mozilla::net::CheckForBrokenChromeURL.
Differential Revision: https://phabricator.services.mozilla.com/D199769
2024-02-05 17:04:37 +00:00
Gijs Kruitbosch
532c3bc439
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
mcheang
4ffcfc6cbc
Bug 1667639 - Make keyword at the start of the string take precedence over restrict symbols at the end of the string. r=mak
...
This patch modifies PlacesUtils to cache the keywords and adds functionality to
find a keyword. The Tokenizer calls PlacesUtils to know if the first word
is a keyword and if the first word is a keyword, then the rest of the search
string will be treated as text and Tokenizer won't filter any other restrict
symbols.
Differential Revision: https://phabricator.services.mozilla.com/D198208
2024-01-19 01:13:39 +00:00
Mark Banner
a03d040295
Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in extension code. r=extension-reviewers,geckoview-reviewers,rpl,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D197488
2024-01-05 09:22:34 +00:00
Mark Banner
0d18781645
Bug 1870644 - Remove nsISearchEngine.iconURI and replace by the new getIconURL function. r=search-reviewers,extension-reviewers,settings-reviewers,mconley,mcheang,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D196734
2023-12-20 13:28:24 +00:00
Mark Banner
742520b2f6
Bug 1870644 - Pass a preferred width rather than width and height when getting search engine icon urls. r=search-reviewers,mcheang
...
This also renames the function, in preparation for iconURI being merged into it.
Differential Revision: https://phabricator.services.mozilla.com/D196733
2023-12-20 13:28:24 +00:00
Mark Banner
6b3f126991
Bug 1870644 - Remove nsISearchEngine.getIcons as it is only used by tests and not necessary. r=search-reviewers,mcheang
...
The tests are able to use getting the icon by size for their own checks.
Differential Revision: https://phabricator.services.mozilla.com/D196732
2023-12-20 13:28:24 +00:00
Joel Maher
33fa84a382
Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Drew Willcoxon
057316e5c2
Bug 1827966 - Part 3: Remove support for dismiss and help buttons from extensions tests. r=dao
...
Depends on D190893
Differential Revision: https://phabricator.services.mozilla.com/D190894
2023-10-13 21:52:07 +00:00
Karandeep
b4cba16887
Bug 1853910 - Remove Legacy Event Telemetry Dependencies. r=mak,extension-reviewers,robwu
...
Depends on D188721
Differential Revision: https://phabricator.services.mozilla.com/D189558
2023-10-11 07:45:13 +00:00
Stanca Serban
341caf1e76
Backed out 2 changesets (bug 1853910) for causing mochitests failures in browser_ext_urlbar_attributionURL.js. CLOSED TREE
...
Backed out changeset eea288462cbb (bug 1853910)
Backed out changeset 75543d7d4250 (bug 1853910)
2023-10-07 00:17:27 +03:00
Karandeep
45ddb19915
Bug 1853910 - Remove Legacy Event Telemetry Dependencies. r=mak,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D189558
2023-10-06 12:33:14 +00:00
Luca Greco
e3fd5a4804
Bug 1853617 - Clear all logins included FxAccounts ones in test_ext_browsingData_passwords test and re-enable it on windows11 conditioned profile jobs. r=jmaher,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D189148
2023-09-25 19:07:35 +00:00
Mark Banner
32e5048c7c
Bug 1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D187512
2023-09-25 10:44:49 +00:00
Joel Maher
5db0cfc304
Bug 1853617 - skip test_ext_browsingData_passwords.js on condprof. r=aryx,extension-reviewers,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D188999
2023-09-22 19:02:48 +00:00
Sandor Molnar
a59dc0e8cf
Backed out changeset f0a2aa2ffe6d (bug 1832704) for causing xpc failures in toolkit/components/search/tests/xpcshell/test_async.js
2023-09-19 03:19:30 +03:00
Mark Banner
8b11f7c564
Bug 1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D187512
2023-09-18 15:09:56 +00:00
Neil Deakin
90a396f96a
Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
...
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin
Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-15 00:21:05 +00:00
Sandor Molnar
2899c1f4da
Backed out changeset b463b9cd8aef (bug 1846036) for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html CLOSED TREE
2023-08-05 02:15:47 +03:00
Neil Deakin
5e36a94898
Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
...
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin
Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-04 18:36:03 +00:00
Mark Banner
544ecba3af
Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Katherine Patenio
ce9d8a5dad
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621
Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
...
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22
Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Mark Banner
40de601f11
Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Marco Bonardo
ac9c47ede2
Bug 1826946 - Delay frecency calculation for history batch inserts. r=daisuke
...
When inserting multiple URIs in history, it makes sense to delay expensive
frecency calculations to a later time. We only set recalc_frecency and the
PlacesFrecencyRecalculator will take care of it.
We keep immediately calculating frecency only when a single url is inserted,
that is the case when the user is normally browsing the Web.
Differential Revision: https://phabricator.services.mozilla.com/D179263
2023-06-05 16:13:57 +00:00
Rob Wu
f0c7c874d6
Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D179890
2023-06-05 10:23:40 +00:00
Rob Wu
bad812f243
Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
...
This patch was generated as follows:
Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.
The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.
1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.
Commands:
```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^ # and verify that the removed lines are ok.
git commit -va # one last review to verify correctness of whole patch.
git rebase -i HEAD~3 # drop the WIP + reverted commit, pick only the last.
```
`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.
Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Mark Banner
232facd440
Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
...
Depends on D179819
Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Saira Abdulla
d8dc989e1b
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32
Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
...
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Marco Bonardo
ddbafa4329
Bug 1834989 - Clean up UrlbarTestUtils use. r=adw
...
Differential Revision: https://phabricator.services.mozilla.com/D179056
2023-05-26 14:56:55 +00:00
Mark Banner
81c86b200c
Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Natalia Csoregi
1b67d0b941
Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
...
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
d1fc869252
Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Noemi Erli
1f146f097e
Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
...
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00
Mark Banner
08ff6c0ad9
Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 08:13:08 +00:00
Mark Banner
0666077666
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00