Commit Graph

81 Commits

Author SHA1 Message Date
Shane Hughes
3effbbc0c4 Bug 1911878 - Fix shrinking radio buttons in feature callouts. r=jprickett,omc-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D218668
2024-08-20 14:07:45 +00:00
Meg Viar
26fd29a83b Bug 1911123 - Add configurable description text for checklist items in about:welcome MultiSelect component r=omc-reviewers,jprickett
These changes support an upcoming opt-out telemetry experiment that requires descriptions for certain items in the aboutwelcome MultiSelect template.
Margins, padding, font size, and other [[ https://searchfox.org/mozilla-central/source/browser/components/aboutwelcome/content-src/components/MSLocalized.jsx#6-18 | configurable styles ]] can be adjusted for the title, subtitle, labels, and description text to best fit a given message.

**LTR**
{F7498988}

**RTL**
{F7498984}

**RDM**
{F7499309}

**Full split with wrapping label (might occur in some languages)**
{F7499811}

Differential Revision: https://phabricator.services.mozilla.com/D218342
2024-08-02 10:53:51 +00:00
Emily McMinn
fb8655c224 Bug 1908520 - Move addons picker strings to localized .ftl file r=omc-reviewers,fluent-reviewers,bolsson,mviar
Differential Revision: https://phabricator.services.mozilla.com/D216866
2024-07-31 16:48:06 +00:00
Emily McMinn
53f45deb25 Bug 1903529 - Make addon install state available to the Addons Picker r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216211
2024-07-25 15:58:02 +00:00
Jason Prickett
b22f465e61 Bug 1908210 - Allow addons screen install button strings to be configurable r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216763
2024-07-18 21:55:30 +00:00
Shane Hughes
aefae347a1 Bug 1908237 - Fix img srcset in chrome feature callouts. r=omc-reviewers,frontend-codestyle-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D216745
2024-07-18 12:27:10 +00:00
Shane Hughes
080905839f Bug 1905119 - Fix feature callout RTL display. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D216597
2024-07-16 02:11:32 +00:00
Jason Prickett
13b25acf84 Bug 1901272 - Add fullscreen toggle and styles to about:welcome r=mviar,omc-reviewers,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215461
2024-07-03 20:55:21 +00:00
negin
33463aa315 Bug 1903841 - Remove ghost shadow on feature callout r=omc-reviewers,aminomancer,mviar
Removes additional 'ghost' shadow around the feature callout container when the feature callout repositions.

Before:
{F7346454}

After:
{F7346458}

Differential Revision: https://phabricator.services.mozilla.com/D215117
2024-06-28 14:36:21 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212499
2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
2024-06-18 15:06:03 +00:00
Jason Prickett
aaf2d598c0 Bug 1896090 - Fix about:welcome dismiss button position when in reverse-split mode r=omc-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D213728
2024-06-17 22:22:06 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
2024-06-17 14:53:04 +00:00
Jason Prickett
91fb205924 Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 03:53:10 +00:00
Stanca Serban
ae9f298177 Backed out changeset 75215e4ff218 (bug 1896597) for causing mochitests failures. 2024-06-08 04:24:47 +03:00
Jason Prickett
09251075f4 Bug 1896597 - Add custom event for migration wizard anchors to be handled in spotlight r=mconley,migration-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D212898
2024-06-08 00:47:23 +00:00
Shane Hughes
64ab25b51e Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D211275
2024-05-28 17:59:47 +00:00
Sarah Chung
9a286a1dc8 Bug 1877512 - change feature-callout dismiss-button background color to transparent r=aminomancer,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D209302
2024-05-03 15:48:26 +00:00
Nathan Barrett
acf230c6f1 Bug 1893704 - update wallpaper onboarding to use updated prefs r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D208928
2024-05-01 00:03:38 +00:00
Nathan Barrett
2da579d075 Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208626
2024-04-26 19:10:39 +00:00
Sandor Molnar
766c1a48c4 Backed out changeset 43278981d771 (bug 1892487) for causing node newtab failures. 2024-04-26 01:13:44 +03:00
Nathan Barrett
a7a0dbc9d6 Bug 1892487 - Fix tabbing issue with wallpaper thumbnails r=maxx,omc-reviewers,home-newtab-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D208626
2024-04-25 20:34:40 +00:00
Jason Prickett
42eb1508b9 Bug 1892772 - Prevent about welcome split title container from rendering when no title or subtitle is present r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D208269
2024-04-25 20:24:21 +00:00
Cristian Tuns
5bec5d4dfa Backed out changeset cad50dfead95 (bug 1892772) for causing node newtab failures. CLOSED TREE 2024-04-24 23:07:09 -04:00
Shane Hughes
ca7244fbbc Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
2024-04-24 20:54:02 +00:00
Amy Churchwell
788dc6f278 Bug 1893076 - Update wallpaper onboarding thumbnail images. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208420
2024-04-24 20:11:29 +00:00
Jason Prickett
3ab800b0c7 Bug 1892772 - Prevent about welcome split title container from rendering when no title or subtitle is present r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D208269
2024-04-24 20:07:35 +00:00
Jason Prickett
33a3dc43a5 Bug 1892769 - Add reverse-split styles to no-rdm selector r=omc-reviewers,hanna_a
This patch adds the reverse-split rules to the `no-rdm` selector so that reverse-split isn't reverted at widths less than 800px.

Differential Revision: https://phabricator.services.mozilla.com/D208272
2024-04-23 19:04:46 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Amy Churchwell
67214e1c05 Bug 1883516 - Add new wallpaper component for onboarding r=fluent-reviewers,omc-reviewers,bolsson,maxxcrawford,pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D205658
2024-04-11 19:51:58 +00:00
Sandor Molnar
6b12c70be4 Backed out changeset 4ad2cddade30 (bug 1883516) for causing node newtab failures 2024-04-11 06:03:15 +03:00
Amy Churchwell
5920e05eb5 Bug 1883516 - Add new wallpaper component for onboarding r=fluent-reviewers,bolsson,maxxcrawford
Differential Revision: https://phabricator.services.mozilla.com/D205658
2024-04-11 02:28:13 +00:00
Shane Hughes
2b5b65b43c Bug 1889885 - Fix Review Checker regression caused by no_rdm feature. r=omc-reviewers,hanna_a
Differential Revision: https://phabricator.services.mozilla.com/D206802
2024-04-05 18:54:08 +00:00
negin
45aff83a3d Bug 1889703 - Re-introduce embedded migration wizard default title r=migration-reviewers,aminomancer,mconley,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206683
2024-04-04 19:25:53 +00:00
Jason Prickett
bb433baf3f Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-25 23:05:05 +00:00
Jason Prickett
a6095771b4 Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-22 02:29:57 +00:00
Sandor Molnar
e608e4df81 Backed out 2 changesets (bug 1876176) for causing node newtab failures @ browser/components/aboutwelcome CLOSED TREE
Backed out changeset 4899c27af9c2 (bug 1876176)
Backed out changeset 9ae306e9577a (bug 1876176)
2024-03-21 20:57:54 +02:00
Jason Prickett
569f5bb7a6 Bug 1876176 - Update migration wizard to support future experiments r=omc-reviewers,desktop-theme-reviewers,mconley,migration-reviewers,aminomancer,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D201142
2024-03-21 17:21:05 +00:00
hanna alemu
0ea6924387 Bug 1876168 - Add the ability to reverse left/right sections of split Spotlight layout r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204095
2024-03-21 01:10:30 +00:00
Emily McMinn
0ebe683d61 Bug 1877295 - Toolbar button option for returning to about:welcome r=pdahiya,fluent-reviewers,Gijs,desktop-theme-reviewers,omc-reviewers,bolsson,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D199934
2024-03-15 20:53:04 +00:00
Stanca Serban
4c3e18b570 Backed out changeset 4aafa3f8df2d (bug 1877295) for causing mochitests failures in browser_preferences_usage.js. CLOSED TREE 2024-03-15 02:34:04 +02:00
Emily McMinn
9e0f6d80e7 Bug 1877295 - Toolbar button option for returning to about:welcome r=pdahiya,fluent-reviewers,Gijs,desktop-theme-reviewers,omc-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D199934
2024-03-14 19:47:17 +00:00
Natalia Csoregi
4bf66df843 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
faeefc390a Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 21:28:06 +00:00
Natalia Csoregi
a6b8803582 Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
9f76e777a7 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 18:23:44 +00:00
negin
601a737f68 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
2024-03-01 21:03:23 +00:00
Emily McMinn
3cbfbbe4f3 Bug 1878935 - Convert addons picker content to use string_ids and add strings r=omc-reviewers,fluent-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D201992
2024-02-27 17:13:26 +00:00
Shane Hughes
9c7d018917 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
2024-02-27 03:29:29 +00:00
Mark Banner
1d4856edef Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
2024-02-24 12:21:20 +00:00