corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
872,378 Commits 1 Branch 0 Tags
b068dcffb1324b82fb2cfab5454360760cb15f45
Commit Graph

233 Commits

Author SHA1 Message Date
Sammy Khamis
8b5458495a Bug 1885645: Update FxA sign in menu r=markh,teshaq,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208249
 2024-05-02 14:22:16 +00:00
Erik Nordin
a665832d05 Bug 1892931 - Make browser_contextmenu_sendpage.js more declarative r=translations-reviewers,gregtatum 
Makes the assertions in browser_contextmenu_sendpage.js
more declarative and more maintainable for adding new
items to the context menu.

Differential Revision: https://phabricator.services.mozilla.com/D208775
 2024-04-30 16:23:41 +00:00
Erik Nordin
4fae255b14 Bug 1892931 - Fix browser_contextmenu_sendpage.js test when SelectTranslations is disabled r=translations-reviewers,gregtatum 
Fixes the browser_contextmenu_sendpage.js test to not expect the
SelectTranslations context menu item is the pref is disabled.

Differential Revision: https://phabricator.services.mozilla.com/D208765
 2024-04-30 16:23:40 +00:00
Erik Nordin
f847f34296 Bug 1890299 - Enable Select Translations for Nightly and Early Beta r=translations-reviewers,gregtatum 
Enables Select Translations for EARLY_BETA_OR_EARLIER
to get early feedback on the implemented functionality.

Depends on D207823

Differential Revision: https://phabricator.services.mozilla.com/D206907
 2024-04-22 22:37:20 +00:00
Iulian Moraru
eb08de35ac Backed out changeset a8a7b57f4e03 (bug 1890299) for causing bc failures on browser_contextmenu.js related to translate. CLOSED TREE 2024-04-17 23:13:01 +03:00
Erik Nordin
8fe2e11bc2 Bug 1890299 - Enable Select Translations for Nightly and Early Beta r=translations-reviewers,gregtatum 
Enables Select Translations for EARLY_BETA_OR_EARLIER
to get early feedback on the implemented functionality.

Differential Revision: https://phabricator.services.mozilla.com/D206907
 2024-04-17 15:47:22 +00:00
Dave Townsend
ab57b0fdc1 Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202949
 2024-03-19 14:59:20 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Sammy Khamis
cbcf1c8bcb Bug 1880556: Add toggles for FxA products r=sync-reviewers,markh 
Differential Revision: https://phabricator.services.mozilla.com/D202365
 2024-02-22 19:32:34 +00:00
Sammy Khamis
5e8457cfe7 Bug 1879211: Move PXI toolbar strings into localization tree r=markh,flod 
Differential Revision: https://phabricator.services.mozilla.com/D201025
 2024-02-13 18:42:17 +00:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster 
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
 2024-01-19 02:15:33 +00:00
Tarik Eshaq
44ef52e8fa Bug 1874311: Enables Account toolbar by default when signed out. r=skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D198338
 2024-01-16 21:43:00 +00:00
Sammy Khamis
249dd51c48 Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao 
Differential Revision: https://phabricator.services.mozilla.com/D194916
 2023-12-13 22:08:33 +00:00
Stanca Serban
2e220c68ae Backed out changeset 2499ef5644ea (bug 1867098) as requested for causing Bug 1869728. 2023-12-13 16:21:31 +02:00
Sammy Khamis
4250cfa9bc Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao 
Differential Revision: https://phabricator.services.mozilla.com/D194916
 2023-12-11 21:53:53 +00:00
Abhishek Madan
62a502bbec Bug 1859831 - Add StripOnShare to context menu tests. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D191339
 2023-10-19 15:05:05 +00:00
Sylvestre Ledru
2e0e132821 Bug 1856530 - run file-whitespace on toml files r=linter-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D189896
 2023-10-03 09:22:18 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
dschomburg
3f4ce2547c Bug 1853815 - Remove "Firefox account" branding from FxA app menu. r=flod,fluent-reviewers 
This replaces the term Firefox account with Account in FxA's app menu.
This replaces the term Firefox account with your account in FxA's sign out pop up.

Differential Revision: https://phabricator.services.mozilla.com/D188615
 2023-09-20 06:23:35 +00:00
Mark Banner
85c9f645f5 Bug 1844784 - Ensure Synced Tabs in the history menu is properly removed when FxAccounts are disabled. r=sync-reviewers,places-reviewers,lina,markh 
Differential Revision: https://phabricator.services.mozilla.com/D185719
 2023-08-09 15:00:20 +00:00
Mark Banner
5797c921a8 Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D184780
 2023-07-31 13:05:44 +00:00
Stanca Serban
f597936605 Backed out 2 changesets (bug 1845252) for causing mochitests failures in browser_fxa_web_channel.js. CLOSED TREE 
Backed out changeset d58bbd55cb35 (bug 1845252)
Backed out changeset 683a87892126 (bug 1845252)
 2023-07-28 21:29:30 +03:00
Mark Banner
cb680469ad Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D184780
 2023-07-28 17:30:39 +00:00
Mark Hammond
7ce4df6ae2 Bug 1710338 - Prefer the FxA displayName over the email address in the app menu. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D180437
 2023-06-12 13:10:00 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Sammy Khamis
435afb34a5 Bug 1824216: Always show sync settings if sync is enabled r=markh,sync-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176960
 2023-05-18 02:26:23 +00:00
Eemeli Aro
4562dff30c Bug 1831851 - Migrate accounts.properties strings used by browser-sync.js to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh 
Differential Revision: https://phabricator.services.mozilla.com/D177601
 2023-05-11 06:27:41 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Mark Hammond
9a080f909e Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-22 03:58:11 +00:00
Norisz Fay
d30055eea6 Backed out changeset d82c03e04249 (bug 1359861) for causing xpcshell failure on test_BrowserUtils.js CLOSED TREE 2023-02-22 00:05:07 +02:00
Mark Hammond
9ef3fc0513 Bug 1359861 - allow reader-mode tabs to be shared. r=Gijs,skhamis 
Differential Revision: https://phabricator.services.mozilla.com/D170186
 2023-02-21 21:04:10 +00:00
Mike Conley
6fcfbd32fa Bug 1817320 - Put mochitest manifest files under browser/base/content/test into alphabetical order. r=kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D170244
 2023-02-17 21:44:52 +00:00
Mark Banner
81e5d26ac3 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 16:34:43 +00:00
Cristian Tuns
b9ee007450 Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE 
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
 2023-02-17 10:51:33 -05:00
Mark Banner
c8baa7a866 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 09:01:45 +00:00
Gijs Kruitbosch
e341f68082 Bug 1811198 - show synced tabs panel correctly when the button is in a hidden area, r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D169742
 2023-02-15 09:19:49 +00:00
Mark Banner
18898557b3 Bug 1814931 - Convert services/sync imports to direct ES imports. r=markh,settings-reviewers,credential-management-reviewers,mconley,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D168837
 2023-02-13 11:44:29 +00:00
Mark Banner
9f5558b211 Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D168070
 2023-01-30 19:33:37 +00:00
lyavor
7f077a7bd9 Bug 1811278 - Add disable next line for all browser/base PART 4 r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D167284
 2023-01-25 14:27:44 +00:00
Norisz Fay
a0b145e9b4 Backed out 5 changesets (bug 1811278) for causing lint failures on browser_bug435325.js CLOSED TREE 
Backed out changeset 715821104ffa (bug 1811278)
Backed out changeset 6f116715687d (bug 1811278)
Backed out changeset 16e69d940e3f (bug 1811278)
Backed out changeset 9dc0451ca213 (bug 1811278)
Backed out changeset 9f60a414e711 (bug 1811278)
 2023-01-25 12:46:52 +02:00
lyavor
1b570de8db Bug 1811278 - Add disable next line for all browser/base PART 4 r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D167284
 2023-01-25 10:15:38 +00:00
Emilio Cobos Álvarez
0f61b77b68 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-15 03:11:55 +00:00
Cristian Tuns
c9c42bc174 Backed out 2 changesets (bug 1805415) for causing dt failures on browser_net_telemetry_throttle_changed.js CLOSED TREE 
Backed out changeset 5056d7df9f1e (bug 1805415)
Backed out changeset e13513500184 (bug 1805415)
 2022-12-14 08:52:21 -05:00
Emilio Cobos Álvarez
9a53f8dea3 Bug 1805415 - Use activateItem() rather than click() to activate menuitems. r=Gijs,extension-reviewers,pip-reviewers,search-reviewers 
Bug 1805414 will move menu event handling to the DOM.

With that change the current synthetic click behavior of XUL menuitems
breaks. On current central, we rely on nsMenuFrame::HandleEvent not
getting called at all for synthetic clicks, and instead we just fire a
command event synchronously here:

  https://searchfox.org/mozilla-central/rev/a0d4f8f112c5c792ae272bf6ce50763ddd23ffa2/dom/xul/nsXULElement.cpp#1071

After my patch the command event is fired properly (potentially
asynchronously too) by the regular menu activation machinery, which is
preferable.

 * They fire a command event synchronously (even though on some
   platforms like macOS activating a context menu item is async).

 * They use a totally different codepath from what a user does.

 * They don't deal with native menus, etc.

We have a proper API for this (activateItem) which takes a much more
closer codepath to what users do, requires that the menu is shown, etc.
Use that API instead for testing.

As a benefit, tests now do not need to close the context menu manually
when clicking on a menu item (because we trigger the same code path as
users clicking the menu).

Differential Revision: https://phabricator.services.mozilla.com/D164567
 2022-12-14 10:25:17 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D161914
 2022-11-17 12:00:30 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00