Files containing theora have been modified to use VP9 in WebM, which is
equivalent for those tests, that only require a video with or without sound.
Differential Revision: https://phabricator.services.mozilla.com/D204644
Files containing theora have been modified to use VP9 in WebM, which is
equivalent for those tests, that only require a video with or without sound.
Differential Revision: https://phabricator.services.mozilla.com/D204644
Files containing theora have been modified to use VP9 in WebM, which is
equivalent for those tests, that only require a video with or without sound.
Differential Revision: https://phabricator.services.mozilla.com/D204644
The 3 signifiers of the minimization being complete are:
1) The sizemodechange event
2) The occlusionstatechange event (on some platforms)
3) The browsing context becoming inactive
Ideally these would happen in 1-2-3 order, but they aren't consistent.
Specifically, since the browsing context is updated by an
occlusionstatechange event listener, tests that add a
occlusionstatechange event listener will fire before the browsing
context has been updated (since they fire in LIFO order). That makes it
very timing dependent on whether or not a check for browsing context
inactive will succeed, and that's the source of the intermittent
failures here. The safest thing to do is to turn the browsing context
active check into another promise and await the sizemodechange and the
active promise together, and that's what this patch does.
Differential Revision: https://phabricator.services.mozilla.com/D202609
The 3 signifiers of the minimization being complete are:
1) The sizemodechange event
2) The occlusionstatechange event
3) The browsing context becoming inactive
Ideally these would happen in 1-2-3 order, but they aren't consistent.
Specifically, since the browsing context is updated by an
occlusionstatechange event listener, tests that add a
occlusionstatechange event listener will fire before the browsing
context has been updated (since they fire in LIFO order). That makes it
very timing dependent on whether or not a check for browsing context
inactive will succeed, and that's the source of the intermittent
failures here. The safest thing to do is to turn the browsing context
active check into another promise and await all 3 promises at once, and
that's what this patch does.
Differential Revision: https://phabricator.services.mozilla.com/D202609
When content analysis is on, pastes will be checked by the CA
agent while tab input is blocked. The synchronous nsIClipboard.getData()
method must block until the analysis result is received, so this
requires doing a SpinEventLoopUntil.
Differential Revision: https://phabricator.services.mozilla.com/D196997
The fact that adding an infobar notificaiton is async now seems to have messed with some of the timing assumptions baked into this test. Explicitly waiting for the about:preferences URI to load, rather than just waiting for a tick seems to make things more reliable.
Differential Revision: https://phabricator.services.mozilla.com/D198636
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.
Differential Revision: https://phabricator.services.mozilla.com/D198826
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
This patch updates the `NotificationMessage` element in `notificationbox.js` so that it extends our newer `moz-message-bar` component instead of the deprecated `message-bar` component. Many of the changes are just dealing with the implications of making things async (so that we can ensure `moz-message-bar.mjs` gets imported). I tried to break out places where I modified related code and tests into separate patches to mitigate some of the review pain here.
This patch solves a longstanding issue where we were loading `in-content/common-shared.css` in the chrome since it gets used by the `message-bar` element. It also makes some small visual changes to our infobars (slight outline, icon colors, adds a bit of spacing).
Differential Revision: https://phabricator.services.mozilla.com/D189872
Use an URL that actually loads, and wait for it, rather than loading an
url that triggers a network error (which we can't wait for) and would
leak the page instead if closed prematurely.
Differential Revision: https://phabricator.services.mozilla.com/D194239
