Commit Graph

7347 Commits

Author SHA1 Message Date
Drew Willcoxon
eeabfdc62a Bug 1913507 - Add capability to show AMP suggestions as top picks based on keyword character counts. r=daisuke,fluent-reviewers,flod
Depends on D219369

Differential Revision: https://phabricator.services.mozilla.com/D219370
2024-08-20 05:57:40 +00:00
Mike Conley
ab5daa32cb Bug 1906318 - Change the idle timeout for evaluating backup creation to 15 seconds. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218998
2024-08-16 16:32:31 +00:00
Mark Hammond
ff976fb221 Bug 1851024 - stop syncing the general.smoothScroll pref. r=skhamis,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219246
2024-08-16 12:16:27 +00:00
Gijs Kruitbosch
9b4a0e1f72 Bug 1908496 - adjust defaults for news/snews/nntp protocols, r=dveditz
Differential Revision: https://phabricator.services.mozilla.com/D216938
2024-08-13 10:50:44 +00:00
Iulian Moraru
4371796885 Backed out changeset c052f2639595 (bug 1086524) for causing multiple browser failures related to urlbar. CLOSED TREE 2024-08-13 12:44:56 +03:00
Collin Richards
ba7657463c Bug 1086524 - Focus window on Esc in address bar r=dao,urlbar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218893
2024-08-13 08:36:51 +00:00
Amy Churchwell
000c4e742c Bug 1911908 – Add pref and CSS hook for Variant A in Layouts experiment. r=#home-newtab-reviewers CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D218881
2024-08-08 18:55:24 +00:00
Sandor Molnar
9b33260630 Backed out changeset 869743a7617e (bug 1911908) for causing build bustages. 2024-08-08 22:10:30 +03:00
Amy Churchwell
3cc52a7bf8 Bug 1911908 – Add pref and CSS hook for Variant A in Layouts experiment. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D218688
2024-08-08 18:07:32 +00:00
Ed Lee
5856999dde Bug 1912080 - Chatbot prompt prefix string missing from localization r=tarek,fluent-reviewers,flod
Allow prefix pref to be json with l10nId that allows localization.

Differential Revision: https://phabricator.services.mozilla.com/D218804
2024-08-08 11:55:10 +00:00
Nika Layzell
1a2a376d39 Bug 1908725 - Part 5: Add additional validation for early-startup command line checks, r=ipc-reviewers,mccr8
This patch adjusts the various places where we initialize content
processes to call SetGeckoProcessType as early as possible, and be more
consistent. After this change we should only ever set GeckoProcessType
and GeckoChildID once per-process (with the exception of the fork server
process).

In addition to this validation, some more checks around the fork server
were added, such as to prevent forking another forkserver, or forking a
non-content process.

As part of this change, there was some refactoring/cleanup done, such as
removing plugin-container.cpp and content_process_main, as compared to
the other duplicated code between the two call-sites, the duplication
was relatively small, and inlining it helped make things more readable.

Differential Revision: https://phabricator.services.mozilla.com/D218471
2024-08-07 20:39:41 +00:00
Nika Layzell
b0d1f2c5e9 Bug 1908725 - Part 1: Introduce GeckoChildID, r=glandium,ipc-reviewers,mccr8
The new GeckoChildID type introduced in this patch is inspired by the existing
ContentParentID type used by ContentParent, but is currently distinct. It is
supported by all process types at the GeckoChildProcessHost level and can be
read for the current process from anywhere.

As this type is similar in many ways to the process type, and should be
available as early as possible within child processes, this was added alongside
the GeckoProcessType value within mozglue to make that easier to do.

The type was chosen to be an int32_t to make it feel similar to a PID, which we
currently use for process identity comparisons across the codebase. The
intention is for GeckoChildID to be preferred for these within-gecko checks, as
these IDs will not be re-used and can be known earlier during child process
creation.

Differential Revision: https://phabricator.services.mozilla.com/D217117
2024-08-07 20:39:39 +00:00
Ed Lee
54766e0f44 Bug 1911748 - Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad ) r=tarek
Allow the long press delay to be pref controlled with a higher default 200ms -> 60s effectively turning it off. Record the delay with glean.

Differential Revision: https://phabricator.services.mozilla.com/D218662
2024-08-07 19:41:20 +00:00
Jan-Ivar Bruaroey
1ae52f7a91 Bug 1609427 - Hide persisted "Always Ask ✖" permissions in the UX over risk of confusion over what happens when they're cleared'. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D183439
2024-08-06 13:53:21 +00:00
DJ
03d24c820a Bug 1908566 - enable tab hover preview by default. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D218420
2024-08-05 09:22:39 +00:00
Ed Lee
035e010fe9 Bug 1907350 - Expose genai-settings-chat-title and other chatbot strings for localization r=tarek,fluent-reviewers,mconley,bolsson
Move featuregate title to features.ftl used by about:preferences and about:support; and other strings to genai.ftl. Allow prompts to use l10nId to get fluent attributes. Convert inline strings for menu and shortcuts to fluent. Update simplify, add explain prompts.

Differential Revision: https://phabricator.services.mozilla.com/D218279
2024-08-03 06:40:26 +00:00
Ed Lee
7fcb70613f Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 04:19:46 +00:00
Noemi Erli
5578e35afb Backed out changeset c9ad93d58c14 (bug 1910005) for causing bustages in GleanMetrics.h CLOSED TREE 2024-08-03 06:17:37 +03:00
Ed Lee
0e362c1019 Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 02:46:23 +00:00
Nathan Barrett
0f4ec1ec5b Bug 1911344 - Enable topic selection and labels in nightly & beta. r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D218433
2024-08-02 22:14:45 +00:00
serge-sans-paille
ea70192ce0 Bug 1906804 - Move CFLAGS and CXXFLAGS from old-configure to moz.configure r=glandium
As a side effect, defaults to empty list for those flags when not set.

Differential Revision: https://phabricator.services.mozilla.com/D216096
2024-08-01 15:12:49 +00:00
Maxx Crawford
5bf4aa04c7 Bug 1910759 - Update firefox prefs to use EARLY_BETA_OR_EARLIER flag for HNT features r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D218225
2024-07-31 17:16:21 +00:00
Mike Conley
ac1fe13cf8 Bug 1910464 - Set identity.fxaccounts.telemetry.clientAssociationPing.enabled to false by default. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D218138
2024-07-31 13:11:07 +00:00
scottdowne
d175bbdb4a Bug 1910776 - Newtab flip wallpapers pref on r=amy
Differential Revision: https://phabricator.services.mozilla.com/D218148
2024-07-30 23:23:07 +00:00
Amy Churchwell
cb39b4b383 Bug 1910757 – Enable topic labels by default. r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D218137
2024-07-30 22:22:00 +00:00
Daniele Ferla
a1ea61aba8 Bug 1647800 - Picture-in-Picture: auto-toggle on tab switch. r=mconley,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,pip-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D214013
2024-07-29 21:35:54 +00:00
Maxx Crawford
86bebe1530 Bug 1909900 - Add region controls to thumbs up and down buttons r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D217761
2024-07-28 20:30:57 +00:00
scottdowne
4598259ac1 Bug 1908670 - Home and newtab topic personalization needs region controls r=home-newtab-reviewers,amy
So this changes a bit how we intend to enable this.

There is still the "discoverystream.topicSelection.enabled" pref, but that's now either, set by the system, or overridden by the user.

We no longer set that pref to enable/disable this feature, and this pref no longer has a set default.

It now has a dynamic default, set from calculating the locale/region pref, which does have defaults, can be controlled from experiments.

Differential Revision: https://phabricator.services.mozilla.com/D217645
2024-07-28 18:06:41 +00:00
Ed Lee
2a0610e953 Bug 1905750 - Display shortcuts on text selection r=tarek
Detect selection to show shortcut icon near the cursor. Open panel with prompts when hovering the icon. Hide these on various events that might move content or no selection.

Differential Revision: https://phabricator.services.mozilla.com/D217545
2024-07-26 07:23:00 +00:00
Ed Lee
1dd2819331 Bug 1905750 - Stub actors and panel to display content-area shortcuts on text selection r=tarek,desktop-theme-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Add default false shortcuts pref to control GenAI actors initially detecting text selection. Prepare content-area elements that stack on top of tab's browser.

Differential Revision: https://phabricator.services.mozilla.com/D217544
2024-07-26 07:22:59 +00:00
Jonathan Sudiaman
4976e075f8 Bug 1886408 - History in sidebar: Remove row limit, fix empty state, add hover button. r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,kcochrane,nsharpley
- max-history-rows pref set to 0 for Nightly only.
- Add the X button to close a tab on hover.
- Introduce an extension to `fxview-tab-list` which handles the differences between here and FxView.
- Reuse the empty state for when history is cleared (same as firefox view).
- Update the logic of `fxview-empty-state` to allow for opening prefs link in the parent window (instead of the sidebar browser).

Differential Revision: https://phabricator.services.mozilla.com/D217111
2024-07-25 16:03:17 +00:00
Nipun Shukla
93c6531ceb Bug 1900035 - Added Windows start menu pinning to MSIX set-to-default and taskbar pinning scenarios r=omc-reviewers,firefox-desktop-core-reviewers ,Gijs,mpohle,aminomancer,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D212461
2024-07-24 21:13:35 +00:00
scottdowne
63eee12c36 Bug 1908469 - Newtab pass experiment data to Merino recommendations request. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D217357
2024-07-24 18:45:44 +00:00
Drew Willcoxon
b93325ad71 Bug 1909565 - Move Fakespot suggestions to the bottom of the Firefox Suggest section, r=daisuke
This also adds a Nimbus variable so we can easily change the index for
experiments.

Depends on D217510

Differential Revision: https://phabricator.services.mozilla.com/D217524
2024-07-24 00:18:11 +00:00
Drew Willcoxon
b665eba613 Bug 1909563 - Set the default Fakespot min keyword length threshold to 4. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D217510
2024-07-24 00:18:10 +00:00
Maxx Crawford
bf5d4deb63 Bug 1909520 - Enable weather location search/locale prefs by default r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D217477
2024-07-23 20:01:48 +00:00
Moritz Beier
650113020b Bug 1863530 - Remove browser.search.widget.inNavBar pref. r=dao,settings-reviewers,search-reviewers,omc-reviewers,urlbar-reviewers,Gijs,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D215607
2024-07-23 17:29:00 +00:00
Sammy Khamis
d2d1f06c36 Bug 1905974: Flip closing tabs remotely to default on r=markh
Differential Revision: https://phabricator.services.mozilla.com/D215570
2024-07-22 17:17:58 +00:00
Gijs Kruitbosch
a42bb0c9ac Bug 1908785 - driveby: remove browser.preferences.search as there is no reason to disable search in settings, r=mconley
This was the feature flag behind which the settings page's 'search' functionality was written.
It's been there for years now, and it is high time to clean this up.

Differential Revision: https://phabricator.services.mozilla.com/D217034
2024-07-19 18:46:25 +00:00
Gijs Kruitbosch
7193715cd8 Bug 1908785 - show Firefox Labs on non-Nightly, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D217032
2024-07-19 18:46:24 +00:00
Maxx Crawford
df392ffebc Bug 1908696 - Update Thumbs up/down pref to default to true for Nightly r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216977
2024-07-18 17:00:07 +00:00
Stephanie Cunnane
cbe0471b10 Bug 1879667 - Record client's experiment information in the SERP categorization ping. r=jteow
Differential Revision: https://phabricator.services.mozilla.com/D209269
2024-07-17 16:51:12 +00:00
Sylvestre Ledru
a3ea006705 Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,necko-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,devtools-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,migration-reviewers,padenot,mconley,nchevobbe,kershaw,gstoll,mstange,bytesized,m_kato
This new version of clang 17 also slightly changed the formatting.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D215914
2024-07-17 11:15:31 +00:00
Amy Churchwell
880328f9a1 Bug 1904657 - Add topic labels to Pocket cards. r=home-newtab-reviewers,nbarrett,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216429
2024-07-16 20:28:23 +00:00
Daisuke Akatsuka
178597f16b Bug 1907878: Put Pocket suggestions at bottom as default r=adw
Differential Revision: https://phabricator.services.mozilla.com/D216627
2024-07-16 03:32:14 +00:00
Norisz Fay
6a89206409 Backed out changeset f6085a9f4c95 (bug 1904657) for causing newtab failures 2024-07-16 00:54:15 +03:00
Amy Churchwell
251953d0da Bug 1904657 - Add topic labels to Pocket cards. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D216429
2024-07-15 20:48:38 +00:00
scottdowne
794c3bc404 Bug 1907392 - Home and newtab weather widget locale controls r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D216326
2024-07-11 19:56:19 +00:00
Mike Conley
548a9fc024 Bug 1903310 - Set identity.fxaccounts.telemetry.clientAssociationPing.enabled to true by default. r=frank
Differential Revision: https://phabricator.services.mozilla.com/D216330
2024-07-11 18:59:58 +00:00
Nicolas Chevobbe
baff5d634c Bug 1905035 - [devtools] Display @starting-style rules in the Inspector. r=devtools-reviewers,jdescottes.
Depends on D216130

Differential Revision: https://phabricator.services.mozilla.com/D216133
2024-07-11 18:13:17 +00:00