Commit Graph

26 Commits

Author SHA1 Message Date
Alessio Placitelli
a7af27a02a Bug 1381617 - Enable stricter scalar, histogram and events expiration validation. r=chutten
MozReview-Commit-ID: 9q93hOYsNUo
2017-07-18 09:59:00 +02:00
Avikalpa Kundu
c2cf02e97d Bug 1344834 - Enable flake8 rule E501: 'line too long (113 > 99 characters)'. r=Dexter 2017-05-03 06:38:00 +02:00
Georg Fritzsche
1fc17df501 Bug 1357001 - Part 5 - Fix linting errors. r=chutten 2017-04-21 15:48:44 +02:00
Georg Fritzsche
316ad47bac Bug 1357001 - Part 4 - Make event error messages style more consistent. r=chutten 2017-04-18 18:25:04 +02:00
Georg Fritzsche
15fb79d095 Bug 1357001 - Part 1 - Unify validation errors in probe parsing scripts. r=chutten, f=gps 2017-04-18 18:21:36 +02:00
Mayank Madan
3a284c17a3 Bug 1349452 - Improve type checking code in parse_events.py. r=dexter 2017-04-11 18:20:15 +05:30
Arjun Nair
50a3b83e76 Bug 1354012 - Fixed nice_type_name function always returning basestring. r=gfritzsche
Changed isinstance function to issubclass function since the nice_type_name function takes a type object as its input
2017-04-11 05:02:08 +02:00
Federico Padua
d28d150c61 Bug 1337022 - Fix the regex in the Telemetry event parser. r=Dexter
This patch fixes the regex defined by IDENTIFIER_PATTERN in
toolkit/components/telemetry/parse_events.py to be less strict and fixes the
relative documentation.
To be precise, before this fix, the regex did not allow the category "ui" (which is described
in the documentation at the webpage
https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/collection/events.html)
to be matched so the documentation was wrong.
The reason for that was that the regex required at least one extra character or
number to be in the string, so for example "uig" would have matched.
With this fix the category "ui" is allowed and matched by the new regex and the documentaion
(https://gecko.readthedocs.io/en/latest/toolkit/components/telemetry/telemetry/collection/events.html#limits)
is updated to reflect the change.

MozReview-Commit-ID: ID2aKOM1v7
2017-03-17 11:59:17 +01:00
Paavini Nanda
8b72dcd8ba Bug 1344852: Enable flake8 rule W602: "deprecated form of raising exception". r=dexter 2017-03-15 17:18:52 +05:30
Federico Padua
0e70316680 Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". r=Dexter
This patch enables flake8 rule E713:
"test for membership should be 'not in'" in toolkit/components/telemetry
by removing the relative E713 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E713 error was reported.
Precisely 6 errors violating E713 rule were found and solved.

MozReview-Commit-ID: 2AaYGgVkxbU
2017-03-14 02:03:13 +01:00
Federico Padua
dc763e2594 Bug 1344832 - Enable flake8 rule E502: "the backslash is redundant between brackets". r+dexter r=Dexter
This patch enables flake8 rule E502:
"the backslash is redundant between brackets" in toolkit/components/telemetry
by removing the relative E502 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E502 error was reported.
Precisely 8 errors violating E502 rule were found and solved.

MozReview-Commit-ID: 1z8f3JjJ2gt
2017-03-14 01:04:56 +01:00
Paavini Nanda
9f5fb0a113 Bug 1344840 - Enable flake8 rule E231: "missing whitespace after ','". r=dexter 2017-03-14 00:37:32 +05:30
djmdev
2410c58bae Bug 1344718 - Enable flake8 rule E302: "expected 2 blank lines, found 1" for Telemetry code. r=Dexter 2017-03-08 22:41:00 +05:30
Georg Fritzsche
d8b6b7d1e8 Bug 1313326 - Part 2 - Restrict event recording to specified processes. r=dexter 2017-03-06 16:12:49 +01:00
Sebastian Hengst
f464fc5724 Backed out changeset 223a0be48369 (bug 1313326) 2017-03-01 19:47:19 +01:00
Georg Fritzsche
ab4191da5a Bug 1313326 - Part 2: Restrict event recording to specified processes. r=dexter 2017-02-15 16:59:42 +01:00
Georg Fritzsche
7b725144a8 Bug 1329620 - Part 2 - Use event names to print better error messages. r=dexter 2017-01-09 23:14:00 +07:00
Georg Fritzsche
43247e46e6 Bug 1329620 - Part 1 - Add event names to Events.yaml. r=dexter 2017-01-09 18:03:21 +07:00
Georg Fritzsche
5c03e7d1cd Bug 1316810 - Part 1 - Use more strict size limits for event recording. r=dexter 2016-12-02 12:17:12 +01:00
Phil Ringnalda
6f651bae70 Backed out 5 changesets (bug 1316281, bug 1316810) for ASan failures in UsageTelemetry tests
Backed out changeset 2c711bb8e373 (bug 1316281)
Backed out changeset b3ea1334c33a (bug 1316281)
Backed out changeset 823e118b3fad (bug 1316281)
Backed out changeset 84e97301a8c9 (bug 1316810)
Backed out changeset f98ddece4b12 (bug 1316810)

MozReview-Commit-ID: 5tR2v8NWxQW
2016-12-01 07:46:00 -08:00
Georg Fritzsche
ec344d978a Bug 1316810 - Part 1 - Use more strict size limits for event recording. r=dexter 2016-12-01 14:57:32 +01:00
Georg Fritzsche
6509220740 Bug 1302663 - Part 1 - Add script to generate headers with event data from Events.yaml. r=dexter 2016-11-18 15:51:58 +01:00
Carsten "Tomcat" Book
277cde6ebd Backed out changeset 5c047b770037 (bug 1302663) for eslint failures 2016-11-18 14:29:03 +01:00
Georg Fritzsche
b82f2a6a5b Bug 1302663 - Part 1 - Add script to generate headers with event data from Events.yaml. r=dexter 2016-11-18 13:03:58 +01:00
Sebastian Hengst
527e0ad612 Backed out changeset ac12dbbe7b63 (bug 1302663) for leaks and eslint failure. r=backout 2016-11-12 21:18:23 +01:00
Georg Fritzsche
28979c0a42 Bug 1302663 - Part 1 - Add script to generate headers with event data from Events.yaml. r=dexter 2016-11-13 01:52:28 +07:00