This is needed before we can upgrade to flake8 3.3.0, as that version starts flagging these errors.
These files were modified by running:
autopep8 --select E305 --in-place -r <dir>
on the affected directories. I did it one dir at a time and verified the result after each.
MozReview-Commit-ID: FmlsfiKIbtr
Changed |print("enum ID : uint32_t {", file=output)| to |print("enum HistogramID : uint32_t {", file=output)| at line 53 of the file |toolkit/components/telemetry/gen-histogram-enum.py|, and then replaced all the textual occurrences of |Telemetry::ID| to |Telemetry::HistogramID| and |ID| to |HistogramID| in 43 other files.
We're changing the definition of each of the use counter histograms.
Therefore, they need new names, so as to not throw wrenches into the
server-side machinery. This renaming is the most straightforward way to
do things and similar to how we have renamed other histograms before.
We're changing the definition of each of the use counter histograms.
Therefore, they need new names, so as to not throw wrenches into the
server-side machinery. This renaming is the most straightforward way to
do things and similar to how we have renamed other histograms before.
This patch teaches gen-histogram-enum.py how to correctly deal with the
situation where there are no use counters. It also adds
mozilla::Telemetry::GetHistogramName for debugging purposes.
We would like to be able to forward-declare Telemetry::ID, so fewer
header files need to include Telemetry.h. Empirical evidence shows that
forward-declaring enums requires either enum classes, or plain
fixed-width enums. Let's opt for the latter here; there's no need to
constrain the size to 16 bits, since Telemetry::IDs are rarely stored in
data structures.
