Commit Graph

37 Commits

Author SHA1 Message Date
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
e5b59d7fbd Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Sebastian Hengst
e906b9416f Backed out changeset 61029bd1995a (bug 1285577) for failing test_autofill_https_upgrade.html at least on Linux. r=backout 2016-12-20 22:56:02 +01:00
Gijs Kruitbosch
c8e3816d11 Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Luke Chang
36e6375328 Bug 1309481 - Remove leftover code specific to Logins from JSONFile.jsm and add tests; r=Paolo
MozReview-Commit-ID: DjEPCN2PXA1
2016-10-17 18:26:35 +08:00
Matthew Noorenberghe
a33e675832 Bug 1301287 - Password manager: enable eslint brace-style rule on shipping code. r=johannh
MozReview-Commit-ID: BDHUOlv83eR
2016-09-07 21:45:20 -07:00
Matthew Noorenberghe
dfc22c9e92 Bug 1299984 - Enable eslint no-unused-vars for shipping pwmgr code. r=johannh
I also fixed two test cases while I was looking at the results.

MozReview-Commit-ID: LpUj56UNV3r
2016-09-02 14:07:13 -07:00
Kapeel Sable
a01eea4f83 Bug 1058438 - Migrate disabledHosts from json storage to permission manager. r=MattN
MozReview-Commit-ID: 2qaUCZjqc47
2016-01-06 17:57:40 +05:30
Saad Quadri
27833c0d92 Bug 1058438 - Remove disabledHost APIs from storage and use permission manager directly in LoginManager. r=MattN
MozReview-Commit-ID: AheLazqkLoK
2016-08-09 10:14:46 -07:00
Matthew Noorenberghe
0807994fd9 Bug 1127579 - Handle a user capturing a HTTPS login with an already saved login for the HTTP version. r=dolske
MozReview-Commit-ID: 4vWuFUmicYV
2016-06-24 10:32:16 -04:00
Matthew Noorenberghe
f8dcc2a8ff Bug 667233 - Support scheme upgrades for searching logins. r=dolske
MozReview-Commit-ID: GAw0HIBgOFw
2016-05-29 17:15:52 -07:00
Matthew Noorenberghe
370df6c2aa Bug 667233 - Backout bug 1147561 to only support formSubmit upgrades so we can use the same logic. r=dolske
[mq]: backout_1147561

MozReview-Commit-ID: IKGj6rT1xTX
2016-05-29 17:15:45 -07:00
Sebastian Hengst
0abe30125d Bug 1251916 - Use standard JavaScript features in toolkit/components/passwordmgr to pass eslint checks: replace legacy generators with ES6 generators. r=MattN
MozReview-Commit-ID: KxMSovx0mfl
2016-02-28 14:11:17 -08:00
Tooru Fujisawa
2bf22fe47e Bug 1217082 - Remove for-each from toolkit/. r=Gijs 2015-10-19 04:57:14 +09:00
Matthew Noorenberghe
5cce34db10 No bug - Password manager: Modernize the style of storage-json.js. 2015-08-25 16:11:42 -07:00
Riadh Chtara
9bb3222b09 Bug 1178453 - Change logging in storage-json.js to avoid string concatenation. r=MattN 2015-06-30 12:06:52 -07:00
Bernardo P. Rittmeyer
2ac850acd1 Bug 1147561 - Fallback to logins with the same hostPort but different scheme for the form action. r=MattN 2015-06-04 14:54:44 -07:00
Matthew Noorenberghe
d8deac6c51 Bug 1171348 - Switch password manager to richer logging via Console.jsm. r=dolske 2015-06-04 14:32:44 -07:00
Ryan VanderMeulen
dd4904d1a0 Backed out changeset 2614fbb8d385 (bug 1147561) for Android mochitest failures. 2015-05-29 12:22:47 -04:00
Bernardo P. Rittmeyer
c563fd3860 Bug 1147561 - Fallback to logins with the same hostPort but different scheme for the form action. r=MattN 2015-05-28 15:11:48 -07:00
shreyas
1eb670c74d Bug 394686 - passwordmgr: Throw Components.Exceptions and Error instead of strings. r=MattN 2015-02-23 18:45:00 -08:00
Paolo Amadini
23b9a8d9ce Bug 1128203 - Reduce indentation from 4 to 2 spaces. rs=dolske DONTBUILD CLOSED TREE 2015-01-31 21:25:49 +00:00
Blake Kaplan
197bf4e441 Bug 1029128 - Fix strict-mode error in the JSON storage file. r=dolske 2014-06-24 16:57:40 -04:00
Carsten "Tomcat" Book
73708a0db4 Backed out changeset df7bcbbeda21 (bug 1029128) 2014-06-27 15:17:23 +02:00
Blake Kaplan
e7396ccb03 Bug 1029128 - Fix strict-mode error in the JSON storage file. r=dolske 2014-06-24 16:57:40 -04:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Ryan VanderMeulen
e3bc0bb1f8 Backed out 5 changesets (bug 993197, bug 949617, bug 995489, bug 1029128) for Android test failures.
Backed out changeset 033d6271fd19 (bug 1029128)
Backed out changeset f568b1dc9880 (bug 1029128)
Backed out changeset daa9c46d19dc (bug 949617)
Backed out changeset 2baf5c61cbf5 (bug 995489)
Backed out changeset 654c1f0c88bc (bug 993197)
2014-06-24 15:36:18 -04:00
Blake Kaplan
2284458971 Bug 1029128 - Fix strict-mode error in the JSON storage file. r=dolske 2014-06-24 14:34:02 -04:00
Paolo Amadini
999537c1cc Bug 853549 - Use a JSON storage back-end in the Login Manager, except on Android. r=dolske 2014-01-07 17:29:41 +01:00
Carsten "Tomcat" Book
be98627aee Backed out changeset ca4caf0d721c (bug 853549) for valgrind testfailures 2014-05-28 15:53:13 +02:00
Paolo Amadini
3bf90d715a Bug 853549 - Use a JSON storage back-end in the Login Manager, except on Android. r=dolske 2014-01-07 17:29:41 +01:00