Commit Graph

48 Commits

Author SHA1 Message Date
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Florian Quèze
c1bca211b8 Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop. 2017-03-16 19:26:02 +01:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
703aa9e231 Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
MozReview-Commit-ID: Ed9FfkskDos
2017-02-20 11:45:58 +00:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Jared Wein
cc200d7f1f Bug 1294618 - Enable the computed-property-spacing rule for eslint. r=felipe
MozReview-Commit-ID: IaN54BFBksA
2016-08-16 15:44:14 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
e8b20b6db5 Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
MozReview-Commit-ID: 2XVoU05YvES
2016-08-04 03:20:25 -04:00
Tooru Fujisawa
2bf22fe47e Bug 1217082 - Remove for-each from toolkit/. r=Gijs 2015-10-19 04:57:14 +09:00
Tooru Fujisawa
afbd2956bc Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs 2015-09-24 20:32:23 +09:00
Tooru Fujisawa
3d13712ac2 Backed out changeset 036615ba3257 (bug 1207498) for Linux pgo M(oth) failure 2015-09-27 23:42:50 +09:00
Tooru Fujisawa
f2efd2a948 Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs 2015-09-24 20:32:23 +09:00
aceman
eec6d90c80 Bug 1063469 - fix some trivial "assignment to undeclared variable" in extApplication.js. r=Neil 2014-09-10 07:49:00 +01:00
Justin Lebar
9339ceb731 Bug 750454 - Fix FUEL leaks. Part 8: Reformat FUEL code. r=mak 2012-06-05 20:05:50 -04:00
Justin Lebar
8c56ff5daa Bug 750454 - Fix FUEL leaks. Part 6: Remove gShutdown. r=mak 2012-06-05 20:05:50 -04:00
Justin Lebar
d4ec28e1d1 Bug 750454 - Fix FUEL leaks. Part 5: Fix extensions. r=mak 2012-06-05 20:05:50 -04:00
Justin Lebar
2f4e0426db Bug 750454 - Fix FUEL leaks. Part 3: Fix preferences leaks. r=mak 2012-06-05 20:05:50 -04:00
Justin Lebar
049b3cd33e Bug 750454 - Fix FUEL leaks. Part 1: Use weak refs in Application. r=mak 2012-06-05 20:05:50 -04:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Patrick Walton
fa51df0e40 Bug 750583 - Empty out FUEL's gShutdown array in a less clownshoes manner. r=jlebar 2012-05-04 12:11:13 -07:00
Geoff Lankow
ea30cec949 Bug 718255 - Merge nsIPrefBranch2 with nsIPrefBranch - Part C, remove uses of nsIPrefBranch2 in toolkit/ ; r=bsmedberg 2012-01-17 14:18:29 +13:00
Peter Van der Beken
c5e3434613 Fix for bug 658632 (Provide easy way to add non-leaky classinfo to JS components). r=gavin. 2011-05-25 10:46:51 +02:00
Benjamin Smedberg
1c52097d6a Fix review comments from bug 568691 comment 45. 2010-06-24 11:56:28 -04:00
Benjamin Smedberg
27bd95f35a Bug 573557 - Rename the category names for script globals to avoid spaces, r=jst 2010-06-21 16:57:44 -04:00
John P Baker
9ae67110e0 Bug 566866 - "Restart now" gives Quit dialog instead of Restart dialog. r=dtownsend 2010-05-26 14:50:29 +02:00
Dave Townsend
94d5b45b62 Bug 552731: Update FUEL to use the new EM APIs. r=mfinkle 2010-04-20 15:14:15 -07:00
Dave Townsend
c92630540b Backout new add-ons manager due to Ts regression on OSX 10.5 2010-05-01 11:04:44 -07:00
Dave Townsend
71b219fa1e Bug 552731: Update FUEL to use the new EM APIs. r=mfinkle 2010-04-20 15:14:15 -07:00
Dão Gottwald
cd69cf50e2 Bug 543675 - Assignment to undeclared variable eventItem. r=mfinkle 2010-02-03 13:40:55 +01:00
Dietrich Ayala
971fcd529d Bug 506471 - FUEL should avoid putting itself in the app-startup category (r=mfinkle) 2010-01-31 19:12:57 -08:00
Metal Sonic
259a398dae Bug 507387 - fix copyright holder; Mozilla Corporation -> Mozilla Foundation. r=gerv. 2009-12-21 21:50:30 +00:00
Dão Gottwald
37102a6574 Bug 526987 - getItemList, getIncompatibleItemList, getDependentItemListForID and updateAndGetNewBlocklistedItems itemCount out params should be optional. r=dtownsend 2009-11-07 09:21:07 +01:00
Dão Gottwald
9ed8c58506 Bug 524270 - Make the second getChildList parameter optional. r=bsmedberg 2009-10-26 21:02:06 +01:00
Dietrich Ayala
5092f3e863 backing out bug 506471 due to leaks 2009-10-14 17:01:55 -07:00
Paul O’Shannessy
b4a55e2e19 Followup to Bug 506471 - Fix whitespace & remove unused code. r=dietrich 2009-10-14 15:17:51 -07:00
33c7e4a2a3 Bug 506471 - FUEL should avoid putting itself in the app-startup category (r=mfinkle) 2009-10-14 13:31:48 -07:00
Mark Finkle
99b8336588 Bug 473156: fuelIEvents.removeListener removes all listeners for an event, r=dtownsend 2009-01-15 13:47:55 -05:00
Shawn Wilsher
74ac72d8b2 Bug 462077 - Lazily create Extensions object (FUEL)
This lazily creates the Extensions object off of Application so we do not take
the hit of initializing the object during startup if we do not need it.
r=gavin
2008-10-29 16:56:46 -04:00
816cfbea6c b=338039, p=zeniko, r=enndeakin. Provide easy, right way to restart an application. 2008-09-06 23:30:13 -05:00
9d3f9e1efd Factor out generic toolkit aspects of FUEL into a reusable form (bug 407693), patch by Joey Minta <jminta@gmail.com> and Emre Birol <ebirol@gmail.com>; r=mfinkle, moa for adding toolkit directory=bsmedberg, a1.9b5=beltzner 2008-03-24 17:38:03 -07:00
017872126a Back out jminta's FUEL/exthandler patch from bug 407963 due to assertion failure and leaks. 2008-01-13 00:26:09 -08:00
65780f848d Bug 407963 - "[FUEL] Factor out generic toolkit aspects of FUEL into a reusable form" [p=jminta@gmail.com (Joey Minta) r=mfinkle r=gavin sr=bsmedberg a1.9=beltzner] 2008-01-12 23:48:31 -08:00