corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
854,239 Commits 1 Branch 0 Tags
ae45f2ecde7111edd410ff7884dc28cc8ba3496a
Commit Graph

878 Commits

Author SHA1 Message Date
Kelly Cochrane
d65e0d0ea0 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 17:02:53 +00:00
Kelly Cochrane
53986eb4ea Bug 1877298 - Create reusable token for color used in the tab attention radial gradient. r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,jules,dao,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D202736
 2024-03-22 16:24:02 +00:00
Stanca Serban
766c9f922a Backed out changeset 319a405e8b57 (bug 1883876) for causing mochitests failures in browser_blanking.js. 2024-03-22 18:22:25 +02:00
Kelly Cochrane
7cc1085907 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 14:02:18 +00:00
Sandor Molnar
ae3c7d9083 Backed out changeset 153aa2b4247f (bug 1883876) for causing multiple bc failures @ browser/components/firefoxview/<...> & browser/components/aboutwelcome/<...> 2024-03-21 21:46:22 +02:00
Kelly Cochrane
8b550e92b2 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-21 18:44:36 +00:00
Jonathan Sudiaman
500347dd76 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 23:21:13 +00:00
Anna Yeddi
ffcc38c3ed Bug 1886114 - Remove fail-if notation from the Firefox View test passing a11y-checks. r=sfoster,fxview-reviewers 
the updated version of the Show More link activation has resolved the issue that was there before: the link used to be clicked when it still had `hidden` attribute on - probably, right before it was rendered as shown/un-hidden, since the test harness is moving too fast. In this updated case, all the instances of the Show More links being clicked while they are visible and, therefore, accessible for the Accessibility API. We could safely remove the `fail-if` since it's working now as expected

Differential Revision: https://phabricator.services.mozilla.com/D205151
 2024-03-19 23:07:42 +00:00
Sandor Molnar
ac42f14d15 Backed out changeset 2092d43bfaae (bug 1880539) for causing bc failures @ browser/components/firefoxview/tests/browser/<...> CLOSED TREE 2024-03-19 18:29:33 +02:00
Jonathan Sudiaman
4076b15f24 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 14:03:41 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Sam Foster
688e369bcf Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements 
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
 2024-03-18 21:08:13 +00:00
Sam Foster
db523bd98e Bug 1877678 - Split out the some of the open tabs tests into their own file. r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202486
 2024-03-18 21:08:12 +00:00
Nikki Sharpley
c5dc18eeec Bug 1880540 - Refactor History component functionality into Lit controller r=fxview-reviewers,jsudiaman,sclements,hjones 
Extrapolate common history functionality to a controller that can be used across view and sidebar.
This includes the ability to delete from history, visit a link from history, sort by options, search history and format results.

Differential Revision: https://phabricator.services.mozilla.com/D202726
 2024-03-18 04:59:43 +00:00
Anna Yeddi
62176e33f3 Bug 1884278 - Add exceptions from a11y_checks for clicks on a not focusable pinned media button on Firefox View. r=kcochrane,fxview-reviewers 
The Firefox View tests, i.e. `browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js:test_mute_unmute_pinned_tab` sends [a click on a pinned mute/unmute control](https://searchfox.org/mozilla-central/rev/b55a24116575b1b6c17f1aa56a0b142d86dfa41c/browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js#324-325,341-342) that is intentionally made not focusable to follow the existent tab panel behavior.

A keyboard-only user could mute/unmute this pinned tab via the context menu, while we do not want to create an additional, unnecessary tabstop for this control as well. Thus we add an exception from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notation from its test manifest.

Depends on D203987

Differential Revision: https://phabricator.services.mozilla.com/D203988
 2024-03-12 14:32:45 +00:00
Anna Yeddi
a19a18f721 Bug 1879447 - Update AccessibilityUtils to support intervening generics between a tab and its tablist in isKeyboardFocusableTabInTablist check. r=Jamie,fxview-reviewers 
There are cases in our code base, in the reusable component that is using Lit components, where a tablist includes a tab component wrapper (that has an accessible role `ROLE_TEXT_CONTAINER`) - the `<moz-page-nav-button>` - we want to include this case in the calculation of the tabs within a tablist calculation when checking the tablist's keyboard accessibility.

Differential Revision: https://phabricator.services.mozilla.com/D203987
 2024-03-12 14:32:45 +00:00
Kelly Cochrane
675a186e05 Bug 1884322 - Only toggle mute/unmute tabs in Fx View with Enter/Space keys if using keyboard navigation r=fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D204042
 2024-03-09 17:14:17 +00:00
Nikki Sharpley
f77658f22b Bug 1877786 - Test for muting and unmuting a tab via tab row keyboard navigation r=fxview-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D203936
 2024-03-08 19:58:02 +00:00
Nikki Sharpley
5357a2cc6f Bug 1884170 - Missing options button icon in history fixed r=fxview-reviewers,kcochrane 
Added correct secondary class names to show options button icon in history.

Differential Revision: https://phabricator.services.mozilla.com/D203928
 2024-03-07 21:39:31 +00:00
Nikki Sharpley
b5e05a75af Bug 1883714 - Prioritise styling for attention class over bookmark and pinnedOnNewTab r=fxview-reviewers,desktop-theme-reviewers,kcochrane 
The bug report showed the tabs that were pinned and bookmarked shift the notification dot position.
This fix excludes `.attention` from positional styling applied to `.pinnedOnNewTab` and `.bookmark` classes

Differential Revision: https://phabricator.services.mozilla.com/D203923
 2024-03-07 20:58:38 +00:00
Kelly Cochrane
cd1bec4c24 Bug 1883890 - Ensure proper HCM styles are being applied to media button for pinned tabs in Fx View r=fxview-reviewers,ayeddi,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D203827
 2024-03-07 18:32:21 +00:00
Kelly Cochrane
b530008ed4 Bug 1883628 - Wrap pinned tabs in Firefox View to a new line once there are more than one line's worth r=fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D203635
 2024-03-07 14:47:57 +00:00
Cosmin Sabou
0e89801978 Bug 1877678 - Disable browser_opentabs_cards.js on linux and osx1100 opt for frequent failures. r=#intermittent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203861
 2024-03-07 00:19:37 +00:00
Kelly Cochrane
f9d8aa7f85 Bug 1883850 - Ensure selected moz-page-nav button remains selected upon page refresh of Fx View r=fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203783
 2024-03-06 21:13:29 +00:00
Nikki Sharpley
0fed7c98ce Bug 1883610 - skip a11y tests for browser_history_firefoxview.js` temporarily r=ayeddi,fxview-reviewers 
Until we have a fix for the sidebar navigation component buttons, `moz-page-nav-button`, in bug 1850591, disable a11y tests referencing these buttons.

Differential Revision: https://phabricator.services.mozilla.com/D203617
 2024-03-06 21:05:26 +00:00
Hanna Jones
47bca262bf Bug 1880481 - Create a story for panel-list submenu r=reusable-components-reviewers,desktop-theme-reviewers,fxview-reviewers,emilio,sclements 
This patch adds a story for `panel-list` submenus to document how to create them. It also amends the README with a small code example, and moves the submenu slot creation out of the constructor to the connectedCallback, since we can't reliably read attribute values in custom element constructors.

Differential Revision: https://phabricator.services.mozilla.com/D202012
 2024-03-06 20:09:39 +00:00
Kelly Cochrane
bf4070efdc Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 15:49:24 +00:00
Norisz Fay
81c5a0094d Backed out changeset c23d6a5f066e (bug 1883337) for causing bc failures on browser_opentabs_pinned_tabs.js CLOSED TREE 2024-03-05 17:10:15 +02:00
Kelly Cochrane
4a30e42b73 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 13:49:03 +00:00
Jonathan Sudiaman
79a9016c9f Bug 1883235 - [Firefox View] The search box cannot fully display CJK characters r=fxview-reviewers,sclements 
[Input size](https://searchfox.org/mozilla-central/source/browser/components/firefoxview/opentabs.mjs#216) of `30` approximately matches what's shown in [the spec](https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=6730-179702&mode=design&t=9DlykASuAzE3hP9S-0). Establish that as the minimum, and it will automatically expand for other locales as needed.

Differential Revision: https://phabricator.services.mozilla.com/D203477
 2024-03-04 20:33:13 +00:00
Nikki Sharpley
615a7e4a90 Bug 1876862 - Add extra logs and update waitForCondition to resolve browser_history_firefoxview.js timeouts r=fxview-reviewers,sclements,kcochrane 
- added extra log in for when `waitForCondition` `historyComponentReady` fails
- added extra `waitForCondition` for history component selection.
- added helper function for creating history entries

Try submission: https://treeherder.mozilla.org/jobs?repo=try&revision=4682e0db2e42e87278e9d6dd321c0174f67cfe49&selectedTaskRun=G8kefdugSt6U4J0VsfMsXQ.0

This seems to resolve bug 1877594 as well.

Differential Revision: https://phabricator.services.mozilla.com/D201223
 2024-03-04 17:55:35 +00:00
Jonathan Sudiaman
a85f5fcf62 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-04 13:02:16 +00:00
Nikki Sharpley
3d5f2a1927 Bug 1882605 - Fix intermittent browser_tab_list_keyboard_navigation failure due to reordering of tabs r=fxview-reviewers,kcochrane,jsudiaman 
This patch also disables `browser_tab_list_keyboard_navigation` a11y failing tests noted in Bug 1882597
until Bug 1850591 resolves a11y checks for the `moz-page-nav-button` button to be focusable.

Differential Revision: https://phabricator.services.mozilla.com/D203182
 2024-03-02 00:51:33 +00:00
Iulian Moraru
42888b21f8 Backed out changeset 901f008190e4 (bug 1882605) for causing bc failures on browser_tab_list_keyboard_navigation.js. CLOSED TREE 2024-03-01 19:44:29 +02:00
Nikki Sharpley
efe758b096 Bug 1882605 - Fix intermittent browser_tab_list_keyboard_navigation failure due to reordering of tabs r=fxview-reviewers,kcochrane,jsudiaman 
This patch also disables `browser_tab_list_keyboard_navigation` a11y failing tests noted in Bug 1882597
until Bug 1850591 resolves a11y checks for the `moz-page-nav-button` button to be focusable.

Differential Revision: https://phabricator.services.mozilla.com/D203182
 2024-03-01 16:50:59 +00:00
Iulian Moraru
26d2d56621 Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
f4ce3f9847 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-01 13:34:08 +00:00
Nikki Sharpley
8dceebb0c7 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio 
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
 2024-02-29 02:26:27 +00:00
Stanca Serban
c5104d8b31 Bug 1857298 - Fix lint failure in browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js. a=lint-fix CLOSED TREE 2024-02-28 22:20:51 +02:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE 
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
 2024-02-28 20:47:18 +02:00
Sandor Molnar
38ed31cc11 Bug 1857298 - Fix lint failure @ browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js a=lint-fix CLOSED TREE 2024-02-28 19:52:12 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 17:31:17 +00:00
Kelly Cochrane
32b2d59715 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 23:33:19 +00:00
Natalia Csoregi
20f1a3f6d6 Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE 
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
 2024-02-28 00:22:14 +02:00
Kelly Cochrane
4cd48be87c Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 20:30:59 +00:00
Sam Foster
ae1907b174 Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements 
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
 2024-02-27 18:26:18 +00:00
Sam Foster
a00823f347 Bug 1877678 - Split out the open tabs 'more' tests into their own file. r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202486
 2024-02-27 18:26:18 +00:00
Cristian Tuns
26a80e06db Backed out changeset f9c17890d242 (bug 1849175) for causing bc failures in browser_opentabs_firefoxview.js CLOSED TREE 2024-02-27 11:56:55 -05:00
Kelly Cochrane
11fb04203e Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 16:27:20 +00:00