Commit Graph

77 Commits

Author SHA1 Message Date
Mike Conley
7b4982e14e Bug 1783918 - Part 4: Plumb trigger event through to calls to webrtcUI.showSharingDoorhanger and have it call openPopup directly. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154130
2022-08-10 15:05:33 +00:00
Mike Conley
60c3b5bffe Bug 1783918 - Part 1: Remove redundant command event handlers. r=pbz
There's already a command event handler on the whole webrtcIndicator window,
so we don't need to set additional ones on the menuitems, as the window handler
is doing the same thing.

Differential Revision: https://phabricator.services.mozilla.com/D154127
2022-08-10 15:05:31 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
bf94464e91 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 04:42:08 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
6ed0357d29 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 02:49:12 +00:00
Mike Conley
bccd5b3efd Bug 1672432 - Don't remove persistent device permissions when clicking 'Stop Sharing' in the WebRTC global indicator. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D94501
2020-10-27 16:28:25 +00:00
Mike Conley
fb9e758891 Bug 1669801 - Fix the shared device menupopup when sharing an application window over WebRTC. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D92994
2020-10-13 01:13:04 +00:00
Mike Conley
69dc33ff19 Bug 1668838 - Make sure popuphiding event is only considered for device control menus in WebRTC indicator. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D92241
2020-10-05 09:23:40 +00:00
Mike Conley
25f995b3c3 Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
2020-09-30 21:14:10 +00:00
Mike Conley
630db48455 Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
2020-09-30 21:14:07 +00:00
Narcis Beleuzu
d67d02f05c Backed out 9 changesets (bug 1661474, bug 1668010, bug 1663784, bug 1665490) for bc failures on browser_all_files_referenced.js . CLOSED TREE
Backed out changeset 9a5e08c77923 (bug 1668010)
Backed out changeset 9bcba802456e (bug 1665490)
Backed out changeset 82ba64e4e81f (bug 1661474)
Backed out changeset 9b5d89c13aa3 (bug 1661474)
Backed out changeset e812f197f225 (bug 1663784)
Backed out changeset ddfbe96735f3 (bug 1663784)
Backed out changeset 282d763360a2 (bug 1663784)
Backed out changeset 9e5267b83d94 (bug 1663784)
Backed out changeset 53a57a5b60d3 (bug 1663784)
2020-10-01 00:08:50 +03:00
Mike Conley
0d469c4a46 Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
2020-09-30 15:15:58 +00:00
Mike Conley
0e5e8e10f6 Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
2020-09-30 15:13:14 +00:00
Razvan Maries
80c4993f85 Backed out 8 changesets (bug 1661474, bug 1663784, bug 1665490) for build bustages on IconLoaderHelperCocoa.h and nsMenuItemIconX.mm. CLOSED TREE
Backed out changeset 4a035c0339f8 (bug 1665490)
Backed out changeset 573e8d8d1fc8 (bug 1661474)
Backed out changeset c2d5b0b0a1a3 (bug 1661474)
Backed out changeset 97be0dd0742d (bug 1663784)
Backed out changeset 428926be2268 (bug 1663784)
Backed out changeset a737df82383a (bug 1663784)
Backed out changeset d1faf309c9d0 (bug 1663784)
Backed out changeset 4ee61c4a6bc8 (bug 1663784)
2020-09-30 02:16:00 +03:00
Mike Conley
2be147db6c Bug 1661474 - Hide the global mute toggles by default, and only show the new indicator when sharing a display. r=pbz
Depends on D91644

Differential Revision: https://phabricator.services.mozilla.com/D88478
2020-09-29 06:51:43 +00:00
Mike Conley
e0bd8fae92 Bug 1663784 - Make the new WebRTC indicator use the nsISystemStatusBar service on Windows. r=pbz,fluent-reviewers,flod
Depends on D89787

Differential Revision: https://phabricator.services.mozilla.com/D89788
2020-09-29 06:50:04 +00:00
Mike Conley
844a8b92ad Bug 1643027 - Turn the microphone and camera icons in the WebRTC indicator into global mute toggles. r=pbz,fluent-reviewers,flod
Depends on D86719

Differential Revision: https://phabricator.services.mozilla.com/D86619
2020-08-27 17:03:43 +00:00
Bogdan Tara
73e3a4abbb Backed out 6 changesets (bug 1643027, bug 1658353) for browser_parsable_css.js failures CLOSED TREE
Backed out changeset e50501b54674 (bug 1643027)
Backed out changeset aa5d33b0d0b5 (bug 1643027)
Backed out changeset 51c592eb4ebd (bug 1643027)
Backed out changeset fe37ed8ba008 (bug 1658353)
Backed out changeset acb933a440c7 (bug 1658353)
Backed out changeset 7aa764991e49 (bug 1658353)
2020-08-27 18:39:49 +03:00
Mike Conley
8f9b3e74f6 Bug 1643027 - Turn the microphone and camera icons in the WebRTC indicator into global mute toggles. r=pbz,fluent-reviewers,flod
Depends on D86719

Differential Revision: https://phabricator.services.mozilla.com/D86619
2020-08-26 21:31:29 +00:00
Mike Conley
7030e675f5 Bug 1657484 - Change default location of the WebRTC global sharing indicator. r=pbz
Per UX, the new default location for the indicator upon opening is the the top
of the content viewport of the most recently used browser window.

Differential Revision: https://phabricator.services.mozilla.com/D86080
2020-08-11 10:03:07 +00:00
Mike Conley
b0f27dc578 Bug 1655078 - Make the 'Stop Sharing' button in the WebRTC indicator stop all screen sharing streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D85414
2020-08-05 03:38:19 +00:00
Bogdan Tara
e743b40e47 Backed out changeset 33eb26623d7e (bug 1655078) for browser_stop_sharing_button.js failures CLOSED TREE 2020-08-05 01:00:42 +03:00
Mike Conley
aee9e6de85 Bug 1655078 - Make the 'Stop Sharing' button in the WebRTC indicator stop all screen sharing streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D85414
2020-08-04 20:50:19 +00:00
Mike Conley
68d3b6fb69 Bug 1654266 - Make sure the 'Stop Sharing' button in the WebRTC indicator only stops displays, and not mic/camera streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D84574
2020-07-24 15:14:17 +00:00
Mike Conley
d39711da49 Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-17 01:22:10 +00:00
Bogdan Tara
17ab4cfa11 Backed out 2 changesets (bug 1649032) for leakcheck failures CLOSED TREE
Backed out changeset ef80a597db37 (bug 1649032)
Backed out changeset a8462c37bef1 (bug 1649032)
2020-07-16 00:37:06 +03:00
Mike Conley
9a062460bd Bug 1652466 - Add an about:config preference to hide the new global sharing indicator. r=pbz
This works by hiding the window instead of skipping opening it. This seems safer, since
there are parts of webrtcUI that expect to call functions on the window.

Differential Revision: https://phabricator.services.mozilla.com/D83348
2020-07-15 10:40:04 +00:00
Mike Conley
c702848ffa Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-15 10:22:12 +00:00
Mike Conley
df9d7d3d5a Bug 1650243 - Don't accidentally restore the WebRTC global sharing indicator if it is minimized when changing streams. r=pbz
window.sizeToContent causes a minimized window to be restored, so we skip calling that if the
indicator is minimized. We call it instead once the indicator is restored.

Differential Revision: https://phabricator.services.mozilla.com/D82620
2020-07-08 09:34:39 +00:00
Mike Conley
080caf098d Bug 1645466 - Prevent the WebRTC indicator from being resized manually on Linux GTK. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D80019
2020-06-17 17:04:51 +00:00
Mike Conley
35927f76f2 Bug 1645481 - Open the WebRTC indicator on the same display as the most recent browser window. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79544
2020-06-16 13:19:16 +00:00
Mike Conley
e052c6ab51 Bug 1644905 - Make the display sharing container a group, and set aria-labelledby when updating the displayed label. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79357
2020-06-16 11:20:57 +00:00
Mike Conley
4c141c447c Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79343
2020-06-12 18:59:59 +00:00
Narcis Beleuzu
d61fb48e85 Backed out 4 changesets (bug 1643503) for bc failures on browser_parsable_css.js . CLOSED TREE
Backed out changeset a890be633ec3 (bug 1643503)
Backed out changeset 1f8dcaafb864 (bug 1643503)
Backed out changeset b28d0c018553 (bug 1643503)
Backed out changeset 1bcaedf06fb9 (bug 1643503)
2020-06-12 21:56:16 +03:00
Mike Conley
93df24710e Bug 1643503 - Offset the initial vertical position of the WebRTC indicator by 80px. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D79343
2020-06-12 15:39:01 +00:00
Mike Conley
3f869ebd2a Bug 1639337 - Factor out the macOS status bar WebRTC indicator into a reusable class. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D76388
2020-05-26 18:00:36 +00:00
Mike Conley
563c1b3ca3 Bug 1636207 - Create a new WebRTC global indicator. r=fluent-reviewers,flod,johannh
Differential Revision: https://phabricator.services.mozilla.com/D74333
2020-05-18 18:57:40 +00:00
devRD
be92aeb6cc Bug 1618477 - The permissions prompt is not displayed by clicking on the control sharing panel. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66381
2020-03-16 09:22:29 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00