Commit Graph

38349 Commits

Author SHA1 Message Date
Rob Wu
ac7632657a Bug 1874232 - Simplify platform-conditional extension css r=rpl,desktop-theme-reviewers,emilio
Merge (browser_style) extension-mac.css with extension.css and use
-moz-platform media query for conditional CSS.

Replace extension-{mac,linux,win}-panel.css with one CSS file, without
platform-specific conditions since their content were already identical.

Simplified JS code referencing these CSS files: Instead of lazy getters
("extensionStylesheets") exported and imported across modules, use plain
string constants for simplicity. The extension.css file is not expected
to be used in new code since it is a deprecated feature, and the string
is sufficiently unique to be easily findable through code search.

Differential Revision: https://phabricator.services.mozilla.com/D198312
2024-01-22 17:19:51 +00:00
Rob Wu
3b4a42c169 Bug 1873024 - Move browser_style sheets to layered author sheet r=rpl,desktop-theme-reviewers,emilio
The `browser.display.document_color_use` is an a11y feature to allow
users to override colors. This feature does not work for UA stylesheets
and results in the reported bug.

To resolve the bug, this patch changes browser_style to be added as an
AUTHOR_SHEET instead of AGENT_SHEET. To avoid backwards-compatibility
issues, the patch also wraps the stylesheet content in a @layer to
ensure that all rules have a lower precedence than any (unlayered)
extension stylesheet.

The `browser.display.document_color_use` pref is also controlled
through the `browserSettings.overrideDocumentColors` extension API.
For extra test coverage, this patch sets the pref with that API
instead of setting the prefs directly.

Differential Revision: https://phabricator.services.mozilla.com/D198117
2024-01-22 17:19:51 +00:00
Norisz Fay
fd5de2796c Backed out 6 changesets (bug 1873743) for causing bc failures on browser_translations_panel_auto_translate_error_view.js
Backed out changeset bb96b326fd83 (bug 1873743)
Backed out changeset a695e04c3d54 (bug 1873743)
Backed out changeset 114ea06972d3 (bug 1873743)
Backed out changeset 59d5a7bff4fa (bug 1873743)
Backed out changeset 70ffe08ff7cb (bug 1873743)
Backed out changeset af470fddc2d4 (bug 1873743)
2024-01-22 21:30:16 +02:00
Greg Tatum
db713c8e44 Bug 1873743 - Centralize the engine process logic; r=translations-reviewers,nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D198075
2024-01-22 16:21:50 +00:00
Thomas Wisniewski
6e38e55839 Bug 1875355 - simplify the input validation logic of Report Broken Site to be stateless; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D199015
2024-01-22 16:05:11 +00:00
Jaydeep Das
95cda128bf Bug 328707 - Allow only valid IP/Hostname for Proxy Config, r=mconley,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D198425
2024-01-22 14:28:41 +00:00
Norisz Fay
22f52ae24a Backed out 2 changesets (bug 1875079) for causing bc failures on browser_menu_touch.js CLOSED TREE
Backed out changeset 015e7b62138b (bug 1875079)
Backed out changeset 3a62cca5ea26 (bug 1875079)
2024-01-22 20:01:57 +02:00
Mike Conley
5f1e50dd88 Bug 1873969 - Convert HighlightsFeed.jsm to an ESM. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D198323
2024-01-22 14:22:35 +00:00
Mike Conley
d8c6aab709 Bug 1873969 - Convert HighlightsFeed.test.js to an xpcshell test. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D198322
2024-01-22 14:22:35 +00:00
Mike Conley
568af18b86 Bug 1868194 - Convert TelemetryFeed.jsm to an ESM. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D197972
2024-01-22 14:22:34 +00:00
Mike Conley
4224a8301a Bug 1868194 - Convert TelemetryFeed.test.js to an xpcshell test. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D197731
2024-01-22 14:22:34 +00:00
Mike Conley
1c9ce2e1dd Bug 1868194 - Convert some PingCentre ping schema tests from joi to JSON schema. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D197730
2024-01-22 14:22:33 +00:00
Mike Conley
6426ed7ca6 Bug 1868194 - TelemetryFeed.uninit should unregister all preference observers. r=thecount
Prior to this patch, we would add preference observers during TelemetryFeed.init,
but never remove them on uninit. In the common case, a TelemetryFeed is only ever
created once, so this is mostly fine - but in rare cases (for example, a user chooses
to disable and re-enable TelemetryFeed multiple times via prefs) or in automated
testing (where we create, init and destroy many instances of TelemetryFeed), failing
to remove preference observers means that we keep the feed alive even after its
uninitted, and also continue to have it react to preference changes.

Differential Revision: https://phabricator.services.mozilla.com/D197729
2024-01-22 14:22:33 +00:00
Meera Murthy
fe0b7efdd1 Bug 1869830 - [translations] Add a page for Translation Setting Preferences. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D197048
2024-01-22 14:19:25 +00:00
Kagami Sascha Rosylight
5b2c025f9e Bug 1875079 - Part 2: Reduce max-height by zoom factor r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D198803
2024-01-22 12:05:34 +00:00
Narcis Beleuzu
f9b3d057ab Backed out changeset f83bd0235854 (bug 1863636) for causing Bug 1875554 2024-01-22 12:52:17 +02:00
Niklas Baumgardner
9b5daf0abd Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Dão Gottwald
fe07007fb3 Bug 1810113 - UrlbarProviderPlaces and UrlbarProviderSearchSuggestions should set isBlockable and blockL10n for history results. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D168993
2024-01-19 21:43:28 +00:00
Nipun Shukla
42f11d9ee3 Bug 1863636 - Part 2: Added native code changes for taskbar tabs r=win-reviewers,mhughes,gstoll
Differential Revision: https://phabricator.services.mozilla.com/D197342
2024-01-19 20:58:16 +00:00
negin
1e401dc974 Bug 1874968 - Implements focus urlbar on newtab after onboarding pref r=omc-reviewers,hanna_a,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D198860
2024-01-19 20:05:31 +00:00
Jason Prickett
d7afb78348 Bug 1871040 - Add margin to shopping survey header to prevent dismiss overlap r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D198346
2024-01-19 17:44:13 +00:00
Cosmin Sabou
bca083246a Bug 1855360 - Fix the skip-if syntax. a=bustage-fix
CLOSED TREE
2024-01-19 19:31:01 +02:00
Cosmin Sabou
57f0dde265 Bug 1855360 - Disable browser_ui_telemetry.js on linux 18.04 for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D199099
2024-01-19 16:43:32 +00:00
Stephanie Cunnane
2d104f535b Bug 1843509 - Remove suggest_sponsor and suggest_non_sponsor are from the urlbar's metrics.yaml file. r=mak DONTBUILD
@mak, in [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1843509#c0 | this comment ]], you mention letting DS know about this removal. So once this patch lands, I'll update the commentary box in the Glean dictionary for urlbar engagement telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D199010
2024-01-19 15:02:30 +00:00
Sandor Molnar
2ed9ff83fd Backed out changeset 4ec2b9afc62a (bug 1874202) bc failures at browser/components/urlbar/tests/browser/browser_clipboard.js CLOSED TREE 2024-01-19 17:03:32 +02:00
Karandeep
a9b23c7611 Bug 1874202 - Add a stopwatch telemetry to record the time it takes to read from the clipboard. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D198595
2024-01-19 13:24:04 +00:00
Daisuke Akatsuka
eb79c672da Bug 1868922: Pass user's query as is to Rust component to keep string cases r=adw
Differential Revision: https://phabricator.services.mozilla.com/D198513
2024-01-19 02:44:41 +00:00
Daisuke Akatsuka
b983b699b2 Bug 1855375: Basic implementation for Yelp Suggestions r=fluent-reviewers,flod,adw
Differential Revision: https://phabricator.services.mozilla.com/D189335
2024-01-19 02:44:41 +00:00
Erik Nordin
87592ba425 Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198831
2024-01-19 02:15:34 +00:00
Erik Nordin
399f696700 Bug 1875090 - Rename ContentTaskUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich,kpatenio
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198830
2024-01-19 02:15:34 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
James Teow
2099213042 Bug 1871084 - Add a timeout for categorization impressions - r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D198592
2024-01-19 01:59:29 +00:00
James Teow
9d567d2240 Bug 1804010 - Add tests for topsite_search interactions - r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D198798
2024-01-19 01:48:22 +00:00
Natalia Csoregi
eb2e3cf8cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
mcheang
4ffcfc6cbc Bug 1667639 - Make keyword at the start of the string take precedence over restrict symbols at the end of the string. r=mak
This patch modifies PlacesUtils to cache the keywords and adds functionality to
find a keyword. The Tokenizer calls PlacesUtils to know if the first word
is a keyword and if the first word is a keyword, then the rest of the search
string will be treated as text and Tokenizer won't filter any other restrict
symbols.

Differential Revision: https://phabricator.services.mozilla.com/D198208
2024-01-19 01:13:39 +00:00
Niklas Baumgardner
729c5b4066 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 00:07:46 +00:00
negin
b49988987f Bug 1863813 - [Easy Setup Feature] - Remove unused strings r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D198816
2024-01-18 21:11:48 +00:00
Punam Dahiya
bcdd920581 Bug 1872768 - Milestone message doorhanger shows incorrect date r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D198477
2024-01-18 20:20:26 +00:00
Iulian Moraru
e1d66150c9 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Dale Harvey
a6bc2baf74 Bug 1841762 - Ensure onEngagement has queryContext defined. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D197265
2024-01-18 17:52:58 +00:00
Niklas Baumgardner
6dd5c4f60b Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-18 17:47:54 +00:00
Cristian Tuns
87fcff935b Backed out 4 changesets (bug 1868922, bug 1855375, bug 1874990) for causing xpcshell failures in /test_tab_quickwrite.js CLOSED TREE
Backed out changeset d558120aba19 (bug 1868922)
Backed out changeset e2c1399903d8 (bug 1855375)
Backed out changeset de119e6a8ced (bug 1874990)
Backed out changeset 3d1ef7c11154 (bug 1874990)
2024-01-18 12:07:55 -05:00
Daisuke Akatsuka
03a5a6291f Bug 1868922: Pass user's query as is to Rust component to keep string cases r=adw
Differential Revision: https://phabricator.services.mozilla.com/D198513
2024-01-18 15:54:42 +00:00
Daisuke Akatsuka
beb26b8db7 Bug 1855375: Basic implementation for Yelp Suggestions r=fluent-reviewers,flod,adw
Differential Revision: https://phabricator.services.mozilla.com/D189335
2024-01-18 15:54:41 +00:00
Sidharth Sachdev
5e76040d6b Bug 1872139 - [about:logins] The top of the focus ring for Edit/Remove button is hidden behind the Sign in to sync section. r=tgiles,credential-management-reviewers,issammani
Differential Revision: https://phabricator.services.mozilla.com/D198251
2024-01-18 15:34:59 +00:00
Nikki Sharpley
17c37d523d Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test

Differential Revision: https://phabricator.services.mozilla.com/D196347
2024-01-18 14:32:33 +00:00
Sarah Clements
3acd84eaf2 Bug 1868583 - Ensure scroll position moves to top when searching in fxview r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D198709
2024-01-18 10:43:35 +00:00