corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,330 Commits 1 Branch 0 Tags
ac73bae0914ea4f1215ebcb72fc7bd2618aaf1b8
Commit Graph

73 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
35c8de4ab5 [components] Import l10n. 2020-10-05 00:29:08 +00:00
Mozilla L10n Automation Bot
51662a3fe3 [components] Import l10n. 2020-10-04 00:25:33 +00:00
Mozilla L10n Automation Bot
b427b25d68 [components] Import l10n. 2020-09-25 00:22:10 +00:00
MozLando
f451c7b0a6 [components] Merge https://github.com/mozilla-mobile/android-components/pull/8176 
8176: For https://github.com/mozilla-mobile/android-components/issues/8175: Allow SuggestionProviders to specify a edit suggestion r=pocmo a=miDeb

The edit suggestion arrow will only be shown if the suggestion is not null or empty. Tapping it autocompletes the suggestion, which can now be specified by the `SuggestionProvider`.



Co-authored-by: Michael Debertol <michael.debertol@gmail.com>
 2020-09-10 17:36:57 +00:00
Mozilla L10n Automation Bot
ad197c4761 [components] Import l10n. 2020-09-10 13:02:00 +02:00
Mozilla L10n Automation Bot
f67c8d27e1 [components] Import l10n. 2020-09-09 00:05:30 +00:00
Mozilla L10n Automation Bot
84a67bde4a [components] Import l10n. 2020-08-28 00:06:37 +00:00
Mozilla L10n Automation Bot
29070805dd [components] Import l10n. 2020-08-27 00:08:31 +00:00
Mozilla L10n Automation Bot
c325d0c9e4 [components] Import l10n. 2020-08-25 00:01:46 +00:00
Michael Debertol
cf7af4cc8e [components] For https://github.com/mozilla-mobile/android-components/issues/8175: Allow SuggestionProviders to specify a edit suggestion 2020-08-20 20:04:09 +02:00
Mozilla L10n Automation Bot
d494cb50c2 [components] Import l10n. 2020-08-20 00:09:22 +00:00
Mozilla L10n Automation Bot
bff26a47e2 [components] Import l10n. 2020-08-13 00:09:23 +00:00
Mozilla L10n Automation Bot
977403cc2b [components] Import l10n. 2020-08-12 00:01:49 +00:00
Mozilla L10n Automation Bot
40f12f14cd [components] Import l10n. 2020-08-11 00:12:54 +00:00
Mozilla L10n Automation Bot
6b1375f5de [components] Import l10n. 2020-08-10 00:04:27 +00:00
Mozilla L10n Automation Bot
6bd29f3d8a [components] Import l10n. 2020-08-09 00:14:57 +00:00
Mozilla L10n Automation Bot
f8ef7b6121 [components] Import l10n. 2020-08-08 00:02:51 +00:00
Mozilla L10n Automation Bot
f798f76e02 [components] Import l10n. 2020-08-07 00:15:41 +00:00
Kirill Rakhman
5e13b69faf [components] Closes https://github.com/mozilla-mobile/android-components/issues/6813 Awesomebar: Add ability to accept suggestion from search completion without submitting 2020-07-31 18:29:40 +02:00
MozLando
1ed2c50eb2 [components] Merge https://github.com/mozilla-mobile/android-components/pull/7738 https://github.com/mozilla-mobile/android-components/pull/7798 (part 1) 
7738: For https://github.com/mozilla-mobile/fenix/issues/12632: Align search suggestion and search text r=NotWoods a=hakkikaancaliskan

This is just a small pr for aligning search text and suggestion text, also aligns icons.

![Screenshot_20200716-145421_Firefox_Preview](https://user-images.githubusercontent.com/17825767/87668283-8170ab80-c774-11ea-898e-3edfbad0cd87.png)

<!-- Text above this line will be added to the commit once "bors" merges this PR -->

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


7798: Add tests for Trimming whitespace from email & call context share r=sblatz a=Amejia481

@sblatz as I missed the tests on my initial review, I'm adding them as part of this pr, sorry about that.



Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-07-21 16:00:14 +00:00
Hakkı Kaan Çalışkan
f855c377df [components] For https://github.com/mozilla-mobile/android-components/issues/7803: Visually indicate different types of suggestions in the search screen 2020-07-21 18:43:03 +03:00
Hakkı Kaan Çalışkan
336c9ce917 [components] For https://github.com/mozilla-mobile/fenix/issues/12632: Align search suggestion and search text 2020-07-16 14:55:45 +03:00
Grisha Kruglov
013a08c6cf [components] Closes https://github.com/mozilla-mobile/android-components/issues/7016: Emit awesomebar provider metrics in ms 2020-05-18 17:10:08 -07:00
Christian Sadilek
0095b9eed6 [components] Closes https://github.com/mozilla-mobile/android-components/issues/6985: Make sure suggestions with long title/desc don't freeze UI 2020-05-15 11:47:45 -04:00
Grisha Kruglov
5179fdefa0 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4992: Emit provider duration facts from BrowserAwesomeBar 
Some things to consider and trade-offs:

When recording durations of various providers into a glean metric, we have a bit of a hurdle.
One approach would be to encapsulate all of the awesomebar-related perf telemetry entirely within the
awesomebar a-c component. But, set of providers isn't entirely known to us at the a-c level.
We know what providers we have defined, but we don't know what providers applications will provide themselves.
Also, glean doesn't have a metric of type (string->timespan), which would allow us to work-around this.
So, we can't define ping/metrics in the a-c component. This means that they need to be defined elsewhere, while
the measurement happens within the component. An established pattern for that in the codebase is emitting "facts",
which is what this patch does.

We delegate to the consuming application to then actually do something with these facts - e.g. map providers
to concrete glean metric definitions.

Another consideration is if we should try to group timings related to a single query. That's hard to do reliably,
and will introduce additional complexity into what's otherwise a super simple setup. Source of that complexity
is that we actively try to cancel query jobs as user is typing; our providers could take an arbitrary time to resolve,
and so grouping becomes difficult. However, we care about improving how long each individual provider takes,
since that's a good proxy for "how responsive is this UI?". Simply recording each individual timing we see
should be enough for that.
 2020-05-12 15:36:21 -07:00
Jonathan Almeida
b86fa6dfb5 [components] Close https://github.com/mozilla-mobile/android-components/issues/6601: Update targetSdkVersion to 29 2020-04-28 03:16:54 -04:00
levimatheri
181eaea947 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4632. Add contains function for suggestion providers 2020-03-24 16:29:22 -04:00
Tiger Oakes
1bdf8c8234 [components] Add JUnit coroutine test rule 2019-11-18 19:52:50 -08:00
MozLando
fe3b207233 [components] Merge https://github.com/mozilla-mobile/android-components/pull/4584 https://github.com/mozilla-mobile/android-components/pull/4817 (part 1) 
4584: For https://github.com/mozilla-mobile/android-components/issues/4583 Avoid icon engine in suggestion being cut off in RTL r=pocmo a=mcarare



4817: For https://github.com/mozilla-mobile/android-components/issues/4816 Remove autoMirrored from checkmark drawable r=pocmo a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
 2019-10-22 15:11:42 +00:00
Sawyer Blatz
9755cb907b [components] For https://github.com/mozilla-mobile/android-components/issues/4653: Improves performance 2019-10-08 10:15:55 +02:00
Sawyer Blatz
c3abe2f6c9 [components] For https://github.com/mozilla-mobile/android-components/issues/4653: Do not display suggestion until icon is ready 2019-10-07 17:20:06 -07:00
mcarare
e03aa5ed63 [components] For https://github.com/mozilla-mobile/android-components/issues/4583 Avoid icon engine in suggestion being cut off in RTL 2019-09-30 15:56:38 +03:00
Denys M
b95c932f81 [components] For https://github.com/mozilla-mobile/android-components/issues/4460. Fix detekt warning about license in project files. 2019-09-24 01:01:03 +04:00
Sebastian Kaspari
c6fecc6f06 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4283: Migrate feature-contextmenu to use browser-state. 2019-09-16 12:09:09 +02:00
ekager
0627b5b321 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4016 - Use padding instead of margin for awesomebar item layout 2019-08-06 10:56:14 -07:00
Sawyer Blatz
780a36ab65 [components] For https://github.com/mozilla-mobile/android-components/issues/3574: Updates visuals for search view 
Co-authored-by: NotWoods <contact@tigeroakes.com>
 2019-06-27 12:45:26 -07:00
Tiger Oakes
e5b6e27420 [components] Fixes https://github.com/mozilla-mobile/android-components/issues/2605 - Replace pxToDp with dpToPx 2019-06-25 06:05:10 -07:00
Denys M
1f8fc3fa5b [components] For https://github.com/mozilla-mobile/android-components/issues/1481. Enable unit test binary resources globally. 
Excluded few modules.
 2019-06-13 09:29:52 +02:00
Denys M
b6629cd6fc [components] For https://github.com/mozilla-mobile/android-components/issues/1481. Use androidx runner in browser-domains. 2019-06-11 17:48:41 +02:00
Denys M
cfcec95e0f [components] For https://github.com/mozilla-mobile/android-components/issues/1481. Use androidx runner in browser-awesomebar. 2019-06-10 09:23:10 -04:00
Christian Sadilek
95177f1a4c [components] Issue https://github.com/mozilla-mobile/android-components/issues/2364: Always clear previous provider suggestions 2019-06-06 11:30:33 -04:00
Christian Sadilek
69501e16bb [components] Issue https://github.com/mozilla-mobile/android-components/issues/2364: Make sure suggestions are removed before new ones are added 2019-06-03 13:37:42 -04:00
Christian Sadilek
14ff2b71dd [components] Issue https://github.com/mozilla-mobile/android-components/issues/2364: getItemId is not synchronized 2019-05-30 18:54:51 -04:00
Christian Sadilek
895c4571a5 [components] Closes https://github.com/mozilla-mobile/android-components/issues/3177: AwesomeBar should throw when duplicate provider added 2019-05-30 14:56:52 -04:00
Denys M
faf850118e [components] Fixes https://github.com/mozilla-mobile/android-components/issues/3124. Make BrowserAwesomeBarTests more deterministic. 2019-05-27 12:22:01 -04:00
Sebastian Kaspari
8d595984e7 [components] BrowserAwesomeBar: Only call onInputChanged() after onInputStarted() and allow provider to return suggestions from onInputStarted(). 
For: https://github.com/mozilla-mobile/fenix/issues/2406
 2019-05-23 11:05:02 -04:00
Christian Sadilek
56937dbe3a [components] Issue https://github.com/mozilla-mobile/android-components/issues/2997: Add back layout constraint for awesomebar desc. 2019-05-14 13:36:17 -04:00
Blake Winton
ef4f476d8b [components] Closes https://github.com/mozilla-mobile/android-components/issues/2997: Tighten the spacing between search result title and description. 2019-05-13 17:21:53 -04:00
Denys M
c65630b16a [components] For https://github.com/mozilla-mobile/android-components/issues/2346. Enable kotlin warningsAsErrors for browser-awesomebar. 2019-05-13 10:54:19 -04:00
Blake Winton
a649b5ce1f [components] Line up the text, as well. 
The start with the start of the search term and the end with the end of the search box's content.
 2019-05-10 19:29:36 -04:00