Commit Graph

4336 Commits

Author SHA1 Message Date
Kelly Cochrane
f07a9b2932 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs. r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-06 14:21:04 +00:00
Ed Lee
035e010fe9 Bug 1907350 - Expose genai-settings-chat-title and other chatbot strings for localization r=tarek,fluent-reviewers,mconley,bolsson
Move featuregate title to features.ftl used by about:preferences and about:support; and other strings to genai.ftl. Allow prompts to use l10nId to get fluent attributes. Convert inline strings for menu and shortcuts to fluent. Update simplify, add explain prompts.

Differential Revision: https://phabricator.services.mozilla.com/D218279
2024-08-03 06:40:26 +00:00
Ed Lee
7fcb70613f Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 04:19:46 +00:00
Noemi Erli
5578e35afb Backed out changeset c9ad93d58c14 (bug 1910005) for causing bustages in GleanMetrics.h CLOSED TREE 2024-08-03 06:17:37 +03:00
Ed Lee
0e362c1019 Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 02:46:23 +00:00
Noemi Erli
add41c1a33 Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE 2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7 Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures 2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15 Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 18:32:38 +00:00
Mark Striemer
5347d38678 Bug 1910623 - Fix Firefox Labs telemetry with moz-checkbox elements r=mconley,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218103
2024-08-01 21:56:48 +00:00
Mathew Hodson
3897b0e480 Bug 1830673 - Use support-page attribute for telemetry article link r=settings-reviewers,mconley
This prevents two tabs from being opened.

Differential Revision: https://phabricator.services.mozilla.com/D218268
2024-08-01 21:37:44 +00:00
Mathew Hodson
c973289aa3 Bug 1792887 - Correct alignment of telemetry learn more link r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D218269
2024-08-01 21:33:42 +00:00
Tim Giles
dd3ae829fd Bug 1904094 - Match select element styling in experimental section with other components. r=reusable-components-reviewers,settings-reviewers,desktop-theme-reviewers,dao,hjones,mstriemer
Went with adding margin-block-end to achieve the ~4px spacing between
label and select, and between select and description.

Also adds the "input-space-block" token.

Differential Revision: https://phabricator.services.mozilla.com/D216336
2024-07-29 17:33:11 +00:00
Moritz Beier
fdbc342302 Bug 1910109 - Perma TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_search_searchTerms.js | showSearchTerms checkbox should be shown. - false == true - when Gecko 130 merges to beta on 2024-08-05. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D217947
2024-07-29 13:16:47 +00:00
Moritz Beier
650113020b Bug 1863530 - Remove browser.search.widget.inNavBar pref. r=dao,settings-reviewers,search-reviewers,omc-reviewers,urlbar-reviewers,Gijs,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D215607
2024-07-23 17:29:00 +00:00
Gijs Kruitbosch
85ca3fdea4 Bug 1908965 - re-instate telemetry for toggling items in Firefox Labs, r=mstriemer,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217150
2024-07-22 10:32:34 +00:00
mcheang
934e5f7581 Bug 1902537 - Create UrlbarProviderRestrictKeywords to show localized bookmarks, history, and tabs restrict keywords results. r=mak,settings-reviewers,urlbar-reviewers
This patch includes:
- A new UrlbarProviderRestrictKeywords class
- Showing localized Search with Bookmarks, Search with History, Search with Tabs results after the user types @
- Add search restrict keywords to preferences UI Search Shortcuts table
- Hiding search restrict keyword behind browser.urlbar.searchRestrictKeywords.featureGate pref

Differential Revision: https://phabricator.services.mozilla.com/D213697
2024-07-19 23:45:58 +00:00
Gijs Kruitbosch
a42bb0c9ac Bug 1908785 - driveby: remove browser.preferences.search as there is no reason to disable search in settings, r=mconley
This was the feature flag behind which the settings page's 'search' functionality was written.
It's been there for years now, and it is high time to clean this up.

Differential Revision: https://phabricator.services.mozilla.com/D217034
2024-07-19 18:46:25 +00:00
Meera Murthy
8eaf0980bf Bug 1881259 - [translations] Ensure Secondary Translation Settings interacts with Preferences. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,bolsson,dao,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D203097
2024-07-19 15:11:22 +00:00
Malte Juergens
7d71bae2f3 Bug 1907517 - Update strings in HTTPS-Only settings to make users aware of HTTPS-First r=freddyb,fluent-reviewers,settings-reviewers,mossop
In light of us being in the process of enabling HTTPS-First by default, these strings have been proposed by content design to make it more clear to the user that if they disable HTTPS-Only, upgrades may still be happening.

The description generally has been updated, but the labels for the radio buttons only get the new strings in this patch when HTTPS-First is also enabled.

Differential Revision: https://phabricator.services.mozilla.com/D216381
2024-07-19 12:34:09 +00:00
Emilio Cobos Álvarez
4758aafdc8 Bug 1907709 - Add a search header for website advertising section. r=settings-reviewers,Gijs
A bit weird that this doesn't work more automatically but...

Differential Revision: https://phabricator.services.mozilla.com/D216680
2024-07-17 18:21:44 +00:00
Gijs Kruitbosch
a295abd9b9 Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r=bgrins,settings-reviewers,firefox-desktop-core-reviewers ,mossop
Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Differential Revision: https://phabricator.services.mozilla.com/D216801
2024-07-17 16:00:47 +00:00
Mark Striemer
405493dee8 Bug 1904089 - Match Firefox Labs header with design system spacing r=reusable-components-reviewers,settings-reviewers,desktop-theme-reviewers,hjones,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D216176
2024-07-16 14:43:45 +00:00
Mike Kaply
3ba79c24af Bug 1675077 - Add policy for PrivateBrowsingModeAvailability. r=kcochrane,fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D216315
2024-07-15 15:58:18 +00:00
Moritz Beier
12220c0dde Bug 1906875 - Remove the old search engine selector from the search service. r=Standard8,extension-reviewers,urlbar-reviewers,settings-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D216047
2024-07-15 11:15:22 +00:00
Ed Lee
877a103ec2 Bug 1906691 - The Select Provider combobox in the Settings UI AI Chatbot Integration section is not programmatically labelled r=settings-reviewers,Gijs
Use xul control and aria attributes for provider menulist.

Differential Revision: https://phabricator.services.mozilla.com/D216247
2024-07-11 13:41:19 +00:00
Mark Striemer
8109af5152 Bug 1900124 - Part 3: Define experiments sorting by Features.toml r=Gijs,settings-reviewers
Depends on D215263

Differential Revision: https://phabricator.services.mozilla.com/D215680
2024-07-09 23:14:56 +00:00
Mark Striemer
3550f06384 Bug 1900124 - Part 2: Use moz- components, card styling in Experimental section r=Mardak,reusable-components-reviewers,settings-reviewers,fluent-reviewers,desktop-theme-reviewers,flod,Gijs,dao
Depends on D215262

Differential Revision: https://phabricator.services.mozilla.com/D215263
2024-07-09 23:14:56 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Gijs Kruitbosch
136bb9abab Bug 1904714 - rename Nightly Experiments to Firefox Labs, r=Mardak,settings-reviewers,fluent-reviewers,flod,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D215399
2024-07-08 20:01:35 +00:00
Mike Conley
b2707c88f1 Bug 1906326 - Don't manually unhide the dataBackupGroup in preferences if enabled. r=settings-reviewers,Gijs
The preferences initialization code will take care of showing and hiding
this for us when loading different panes - it's the `data-hidden-from-search`
attribute removal that's allowing us to show the group when the preference
is enabled.

The existing test_preferences_visibility test under
browser/components/backup/test/browser/browser_settings.js tests that we
haven't regressed showing and hiding behaviour for the pref.

Differential Revision: https://phabricator.services.mozilla.com/D215806
2024-07-08 18:39:00 +00:00
Dale Harvey
af847146da Bug 1906103 - Move trending strings into localised files. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D215642
2024-07-04 16:23:48 +00:00
Marco Bonardo
c23719eb3b Bug 1904909 - PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries r=daisuke,places-reviewers
There's a few problems in the code gathering text data for nodes.
First it should not recurse into queries (included folder shortcuts) as it's
easy to create infinite recursion with them. The first level is excluded though,
as otherwise it would not be possible to copy contents of left pane roots.
Second it should requery folder shortcut contents in excludeItems results,
as otherwise it's not possible to copy contents of a root as text.
There's no longer the risk of dragging around root folders as this code is only
used for text flavors today, drag&drop uses serializeNode instead.

Differential Revision: https://phabricator.services.mozilla.com/D215068
2024-07-02 13:45:37 +00:00
Jan Grulich
c8affaf5e8 Bug 1882079 - Display real path when choosing download directory over portal r=settings-reviewers,Gijs,emilio
Use the new API addition to Document portal allowing clients to get real
path to the exported document. This allows to still use the same path as
provided by the document portal, but display the path as exists on the
host side.

Differential Revision: https://phabricator.services.mozilla.com/D202717
2024-06-28 19:31:13 +00:00
Norisz Fay
31c6f1a617 Backed out changeset 032d22e94bd3 (bug 1882079) for causing bustages on nsLocalFileUnix.cpp CLOSED TREE 2024-06-28 18:10:16 +03:00
Jan Grulich
a2c79faafd Bug 1882079 - Display real path when choosing download directory over portal r=settings-reviewers,Gijs,emilio
Use the new API addition to Document portal allowing clients to get real
path to the exported document. This allows to still use the same path as
provided by the document portal, but display the path as exists on the
host side.

Differential Revision: https://phabricator.services.mozilla.com/D202717
2024-06-28 14:33:04 +00:00
Gijs Kruitbosch
a6832d7418 Bug 1904478 - clean up leftover reference to now non-existing fluent string, r=settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D214798
2024-06-25 10:50:28 +00:00
Gijs Kruitbosch
729e9e5b81 Bug 1903820 - update intro language in nightly experiments page, r=settings-reviewers,fluent-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D214439
2024-06-24 23:30:05 +00:00
Hanna Jones
f26d450f6e Bug 1901264 - update settings search to work for all moz- prefixed custom elements r=reusable-components-reviewers,settings-reviewers,mstriemer
This patch:

* adds some simple logic to settings search that should prevent us from having to manually allow searching in every moz- prefixed custom element
* cleans up the existing settings search logic slightly for improved readability
* expands the tests to check searching for text in the shadow DOM of additional moz- prefixed custom elements

Differential Revision: https://phabricator.services.mozilla.com/D214141
2024-06-19 21:58:14 +00:00
Ed Lee
d068fce0da Bug 1895494 - Support more generic handling of custom experimental preferences logic r=tarek,settings-reviewers
Switch from direct import to observer now that GenAI has an init.

Differential Revision: https://phabricator.services.mozilla.com/D214216
2024-06-19 17:01:12 +00:00
Sean
a41f1de616 Bug 1900672 - DNS-over-HTTPS (DoH, TRR) provider OFF should default to fallbackProviderURI r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D213838
2024-06-18 14:15:43 +00:00
Mike Conley
456ade4c9a Bug 1901184 - The translations-manage-install-list div should not be keyboard focusable. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213649
2024-06-14 18:37:32 +00:00
Tim Huang
ac6f31da0d Bug 1898255 - Enable third-party cookie deprecation in ETP strict and PBM. r=anti-tracking-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,pbz,mak
Differential Revision: https://phabricator.services.mozilla.com/D212547
2024-06-12 12:08:54 +00:00
Dale Harvey
27e7b6422f Bug 1900601 - Dont enter search mode when '>' is pressed. r=daisuke,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D212558
2024-06-07 13:32:36 +00:00
Emilio Cobos Álvarez
3008f7bfed Bug 1901194 - Fix a test I missed.
MANUAL PUSH: Trivial fix CLOSED TREE
2024-06-07 15:35:29 +02:00
Emilio Cobos Álvarez
9e7668fdbe Bug 1901194 - Remove useless tail-with-learn-more class on <span>s. r=settings-reviewers
It doesn't do anything on a span so it's just confusing.

Differential Revision: https://phabricator.services.mozilla.com/D212902
2024-06-07 12:11:23 +00:00