corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
897,411 Commits 1 Branch 0 Tags
abc3d2c04bda2b13af0fa1b2de21f01697be44cc
Commit Graph

383 Commits

Author SHA1 Message Date
Sandor Molnar
695882bbbf Backed out changeset d6f61409b245 (bug 1899019) for causing build bustages @ AsrouterMetrics.h CLOSED TREE 2025-02-26 08:02:04 +02:00
Punam Dahiya
88d6323bef Bug 1899019 - Part 1 - Add FxMS metrics.yaml and pings.yaml files r=chutten,omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238891
 2025-02-25 23:16:59 +00:00
Gregory Pappas
2300895022 Bug 1750304 - Move isChinaRepack out of AppConstants r=settings-reviewers,home-newtab-reviewers,Gijs,pdahiya,omc-reviewers,mossop,mconley 
AppConstants seems like the wrong place for this method

Differential Revision: https://phabricator.services.mozilla.com/D239276
 2025-02-25 20:46:37 +00:00
Rebecca King
b3a22ac978 Bug 1938253 - Implement Callout 3 for integrated version of Review Checker - r=kpatenio,shopping-reviewers,fluent-reviewers,settings-reviewers,omc-reviewers,aminomancer,bolsson,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D233053
 2025-02-24 18:15:36 +00:00
negin
4b16185899 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud 
Differential Revision: https://phabricator.services.mozilla.com/D229198
 2025-02-24 15:21:41 +00:00
Rebecca King
622361d010 Bug 1938413 - Implement callout 4A and callout 4B for RC in the sidebar when a user disables auto-open r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D234974
 2025-02-21 23:30:51 +00:00
negin
3d8c9dcaaf Bug 1919598 - Avoid creating a notification box during activeNotifications r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D238817
 2025-02-21 23:05:26 +00:00
Rebecca King
ddf1ba4c90 Bug 1938417 - Implement callout 5 for Review Checker in the sidebar when a user turns off Review Checker - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D234997
 2025-02-21 22:07:22 +00:00
Emily McMinn
31aeebfe5f Bug 1949261 - Tab Groups message refinements and strings r=omc-reviewers,dao,fluent-reviewers,bolsson,pdahiya,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D238837
 2025-02-21 16:53:18 +00:00
Goloman Adrian
3624802d33 Backed out changeset 8b98d8d87760 (bug 1948423) for causing bc failures @browser_foxdoodle_set_default.js. CLOSED TREE 2025-02-20 06:56:38 +02:00
Shane Hughes
378d8ec5e5 Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238374
 2025-02-20 03:03:45 +00:00
Meg Viar
4066ecbd13 Bug 1948717 - Add flag that enables running actions in MULTI_ACTION SMA in sequential order r=jprickett,omc-reviewers,nalexander 
To support the upcoming TOS preonboarding experiment, we want to ensure the following actions occur sequentially:
  - setting prefs, including `datareporting.healthreport.uploadEnabled` (`SET_PREF`)
  - submitting the onboarding opt-out ping, if applicable (`SUBMIT_ONBOARDING_OPT_OUT_PING`)
  - notifying that the data reporting notification has been interacted with (`DATAREPORTING_NOTIFY_DATA_POLICY_INTERACTED`).

When these actions occur out of order, it is possible for telemetry to be enabled and then disabled. This is likely what accounts for the onboarding-opt-out followed by deletion-request pings witnessed by QA in Bug 1948717.

We believe that the issue is that the `MULTI_ACTION` SMA does not guarantee any ordering of its child actions: see [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/toolkit/components/messaging-system/lib/SpecialMessageActions.sys.mjs#687-696 | here ]]. That's by design, since early actions including pinning and set-to-default, which are slow and can be run concurrently. But here, we expect sequential ordering (and also [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#578-585 | in the code ]]).

The obvious way to address this is to have the MULTI_ACTION order its child actions. However, this needs to be a flag, since we have existing consumers and we want to minimize disruption.

This patch adds support for an `orderedExecution` flag on message `action` configurations for those with type `MULTI_ACTION`. This applies to nested `MULTI_ACTIONS` using `collectSelect` as well, assuming each `MULTI_ACTION` has the `orderedExecution` flag.

Differential Revision: https://phabricator.services.mozilla.com/D238816
 2025-02-20 00:28:02 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya 
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
 2025-02-19 16:19:42 +00:00
jprickett
aa7d7f50c8 Bug 1927504 - Update feature callout documentation r=omc-reviewers,mviar DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D231349
 2025-02-18 20:30:41 +00:00
Butkovits Atila
91a59f70d0 Backed out changeset aedc669b8499 (bug 1919598) for causing failures at browser_tabnotificationbox_switch_tabs.js. CLOSED TREE 2025-02-14 19:24:24 +02:00
negin
4935d2153f Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud 
Differential Revision: https://phabricator.services.mozilla.com/D229198
 2025-02-14 16:05:20 +00:00
Sarah Chung
802e677efa Bug 1942154 - fix npm package vulnerabilities in asrouter and aboutwelcome r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D234580
 2025-02-13 21:11:05 +00:00
Sarah Chung
4a5e5fad96 Bug 1947536 - expose qr code in desktop to mobile adoption message to assistive technology r=emcminn,omc-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237898
 2025-02-12 20:37:21 +00:00
Meg Viar
da90402d32 Bug 1947510 - Save default MultiSelect choices even if component defaults to a collapsed state r=omc-reviewers,hanna_a,jprickett 
We want to capture the default state of multiselect checklist items when a user clicks the primary CTA on an aboutwelcome screen, even if the checklist hasn't been rendered yet (such as when the user needs to click a button to toggle it in to view).

Differential Revision: https://phabricator.services.mozilla.com/D237773
 2025-02-11 22:22:30 +00:00
Punam Dahiya
1fd0f99f8e Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi CLOSED TREE 
Differential Revision: https://phabricator.services.mozilla.com/D236880
 2025-02-10 17:55:34 +00:00
Sarah Chung
ccdd8c7af2 Bug 1947182 - update targeting for desktop to mobile adoption message r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237616
 2025-02-10 21:51:11 +00:00
Norisz Fay
29170cefc4 Backed out changeset 5785f202084e (bug 1940816) for causing Bpgo bustage CLOSED TREE 2025-02-11 06:11:10 +02:00
Punam Dahiya
7059cde7b0 Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D236880
 2025-02-10 17:55:34 +00:00
Punam Dahiya
4197a454e1 Bug 1946458 - Remove wallpaper select custom handling in aboutwelcome bundle r=amy,omc-reviewers,emcminn,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237130
 2025-02-07 21:21:19 +00:00
Emily McMinn
967f0a3050 Bug 1946512 - Add automated test for alltabsButtonAreaType r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D237113
 2025-02-06 22:52:43 +00:00
Emily McMinn
8a96646dd7 Bug 1945564 - Update Create Tab Group callout && add new callout for users who have removed the all tabs button r=omc-reviewers,dao,fluent-reviewers,bolsson,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D236588
 2025-02-06 17:28:08 +00:00
Emily McMinn
b6fec0fc15 Bug 1944344 - Anchor vertical callout to tab strip if active tab is pinned r=omc-reviewers,dao,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D236956
 2025-02-06 15:38:50 +00:00
Sarah Chung
00af71e19a Bug 1944079 - land desktop to mobile adoption experiment in tree r=omc-reviewers,emcminn,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D236551
 2025-02-06 15:14:36 +00:00
Emily McMinn
3a3f5adda0 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D222032
 2025-02-05 21:01:41 +00:00
Rebecca King
ddcdf53352 Bug 1938421 - Implement callout 6 for RC in the sidebar, when a user closes RC - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D235003
 2025-02-03 22:55:31 +00:00
Sandor Molnar
603aa1973c Backed out changeset d98b62477b98 (bug 1904441) for causing bc failures & assertion failures @ browser_messagepreview_receivemessage.js / nsContentSecurityUtils.cpp CLOSED TREE 2025-02-03 23:36:24 +02:00
Emily McMinn
b0ba7f9890 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D222032
 2025-02-03 17:18:47 +00:00
Mike Conley
6db006549f Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 16:45:33 +00:00
Mike Conley
0cab9e0390 Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount 
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
 2025-02-03 16:45:33 +00:00
Mike Conley
829da877ed Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy 
Differential Revision: https://phabricator.services.mozilla.com/D233866
 2025-02-03 16:45:30 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE 
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
 2025-02-03 18:28:59 +02:00
Mike Conley
661a090489 Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce 
Differential Revision: https://phabricator.services.mozilla.com/D233874
 2025-02-03 15:07:11 +00:00
Mike Conley
5cc1e5190e Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount 
This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873
 2025-02-03 15:07:10 +00:00
Mike Conley
b75d1059ab Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy 
Differential Revision: https://phabricator.services.mozilla.com/D233866
 2025-02-03 15:07:08 +00:00
negin
746f501995 Bug 1939921 - [FxMS Docs] Adds Triggers and User Actions, schema links under Messaging System source doc r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D234904
 2025-01-30 17:29:15 +00:00
Emily McMinn
c749a0b825 Bug 1944103 - Refine targeting for tab groups onboarding messages r=omc-reviewers,dao,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D235698
 2025-01-29 22:15:28 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn 
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
 2025-01-29 19:09:19 +00:00
Emily McMinn
da797a5490 Bug 1943442 - Land onboarding callouts for Tab Groups r=omc-reviewers,aminomancer,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D235376
 2025-01-24 21:56:55 +00:00
Meg Viar
7dca8efc49 Bug 1941807 - Add ability to toggle AboutWelcome screen content by clicking a configurable header r=omc-reviewers,jprickett 
Support a second variant of the preonboarding modal design by adding the ability to configure a header that toggles visiblity of content tiles.

- See design for [[ https://docs.google.com/presentation/d/1dDC9M9y-W3q90mkVRp4gq3p-x3u7F6qgy0jVeE4MwUw/edit#slide=id.g325219d6753_0_95 | modal Variant B ]]

Differential Revision: https://phabricator.services.mozilla.com/D235325
 2025-01-24 13:30:07 +00:00
Punam Dahiya
a7b627a8a4 Bug 1942895 - Move FilterAdult into shared browser/modules folder r=home-newtab-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D235259
 2025-01-23 23:07:57 +00:00
Punam Dahiya
0628dbd0a7 Bug 1937172 - Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage r=home-newtab-reviewers,omc-reviewers,mconley,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D234447
 2025-01-23 21:32:23 +00:00
Tooru Fujisawa
8084bcd8ca Bug 1881888 - Part 10: Remove ChromeUtils.import. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233722
 2025-01-23 05:21:58 +00:00
Tooru Fujisawa
ac7fdd6102 Bug 1881888 - Part 9: Remove ChromeUtils.defineModuleGetter. r=Standard8,mccr8,profiler-reviewers,omc-reviewers,home-newtab-reviewers,julienw,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D233721
 2025-01-23 05:21:58 +00:00
Tooru Fujisawa
6de3931fde Bug 1940422 - Remove XPCOMUtils.defineLazyModuleGetters. r=mccr8,credential-management-reviewers,omc-reviewers,home-newtab-reviewers,mconley,pdahiya,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D233379
 2025-01-23 05:21:54 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D234113
 2025-01-22 05:59:40 +00:00