Thomas Nguyen
b2373700f4
Bug 1397231 - Skip new URLClassifierLocalChild when ContentChild is shutting down r=Ehsan
...
MozReview-Commit-ID: HRv5DpiPwmB
2017-09-07 16:16:43 +08:00
Thomas Nguyen
8496e0fafa
Bug 1385609 - Fix backoff issue that makes SB lists no longer update r=francois
...
The issue occurs when nsITimer is fired earlier than the backoff time. In that
case, the update doesn't proceed and we never make another attempt because the
backoff update timer was oneshot.
We fix the issue in two ways:
- Add a tolerance of 1 second in case the timer fires too early.
- Set another oneshot timer whenever we are prevented from updating due to
backoff.
MozReview-Commit-ID: E2ogNRsHJVK
2017-08-30 18:04:10 +08:00
Sebastian Hengst
061e6ef724
Backed out changeset 14b4af261515 (bug 1385609) for eslint failures in nsUrlClassifierLib.js. r=backout
2017-09-05 19:04:43 +02:00
Thomas Nguyen
f699e980cb
Bug 1395411 - Unregister tables when they're removed from urlclassifier.*Table. r=francois
...
MozReview-Commit-ID: Ex1ZxMcJLep
2017-08-31 18:46:23 +08:00
Thomas Nguyen
cf82b0fcf8
Bug 1385609 - Fix backoff issue that makes SB lists no longer update r=francois
...
The issue occurs when nsITimer is fired earlier than the backoff time. In that
case, the update doesn't proceed and we never make another attempt because the
backoff update timer was oneshot.
We fix the issue in two ways:
- Add a tolerance of 1 second in case the timer fires too early.
- Set another oneshot timer whenever we are prevented from updating due to
backoff.
MozReview-Commit-ID: E2ogNRsHJVK
2017-08-30 18:04:10 +08:00
Sebastian Hengst
f811dfefc1
Backed out changeset 7bb00f5e0120 (bug 1395411) for eslint failures in test_classifier_changetablepref_bug1395411.html: 'classifierHelper' is not defined. r=backout
2017-09-04 16:45:35 +02:00
Thomas Nguyen
b80ab7c3df
Bug 1395411 - Unregister tables when they're removed from urlclassifier.*Table. r=francois
...
MozReview-Commit-ID: Ex1ZxMcJLep
2017-08-31 18:46:23 +08:00
Thomas Nguyen
25da99d8f4
Bug 1345058 - Asynchronously decide if a flash document should be blocked. r=baku
...
MozReview-Commit-ID: K91cSvIdOrb
2017-08-14 14:05:23 +08:00
Steve Armand
fb4c16351d
Bug 1343843 - Remove unused chrome://global/content/url-classifier/unittests.xul. r=standard8
...
MozReview-Commit-ID: IMiDbyPu5n9
2017-09-01 23:31:57 -04:00
Francois Marier
76d985fb87
Bug 1395733 - Ensure the default value of urlclassifier.malwareTable is always sorted. r=gcp
...
MozReview-Commit-ID: 10M2ZpDyAI9
2017-08-31 14:54:11 -07:00
Francois Marier
cae69060c8
Bug 1394601 - Log an error when the Google API key is missing during Safe Browsing initialization. r=gcp
...
MozReview-Commit-ID: DNwa9lR0J6K
2017-08-28 17:06:00 -07:00
Eric Rahm
b3a9bd1c4c
Bug 1393235 - Fix improper usages of string functions. r=njn
...
This fixes usages of `Find`, `RFind` and the equality operator that kind of
work right now but will break with the proper type checking of a templatized
version of the string classes.
For `Find` and `RFind` it appears that `nsCString::(R)Find("foo", 0)` calls
were being coerced to the `Find(char*, bool, int, int)` versions. The intent was
probably to just start searching from position zero.
For the equality operator, the type of nullptr is nullptr_t rather than
char(16_t)* so we'd need to add an operator overload that takes nullptr_t. In
this case just using `IsVoid` is probably more appropriate.
2017-08-22 19:30:46 -07:00
Francois Marier
042bbe0b38
Bug 1388574 - Use the correct pref to gate the Application Reputation lists. r=hchang
...
MozReview-Commit-ID: 1ZuxnbgsOMX
2017-08-23 13:40:50 -07:00
Thomas Nguyen
a014d3a744
Bug 1363038 - Remove synchronous dispatch when worker is racing against shutdown r=hchang
...
MozReview-Commit-ID: JOkOukz1fov
2017-08-22 14:51:44 +08:00
Henry Chang
0d7d639fec
Bug 1392204 - Disable goog-badbinurl-proto and goog-downloadwhite-proto on Fennec. r=francois
...
Version 4 of the Google Safe Browsing server will return a 404 if any of the
application reputation lists are requested on Android. As a result, we should
avoid these threat types from being sent along with ANDROID_PLATFORM.
MozReview-Commit-ID: 6TUBVxe455y
2017-08-22 12:20:57 +08:00
Francois Marier
3fb9813b89
Bug 1385484 - Add the login reputation whitelist behind a pref. r=hchang
...
MozReview-Commit-ID: Dbtl3WL5tMJ
2017-08-08 16:23:10 -07:00
Francois Marier
366ae48b73
Bug 1385484 - Cleanup Safe Browsing prefs and sync the download protection setting. r=hchang
...
MozReview-Commit-ID: B42p2Gw8y9i
2017-08-08 15:52:29 -07:00
Wes Kocher
ee18e318e9
Backed out 4 changesets (bug 1385484) for build failures a=backout
...
Backed out changeset 401c2744f16b (bug 1385484)
Backed out changeset 2ff443a0c744 (bug 1385484)
Backed out changeset 1a1c476a9aaa (bug 1385484)
Backed out changeset 87ec064a3681 (bug 1385484)
MozReview-Commit-ID: D9WGXiXaNoZ
2017-08-22 17:22:41 -07:00
Francois Marier
b4f1a9b65e
Bug 1385484 - Add the login reputation whitelist behind a pref. r=hchang
...
MozReview-Commit-ID: Dbtl3WL5tMJ
2017-08-08 16:23:10 -07:00
Francois Marier
0bdc6213e0
Bug 1385484 - Cleanup Safe Browsing prefs and sync the download protection setting. r=hchang
...
MozReview-Commit-ID: B42p2Gw8y9i
2017-08-08 15:52:29 -07:00
Nicholas Nethercote
42d8740878
Bug 1390428 (part 2, attempt 2) - Remove more nsXPIDLCString local variables. r=erahm.
2017-08-21 20:01:27 +10:00
Henry Chang
d022ca7e9b
Bug 1388582 - Skip unsupported threat types on current platform while making v4 request. r=francois
...
MozReview-Commit-ID: FTmOMQ339ZL
2017-08-16 15:30:20 +08:00
Thomas Nguyen
a63544b5cb
Bug 1376410 - Handle OOM when appending prefix to map r=francois,hchang
...
MozReview-Commit-ID: 7MOHHAgEI1I
2017-08-11 17:28:40 +08:00
Nicholas Nethercote
b7346a7502
Bug 1390428 (part 1) - Remove many nsXPIDLCString local variables. r=erahm.
...
These are all easy cases where an nsXPIDLCString local variable is set via
getter_Copies() and then is only used in ways that nsCStrings can also be used
(i.e. no null checks or implicit conversions to |char*|).
In every case the patch trivially replaces the nsXPIDLCString with an
nsCString. (Also, there are a couple of unused nsXPIDLCString variables that
the patch simply removes.)
2017-08-16 13:58:35 +10:00
Dan Banner
0d33a246ae
Bug 1386684 - Enable ESLint for toolkit/components/url-classifier (manual fixes). r=hchang
...
MozReview-Commit-ID: JH1XDFMVd43
2017-08-02 20:09:14 +01:00
Dan Banner
1a5db31879
Bug 1386684 - Enable ESLint for toolkit/components/url-classifier (automatic fixes). r=hchang
...
MozReview-Commit-ID: F0Z8dRaYOku
2017-08-02 16:12:07 +01:00
Henry Chang
53064b6aa0
Bug 1375277 - Test case for new error code NS_ERROR_HARMFUL_URI. r=francois
...
The test is based on "test-harmful-simple" so we can add testing entries
in a human-readable way.
MozReview-Commit-ID: IJcYrp04uFs
2017-07-28 17:38:01 +08:00
Henry Chang
325a9e1bb5
Bug 1375277 - Move Safe Browsing UI events to a separate telemetry probe. r=francois
...
MozReview-Commit-ID: KDAklsznekw
2017-08-02 14:01:44 +08:00
Henry Chang
3ddce6c31d
Bug 1375277 - New safebrowsing threat type "POTENTIALLY_HARMFUL_APPLICATION" introduced by v4. r=francois
...
As our threattype-listname conversion design, "goog-harmful-proto" is allocated
for this new threat type. This threat type is mainly for mobile.
MozReview-Commit-ID: G9GbgmHHHfp
2017-07-27 15:37:57 +08:00
Masatoshi Kimura
012500cff8
Bug 1375125 - Remove nsILocalFile. r=froydnj
...
MozReview-Commit-ID: 6oU6Ya5UXtC
2017-08-05 09:43:49 +09:00
Masatoshi Kimura
0af76969af
Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
...
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.
MozReview-Commit-ID: 4ecl3RZhOwC
2017-08-04 17:49:22 +09:00
Masatoshi Kimura
c0943e4f30
Bug 1326520 - Rename nsIURI.path to pathQueryRef. r=valentin.gosu
...
MozReview-Commit-ID: DqJdTGopR9G
2017-07-29 20:50:21 +09:00
Francois Marier
d33e0251eb
Bug 1386013 - Log an error when Safe Browsing times out. r=hchang
...
MozReview-Commit-ID: A99ov9T7rtm
2017-07-31 20:29:25 -07:00
Nicholas Nethercote
636397db95
Bug 1384835 (part 1, attempt 2) - Use nsA[C]String references instead of pointers for outparams of Get*String() pref functions. r=froydnj.
2017-07-31 10:52:51 +10:00
Thomas Nguyen
e8a574aa62
Bug 1366384 - Add Advisory test on Safe Browsing warning page r=francois
...
MozReview-Commit-ID: C0c7GRj1qJo
2017-07-27 15:11:00 +08:00
Carsten "Tomcat" Book
3fe83e45ea
merge mozilla-inbound to mozilla-central a=merge
2017-07-27 10:57:25 +02:00
Wes Kocher
6b1bdab609
Merge m-c to inbound, a=merge
...
MozReview-Commit-ID: LhiAcCiFBus
2017-07-26 18:33:18 -07:00
Thomas Nguyen
edc3d1fb65
Bug 1381718 : Dump request when receiving 400 error r=hchang
...
MozReview-Commit-ID: 1ZFOIRTryiV
2017-07-25 14:43:11 +08:00
Thomas Nguyen
41442f215a
Bug 1378680 - Refactor usage fallible alloc in url-classifier r=francois
...
MozReview-Commit-ID: HHG1ByeIwZv
2017-07-20 16:20:27 +08:00
Bevis Tseng
59627df038
Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm
2017-07-27 02:18:20 +08:00
Kartikaya Gupta
14424677af
Bug 1384233 - Remove SizePrintfMacros.h. r=froydnj
...
We have a minimum requirement of VS 2015 for Windows builds, which supports
the z length modifier for format specifiers. So we don't need SizePrintfMacros.h
any more, and can just use %zu and friends directly everywhere.
MozReview-Commit-ID: 6s78RvPFMzv
2017-07-26 16:03:57 -04:00
Marco Castelluccio
927b079f10
Bug 1384040 - Stop using preprocessor in nsUrlClassifierLib.js and nsUrlClassifierListManager.js, by directly copying the contents of the files they were including. r=francois
2017-07-26 01:24:09 +02:00
Sylvestre Ledru
576cac5ec7
Bug 1381253 - Remove redundant control flow declarations rs=ehsan
...
MozReview-Commit-ID: FFxP4aMCbOL
2017-07-15 19:03:04 +02:00
Andrea Marchesini
9e8ae1dfd0
Bug 1350958 - Finish labeling ProxyReleaseEvent, r=billm
2017-07-14 08:49:22 +02:00
Thomas Nguyen
f5552fcab6
Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse r=francois
...
MozReview-Commit-ID: 1yWe7wB0ARl
2017-07-04 16:36:31 +08:00
Wes Kocher
5ff640dd5b
Merge m-c to autoland, a=merge
...
MozReview-Commit-ID: 4R4GFHPiij
2017-07-06 16:19:38 -07:00
Wes Kocher
4f9edb4a89
Merge inbound to central, a=merge
...
MozReview-Commit-ID: 2nFzji7su8C
2017-07-06 16:10:49 -07:00
Nathan Froyd
8953d05316
Bug 1378387 - use dependent strings in the url-classifier where possible; r=gcp
...
Doing this makes various operations more efficient, as we don't have to
allocate, copy strings, and deallocate needlessly. The remaining
instances of nsCString temporaries are in logging code, which didn't
seem worthwhile to deal with here.
2017-07-06 15:26:12 -04:00
Thomas Nguyen
526e01f06e
Bug 1363882 - Remove casting address of inactive member union result.hash r=francois
...
MozReview-Commit-ID: 3pVaVJ1EJZu
2017-07-05 17:21:01 +08:00
Thomas Nguyen
5ab2608614
Bug 1297614 - Refactor and remove dead code in toolkit/components/url-classifier/content r=francois
...
MozReview-Commit-ID: GzVGS1ZTRGL
2017-06-30 13:31:03 -07:00