Commit Graph

843 Commits

Author SHA1 Message Date
Erik Nordin
c895daa5dd Bug 1903393 - Send the text source to telemetry r=translations-reviewers,gregtatum
Adds the ability for the SelectTranslationsPanel to send
to telemetry whether the source text came from an active
selection or from a right-clicked hyperlink's text.

Differential Revision: https://phabricator.services.mozilla.com/D214161
2024-06-18 23:55:24 +00:00
Masayuki Nakano
b3c5045ec1 Bug 1675847 - part 5: Make contextmenu event dispatchers use WidgetPointerEvent or PointerEvent r=smaug,pip-reviewers,devtools-reviewers,nchevobbe,mconley
`eContextMenu` event may be fired from `widget`.  Therefore, different from
`ePointerClick` and `ePointerAuxClick`, they may cross the process boundary,
may be handled by APZ and may be dispatched into the DOM after a delay.
Therefore, this patch is complicated than the previous patch.  This adds
* New IPC message handlers for sending/receiving a `WidgetPointerEvent`
* New `DelayedPointerEvent` class and templated `MouseInput::ToWidgetEvent`
* `PresShell::EventHandler` handles `eContextMenu` as same as `WidgetMouseEvent`

Differential Revision: https://phabricator.services.mozilla.com/D213003
2024-06-14 00:18:48 +00:00
Erik Nordin
10c37afaee Bug 1901351 - Do not offer Translate Link Text for URLs r=translations-reviewers,ohall
This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in only a URL being translated.

Differential Revision: https://phabricator.services.mozilla.com/D212980
2024-06-11 14:14:59 +00:00
Cristian Tuns
6f964848ed Backed out changeset a3650bda33a8 (bug 1901351) for causing bc failures in browser_contextmenu.js CLOSED TREE 2024-06-11 05:52:43 -04:00
Erik Nordin
440dee2ad3 Bug 1901351 - Do not offer Translate Link Text for URLs r=translations-reviewers,ohall
This patch ensures that the Translate Link Text
option is not offered in the context menu when
right clicking hyperlinked text that would result
in only a URL being translated.

Differential Revision: https://phabricator.services.mozilla.com/D212980
2024-06-10 23:52:09 +00:00
Ed Lee
6eba03edae Bug 1894994 - Stub initial context menu entrypoint for asking chat r=tarek,mconley
Differential Revision: https://phabricator.services.mozilla.com/D209637
2024-06-05 20:43:12 +00:00
Erik Nordin
0c943a3389 Bug 1870368 - Rename langPairPromise return values r=translations-reviewers,gregtatum
Renames the returned values from langPairPromise to be
`{ fromLanguage, toLanguage }` rather than `{ fromLang, toLang }`
to be more consistent with the rest of the code.

Depends on D210826

Differential Revision: https://phabricator.services.mozilla.com/D208583
2024-05-23 17:56:35 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Kelly Cochrane
a45a9953b8 Bug 1730169 - Show 'Take Screenshot' context menu item for images and videos r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D209090
2024-05-07 18:56:41 +00:00
Abhishek Madan
310bd3f288 Bug 1884535 - Added error catching for Strip on Share.r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D209292
2024-05-06 19:11:26 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
Erik Nordin
34a8c23c93 Bug 1871645 - Disallow Select Translations if unsupported r=translations-reviewers,gregtatum
Ensures that hardware support for Translations is checked
before displaying the context menu item to translate
selected text.

Differential Revision: https://phabricator.services.mozilla.com/D208396
2024-04-25 04:56:26 +00:00
Erik Nordin
5e4b75b352 Bug 1892359 - Fix Translations Exception Handling r=translations-reviewers,gregtatum
Fixes an issue where an exception was not being
caught correctly if the Translations Engine failed
to be created for SelectTranslations.

Differential Revision: https://phabricator.services.mozilla.com/D207939
2024-04-22 22:33:47 +00:00
Greg Stoll
3625ba8618 Bug 1869868 part 2 - do not consult DLP when copy/pasting items in the same tab r=edgar,dlp-reviewers,credential-management-reviewers,handyman,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D205744
2024-04-15 12:10:46 +00:00
Yi Xiong Wong
c585b6d660 Bug 1880914 - Move BrowserPageInfo. r=Gijs,anti-tracking-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206199
2024-04-08 17:21:02 +00:00
Yi Xiong Wong
69496efae6 Bug 1880914 - Move view source functions. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D206198
2024-04-08 17:21:01 +00:00
Erik Nordin
b92ebb4af9 Bug 1878721 - Open SelectTranslationsPanel at Context Menu r=translations-reviewers,gregtatum
Opens the SelectTranslationsPanel at the location of the context menu
from which the open event was invoked, rather than opening at the
Application Menu always.

Differential Revision: https://phabricator.services.mozilla.com/D205731
2024-04-06 02:07:31 +00:00
Erik Nordin
94beb308b7 Bug 1870316 - SelectTranslationsPanel Translate on open r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D204978
2024-04-06 02:07:28 +00:00
Erik Nordin
e4d17cc19f Bug 1870316 - Refactor getTranslationsActor r=translations-reviewers,gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D204973
2024-04-06 02:07:26 +00:00
Dave Townsend
ab57b0fdc1 Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Calixte
39b95434d2 Bug 1867739 - Add an entry in the context menu in order to be able to highlight the selected text in a pdf r=Gijs,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D202335
2024-03-12 16:53:50 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Natalia Csoregi
906b1810c7 Backed out changeset f319d88c8aad (bug 1867739) for causing failures on browser_pdfjs_editing_contextmenu.js CLOSED TREE 2024-03-11 13:56:21 +02:00
Calixte
d825932fe4 Bug 1867739 - Add an entry in the context menu in order to be able to highlight the selected text in a pdf r=Gijs,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D202335
2024-03-11 11:23:07 +00:00
Sergey Galich
c923e70636 Bug 1864896: Polishing autofix of unused function arguments (credential management). r=credential-management-reviewers,dimi
Depends on D202958

Differential Revision: https://phabricator.services.mozilla.com/D203314
2024-03-05 00:08:04 +00:00
Erik Nordin
e139e3ec78 Bug 1870327 - Populate Select Translations Panel menulists r=translations-reviewers,gregtatum
Implements the logic to determine which from-language
and which to-language should be automatically selected
when the SelectTranslationsPanel is opened, based on the
context in which it was opened.

Depends on D201282

Differential Revision: https://phabricator.services.mozilla.com/D201283
2024-02-23 21:30:39 +00:00
Gregory Pappas
b8a57ea6f0 Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D199328
2024-02-01 00:48:24 +00:00
Erik Nordin
567d967889 Bug 1871642 - Disallow Select Translations when Full Page Translations is active r=translations-reviewers,gregtatum
Ensures that the Select Translations context menu item
will not appear while Full Page Translations is active,
even in situations where it would otherwise be expected
to appear. Select Translations is not available on top
of Full Page Translations.

Depends on D197226

Differential Revision: https://phabricator.services.mozilla.com/D197227
2024-01-05 18:50:15 +00:00
Erik Nordin
7ae7fc92db Bug 1870306 - Enable Select Translations context menu item for hyperlinked text r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
Adds the functionality for the Select Translations
context menu item to appear when a hyperlink is clicked
even if no text is selected. Selected text takes precedence
if a link is clicked while there is also an active selection.

Depends on D197225

Differential Revision: https://phabricator.services.mozilla.com/D197226
2024-01-05 18:50:14 +00:00
Erik Nordin
cb5bc082fe Bug 1870305 - Show Select Translations context menu item when text is selected r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
Ensures that the Select Translations context menu
item only appears when there is actively selected text
at the time the context menu is invoked.

Depends on D197224

Differential Revision: https://phabricator.services.mozilla.com/D197225
2024-01-05 18:50:14 +00:00
Erik Nordin
73ded47df3 Bug 1870305 - Add Select Translations context menu item r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
Adds the Select Translations context menu item
to the right-click context menu with an initial
localized label value.

Depends on D197223

Differential Revision: https://phabricator.services.mozilla.com/D197224
2024-01-05 18:50:13 +00:00
Erik Nordin
155e0ec366 Bug 1870305 - Rename textSelected to selectedText in nsContextMenu.js r=translations-reviewers,gregtatum
Renames the data member textSelected to selectedText.
I think textSelected sounds more like a boolean, rather
than a string, and I think selectedText is a better name.

Depends on D197222

Differential Revision: https://phabricator.services.mozilla.com/D197223
2024-01-05 18:50:13 +00:00
Johannes J. Schmidt
ec2d81f53c Bug 1867024 - Update String for Context Menu - Username and password fields - r=credential-management-reviewers,fluent-reviewers,kpatenio,bolsson,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195257
2023-12-11 11:47:14 +00:00
Abhishek Madan
59cb061cf5 Bug 1864931 - Added check to see if a webpage is internal for strip on share. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D195035
2023-12-07 20:16:05 +00:00
Abhishek Madan
cba9a32a71 Bug 1853998 - Updated UI to always show Copy without Site Tracking. r=pbz,anti-tracking-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D188626
2023-10-19 15:05:04 +00:00
Norisz Fay
f636085f1f Backed out 2 changesets (bug 1853998, bug 1842581) for causing bc failures on browser_contextmenu.js
Backed out changeset ecb00efc209a (bug 1842581)
Backed out changeset 9c4eed63d7c0 (bug 1853998)
2023-10-17 19:02:06 +03:00
Abhishek Madan
1b81445563 Bug 1853998 - Updated UI to always show Copy without Site Tracking. r=pbz,anti-tracking-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D188626
2023-10-17 14:16:07 +00:00
Butkovits Atila
62f1dc61e3 Backed out 2 changesets (bug 1853998, bug 1842581) for causing failures at browser_strip_on_share_link.js. CLOSED TREE
Backed out changeset 666a5cee0716 (bug 1842581)
Backed out changeset 0c698bf2cec5 (bug 1853998)
2023-10-12 08:35:28 +03:00
Abhishek Madan
29927136c8 Bug 1853998 - Updated UI to always show Copy without Site Tracking. r=pbz,anti-tracking-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D188626
2023-10-12 01:27:47 +00:00
Mathew Hodson
28aa899942 Bug 1564391 - Rename internal uses of mozInputSource. r=emilio,pip-reviewers,tabbrowser-reviewers,dao,kpatenio
This allows us to deprecate `mozInputSource` for the Web while
avoiding console warnings for internal uses, which now use the
ChromeOnly `inputSource` attribute.

Differential Revision: https://phabricator.services.mozilla.com/D183643
2023-07-26 09:27:45 +00:00
Sergey Galich
348bc91ede Bug 1845165 - stopping polluting logs on right clicks at about: pages r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D184411
2023-07-24 20:41:28 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00