Ensure the `Manage bookmarks` control is marked up as a link and is accessible to assistive technology.
Also, by adding a `role="alert"` to the grouping, we are making sure that a screen reader like NVDA would be able to hear the static text on the Personal toolbar message when navigating the browser UI and that it would be announced to a user whenever this message is added to the toolbar, i.e. when the user removes the last bookmark from the Bookmarks Toolbar.
Differential Revision: https://phabricator.services.mozilla.com/D209588
Renames the TranslationsPanel class itself to FullPageTranslationsPanel
to distinguish it from the SelectTranslationsPanel class.
Depends on D200877
Differential Revision: https://phabricator.services.mozilla.com/D201280
Move it out of the UA sheet into popup.css, and share most of the code
between macOS and non-macOS.
Also, don't duplicate it for the bookmarks popup. Instead just add an
animatable-menupopup class for it.
Differential Revision: https://phabricator.services.mozilla.com/D202108
Since, in the bug 1875654, we have updated the `browser-toolbarKeyNav.js` to ensure the keyboard navigation handler accounts for intentionally non-focusable controls when calculating focus behavior of toolbar buttons.
We are updating the URL Bar `Go` button markup to ensure it won't be included in the keyboard focus order (since a keyboard-only user could press `Enter` to achieve the same submission of their search query), as well as associated mochitests since we do not need to separately set an environment to skip the focus check. This is because we also fine-tune the AccessibilityUtils' `isKeyboardFocusableBrowserToolbarButton()` check to ensure more through confirmation of the image button in question.
Differential Revision: https://phabricator.services.mozilla.com/D199394
Previously the "See tabs from synced devices" button redirected to `about:firefoxview`.
This patch updates the `openTab` function to accept a category instead of an entryPoint or event.
For previous instances where `openTab` passed an event, `openTab` has been replaced with `openToolbarMouseEvent` to handle event.
We should open an issue in FxA to update the following `entryPoint` from "preferences" to "syncedtabs".
2b2ee47c4b/packages/fxa-content-server/app/scripts/views/pair/auth_complete.js (L55-L63)
Depends on D196208
Differential Revision: https://phabricator.services.mozilla.com/D196881
Ensure the focusable and actionable control is also labeled, so an assistive technology user would know the purpose of this control. It should not only be announced as `Close` but also provide a context by referencing the search mode title text as well, so the "History" search would be announced as `Close History mode` or just `Close History` or similar.
Also, since there were a series of test cases failing the a11y-checks because of this unlabeled control, we remove the `fail-if` notations from their test manifests to allow for the accessibility tests to run and expect to pass, as they should be.
Differential Revision: https://phabricator.services.mozilla.com/D196095
We provide `role=button` to the image control that can be clicked (with a mouse or with an assistive technology as speech-to-text/voice control) as an alternative way of the urlbar search query submission, where other ways are accessible (and are tested here too).
Setting an environment to `focusableRule: false` allows us to flag to the AccessibilityUtils that this specific button is purposefully not made focusable and its keyboard focusability should not be tested.
The previously failing accessibility checks should now be passing, thus we are also removing the `fail-if` notations that were added by bug 1854660 before the investigation in the meta bug 1854661.
Differential Revision: https://phabricator.services.mozilla.com/D193703
- Adds a urlbar button to toggle shopping sidebars and show sidebar state
- ShoppingSidebarParent.toggleAllSidebars() method to open and close sidebars
- Adds `browser.shopping.experience2023.active` pref to store the state of all sidebars
- Sidebars open and close based on state of the active pref
Differential Revision: https://phabricator.services.mozilla.com/D183394
This creates 3 icon states:
1. The translations offering with a single icon.
2. The loading icon with the spinner.
3. The live translation document, with the "translate to" locale listed.
Note that the locale text in the icon can grow to three letters in
theory, but in practice this does not happen with our currently
supported languages. I made sure the button can grow correctly if this
ever happens.
The tests are in the next patch.
Differential Revision: https://phabricator.services.mozilla.com/D178226
