corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
780,392 Commits 1 Branch 0 Tags
aa15989557fa76455874c1d28a40b88bcc8fa9c2
Commit Graph

67 Commits

Author SHA1 Message Date
Drew Willcoxon
0b3ffdfa49 Bug 1825432 - Don't reset engagement telemetry start event info on dismissal. r=mak 
In the future, due to the result menu there may be other engagement types that
do not close the view, so we may need to revisit this, but for now the fix is
pretty simple.

Differential Revision: https://phabricator.services.mozilla.com/D174038
 2023-03-30 15:49:01 +00:00
Daisuke Akatsuka
36f8079d27 Bug 1822210: Check wheather the view is opening when recording r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D172098
 2023-03-15 21:51:12 +00:00
Daisuke Akatsuka
7c048856b3 Bug 1817208: Introduce search_shortcut_button type for immediate search on oneoff button r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D172207
 2023-03-13 23:59:06 +00:00
Dão Gottwald
acb8d341cc Bug 1821375 - Remove weird providerName != "UrlbarProviderTopSites" check from UrlbarController::typeFromElement. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D172134
 2023-03-09 16:34:33 +00:00
Dão Gottwald
8b7b30f0a4 Bug 1790020 - Hook up urlbar result menu with telementry. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D168688
 2023-03-09 12:02:13 +00:00
Cristina Horotan
1255ede78b Backed out changeset fcc4aae881d7 (bug 1790020) for causing bc failures at browser_ext_urlbar.js CLOSED TREE 2023-03-09 13:11:26 +02:00
Dão Gottwald
4d726892e1 Bug 1790020 - Hook up urlbar result menu with telementry. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D168688
 2023-03-09 09:54:20 +00:00
Stanca Serban
0edec904ef Backed out changeset e7822e311e0c (bug 1790020) for causing mochitests failures in browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js. CLOSED TREE 2023-03-08 17:40:26 +02:00
Dão Gottwald
42c66fc8dd Bug 1790020 - Hook up urlbar result menu with telementry. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D168688
 2023-03-08 14:22:31 +00:00
Daisuke Akatsuka
b30c8f79a4 Bug 1820453: Introduce unsortedResults to the query r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D171673
 2023-03-08 02:30:33 +00:00
Daisuke Akatsuka
529ee1c6c1 Bug 1817206: Use visibleResults for telemetry instead of results in query r=adw,mak 
Differential Revision: https://phabricator.services.mozilla.com/D171444
 2023-03-07 21:27:07 +00:00
Daisuke Akatsuka
3957aa642a Bug 1817196: Record preference value that affects the number of results showing in the urlbar r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D170317
 2023-02-28 21:02:35 +00:00
Stanca Serban
590cfe9a89 Backed out changeset e7a8fb56745e (bug 1817196) as requested by dev for missing data-review. CLOSED TREE 2023-02-28 11:40:18 +02:00
Daisuke Akatsuka
95dabb81e9 Bug 1817203: Introduce go_button in engagement_type r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D171033
 2023-02-28 01:26:49 +00:00
Daisuke Akatsuka
b4d694fef0 Bug 1817196: Record preference value that affects the number of results showing in the urlbar r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D170317
 2023-02-28 00:51:46 +00:00
Daisuke Akatsuka
5c8e4d197d Bug 1817156: Use input_field as selected_result value if the result view has not been shown upon engagement r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D170144
 2023-02-25 07:32:04 +00:00
Daisuke Akatsuka
cc5cbd2fef Bug 1817155: Make results and groups empty if the result view has not been shown upon engagement r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D170143
 2023-02-25 07:32:04 +00:00
Dão Gottwald
fa7b554ee2 Bug 1801389 - SPACE should open the result menu when the button is selected. r=mak,Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D168522
 2023-02-03 03:11:20 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D167297
 2023-01-20 17:49:21 +00:00
Dão Gottwald
95d9a858cf Bug 1801298 - Fix down/up arrow behavior with multiple selectable elements per row. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D166803
 2023-01-19 10:26:53 +00:00
Sandor Molnar
6373ae2505 Backed out changeset 357170b2f52a (bug 1801298) for causing bc failures in browser/components/urlbar/tests/browser-tips/browser_selection.js CLOSED TREE 2023-01-19 12:00:27 +02:00
Dão Gottwald
367bd12003 Bug 1801298 - Fix down/up arrow behavior with multiple selectable elements per row. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D166803
 2023-01-19 08:25:15 +00:00
Daisuke Akatsuka
4b4fa32e15 Bug 1805717: Introduce search_mode property. r=mak,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D164794
 2022-12-20 07:10:11 +00:00
Stanca Serban
8afe90eead Backed out changeset 3adf002ab926 (bug 1805717) for searchMode mochitests related failures in browser_touchbar_searchrestrictions.js. CLOSED TREE 2022-12-20 07:07:55 +02:00
Daisuke Akatsuka
3bce4ac968 Bug 1805717: Introduce search_mode property. r=mak,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D164794
 2022-12-20 00:55:36 +00:00
Daisuke Akatsuka
ea23c8fcc3 Bug 1804314: Introduce persisted_search_terms_* interaction type. r=mak,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D163803
 2022-12-19 03:32:17 +00:00
Norisz Fay
5cbd726d6d Backed out changeset d6454f53dcc0 (bug 1804314) for causing mochitest failures on browser_glean_telemetry CLOSED TREE 2022-12-19 01:40:31 +02:00
Daisuke Akatsuka
ab22a1563a Bug 1804314: Introduce persisted_search_terms_* interaction type. r=mak,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D163803
 2022-12-18 22:21:26 +00:00
Marco Bonardo
e14c64ef54 Bug 1805702 - Log engagement event regardless of recording being enabled. r=daisuke 
Logs engagement telemetry for debug purposes, regardless of it being reported
upstream.
Also changes a couple other logs to make browser.urlbar.logLevel = "Info"
more readable and usable.

Differential Revision: https://phabricator.services.mozilla.com/D164701
 2022-12-15 08:59:22 +00:00
Daisuke Akatsuka
302775a826 Bug 1804561: Handle the interaction type 'refined' as a subset of 'returned'. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D164180
 2022-12-13 21:14:06 +00:00
Daisuke Akatsuka
fc77179b9f Bug 1805112: Make Nimbus experiments allow telemetry recording to be enabled. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D164427
 2022-12-13 01:50:51 +00:00
Daisuke Akatsuka
604bc3f4a7 Bug 1800579: Refactoring _recordSearchEngagementTelemetry() function. r=mak 
Depends on D162085

Differential Revision: https://phabricator.services.mozilla.com/D163671
 2022-12-07 06:35:51 +00:00
Daisuke Akatsuka
42601e6a91 Bug 1800579: Implement the impression event. r=mak,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D162085
 2022-12-07 06:35:50 +00:00
Cristian Tuns
6d439f9c19 Backed out 2 changesets (bug 1800579) for causing mochitest failures on browser_glean_telemetry_impression_interaction.js 
Backed out changeset 329d79c6403b (bug 1800579)
Backed out changeset 2796c110119d (bug 1800579)
 2022-12-06 17:08:20 -05:00
Daisuke Akatsuka
51ecbb4208 Bug 1800579: Refactoring _recordSearchEngagementTelemetry() function. r=mak 
Depends on D162085

Differential Revision: https://phabricator.services.mozilla.com/D163671
 2022-12-06 20:48:39 +00:00
Daisuke Akatsuka
6d66275743 Bug 1800579: Implement the impression event. r=mak,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D162085
 2022-12-06 20:48:39 +00:00
Daisuke Akatsuka
d82f055d58 Bug 1800414: Implement the abandonment event. r=mak,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D161977
 2022-12-01 23:37:32 +00:00
Daisuke Akatsuka
238cee7905 Bug 1797265: Make user event fired while opening urlbar result by empty string be the target for interaction. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D162184
 2022-12-01 12:05:49 +00:00
Daisuke Akatsuka
f12f72c9eb Bug 1797265: Implement the engagement event. r=mak,adw,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D160193
 2022-12-01 12:05:48 +00:00
Mark Banner
319bc25bd8 Bug 1802855 - Convert toolkit/components/satchel JSM modules to ES modules. r=credential-management-reviewers,daleharvey,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D163201
 2022-11-29 15:53:20 +00:00
Marco Bonardo
6859ef34b1 Bug 1429108 - Switch FormHistory::update to promises. r=sgalich,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D160925
 2022-11-03 09:35:39 +00:00
trickypr
f28fa5aa80 Bug 1510561 - Part 6: Apply plugin:mozilla/valid-jsdoc to browser/components/urlbar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159471
 2022-10-24 13:32:37 +00:00
James Teow
8448fad066 Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw 
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
 2022-10-18 13:38:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 16:51:10 +00:00
Daisuke Akatsuka
d30690f485 Bug 1782594: Revert PageDown/Up key behavior on urlbar. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D153418
 2022-08-04 09:51:02 +00:00