Commit Graph

395 Commits

Author SHA1 Message Date
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-15 23:07:45 +00:00
Nikki Sharpley
4132fa94c6 Bug 1932347 - Adjust positioning of tab preview for vertical tabs r=tabbrowser-reviewers,dwalker
Previous patch was slightly off in Nightly. Opt for 3px offset instead.

Differential Revision: https://phabricator.services.mozilla.com/D234205
2025-01-14 18:07:52 +00:00
DJ
41d6122076 Bug 1939535 - TOM indicates collapsed groups and hides their tabs. r=sthompson,dao,desktop-theme-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233417
2025-01-14 17:24:19 +00:00
Dão Gottwald
027c8b5a85 Bug 1927927 - Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234173
2025-01-14 15:55:47 +00:00
Nikki Sharpley
ec1812e2e7 Bug 1932347 - Adjust vertical tab preview positioning r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D233266
2025-01-13 19:36:27 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-13 17:55:32 +00:00
Dão Gottwald
9dc9702c7e Bug 1940545 - Prevent empty tooltip on unnamed tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233666
2025-01-10 14:23:19 +00:00
Stephen Thompson
86ccb78df7 Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-09 20:07:00 +00:00
Dão Gottwald
83741f2f76 Bug 1940740 - Dispatch event when accepting the tab group creation panel. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233663
2025-01-09 14:58:03 +00:00
Dão Gottwald
a5e0177580 Bug 1940444 - Uncaught TypeError: can't access property "pinned", middleTab is undefined when attemtping to drag multiple discontinuous tabs while there's a collapsed tab group. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233495
2025-01-08 16:22:11 +00:00
Cosmin Sabou
2d51d552df Bug 1928146 - Disable browser_tab_groups.js on windows for frequent failures. r=intermittent-reviewers,dwalker,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D232155
2025-01-08 09:06:43 +02:00
Butkovits Atila
d7afe8c2aa Backed out changeset 0edde29b2e70 (bug 1939503) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-08 05:43:29 +02:00
Stephen Thompson
607c9a5cec Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-08 02:47:03 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D233026
2025-01-07 19:51:49 +00:00
Dão Gottwald
206b27689c Bug 1939593 - Unbreak ::first-letter for tab group labels. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D233347
2025-01-07 14:18:48 +00:00
Dão Gottwald
048a7a56f8 Bug 1940041 - Fix typo. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D233271
2025-01-06 19:27:45 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Mauro B
35bae9ed07 Bug 1921951 - Fixed linter errors. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233208
2025-01-04 12:48:45 +00:00
Mauro B
dea2dbc861 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-04 12:48:45 +00:00
Narcis Beleuzu
884122ae28 Backed out changeset 5ddfa4c882b5 (bug 1921951) for lint failures on tabs.js . CLOSED TREE 2025-01-04 02:05:03 +02:00
Mauro B
1cae811100 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-03 23:24:54 +00:00
Joel Maher
aec9b5a5d9 Bug 1939738 - move most remaining mochtests (a11y, devtools, browser-media) from macosx 10.15 -> 14.70. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D233108
2025-01-03 18:44:22 +00:00
Dão Gottwald
1a4c207141 Bug 1939677 - Correctly add toolbarbuttons to TAB key order. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233089
2025-01-03 17:34:14 +00:00
Dão Gottwald
e9e9d3a05a Bug 1926254 - Esc key should cancel rather than accept the tab group create panel. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233185
2025-01-03 17:15:50 +00:00
Goloman Adrian
d33f45c6a2 Backed out changeset 333ccf52cb65 (bug 1939738) for causing mda failures @GMPServiceChild.cpp. CLOSED TREE 2025-01-03 19:29:25 +02:00
Joel Maher
63d0466126 Bug 1939738 - move most remaining mochtests (a11y, devtools, browser-media) from macosx 10.15 -> 14.70. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D233108
2025-01-03 15:24:26 +00:00
Jeremy Swinarton
82d7acff7a Bug 1936015: Groups can be deleted after switching between horizontal and vertical tabs r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232925
2025-01-03 13:37:41 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
2024-12-31 20:03:05 +00:00
Sandor Molnar
70055345d6 Bug 1928146 - Disable 'browser_window_open_modifiers.js' on macOS for permafailing under vertical tab config. r=intermittent-reviewers,jmaher DONTBUILD 2024-12-28 15:26:44 +02:00
Cosmin Sabou
f99dd35df8 Bug 1928146 - Disable several tests on macOS that are permafailing under vertical tab config. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D232905
2024-12-28 10:21:33 +00:00
Goloman Adrian
b719cd2c84 Bug 1938525 - disable browser_tabReorder_overflow.js for perma failures on macOS. r=intermittent-reviewers,tabbrowser-reviewers,jmaher,dao DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D232801
2024-12-26 17:56:17 +00:00
Daisuke Akatsuka
abd3414bd9 Bug 1937363: Show/Focus Unified Search Button when P&S icon group gets focus r=desktop-theme-reviewers,urlbar-reviewers,dao,tabbrowser-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D232160
2024-12-24 04:02:25 +00:00
Alexandru Marc
d3a6a84fb2 Backed out 4 changesets (bug 1325876) for causing wd failures @ navigation.spec.js CLOSED TREE
Backed out changeset b29ef3f14bf7 (bug 1325876)
Backed out changeset f8add6e2ef93 (bug 1325876)
Backed out changeset 41cc884f84c1 (bug 1325876)
Backed out changeset 014c9c77393a (bug 1325876)
2024-12-21 04:41:41 +02:00
Sean
b926b49e9e Bug 1325876 - Add a pref for showing error page for HTTP responses with error codes and Content-Length: 0 r=necko-reviewers,valentin,credential-management-reviewers,tabbrowser-reviewers,dimi,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D232429
2024-12-20 22:12:11 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Dão Gottwald
3336bd457a Bug 1937203 - Tab group panel should close when expanding/collapsing a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232657
2024-12-19 20:30:41 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
DJ
6def3c2478 Bug 1928146 - fix high freq intermittent in browser_tab_groups.js r=dao,tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D232572
2024-12-19 16:42:48 +00:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Dão Gottwald
8b91d8e6b9 Bug 1935956 - Include group labels in scrollable elements. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232517
2024-12-19 15:32:48 +00:00
DJ
a807e8e024 Bug 1908431 - add basic support for tab groups in overflow menu. r=dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D232389
2024-12-19 12:04:19 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232430
2024-12-19 08:54:25 +00:00
Stanca Serban
4db9e4acb2 Backed out 2 changesets (bug 1938187, bug 1908431) for causing xpcshell failures in test_providerOmnibox.js. CLOSED TREE
Backed out changeset 0449f79cb3bd (bug 1938187)
Backed out changeset 26bd70f6e763 (bug 1908431)
2024-12-19 06:26:36 +02:00
DJ
13502b2c42 Bug 1908431 - add basic support for tab groups in overflow menu. r=dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D232389
2024-12-19 03:08:11 +00:00
Sam Foster
1e5b885006 Bug 1902032 - Add test variant to run select tabbrowser tests with sidebar.verticalTabs enabled. r=jmaher,sidebar-reviewers,tabbrowser-reviewers,taskgraph-reviewers,ahal,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D229559
2024-12-19 00:37:58 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Dão Gottwald
468d6c6d01 Bug 1938054 - Add a zero width space to tab group labels so we always create a text node and get consistent layout even if the group is unnamed. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232453
2024-12-18 13:58:29 +00:00
Sandor Molnar
a1f186646b Backed out changeset ae226b670402 (bug 1902032) for causing py3 unit test failures. CLOSED TREE 2024-12-18 08:52:59 +02:00