To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.
Differential Revision: https://phabricator.services.mozilla.com/D233749
To help catch bugs such as Bug 1919721, assert the toolbar is unchanged and widgets are in the correct order on browser restart.
Differential Revision: https://phabricator.services.mozilla.com/D233749
I ended up having to change some of the fundamentals of the popupnotification element because the code relied on being able to inherit inline event handler attributes such as buttoncommand as oncommand on the button element and so on.
The primary user of the popupnotification element seems to be `PopupNotifications`. Following a pre-existing coupling with `PopupNotifications._onCheckboxCommand`, by default all commands/actions will simply call the corresponding `PopupNotifications` handler. However, I found at least one instance in `panelUI.js` that tries to override the command handlers. I solved this by dispatching a custom cancelable event on the popupnotification element.
Differential Revision: https://phabricator.services.mozilla.com/D231927
This does keep the checks in the interactive update interface, since we don't want to to show the user the "Restart to Update" button at the end if restarting will not update.
Differential Revision: https://phabricator.services.mozilla.com/D227285
This does keep the checks in the interactive update interface, since we don't want to to show the user the "Restart to Update" button at the end if restarting will not update.
Differential Revision: https://phabricator.services.mozilla.com/D227285
- fix setup and cleanup so that tests pass on --verify
- need to add "sidebar.revamp" to ensure sidebar button gets added each time
- make test more dynamic in case extra nav bar buttons are added later
Differential Revision: https://phabricator.services.mozilla.com/D231747
The change in CustomizableUI is required because the routine wasn't designed to handle
custom elements with shadow roots. The routine's job is to walk up the ancestry of
the click event and determine if any of the parents have certain characteristics
that would indicate that the event should not close the panel, and without this
change it would bail out as soon as it hit the shadow root if the event's original
target was inside the custom element.
In this case, the element enclosing the fxa-menu-message is the "appMenu-fxa-menu-message"
toolbaritem with `closemenu="none"`, which this modification now lets
CustomizableUI detect.
Differential Revision: https://phabricator.services.mozilla.com/D230560
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
We want the nav-bar customizations to be the same across vertical and horizontal tabs mode, minus the Fxview, "list all tabs" buttons, and any other tab strip widgets moved to the nav-bar.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are removed in the nav-bar in vertical mode, they are removed from the tab-strip when switching back to horizontal mode.
- If the Fxview and "list all tabs" buttons and tab-strip widgets are moved in the nav-bar in vertical mode, this should be remembered for vertical mode. Their positions in horizontal mode should remain as they were in horizontal mode.
Differential Revision: https://phabricator.services.mozilla.com/D227555
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
This patch matches the tab title listed on the menu item in the "recently closed tabs" menu with the tab title of the restored tab.
This test was arbitrarily restoring the first listed tab in a menu, but the expectation was that it would load a specific tab. This failed nondeterministically. This patch should always work regardless of how many or which tabs are contained in the tab group.
Differential Revision: https://phabricator.services.mozilla.com/D230346
