corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
888,860 Commits 1 Branch 0 Tags
a807e8e02433e381e4173f3111a708e64ca5bfe1
Commit Graph

104 Commits

Author SHA1 Message Date
Tom Schuster
4f3940189e Bug 1936231 - Remove inline event handlers from placesContext menu. r=places-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D231703
 2024-12-13 14:24:24 +00:00
Henry Wilkes
f55c9c25aa Bug 1436462 - Use "Open in new private window" for bookmarks when in PBM. r=places-reviewers,mak 
This makes the bookmark menu consistent with the "File" and context
menu when using private browsing mode.

We also share the same hide item logic for these "open" items in one
place in PlacesUIUtils so that they can be shared between the two
consumers (regular bookmarks and managed bookmarks). This ensures that
the "Open in container" item if hidden for managed bookmarks in a
private window.

Differential Revision: https://phabricator.services.mozilla.com/D220120
 2024-09-10 16:36:40 +00:00
Moritz Beier
7e45214aee Bug 1653564 - Open options from the context menu doesn't dismiss the bookmarks doorhanger in some cases. r=places-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D219743
 2024-09-09 21:22:57 +00:00
Moritz Beier
0a7191389a Bug 1841429 - Firefox 115 Bookmark Toolbar - Firefox connects(preload) with a right click to web page. r=places-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D219957
 2024-09-09 15:32:31 +00:00
Mark Banner
28e4ba7093 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 16:43:57 +00:00
Butkovits Atila
11a5a23896 Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE 
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
 2024-08-23 12:22:02 +03:00
Mark Banner
1ee70a0f13 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 08:55:49 +00:00
Daisuke Akatsuka
16934e3d29 Bug 1910338: Remove PlacesUIUtils.loadFavicon() function r=places-reviewers,mak 
Differential Revision: https://phabricator.services.mozilla.com/D218041
 2024-08-06 21:36:19 +00:00
Marco Bonardo
c23719eb3b Bug 1904909 - PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries r=daisuke,places-reviewers 
There's a few problems in the code gathering text data for nodes.
First it should not recurse into queries (included folder shortcuts) as it's
easy to create infinite recursion with them. The first level is excluded though,
as otherwise it would not be possible to copy contents of left pane roots.
Second it should requery folder shortcut contents in excludeItems results,
as otherwise it's not possible to copy contents of a root as text.
There's no longer the risk of dragging around root folders as this code is only
used for text flavors today, drag&drop uses serializeNode instead.

Differential Revision: https://phabricator.services.mozilla.com/D215068
 2024-07-02 13:45:37 +00:00
Daisuke Akatsuka
7a73f5cf79 Bug 1845042: Make editing tags feature when adding multiple bookmarks r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D212393
 2024-06-18 21:00:07 +00:00
Norisz Fay
2a03c567e1 Backed out changeset b037b47fd062 (bug 1845042) for causing bc failures on browser_bookmark_current_tabs.js CLOSED TREE 2024-06-18 09:36:24 +03:00
Daisuke Akatsuka
d28b1b2c32 Bug 1845042: Make editing tags feature when adding multiple bookmarks r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D212393
 2024-06-17 20:52:42 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D208680
 2024-05-08 14:33:17 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D208680
 2024-05-03 19:05:59 +00:00
Daisuke Akatsuka
78a5d14298 Bug 1552815: Use setFaviconForPage() instead of replaceFaviconDataFromDataURL() r=sync-reviewers,mak 
Depends on D192535

Differential Revision: https://phabricator.services.mozilla.com/D192536
 2024-05-01 20:40:50 +00:00
Stanca Serban
375a8970d3 Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp. CLOSED TREE 
Backed out changeset 4be83e948d32 (bug 1552815)
Backed out changeset 0b2d40719586 (bug 1552815)
Backed out changeset c17e4da85514 (bug 1552815)
Backed out changeset c66812747d09 (bug 1552815)
Backed out changeset 62b3d85f4ca3 (bug 1552815)
 2024-05-01 09:58:57 +03:00
Daisuke Akatsuka
588b426c7e Bug 1552815: Use setFaviconForPage() instead of replaceFaviconDataFromDataURL() r=sync-reviewers,mak 
Depends on D192535

Differential Revision: https://phabricator.services.mozilla.com/D192536
 2024-05-01 05:47:08 +00:00
Stanca Serban
b0b915869e Backed out 5 changesets (bug 1552815) for causing bp-nu bustages in nsFaviconService.cpp. 
Backed out changeset 08a2ac7a9834 (bug 1552815)
Backed out changeset bb9854e6ffe7 (bug 1552815)
Backed out changeset 4e06ccb2599e (bug 1552815)
Backed out changeset d28dd2aec9f4 (bug 1552815)
Backed out changeset 392389a8d495 (bug 1552815)
 2024-04-24 03:03:10 +03:00
Daisuke Akatsuka
ad006d147a Bug 1552815: Use setFaviconForPage() instead of replaceFaviconDataFromDataURL() r=sync-reviewers,mak 
Depends on D192535

Differential Revision: https://phabricator.services.mozilla.com/D192536
 2024-04-23 23:21:38 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204182
 2024-03-11 15:26:28 +00:00
Dave Townsend
9cde0f8425 Bug 1864896: Remove jsdoc params for removed arguments (places). r=places-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202980
 2024-03-01 20:52:30 +00:00
Dave Townsend
e59a3e41e6 Bug 1864896: Autofix unused function arguments (places). r=places-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202979
 2024-03-01 20:52:29 +00:00
Daisuke Akatsuka
352c077df4 Bug 1849866: Rename moz-anno:favicon protocol to cached-favicon r=necko-reviewers,places-reviewers,valentin,mak 
Differential Revision: https://phabricator.services.mozilla.com/D198130
 2024-01-24 22:05:42 +00:00
Mark Banner
e2e80f646d Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D197489
 2024-01-05 09:22:34 +00:00
Marco Bonardo
e6316e0feb Bug 1865087 - Add optional logging to PlacesTransactions. r=places-reviewers,daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D193814
 2023-11-20 19:09:12 +00:00
Marco Bonardo
d871e09d18 Bug 1865087 - Change PlacesTransaction.batch() to only accept an array of transactions. r=places-reviewers,daisuke 
Rather than accepting either an array or an async function, make it only accept
an array. This simplifies the internals for future refactoring, and avoids
depending on async functions created in other globals.

Differential Revision: https://phabricator.services.mozilla.com/D193813
 2023-11-20 19:09:11 +00:00
Jonathan Sudiaman
1859ecc92c Bug 1855218 - Regression: "Show all the bookmarks folders" button resets changes to Location dropdown in bookmarking pane r=mak,places-reviewers 
Fix bookmarks regression and add a test case. Also simplified the test file to use a single window. (New window is no longer required, now that we don't allow flipping between delayed/instant apply.)

https://treeherder.mozilla.org/jobs?repo=try&revision=8fd198b49afb038c1944d9ccccedbbe06d463517

Differential Revision: https://phabricator.services.mozilla.com/D189658
 2023-10-03 16:04:13 +00:00
Mark Banner
85c9f645f5 Bug 1844784 - Ensure Synced Tabs in the history menu is properly removed when FxAccounts are disabled. r=sync-reviewers,places-reviewers,lina,markh 
Differential Revision: https://phabricator.services.mozilla.com/D185719
 2023-08-09 15:00:20 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Marco Bonardo
530854e412 Bug 1844150 - Don't add moz-anno:favicon to local protocols. r=daisuke,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D184376
 2023-07-25 16:37:14 +00:00
Cristina Horotan
4b34180c2b Backed out changeset 46add7a02063 (bug 1844150) for causing bc failures at browser_readerMode.js CLOSED TREE 2023-07-25 16:31:59 +03:00
Marco Bonardo
b690ec8b26 Bug 1844150 - Don't add moz-anno:favicon to local protocols. r=daisuke,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D184376
 2023-07-25 11:02:18 +00:00
Marco Bonardo
761a9aa462 Bug 1816901 - Stop using promiseItemId in product code. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D180410
 2023-06-24 07:16:51 +00:00
Mark Banner
3eff463fbd Bug 1752744 - Fix opening bookmarks from the library window in certain conditions. r=mak,webdriver-reviewers,whimboo 
This fixes the case where there's no browser window open and browser.tabs.loadBookmarksInTabs is true.

Differential Revision: https://phabricator.services.mozilla.com/D181098
 2023-06-19 19:00:30 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Norisz Fay
ef6bd98346 Backed out changeset f67d1786e5a9 (bug 1752744) for causing bustages on testsuite-targets.mk CLOSED TREE 2023-06-19 15:13:03 +03:00
Mark Banner
7a68d3594e Bug 1752744 - Fix opening bookmarks from the library window in certain conditions. r=mak,webdriver-reviewers,whimboo 
This fixes the case where there's no browser window open and browser.tabs.loadBookmarksInTabs is true.

Differential Revision: https://phabricator.services.mozilla.com/D181098
 2023-06-19 11:49:42 +00:00
Mark Banner
0677cff70b Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Marco Castelluccio
4c09f5ca03 Bug 1406475 - Use Svc.PrefBranch instead of Svc.Prefs in PlacesUIUtils module. r=sync-reviewers,skhamis 
Depends on D180806

Differential Revision: https://phabricator.services.mozilla.com/D180807
 2023-06-14 23:15:36 +00:00
Kershaw Chang
86ab7691ee Bug 1543990 - Simplify nsISpeculativeConnect API, r=necko-reviewers,geckoview-reviewers,search-reviewers,valentin,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D179066
 2023-06-01 09:46:12 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Marco Bonardo
fe84c45462 Bug 1818461 - Remove the synchronous PlacesUtils.getChildCountForFolder().r=daisuke,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D175532
 2023-05-19 12:17:17 +00:00
Jonathan Sudiaman
9fd065c778 Bug 1820979 - Remove instant apply bookmarks panels code r=mak 
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
 2023-05-09 21:03:19 +00:00
Eemeli Aro
2b4fe0fd44 Bug 1830042 - Migrate places prompt strings to Fluent. r=mak,fluent-reviewers,flod 
As the remaining places.properties strings are used only for
errors and other dialogs from contexts that require sync localization,
it's better to put them in their own new file placesPrompts.ftl.

Differential Revision: https://phabricator.services.mozilla.com/D176646
 2023-05-02 18:34:42 +00:00
Eemeli Aro
db51c0f57f Bug 1830042 - Migrate detailsPane.noItems and detailsPane.itemsCountLabel strings to Fluent. r=mak,fluent-reviewers,flod 
This also allows dropping the PlacesUIUtils getFormattedString() and getPluralString() functions as unused

Depends on D176643

Differential Revision: https://phabricator.services.mozilla.com/D176644
 2023-05-02 18:34:41 +00:00