corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
882,799 Commits 1 Branch 0 Tags
a712bf384008e5f845bdc0b30d2f261e83dfb51a
Commit Graph

145 Commits

Author SHA1 Message Date
Sam Foster
a712bf3840 Bug 1921836 - Consolidate the restoreSidebar implementations, and ensure the sidebar launcher gets un-hidden when a sidebar is shown. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227420
 2024-11-05 23:34:25 +00:00
Stanca Serban
7bb12fdb44 Backed out changeset 1768e3e28918 (bug 1921836) for causing mochitests failures in browser_toolbar_sidebar_button.js. 2024-11-04 23:37:28 +02:00
Sam Foster
149a4a2aa9 Bug 1921836 - Consolidate the restoreSidebar implementations, and ensure the sidebar launcher gets un-hidden when a sidebar is shown. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227420
 2024-11-04 18:54:59 +00:00
Jonathan Sudiaman
8f6d47875d Bug 1927499 - Sidebar is showing in extensions popup when closing multiple tabs (and potentially in other popups) r=sidebar-reviewers,nsharpley 
Checks to make sure that the backup state isn't being loaded in a popup window. Adds a test for the scenario which causes this bug.

Differential Revision: https://phabricator.services.mozilla.com/D227119
 2024-10-29 19:45:44 +00:00
Tamas Szentpeteri
7aa7c6235f Backed out changeset 08df39c35f9d (bug 1905027) as requested by Mardak for causing 1927304. CLOSED TREE 2024-10-27 18:38:15 +02:00
Ed Lee
0e72f5e021 Bug 1905027 - There should be a Keyboard shortcut for the AI chat sidebar r=sidebar-reviewers,sclements,fluent-reviewers,flod,ngrato 
Toggle chatbot with accel-shift-i enabling if necessary. Record event on using keyboard shortcut.

Differential Revision: https://phabricator.services.mozilla.com/D226205
 2024-10-25 14:33:50 +00:00
Jonathan Sudiaman
9e5735c395 Bug 1926647 - With new sidebar enabled, opening private windows always have the sidebar expanded. r=sidebar-reviewers,sclements 
- Ensure that we don't load the backup state if a private window was spawned from a non-private one.
- Ensure that undefined values (i.e. missing backup state properties) are not used to set UI state.
- Remove setup functions that "pushed" existing tests to pass, as these concealed a real issue.

Differential Revision: https://phabricator.services.mozilla.com/D226716
 2024-10-24 14:24:41 +00:00
Jonathan Sudiaman
a2e2548835 Bug 1923972 - Telemetry for icons on the sidebar r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D226681
 2024-10-23 22:25:58 +00:00
Norisz Fay
327e2a6efe Backed out changeset 298bca8a48dc (bug 1905027) for causing multiple dt failures 2024-10-23 23:47:43 +03:00
Ed Lee
3896deb1b4 Bug 1905027 - There should be a Keyboard shortcut for the AI chat sidebar r=sidebar-reviewers,sclements,fluent-reviewers,flod,ngrato 
Toggle chatbot with accel-shift-i enabling if necessary. Record event on using keyboard shortcut.

Differential Revision: https://phabricator.services.mozilla.com/D226205
 2024-10-23 17:42:19 +00:00
Sarah Clements
9135d8e91d Bug 1925469 - Update tools icons in the sidebar to correct svg r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226479
 2024-10-22 15:55:34 +00:00
Jonathan Sudiaman
b15a6918fd Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-21 14:52:00 +00:00
Norisz Fay
3e0a85be12 Backed out changeset 214c931a0501 (bug 1908019) for causing bc failure on browser_keyboard_tests.js 2024-10-19 02:25:01 +03:00
Jonathan Sudiaman
59eeb5c1d8 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-18 19:45:30 +00:00
Sandor Molnar
e3731da318 Backed out changeset 47f93788c763 (bug 1908019) for causing perma bc failures @ browser_sidebar_keys.js CLOSED TREE 2024-10-17 21:46:35 +03:00
Jonathan Sudiaman
80c7c66253 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-17 17:45:07 +00:00
Jonathan Sudiaman
1421dd26d7 Bug 1923946 - Update sidebar telemetry for resizing and panel toggling r=sidebar-reviewers,sclements 
- Simplifies the resize tracking logic so that it hooks the splitter, rather than the browser. This removes the need to debounce and solves the issue of reporting automatic resizes.
- Rounds resize event data to the nearest integer.
- Records hide events whenever current panel is switched.

Differential Revision: https://phabricator.services.mozilla.com/D225435
 2024-10-16 13:41:29 +00:00
Sandor Molnar
c15c0c8311 Backed out changeset a7a3ec0f3d35 (bug 1908019) for causing multiple failures. 2024-10-15 17:22:17 +03:00
Jonathan Sudiaman
8808ec1a11 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-15 13:14:26 +00:00
Emilio Cobos Álvarez
7fdc3f0b03 Bug 1923844 - Account for hidden elements during sidebar animation in 'Always Hide' mode r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D225275
 2024-10-11 16:58:23 +00:00
Jonathan Sudiaman
3f3415399b Bug 1922037 - Record Glean metrics upon sidebar initialization r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D224797
 2024-10-09 20:09:55 +00:00
Nikki Sharpley
19c469b319 Bug 1915007 - Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D224493
 2024-10-09 15:46:06 +00:00
Cosmin Sabou
5623f8ad8f Backed out changeset f7e1c167b99b (bug 1915007) for causing bc failures on browser_view_sidebar_menu. CLOSED TREE 2024-10-09 18:30:34 +03:00
Nikki Sharpley
92fbf7e3c4 Bug 1915007 - Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D224493
 2024-10-09 13:36:22 +00:00
Kelly Cochrane
a38bb565f9 Bug 1908989 - Add animations to sidebar launcher in 'Always hide' mode r=sidebar-reviewers,emilio,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D220485
 2024-10-08 16:49:41 +00:00
Gijs Kruitbosch
e68340d490 Bug 1923326 - fix toolbarbutton access on startup when sidebar button isn't in the DOM yet, r=sidebar-reviewers,jsudiaman,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D224930
 2024-10-08 13:43:41 +00:00
Sam Foster
4c7602730b Bug 1914359 - Ensure new sidebar launcher shows when toggling the pref while a legacy sidebar is open. r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D224406
 2024-10-03 20:22:16 +00:00
Nikki Sharpley
b9c3ba706c Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-10-03 14:20:55 +00:00
Sandor Molnar
fbc2bb1bd2 Backed out changeset 6ad99c7c787d (bug 1914452) for causing bc sider bar related failures. CLOSED TREE 2024-10-02 21:25:44 +03:00
Nikki Sharpley
20a153c56b Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-10-02 16:52:46 +00:00
Jonathan Sudiaman
40b2800c49 Bug 1921539 - Sidebar button has no label when moved to the overflow menu r=sidebar-reviewers,fluent-reviewers,Gijs,sclements 
Fluent messages were missing `label` attribute. Use the existing one from customizableWidgets.properties.

Differential Revision: https://phabricator.services.mozilla.com/D224167
 2024-10-01 14:30:04 +00:00
Iulian Moraru
7f4f522517 Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00
Iulian Moraru
d2bc47834b Backed out changeset 1b56a9e3db55 (bug 1921562) for causing conflicts when trying to backout Bug 1914452. 2024-09-28 02:35:55 +03:00
Nikki Sharpley
28adb5f06a Bug 1921562 - Update and animate sidebar toolbar button states r=sidebar-reviewers,desktop-theme-reviewers,sfoster 
- follow up to correct patch for Bug 1914452 and add animations

Differential Revision: https://phabricator.services.mozilla.com/D224025
 2024-09-27 22:16:32 +00:00
Nikki Sharpley
8536a92e8d Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,sfoster,jsudiaman 
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button

Differential Revision: https://phabricator.services.mozilla.com/D223406
 2024-09-27 20:33:59 +00:00
Jonathan Sudiaman
03df9fb463 Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223314
 2024-09-25 23:30:38 +00:00
Sandor Molnar
7599f7c3a6 Backed out changeset ef1b42c36db7 (bug 1902056) for causing perma bc failures @ browser_toolbarKeyNav.js CLOSED TREE 2024-09-25 14:07:40 +03:00
Fred Chasen
a31102ffc2 Bug 1919166 - Prevent registering review checker sidebar panel for private windows. r=shopping-reviewers,sidebar-reviewers,kpatenio,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D222380
 2024-09-24 22:00:18 +00:00
Jonathan Sudiaman
375579d22d Bug 1902056 - Update strings for Sidebar toolbarbutton, close button and Customize Sidebar visibility settings r=sidebar-reviewers,fluent-reviewers,sclements,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D223314
 2024-09-24 20:00:26 +00:00
Kelly Cochrane
8cacd1c229 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-20 11:40:04 +00:00
Fred Chasen
89e6d0b8cb Bug 1916017 - Add Review Checker as a sidebar tool. r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,sclements,kpatenio 
- Registers the a new review checker sidebar using `registerPrefSidebar` that will display if  `browser.shopping.experience2023.integratedSidebar` is enabled.
- Hides any open review checker sidebars if the pref changes.
- Adds `reviewchecker` to the sidebar revamp tools pref.

Note: this only adds the sidebar tool, it will not load anything as the actors aren't setup yet.

Differential Revision: https://phabricator.services.mozilla.com/D221362
 2024-09-19 17:07:29 +00:00
Butkovits Atila
5a9a789f82 Backed out changeset fb2f7f9f6def (bug 1906888) for causing failures at browser_newtabButton.js. CLOSED TREE 2024-09-19 22:04:46 +03:00
Kelly Cochrane
a83714bc93 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-19 15:54:02 +00:00
Emilio Cobos Álvarez
de32a21400 Bug 1919041 - Handle interrupting sidebar animation. r=sidebar-reviewers,kcochrane,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D222297
 2024-09-17 17:03:39 +00:00
Dão Gottwald
23da2b3201 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-17 08:21:24 +00:00
Noemi Erli
353976cead Backed out 2 changesets (bug 1918676, bug 1918638) for causing browser chrome failures 
Backed out changeset c36ab1469893 (bug 1918638)
Backed out changeset f973faab6674 (bug 1918676)
 2024-09-17 02:34:41 +03:00
Dão Gottwald
2b53d56022 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-16 19:53:42 +00:00
Jonathan Sudiaman
15ad15eecf Bug 1898250 - Add telemetry to sidebar r=sidebar-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D220720
 2024-09-16 15:42:48 +00:00
Emilio Cobos Álvarez
2b868a8902 Bug 1918765 - Use ease-in-out easing for sidebar animation. r=sidebar-reviewers,kcochrane 
Restores the easing from before the new animation work.

Differential Revision: https://phabricator.services.mozilla.com/D222185
 2024-09-14 23:13:39 +00:00
Kelly Cochrane
16d633fe66 Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219495
 2024-09-13 17:51:03 +00:00