corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
882,799 Commits 1 Branch 0 Tags
a712bf384008e5f845bdc0b30d2f261e83dfb51a
Commit Graph

364 Commits

Author SHA1 Message Date
Sam Foster
a712bf3840 Bug 1921836 - Consolidate the restoreSidebar implementations, and ensure the sidebar launcher gets un-hidden when a sidebar is shown. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227420
 2024-11-05 23:34:25 +00:00
Kelly Cochrane
23b06d590b Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-11-05 14:39:47 +00:00
Stanca Serban
005c9bd515 Backed out changeset 3a50257f49c6 (bug 1902667) for causing mochitests fai;ures in browser_glean_sidebar.js/ CLOSED TREE 2024-11-05 03:33:45 +02:00
Kelly Cochrane
15189eebf1 Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-11-04 21:31:17 +00:00
Stanca Serban
7bb12fdb44 Backed out changeset 1768e3e28918 (bug 1921836) for causing mochitests failures in browser_toolbar_sidebar_button.js. 2024-11-04 23:37:28 +02:00
Sam Foster
149a4a2aa9 Bug 1921836 - Consolidate the restoreSidebar implementations, and ensure the sidebar launcher gets un-hidden when a sidebar is shown. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227420
 2024-11-04 18:54:59 +00:00
Stanca Serban
fbc301289e Backed out changeset 97f44f6b0d88 (bug 1902667) for causing mochitests failures. 2024-10-30 20:59:54 +02:00
Sarah Clements
7d2061ccba Bug 1923753 - Update empty and error state assets for sidebar and firefox view r=sidebar-reviewers,fxview-reviewers,kcochrane,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226906
 2024-10-30 18:27:18 +00:00
Kelly Cochrane
e0e4fc4145 Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-10-30 17:56:14 +00:00
Mark Striemer
0a64dafac4 Bug 1927428 - Handle larger system fonts in expanded vertical tabs r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D227130
 2024-10-30 15:21:57 +00:00
Jonathan Sudiaman
8f6d47875d Bug 1927499 - Sidebar is showing in extensions popup when closing multiple tabs (and potentially in other popups) r=sidebar-reviewers,nsharpley 
Checks to make sure that the backup state isn't being loaded in a popup window. Adds a test for the scenario which causes this bug.

Differential Revision: https://phabricator.services.mozilla.com/D227119
 2024-10-29 19:45:44 +00:00
Kelly Cochrane
fc97d3f90a Bug 1925451 - Fix for vertical tabs not always being visible in new windows r=sidebar-reviewers,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227089
 2024-10-29 14:34:39 +00:00
Joel Maher
8416ba3c7c Bug 1922725 - Disable browser_vertical_tabs_stacking_context.js on linux/a11y-checks for high failure rate. r=aryx,sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D227053
 2024-10-29 11:39:02 +00:00
Tamas Szentpeteri
7aa7c6235f Backed out changeset 08df39c35f9d (bug 1905027) as requested by Mardak for causing 1927304. CLOSED TREE 2024-10-27 18:38:15 +02:00
Ed Lee
0e72f5e021 Bug 1905027 - There should be a Keyboard shortcut for the AI chat sidebar r=sidebar-reviewers,sclements,fluent-reviewers,flod,ngrato 
Toggle chatbot with accel-shift-i enabling if necessary. Record event on using keyboard shortcut.

Differential Revision: https://phabricator.services.mozilla.com/D226205
 2024-10-25 14:33:50 +00:00
Jonathan Sudiaman
9e5735c395 Bug 1926647 - With new sidebar enabled, opening private windows always have the sidebar expanded. r=sidebar-reviewers,sclements 
- Ensure that we don't load the backup state if a private window was spawned from a non-private one.
- Ensure that undefined values (i.e. missing backup state properties) are not used to set UI state.
- Remove setup functions that "pushed" existing tests to pass, as these concealed a real issue.

Differential Revision: https://phabricator.services.mozilla.com/D226716
 2024-10-24 14:24:41 +00:00
Jonathan Sudiaman
a2e2548835 Bug 1923972 - Telemetry for icons on the sidebar r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D226681
 2024-10-23 22:25:58 +00:00
Norisz Fay
327e2a6efe Backed out changeset 298bca8a48dc (bug 1905027) for causing multiple dt failures 2024-10-23 23:47:43 +03:00
Ed Lee
3896deb1b4 Bug 1905027 - There should be a Keyboard shortcut for the AI chat sidebar r=sidebar-reviewers,sclements,fluent-reviewers,flod,ngrato 
Toggle chatbot with accel-shift-i enabling if necessary. Record event on using keyboard shortcut.

Differential Revision: https://phabricator.services.mozilla.com/D226205
 2024-10-23 17:42:19 +00:00
Stuart Colville
6bd05b9603 Bug 1926119: Remove 2nd empty-state string for don't remember history. r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D226453
 2024-10-23 10:31:29 +00:00
Sarah Clements
9135d8e91d Bug 1925469 - Update tools icons in the sidebar to correct svg r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226479
 2024-10-22 15:55:34 +00:00
Kelly Cochrane
8f5fec9e89 Bug 1924126 - Ensure context menu can be opened via keyboard for sidebar tab items r=sidebar-reviewers,Gijs,sclements,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D225722
 2024-10-21 20:57:34 +00:00
Sandor Molnar
1e666694aa Backed out changeset 7e2dae749d42 (bug 1924126) for causing bc failures @ browser_sidebar_context_menu CLOSED TREE 2024-10-21 20:59:58 +03:00
Kelly Cochrane
60bcf55097 Bug 1924126 - Ensure context menu can be opened via keyboard for sidebar tab items r=sidebar-reviewers,Gijs,sclements,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D225722
 2024-10-21 16:13:46 +00:00
Jonathan Sudiaman
b15a6918fd Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-21 14:52:00 +00:00
Sarah Clements
0980f19cc6 Bug 1924107 - Add missing title and aria attributes to menu buttons in sidebar r=Mardak,sidebar-reviewers,fluent-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226010
 2024-10-21 13:20:58 +00:00
Norisz Fay
3e0a85be12 Backed out changeset 214c931a0501 (bug 1908019) for causing bc failure on browser_keyboard_tests.js 2024-10-19 02:25:01 +03:00
Jonathan Sudiaman
59eeb5c1d8 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-18 19:45:30 +00:00
Mark Striemer
211e1d0562 Bug 1922036 - Make vertical tabs and tools 32px by default r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,nsharpley,sclements,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D224362
 2024-10-18 16:46:26 +00:00
Norisz Fay
abd7b89b34 Backed out changeset cfc9c8d13810 (bug 1924107) for causing sidebar related failures 2024-10-18 22:13:55 +03:00
Sarah Clements
c8749c7247 Bug 1924107 - Add missing title and aria attributes to menu buttons in sidebar r=Mardak,sidebar-reviewers,fluent-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D226010
 2024-10-18 13:41:49 +00:00
Tom Schuster
0cf607ced1 Bug 1923041 - Listen for click events on the sidebar to handle new-tab middle clicks. r=Gijs,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D224765
 2024-10-18 09:28:09 +00:00
Sandor Molnar
e3731da318 Backed out changeset 47f93788c763 (bug 1908019) for causing perma bc failures @ browser_sidebar_keys.js CLOSED TREE 2024-10-17 21:46:35 +03:00
Jonathan Sudiaman
80c7c66253 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-17 17:45:07 +00:00
Stuart Colville
7f22a561de Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D225550
 2024-10-17 17:43:08 +00:00
Cosmin Sabou
162894add1 Backed out changeset 290a68970e02 (bug 1911749) for causing bc failures on browser_history_firefoxview. 2024-10-17 00:50:02 +03:00
Florian Quèze
bcc4b12884 Bug 1923028 - Migrate scalars to use Glean APIs in browser/components/places/, r=chutten,sidebar-reviewers,fxview-reviewers,Standard8,jsudiaman. 
Differential Revision: https://phabricator.services.mozilla.com/D225370
 2024-10-16 20:46:08 +00:00
Stuart Colville
56b5279a66 Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D225550
 2024-10-16 18:46:35 +00:00
Jonathan Sudiaman
1421dd26d7 Bug 1923946 - Update sidebar telemetry for resizing and panel toggling r=sidebar-reviewers,sclements 
- Simplifies the resize tracking logic so that it hooks the splitter, rather than the browser. This removes the need to debounce and solves the issue of reporting automatic resizes.
- Rounds resize event data to the nearest integer.
- Records hide events whenever current panel is switched.

Differential Revision: https://phabricator.services.mozilla.com/D225435
 2024-10-16 13:41:29 +00:00
Kelly Cochrane
031773ad96 Bug 1899599 - Change orientation of tools and extensions in expanded sidebar when more than 5 tools/extensions r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,hjones,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D224983
 2024-10-15 19:56:52 +00:00
Sandor Molnar
c15c0c8311 Backed out changeset a7a3ec0f3d35 (bug 1908019) for causing multiple failures. 2024-10-15 17:22:17 +03:00
Jonathan Sudiaman
8808ec1a11 Bug 1908019 - Store sidebar UI state in a pref that acts as a fallback r=sidebar-reviewers,sessionstore-reviewers,sfoster 
Refactor sidebar state persistence logic outside of SessionStore and into SidebarController and SidebarManager. Expose an API for session store to update state. If session store data is not available, use the backup state instead. Works for both "Never remember history" and "Use custom settings for history".

Differential Revision: https://phabricator.services.mozilla.com/D225220
 2024-10-15 13:14:26 +00:00
Emilio Cobos Álvarez
7fdc3f0b03 Bug 1923844 - Account for hidden elements during sidebar animation in 'Always Hide' mode r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D225275
 2024-10-11 16:58:23 +00:00
Ed Lee
acaddfd634 Bug 1923900 - Record sidebar-customize for toggling chatbot and bookmarks r=jsudiaman,sidebar-reviewers 
Add events for chatbot and bookmarks. Update tests to support default unchecked bookmarks.

Differential Revision: https://phabricator.services.mozilla.com/D225304
 2024-10-11 15:37:32 +00:00
Nikki Sharpley
4059d1dd9f Bug 1922264 - Show container menu on right click of vertical tabs new tab button r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D225087
 2024-10-10 13:10:44 +00:00
Jonathan Sudiaman
3f3415399b Bug 1922037 - Record Glean metrics upon sidebar initialization r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D224797
 2024-10-09 20:09:55 +00:00
Nikki Sharpley
19c469b319 Bug 1915007 - Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D224493
 2024-10-09 15:46:06 +00:00
Cosmin Sabou
5623f8ad8f Backed out changeset f7e1c167b99b (bug 1915007) for causing bc failures on browser_view_sidebar_menu. CLOSED TREE 2024-10-09 18:30:34 +03:00
Nikki Sharpley
92fbf7e3c4 Bug 1915007 - Avoid duplicate View>Sidebar menu items on sidebar pref flip r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D224493
 2024-10-09 13:36:22 +00:00
Kelly Cochrane
a38bb565f9 Bug 1908989 - Add animations to sidebar launcher in 'Always hide' mode r=sidebar-reviewers,emilio,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D220485
 2024-10-08 16:49:41 +00:00