Commit Graph

80 Commits

Author SHA1 Message Date
Hiroyuki Ikezoe
17f5b145da Bug 1704065 - Don't start navigation swipe gestures where there is no navigation history. r=spohl
Apparently we should check each command specified by
browser.gesture.swipe.left or browser.gesture.swipe.right, it will be fixed
in bug 1707118.

Differential Revision: https://phabricator.services.mozilla.com/D113635
2021-04-30 09:08:08 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-20 17:44:16 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
7f0c1757af Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-14 21:23:27 +00:00
Dão Gottwald
e0c3f7fad4 Bug 1690849 - Remove obsolete comment. r=mstange DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D106035
2021-02-22 22:18:17 +00:00
Markus Stange
ad720567b1 Bug 1690849 - Only trigger back/forward swipes when the mouse is over the content area. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D105874
2021-02-22 17:42:51 +00:00
Mark Banner
8a9fc4165b Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
201069fdac Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
36cf48f89d Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
Kartikaya Gupta
e20dafe2b5 Bug 1636473 - Use the APZ machinery to dispatch magnifygesture events. r=dao,tnikkel
Unify two separate codepaths that do conceptually identical things. That is,
instead of having the widget code directly dispatch wheel and pinch gesture
events to Gecko, allow APZ to do it as part of it's handling of pinch inputs
when zooming is disabled.

The main difference is that the WidgetSimpleGestureEvent delta values come out
different, because they are based on the macOS event's magnification value,
rather than the (now deprecated) deltaZ value. This is actually better since it
makes the values consistent across platforms and allows removal of some ifdefs.

Differential Revision: https://phabricator.services.mozilla.com/D74640
2020-05-12 00:46:34 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Paolo Amadini
d668ea1231 Bug 1506125 - Fix gesture support broken by bug 1506125. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D11478
2018-11-09 14:44:58 +00:00
Paolo Amadini
3bd8feb52d Bug 1505791 - Separate the browser panel from the notification box. r=dao,bgrins
This clarifies the intention of each caller, and opens up the possibility of converting the notificationbox element to a class that creates the DOM nodes on demand.

Differential Revision: https://phabricator.services.mozilla.com/D10577
2018-11-08 15:31:37 +00:00
Brian Grinstead
c8b3483e82 Bug 1479538 - Rewrite non-test callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...);r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3275
2018-08-14 16:22:44 +00:00
Stephen A Pohl
238964876c Bug 860493: Add pref to disable history swipe animations. r=felipe 2018-05-16 23:09:45 -04:00
Stephen A Pohl
da7a15b56e Bug 860493: Add arrow indicators for history swipes on macOS. r=felipe,bram 2018-05-16 23:09:39 -04:00
Florian Quèze
3f662053f3 Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Florian Quèze
a72f907c5f Bug 1381853 - lazy load browser-gestureSupport.js into the browser window, r=mconley. 2017-07-23 00:17:58 +02:00
Johann Hofmann
3fca548c18 Bug 1371219 - Add an inputSource attribute to XULCommandEvent. r=smaug
In the frontend we need to know if XUL buttons in the toolbar were
triggered by a touch event, so we're passing on the inputSource
in the command event.

MozReview-Commit-ID: DMvgZULk9hT
2017-07-20 17:45:56 +02:00
Mark Banner
d150a4fcd6 Bug 1342459 - Fix various no-undef issues in browser/base. r=mossop
MozReview-Commit-ID: CRYxu7copKb
2017-04-04 13:42:33 +01:00
Mark Banner
1b6f3efb6e Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR
2017-02-22 17:02:59 +00:00
Florian Quèze
c32c931bc9 Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws. 2017-01-30 08:10:22 +01:00
Florian Quèze
0a4ee94a29 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Jared Wein
9f9dbce16a Bug 1328802 - Enable the no-unsafe-finally rule for eslint and fix the four errors that are triggered by it by moving the control flow statement outside of the finally block. r=mossop
MozReview-Commit-ID: 7UFBBpvptdd
2017-01-05 00:38:24 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
dc3810c548 Bug 1314343: Turn on no-unreachable in eslint. r=standard8
Unreachable code can be a sign of a mistake so we should turn this rule on.

MozReview-Commit-ID: LQphsNL7HBX
2016-11-01 10:58:35 -07:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Sumit Tiwari
4edded08d9 Bug 1290698 - Replace Iterator() with Object.{values, entries}; r=mossop
MozReview-Commit-ID: DEoVeqEZWpd
2016-08-07 21:58:24 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
7c35c99d2d Bug 1292008 - Enable the no-empty rule for eslint. r=markh
MozReview-Commit-ID: EfM3YOUjClW
2016-08-04 00:55:07 -04:00
Andrea Marchesini
7643cdc4ef Bug 1281793 - Remove some non-used telemetry IDs - part 3 - random things, r=chutten 2016-06-28 19:30:15 +02:00
Carsten "Tomcat" Book
970b3affb6 Backed out changeset 3af9c0fa2ba6 (bug 1281793) 2016-06-28 17:04:50 +02:00
Andrea Marchesini
83727d8d75 Bug 1281793 - Remove some non-used telemetry IDs - part 3 - random things, r=chutten 2016-06-28 16:44:42 +02:00
Dave Townsend
141eaedde7 Bug 1245649: Enable no-nested-ternary. r=mconley 2016-02-03 21:17:16 -08:00
Felipe Gomes
cc4e635794 Bug 1229603 - Make most of browser/base lintable by removing non-standard syntax. r=Mossop 2015-12-02 17:51:26 -02:00
Felipe Gomes
ae9ca97935 Bug 1228655 - Remove ifdefs in browser-gesturesupport.js. r=Gijs 2015-12-01 20:06:09 -02:00
Felipe Gomes
e5ea10c3ed Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Neil Deakin
f46e52f201 Bug 1133569, remove cpow usage from back/forward gesture, r=felipe 2015-11-26 10:23:22 -05:00
Tooru Fujisawa
5c61999d79 Bug 1207490 - Part 1: Remove use of expression closure from browser/base/. r=dao 2015-09-21 00:29:37 +09:00