Commit Graph

4930 Commits

Author SHA1 Message Date
Marco Bonardo
a6761dedd6 Bug 1628906 - First search in a tab from location bar could trigger an "Invalid URL" error page. r=Gijs,nika,mattwoodrow
Before 1496578, URIFixup::keywordToURI used to do a synchronous IPC call to be
able to access search engines from the content process. Consumers of URIFixup
didn't care. Bug 1496578 moved the IPC messaging to the callers, in particular
nsDocShell, but assumed nsDocShellLoadState wasn't loading from content.
It looks like in some cases it does, so this adds another sync IPC call for
GetFixupURIInfo.
The total numer of sync IPCs should not change from before Bug 1496578, URIFIxup
was just doing it internally, while now it happens at the call point.
Note the long term plan would be for these docshell objects callers to just
handle URIs, while the UI code should do fixup.
Bug 1375244 tracks the removal of these sync IPC messages.

Differential Revision: https://phabricator.services.mozilla.com/D70607
2020-04-15 22:39:38 +00:00
Christoph Kerschbaumer
a923c367b1 Bug 1621987: Implement Sec-Fetch-User. r=baku,edgar,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69392
2020-04-16 08:04:26 +00:00
Dão Gottwald
1116310e7c Bug 1629953 - Use prefers-reduced-motion media query for the stop/reload button animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D70899
2020-04-15 08:48:08 +00:00
Mihai Alexandru Michis
cbf7619c3b Backed out changeset c522095c6db2 (bug 1629953) for causing failures in browser_aboutStopReload.js
CLOSED TREE
2020-04-15 01:57:31 +03:00
Dão Gottwald
ea92969068 Bug 1629953 - Use prefers-reduced-motion media query for the stop/reload button animation. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D70899
2020-04-14 17:33:13 +00:00
Dão Gottwald
708d5c1a50 Bug 1628731 - Reinstate shouldRemoveFocusedAttribute hack. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70852
2020-04-14 16:18:01 +00:00
Csoregi Natalia
a3c8408007 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)
2020-04-10 21:19:15 +03:00
pbz
336546dc8f Bug 1615588 - TabModalPrompt(Box): Added tab level system prompts. r=MattN
This patch updates the prompt code in browser.js and the tabprompts.jsm module
to support the two new prompt types: tab and content
- Updated TabModalPromptBox to support both prompt types
- Updated TabModalPrompt styles for tab prompt type

Differential Revision: https://phabricator.services.mozilla.com/D67134
2020-04-10 16:44:57 +00:00
William Durand
c283359ee5 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831
2020-04-08 14:18:53 +00:00
Dão Gottwald
6c448c34cd Bug 1627969 - Remove the megabar pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70023
2020-04-08 19:04:24 +00:00
Nika Layzell
13956309e2 Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058
2020-04-07 21:39:47 +00:00
Nika Layzell
4e2290e8e6 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053
2020-04-07 21:39:37 +00:00
Nika Layzell
63bd4e74fb Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046
2020-04-07 21:39:14 +00:00
Cosmin Sabou
357a0887a1 Backed out 24 changesets (bug 1616353) for fission assertion failures nsGlobalWindowOuter.cpp.
Backed out changeset 3a43210e4900 (bug 1616353)
Backed out changeset cb77e9149cf8 (bug 1616353)
Backed out changeset 3aacc7cfe33f (bug 1616353)
Backed out changeset c026b06063a5 (bug 1616353)
Backed out changeset 580e790c5d17 (bug 1616353)
Backed out changeset 6f09bc1c476d (bug 1616353)
Backed out changeset 6955906262c0 (bug 1616353)
Backed out changeset a7700472807a (bug 1616353)
Backed out changeset a4735096e01b (bug 1616353)
Backed out changeset bd1706c57d91 (bug 1616353)
Backed out changeset 363c13296fda (bug 1616353)
Backed out changeset e414df387524 (bug 1616353)
Backed out changeset 765d3364cca0 (bug 1616353)
Backed out changeset 8a13355b4ac4 (bug 1616353)
Backed out changeset ada17fb8fca7 (bug 1616353)
Backed out changeset 6b6b99af186d (bug 1616353)
Backed out changeset ea966e78b296 (bug 1616353)
Backed out changeset cb88e0bbb3b9 (bug 1616353)
Backed out changeset f89a89015114 (bug 1616353)
Backed out changeset ae6058552969 (bug 1616353)
Backed out changeset f42bb5b48c1b (bug 1616353)
Backed out changeset 1ab9d22c73bb (bug 1616353)
Backed out changeset 2692c2c1396b (bug 1616353)
Backed out changeset 11a279c8da08 (bug 1616353)
2020-04-06 20:03:02 +03:00
Nika Layzell
e235a0fdee Bug 1616353 - Part 8: Remove forceInitialBrowserNonRemote, r=Gijs
This method is no longer necessary, as frontend will always make the correct
decisions for the remoteness of the intial content browser by reading
openWindowInfo.

Differential Revision: https://phabricator.services.mozilla.com/D67058
2020-04-06 14:30:22 +00:00
Nika Layzell
1c99918951 Bug 1616353 - Part 7.4: Pass nsOpenWindowInfo through tabbrowser, r=Gijs
The interface changes which browser.js and tabbrowser.js are being updated for
are performed in earlier parts. This patch just covers the required changes to
frontend code to propagate this information down to the nsFrameLoader when it is
created.

Differential Revision: https://phabricator.services.mozilla.com/D67053
2020-04-06 14:30:07 +00:00
Nika Layzell
c9e96c7477 Bug 1616353 - Part 6.2: Remove setOriginAttributesBeforeLoading API, r=smaug
This API is no longer possible to implement, as it will always try to set the
OriginAttributes on a content BrowsingContext after it has been attached, and JS
can never observe a detached BrowsingContext.

Users of this API are instead changed to perform assertions that
originAttributes have already been set correctly.

Differential Revision: https://phabricator.services.mozilla.com/D67046
2020-04-06 14:29:50 +00:00
Mark Banner
b7230156ea Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D69235
2020-04-03 11:36:35 +00:00
Dorel Luca
7eec6ba613 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)
2020-04-02 18:39:32 +03:00
Mark Banner
ba85723ecd Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235
2020-04-02 14:31:45 +00:00
Zibi Braniecki
19ebcdc58b Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661
2020-04-01 18:44:03 +00:00
Dão Gottwald
bdf0d655b4 Bug 1626265 - Don't hide the status panel while a link's context menu is open. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69182
2020-04-01 11:06:31 +00:00
Narcis Beleuzu
5e4aeca080 Backed out changeset 16d82f57e0fb (bug 1602808) for bc failures on browser_privatebrowsing_windowtitle.js . CLOSED TREE 2020-04-01 10:24:08 +03:00
Zibi Braniecki
5914374212 Bug 1602808 - Revert Window Title to use DTD. r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68661
2020-03-31 23:52:03 +00:00
Gijs Kruitbosch
c354b8e5ab Bug 1616639 - revert url bar and search bar width when removing the search bar from the navbar, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D64140
2020-03-31 17:25:50 +00:00
Harry Twyford
7d5be140b4 Bug 1623978 - Disable Search Tips on secondary location changes. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D68067
2020-03-31 13:56:34 +00:00
prathiksha
72d6d2326f Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D65554
2020-03-26 19:04:59 +00:00
Stefan Hindli
5488356992 Backed out changeset 6b86d0dfff95 (bug 1303775) for causing perma bc failures in browser/base/content/test/captivePortal/browser_CaptivePortalWatcher.js CLOSED TREE 2020-03-26 15:52:02 +02:00
prathiksha
135bf7dcda Bug 1303775 - Fix race conditions prevalent with closing captive portal tabs that re-direct to the canonicalURL after successful login/abort. r=johannh,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D65554
2020-03-26 12:43:11 +00:00
Dão Gottwald
c262e0f524 Bug 1623673 - Make gKeywordURIFixup a good browser.js citizen. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D67508
2020-03-20 07:45:26 +00:00
Andrea Marchesini
0fb9104888 Bug 1531289 - target=_blank with a download should close the download tab, r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66454
2020-03-19 13:03:14 +00:00
meenohara
917104903d Bug 1567827 Get rid of security.insecure_password.ui.enabled r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D67178
2020-03-19 11:28:36 +00:00
Masatoshi Kimura
7355e130aa Bug 1623222 - Remove the charset parameter from nsITextToSubURI::UnEscapeURIForUI. r=hsivonen
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
  URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
  document charset.
* Finder.jsm: This caused bug 1623222.

Differential Revision: https://phabricator.services.mozilla.com/D67386
2020-03-19 10:45:28 +00:00
Sam Foster
570b1dcfad Bug 1618696 - Prevent overlapping show/hide of the ConfirmationHint. r=MattN
* Track and clear a timerID for the ConfirmationHint to avoid callbacks from one show() call interfering with a subsequent call.
* Tighten up waiting for and verifying the confirmation hint in browser_doorhanger_generated_password.js
* Pass in the correct browser when retrieving the anchorNode for the confirmation hint.

Differential Revision: https://phabricator.services.mozilla.com/D67398
2020-03-18 23:05:57 +00:00
Sydney
88defc24cd Bug 1587496 - Update nsIBrowserHandler users in browser.js to use new BrowserHandler lazy getter. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D67027
2020-03-18 19:31:54 +00:00
Coroiu Cristina
adde840cf3 Backed out changeset 0453b0a0c49d (bug 1531289) for browser-chrome failures at uriloader/exthandler/tests/mochitest/browser_auto_close_window.js on a CLOSED TREE 2020-03-18 15:55:43 +02:00
Andrea Marchesini
f31ee62e31 Bug 1531289 - target=_blank with a download should close the download tab, r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66454
2020-03-18 12:08:24 +00:00
Dão Gottwald
cac33ac967 Bug 1610479 - Remove UrlbarInput's dependency on focusAndSelectUrlBar. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D66954
2020-03-16 15:53:32 +00:00
Marco Bonardo
85b4838b84 Bug 1621328 - Move CreateExposableURI into nsIOService. r=Gijs,mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66269
2020-03-13 12:44:36 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Dão Gottwald
ef321fc334 Bug 1539838 - Move SetPageProxyState into UrlbarInput. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D66288
2020-03-12 18:15:58 +00:00
Theo Ottah
8969c8e51c Bug 1612650 - Shift clicking navigation buttons in private browser opens content in private window r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D65886
2020-03-13 00:07:05 +00:00
Mike Conley
527cf6e02a Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 03:10:29 +00:00
Dorel Luca
e6edb45133 Backed out changeset 9160f18bc24e (bug 1619992) for XPCshell failures in newtab/test/xpcshell/test_AboutNewTab.js 2020-03-11 04:20:31 +02:00
Mike Conley
f431383314 Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 01:25:31 +00:00
Gijs Kruitbosch
1ff08b659c Bug 1620613 - improve checks for the webrender + fission infobar, r=Yoric
Differential Revision: https://phabricator.services.mozilla.com/D66123
2020-03-10 09:08:09 +00:00
Dão Gottwald
30249a55f7 Bug 1620626 - Move checkEmptyPageOrigin to BrowserUtils. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D65861
2020-03-09 15:52:06 +00:00
Dão Gottwald
8ecbcda93d Bug 1610475 - Move URLBarSetURI to UrlbarInput. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D65535
2020-03-06 16:27:16 +00:00
Dale Harvey
fdb5f2a723 Bug 1615901 - Dont send Origin header with context menu searches. r=ckerschb,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63630
2020-03-06 14:18:34 +00:00
Dão Gottwald
e448aa56d9 Bug 1610533 - Move losslessDecodeURI to UrlbarInput. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D65092
2020-03-04 14:14:25 +00:00