Commit Graph

8 Commits

Author SHA1 Message Date
David Major
a660713d2b Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron
There's an antipattern where nsLiteralString is used as an unnecessary intermediary in converting from CharT* to CharT*,
e.g. CallAFunctionThatTakesACharPointer(NS_LITERAL_CSTRING("foo").get());
or
NS_NAMED_LITERAL_STRING(foo, "abc");
CallAFunctionThatTakesACharPointer(foo.get());

This patch rewrites the callsites that can be trivially changed to use char*/char16_t*.

I'd somewhat like to remove nsTLiteralString::get() altogether, but in code that's less straightforward than these examples, get() is useful enough to keep.

MozReview-Commit-ID: Kh1rUziVllo
2017-03-14 15:26:27 +13:00
Eric Rahm
3c46c51343 Bug 1313488 - Part 0: Adding missing includes. r=froydnj
Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
2016-11-10 12:47:21 -08:00
Sebastian Hengst
d006f80540 Backed out changeset d769f46c4248 (bug 1313488) for leak in Linux x64 debug. r=backout 2016-11-09 21:10:47 +01:00
Eric Rahm
fe610caba2 Bug 1313488 - Part 0: Adding missing includes. r=froydnj
Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
2016-11-09 10:24:56 -08:00
Phil Ringnalda
8e58245a70 Backed out 5 changesets (bug 1313489, bug 1313488, bug 1313484) in hopes that OS X will go back to building without complaining about missing symbols in nsIFileEnumerator
Backed out changeset 276b093c968f (bug 1313489)
Backed out changeset 5a062f72097d (bug 1313489)
Backed out changeset dbd9b56b50e7 (bug 1313488)
Backed out changeset 22e770047827 (bug 1313488)
Backed out changeset 6a7831fbca69 (bug 1313484)

MozReview-Commit-ID: KP9gk9o11co
2016-11-07 19:12:13 -08:00
Eric Rahm
11db782ae1 Bug 1313488 - Part 0: Adding missing includes. r=froydnj
Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
2016-11-07 14:27:03 -08:00
Eric Rahm
4153266d34 Bug 1313479 - Part 2: Expand and split out TestObserverService tests. r=froydnj
This splits out enumertion testing, adds testing of weak references, and other
basic tests for add and remove functions.

MozReview-Commit-ID: CLEafPJhe3z
2016-11-04 16:24:00 -07:00
Eric Rahm
09efb12818 Bug 1313479 - Part 1: Convert TestObserverService to a gtest. r=froydnj
This is a straightforward conversion to a gtest. The test itself is updated
to use RefPtr/nsCOMPtr where appropriate to avoid memory leaks.

MozReview-Commit-ID: JyHF3iTaoOg
2016-11-04 16:23:58 -07:00