Commit Graph

359 Commits

Author SHA1 Message Date
Sammy Khamis
b50be7dada Bug 1959830 - Update new Turn on sync element to be default r=markh,LougeniaBailey,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D245331
2025-04-14 21:12:25 +00:00
Sammy Khamis
e27d030a6a Bug 1956342 - Add experiment for adding text to fxa avatar when signed out r=sync-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,markh,dao
Differential Revision: https://phabricator.services.mozilla.com/D243226
2025-04-14 01:25:11 +00:00
Cristina Horotan
fb90c8482a Backed out changeset bc9a249bc233 (bug 1956342) for causing bc failures at browser_addAdjacentNewTab.js CLOSED TREE 2025-04-12 02:39:15 +03:00
Sammy Khamis
fc6d8e2c4c Bug 1956342 - Add experiment for adding text to fxa avatar when signed out r=sync-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,markh,dao
Differential Revision: https://phabricator.services.mozilla.com/D243226
2025-04-11 20:04:19 +00:00
Sammy Khamis
3f29158828 Bug 1955083 - connect another device button should be shown when sync is enabled r=markh
Differential Revision: https://phabricator.services.mozilla.com/D242207
2025-03-19 21:41:30 +00:00
Sammy Khamis
02a122dac3 Bug 1953031: Hide My Services panel when disconnecting from FxA r=markh
Differential Revision: https://phabricator.services.mozilla.com/D240959
2025-03-11 18:35:42 +00:00
Sammy Khamis
2104e0392e Bug 1951719: Explicitly Unhide turn on sync only when sync is disabled r=sync-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D240711
2025-03-10 23:10:19 +00:00
Niklas Baumgardner
b5436e72e5 Bug 1935600 - Move profiles fxa menu button when signed in. r=profiles-reviewers,markh,jhirsch
Differential Revision: https://phabricator.services.mozilla.com/D237612
2025-02-12 17:31:29 +00:00
Sammy Khamis
e656b62523 Bug 1946609 - Record exposure event for new treatment of sync being disabled r=LougeniaBailey
Differential Revision: https://phabricator.services.mozilla.com/D237148
2025-02-07 21:09:45 +00:00
Sammy Khamis
8fab5603f0 Bug 1944236 - Fix avatar flickering when syncing r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D235889
2025-01-29 23:14:01 +00:00
Sammy Khamis
ac45be94e6 Bug 1938344: Fix choose what to sync not showing on subsequent navigations r=markh,settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D233195
2025-01-13 22:37:03 +00:00
Mike Conley
4647ce1c30 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-20 16:07:56 +00:00
Mark Hammond
3cd024d086 Bug 1938364 - Ensure fxa interaction metrics include whether sync is currently configured or not. r=LougeniaBailey,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232643
2024-12-19 18:46:15 +00:00
Goloman Adrian
1683c8c8b5 Backed out 4 changesets (bug 1937234) for causing newtab failures @asrouter. CLOSED TREE
Backed out changeset 3fd6a002577a (bug 1937234)
Backed out changeset 6ab7c2107849 (bug 1937234)
Backed out changeset baa639909c0e (bug 1937234)
Backed out changeset 77e5bd035f08 (bug 1937234)
2024-12-19 19:46:38 +02:00
Mike Conley
f391c2f6b4 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-19 16:43:39 +00:00
Sammy Khamis
19031ffbca Bug 1935503: Add indicator when sync is disabled for enrolled users r=sync-reviewers,desktop-theme-reviewers,markh,dao
Differential Revision: https://phabricator.services.mozilla.com/D231302
2024-12-19 01:44:36 +00:00
Stanca Serban
b21fd0feda Backed out 4 changesets (bug 1937234) for causing newtab failures.
Backed out changeset 9c4ec733448e (bug 1937234)
Backed out changeset 05d3d5a45230 (bug 1937234)
Backed out changeset 27877e1ab900 (bug 1937234)
Backed out changeset d56b2c3bfd0e (bug 1937234)
2024-12-19 03:55:28 +02:00
Mike Conley
2fad4563b7 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-18 19:47:07 +00:00
Alexandru Marc
650c4988fe Backed out changeset 81bf277604ec (bug 1935503) for causing bc failures @ browser_sync.js CLOSED TREE 2024-12-18 10:03:19 +02:00
Sammy Khamis
9031cb7054 Bug 1935503: Add indicator when sync is disabled for enrolled users r=sync-reviewers,desktop-theme-reviewers,markh,dao
Differential Revision: https://phabricator.services.mozilla.com/D231302
2024-12-18 02:31:53 +00:00
Sammy Khamis
ab66cb966a Bug 1932996: Add 'My services' to the app menu panel r=sync-reviewers,fluent-reviewers,desktop-theme-reviewers,dao,markh
Differential Revision: https://phabricator.services.mozilla.com/D230010
2024-12-17 23:09:53 +00:00
Sammy Khamis
075b628967 Bug 1925377: Refactor updateFxAPanel r=sync-reviewers,markh
Differential Revision: https://phabricator.services.mozilla.com/D226434
2024-11-12 23:30:57 +00:00
Sammy Khamis
b3423d6a97 Bug 1925377: Update treatment of 'Turn on Syncing...' option r=sync-reviewers,fluent-reviewers,desktop-theme-reviewers,markh,hjones
Differential Revision: https://phabricator.services.mozilla.com/D226202
2024-10-28 23:10:47 +00:00
Mike Conley
a52a1d1d9f Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
2024-10-19 03:25:51 +03:00
Mike Conley
53a3f31513 Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-18 20:43:29 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Florian Quèze
c5a791b369 Bug 1918702 - Migrate telemetry events to use Glean APIs for sync, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D222807
2024-09-25 02:46:36 +00:00
Sammy Khamis
b0ede54e8f Bug 1908282: Add tooltip to close tab button r=markh,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D216886
2024-07-19 20:43:17 +00:00
Sammy Khamis
3bdb7ad62c Bug 1908686: FxA sign in entrypoint should match clients r=markh
Differential Revision: https://phabricator.services.mozilla.com/D217048
2024-07-19 18:43:03 +00:00
Sammy Khamis
5cd803a66b Bug 1905172: UI tweaks to closing tabs remotely r=sync-reviewers,desktop-theme-reviewers,markh,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D216079
2024-07-12 00:33:20 +00:00
Sammy Khamis
fc20d583be Bug 1905172: UI tweaks to closing tabs remotely r=markh,desktop-theme-reviewers,jules,dao
Differential Revision: https://phabricator.services.mozilla.com/D215173
2024-07-02 20:53:44 +00:00
Sammy Khamis
596a425412 Bug 1901868: Remove last remotely closed tab fom list r=markh,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D213357
2024-06-17 19:02:41 +00:00
Sammy Khamis
a05f284d32 Bug 1892340: Hide pending remote tab closures r=lina,markh,desktop-theme-reviewers,sync-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D208419
2024-06-10 19:57:25 +00:00
Sammy Khamis
5e669d4bf1 Bug 1900131: Fix FxA toolbar telemetry bug r=markh
Differential Revision: https://phabricator.services.mozilla.com/D212332
2024-06-06 19:49:05 +00:00
Mark Hammond
236a4184ef Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.

Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-23 19:54:46 +00:00
Aron Cseh
217809cd6b Backed out changeset 4db006d78935 (bug 1895521) for causing mochitest failures on browser_synced_tabs_menu.js CLOSED TREE 2024-05-21 23:25:04 +03:00
Mark Hammond
0100e17f73 Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.

Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-21 19:20:40 +00:00
Tarik Eshaq
8ff840ac17 Bug 1887739: Removes force_auth fxa path and uses connect path instead.r=markh,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208783
2024-05-17 18:00:06 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
Mark Hammond
cf93ae331c Bug 1893657 - Inactive tabs from other devices show in a panel subview. r=skhamis,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D208750
2024-05-02 19:08:20 +00:00
Sammy Khamis
8b5458495a Bug 1885645: Update FxA sign in menu r=markh,teshaq,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208249
2024-05-02 14:22:16 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Gijs Kruitbosch
18d848d0c7 Bug 1890718 - move send tab event handlers to not use inline event attributes, r=sync-reviewers,lina
This also reorganizes some duplicated handlers a little and fixes an eslint warning for lexical declarations inside case blocks.

Differential Revision: https://phabricator.services.mozilla.com/D207878
2024-04-22 13:07:24 +00:00
Gijs Kruitbosch
dc38a85d9b Bug 1890718 - move mouseover sync panel handlers away from inline handlers, r=sync-reviewers,lina
Differential Revision: https://phabricator.services.mozilla.com/D207877
2024-04-22 13:07:23 +00:00
Sammy Khamis
9ad1c9d961 Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 20:13:16 +00:00
Cristian Tuns
8904d3681a Backed out changeset ab9a461da1ee (bug 1885064) for causing xpcshell failures in test_commands_closetab.js CLOSED TREE 2024-04-19 15:45:22 -04:00
Sammy Khamis
4e28b48a03 Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 18:44:43 +00:00