corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
880,375 Commits 1 Branch 0 Tags
a52a1d1d9f4428a07eec211cd3b8da779bae0a67
Commit Graph

52 Commits

Author SHA1 Message Date
Mike Conley
a52a1d1d9f Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones 
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
 2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE 
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
 2024-10-19 03:25:51 +03:00
Mike Conley
51c773a1f0 Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers 
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
 2024-10-18 20:43:30 +00:00
Mike Conley
53a3f31513 Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones 
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
 2024-10-18 20:43:29 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D222674
 2024-10-07 20:15:01 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D224270
 2024-10-03 17:16:22 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 21:08:44 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers 
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
 2024-06-24 19:52:53 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211670
 2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount 
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
 2024-06-17 14:53:04 +00:00
Maxx Crawford
f79515b485 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D212952
 2024-06-07 20:44:50 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 23:02:05 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D212157
 2024-06-04 00:54:00 +00:00
Nathan Barrett
c7d3cc489b Bug 1893007 - add location query to weather widget r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212069
 2024-06-03 20:59:32 +00:00
scottdowne
0d285f9aec Bug 1900043 - Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes. r=home-newtab-reviewers,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D212301
 2024-05-31 18:36:19 +00:00
scottdowne
8954d01757 Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode r=desktop-theme-reviewers,home-newtab-reviewers,omc-reviewers,sfoster,aminomancer,amy 
Differential Revision: https://phabricator.services.mozilla.com/D211623
 2024-05-30 18:47:21 +00:00
Maxx Crawford
ca1c9f6bb6 Bug 1898275 - Add impression and error telemetry events to Weather feature r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211402
 2024-05-24 01:46:48 +00:00
Maxx Crawford
ef0230d8ef Bug 1895797 - Add telemetry to New Tab weather widget r=home-newtab-reviewers,omc-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209867
 2024-05-20 18:01:50 +00:00
Nathan Barrett
a46122da52 Bug 1896004 - Add wallpaper telemetry r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D210101
 2024-05-17 14:51:43 +00:00
Maxx Crawford
99b8fc05eb Bug 1890136 - Add weather widget component r=home-newtab-reviewers,omc-reviewers,aminomancer,thecount 
This commit adds the component - including markup, logic and styles for the weather widget on the New Tab page

Differential Revision: https://phabricator.services.mozilla.com/D208885
 2024-05-09 22:11:57 +00:00
Nathan Barrett
3ae97b6c59 Bug 1886833 - Home and newtab creating weather feed r=home-newtab-reviewers,maxx,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D207763
 2024-05-06 16:02:21 +00:00
Maxx Crawford
f7bf5949e2 Bug 1824019 - Adjust hover/focus/active states for HNT card context menu buttons r=home-newtab-reviewers,desktop-theme-reviewers,dao,nbarrett,thecount 
This patch adjusts the background-color/border/outline of the three different context menu buttons across the HNT page: top sites, pocket stories and recent activity cards.

It addresses the different link states: :hover, :focus (inlcuding :focus-visible), and :active for this button. This patch also includes attribute values for dark mode.

Differential Revision: https://phabricator.services.mozilla.com/D207067
 2024-04-18 19:54:22 +00:00
Nathan Barrett
ae3e1aa169 Bug 1881588 - Add Wallpaper component r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount,maxxcrawford 
Differential Revision: https://phabricator.services.mozilla.com/D205373
 2024-04-11 14:01:18 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-28 16:26:14 +00:00
Cristina Horotan
55e65e2992 Backed out changeset 4577a311fab7 (bug 1886856) for causing newtab failures at asrouter CLOSED TREE 2024-03-27 23:21:01 +02:00
Emily McMinn
ecc39fdb91 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 20:00:04 +00:00
Norisz Fay
f3d83af181 Backed out changeset 66d93ead16c4 (bug 1886856) for causing node newtab failure in bundles CLOSED TREE 2024-03-27 21:08:57 +02:00
Emily McMinn
6817fbac59 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D205344
 2024-03-27 17:19:10 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201867
 2024-03-21 22:05:28 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
 2024-03-19 17:01:38 +00:00
Mark Banner
fb8a38fb26 Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer 
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
 2024-03-19 17:01:37 +00:00
scottdowne
b61912d7a1 Bug 1882830 - Home and newtab adding message variants for sponsored content. r=nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D203297
 2024-03-15 06:50:09 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D202950
 2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D203330
 2024-03-02 02:36:24 +00:00
Mark Banner
1d4856edef Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers 
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
 2024-02-24 12:21:20 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202622
 2024-02-24 10:00:59 +00:00
Mark Banner
257b6d2dc7 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-07 08:55:30 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE 
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
 2024-02-07 01:26:39 -05:00
Mark Banner
617d0bb8f5 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-06 22:32:52 +00:00
Mike Conley
02fbf941fd Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
 2024-02-05 22:03:15 +00:00
Mike Conley
ef3fd292cf Bug 1868838 - Move asrouter-utils into browser/components/asrouter. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D198883
 2024-01-29 18:52:23 +00:00
Mark Banner
0e09ea855d Bug 1787278 - Drop babel transpile plugins from newtab and related code. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D197884
 2024-01-10 17:39:29 +00:00
Mike Conley
fe5402f48c Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao 
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
 2023-12-14 18:46:55 +00:00