corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
758,204 Commits 1 Branch 0 Tags
a49b8ef78f01c005304a3b0e304364a1c92830fc
Commit Graph

2522 Commits

Author SHA1 Message Date
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
negin
124dd1b1a1 Bug 1791010 - The backgrounds of the images from the "about:welcome" page are not visible if the "High Contrast Mode" is active r=emcminn 
Added high contrast rule for mr background images.

To test this in macOS enable the following:

{F4178464}

and enable a dark theme for firefox

Differential Revision: https://phabricator.services.mozilla.com/D158264
 2022-09-28 20:08:33 +00:00
hanna alemu
d1d82341cd Bug 1791647 - Check home page checkbox by default for colorway upgrade screen r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D157989
 2022-09-28 17:55:13 +00:00
hanna alemu
e78bca6f49 Bug 1792226 - Fx view CFR profile age of atleast two days r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D158040
 2022-09-28 00:39:35 +00:00
Mark Banner
92309dcd01 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158088
 2022-09-27 18:58:57 +00:00
Cristian Tuns
379cbd0e59 Backed out changeset cd3ab0559b8a (bug 1792344) for causing node failures CLOSED TREE 2022-09-27 14:44:13 -04:00
Mark Banner
87cee1d460 Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply 
Differential Revision: https://phabricator.services.mozilla.com/D158088
 2022-09-27 18:06:46 +00:00
scott
c38905f047 Bug 1791615 - Pocket newtab configurable cache time. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D158059
 2022-09-27 00:53:35 +00:00
Emily McMinn
26f512bf05 Bug 1790396 - Fixup Feature Callout button CSS for HCM r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D158036
 2022-09-23 23:59:14 +00:00
Brian
0b327f0974 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Shane Hughes
e03548a638 Bug 1791412 - Adjust MR Onboarding Pin private browsing illustration to center it. r=pdahiya 
Add 50px to the left side of mr-pinprivate.svg so it feels more centered.

Differential Revision: https://phabricator.services.mozilla.com/D157776
 2022-09-22 21:32:46 +00:00
negin
bc59648a83 Bug 1791669 - tab pickup onboarding flyout has a ui misalignment r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D157964
 2022-09-22 21:29:17 +00:00
Yoen Zhang
e800a9ab3f Bug 1787809 - Secondary button arrow should be inline so responsive shows it more centered r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D156886
 2022-09-22 14:46:43 +00:00
Emily McMinn
e0d5ce02f4 Bug 1791861 - Update tooltip and aria-label for default colorway option r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D157863
 2022-09-22 14:25:48 +00:00
Punam Dahiya
a223d61beb Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157691
 2022-09-20 20:31:36 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D157749
 2022-09-20 20:08:51 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-20 19:39:02 +00:00
Emily McMinn
0763ca6c8b Bug 1790487 - Change Colorways tooltip and aria-label r=aminomancer,fluent-reviewers 
I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.

I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.

Differential Revision: https://phabricator.services.mozilla.com/D157369
 2022-09-20 15:12:18 +00:00
Jonathan Sudiaman
febfadf50b Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D157337
 2022-09-20 12:21:45 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-18 16:01:11 +00:00
Shane Hughes
75546a2dcb Bug 1790655 - Include screen list in AboutWelcome telemetry ping message IDs. r=Mardak 
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).

Differential Revision: https://phabricator.services.mozilla.com/D157581
 2022-09-17 18:08:52 +00:00
Ed Lee
655ad8b48c Bug 1782944 - The marketplace buttons from the “Get Firefox Klar” modal no longer redirect to the Firefox Klar on App Store/Google Play using de locale and region r=pdahiya 
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.

Differential Revision: https://phabricator.services.mozilla.com/D157518
 2022-09-16 05:26:14 +00:00
Shane Hughes
2fade3c4d3 Bug 1791088 - Constrain aboutwelcome styles to onboarding-specific elements. r=Mardak 
Fix a bug where rules in aboutwelcome.css were applying to Firefox View.

Differential Revision: https://phabricator.services.mozilla.com/D157536
 2022-09-16 03:39:05 +00:00
Shane Hughes
2afc0dde2a Bug 1790895 - Make multistage Spotlight dialog background transparent in HCM. r=pdahiya 
Fix a bug where a rule for about:welcome was causing the background for
the multistage spotlight dialog to be white in HCM.

Differential Revision: https://phabricator.services.mozilla.com/D157367
 2022-09-16 02:00:16 +00:00
Emily McMinn
fd387bec24 Bug 1790594 - Update button label colors for HCM r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157246
 2022-09-16 00:48:31 +00:00
Ed Lee
221b28954c Bug 1790462 - Restore responsive layout to 550px total height r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157524
 2022-09-15 22:24:42 +00:00
Punam Dahiya
e22374b3fb Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak 
Configure upgrade spotlight with dark variation to persist variation as bold when starting with a dark theme.

Differential Revision: https://phabricator.services.mozilla.com/D157161
 2022-09-15 02:42:02 +00:00
scott
ca1c4058a5 Bug 1790856 - Fixing Pocket recent saves id for telemetry. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D157353
 2022-09-14 21:35:25 +00:00
Meg Viar
0096bcb2fa Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D157163
 2022-09-14 21:33:29 +00:00
Shane Hughes
0eb8741c0b Bug 1790315 - Remove normalize.scss from aboutwelcome.scss. r=emcminn 
Just remove the import of normalize.scss from aboutwelcome.scss, without
removing the file itself. Add styles needed to maintain the current
appearance and remove styles that were only necessary because of
normalize.scss.

Differential Revision: https://phabricator.services.mozilla.com/D157224
 2022-09-14 20:23:17 +00:00
Shane Hughes
5b7b6ec7d7 Bug 1788754 - Add a primary CTA to the tab pickup message. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157066
 2022-09-14 19:54:38 +00:00
negin
6e90484073 Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157144
 2022-09-14 19:44:39 +00:00
Meg Viar
714d96b541 Bug 1790465 - Add MR holdback study targeting to all Feature Callout messages r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D157146
 2022-09-14 18:50:28 +00:00
Punam Dahiya
a10036f907 Bug 1787275 - Add majorRelease2022 nimbus holdback targeting to hide pin promo r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157291
 2022-09-14 17:49:26 +00:00
Nick Alexander
e0bf9e65d7 Bug 1790444 - Allow to localize action title in Toast Notification actions messages. r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D157165
 2022-09-14 17:47:24 +00:00
negin
bd9a96ff47 Bug 1790474 - Onboarding progress bar: aria-valuetext starts with "step 0 out of %aria-valuemax%" r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D157254
 2022-09-14 17:33:09 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Shane Hughes
ae3150ef08 Bug 1790126 - Change Colorways onboarding primary label. r=Mardak,flod 
Differential Revision: https://phabricator.services.mozilla.com/D157230
 2022-09-14 14:38:20 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Meg Viar
067eaadd58 Bug 1788991 - Add Messaging Trigger for the nth Closed Tab r=dmose,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156905
 2022-09-13 21:03:46 +00:00
Sandor Molnar
adc341e323 Backed out changeset 658be3acc41a (bug 1788991) for causing bc failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE 2022-09-13 23:01:38 +03:00
Meg Viar
edd8a30169 Bug 1788991 - Add Messaging Trigger for the nth Closed Tab r=dmose,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156905
 2022-09-13 18:48:17 +00:00
Punam Dahiya
f332fca018 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz 
Differential Revision: https://phabricator.services.mozilla.com/D157000
 2022-09-13 18:35:01 +00:00
Sandor Molnar
03d1865f8f Backed out changeset a224934d4790 (bug 1786523) for causing multiple failures in browser_siteData_multi_select/browser_aboutwelcome_multistage_mr CLOSED TREE 2022-09-13 22:27:08 +03:00
Emily McMinn
ec1c592456 Bug 1786523 - Add a where prop to FXA Accounts to allow opening in a new tab r=negin 
Differential Revision: https://phabricator.services.mozilla.com/D156206
 2022-09-13 17:53:08 +00:00
Emily McMinn
e1c346b911 Bug 1787123 - Switch to em instead of px on secondary CTA to maintain text size r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D156575
 2022-09-13 17:11:39 +00:00
Mike Conley
023d86fe63 Bug 1775858 - Make sure Discovery Stream cards exist before running about:home startup cache tests. r=daleharvey 
The about:home startup cache tests assert that Discovery Stream nodes are rendered in
the cached page after it loads. It seems that about:home startup is a bit asynchronous,
and _sometimes_ the Discovery Stream cards don't yet exist at the time of caching.

This updates our tests to wait for about:home to have finished loading the Discovery Stream
nodes before continuing.

Differential Revision: https://phabricator.services.mozilla.com/D157147
 2022-09-13 16:30:34 +00:00
Iulian Moraru
dcf1f3817e Backed out changeset b81337fc9ed1 (bug 1789192) for causing multiple bc failures. CLOSED TREE 2022-09-13 19:44:44 +03:00