Commit Graph

193 Commits

Author SHA1 Message Date
Nathan Froyd
a3cd9ee75a Bug 1360236 - make gSocketThread an internal implementation detail of nsSocketTransportService; r=mcmanus
This change makes the code a little cleaner and reduces the number of
places we call PR_GetCurrentThread, which is important for Quantum DOM
scheduling work.

The conversion was largely automatic, via:

find netwerk/ -name \*.cpp | \
  xargs sed -i -e 's/MOZ_ASSERT(PR_GetCurrentThread() == gSocketThread[^;]*/MOZ_ASSERT(OnSocketThread(), "not on socket thread")/'

and related invocations, with a few manual tweaks at the end.
2017-04-27 14:34:42 -04:00
Jason Duell
040e164669 Bug 711886 - Fail Websocket if server replies with non-matching subprotocol, r=mcmanus 2016-05-11 08:50:13 -07:00
Hideki Takeoka
1ae134f83e Bug 1351948 - Refuse ws messages that don't use minimal encoding. r=michal 2017-04-03 10:49:22 -04:00
Wei-Cheng Pan
9f134bdbf1 Bug 1310127 - Part 3: Use MOZ_MUST_USE in netwerk/protocol/http r=mcmanus
Add assertions.

MozReview-Commit-ID: DPvgKzVr3ip
2017-01-12 17:48:45 +08:00
Tim Huang
98a583c4bd Bug 1337893 - Part 3: Updating Necko for DNS changes. r=valentin
MozReview-Commit-ID: AVEp3hP7XqB
2017-02-15 17:48:15 +08:00
Tom Tromey
a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Wei-Cheng Pan
2af5e12dfa Bug 1323949 - Use MOZ_MUST_USE in netwerk/protocol/websocket r=valentin
MozReview-Commit-ID: 6lNrHbDIUez
2016-11-23 18:00:42 +08:00
Ehsan Akhgari
90f8d7c831 Bug 1318887 - Remove NS_GetAppInfo; r=mcmanus
This function is now only used to populate some write-only data members.
2016-11-21 15:00:46 -05:00
Ehsan Akhgari
dd159d47f6 Bug 1318883 - Remove the NetworkStats API and related code; r=baku,mcmanus 2016-11-21 13:33:18 -05:00
Jinank Jain
b875b54a4e Bug 712936 - Convert users of PR_STATIC_ASSERT to C++11 static_assert(). r=Ms2ger 2016-08-23 11:24:54 -04:00
Nicholas Nethercote
1f65390cc9 Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.
2016-08-08 12:18:10 +10:00
Michal Novotny
0492c71819 Bug 1288905 - Questionable reinterpret cast in WebSocketChannel::PrimeNewOutgoingMessage(), r=mcmanus 2016-07-26 19:57:03 +02:00
Michal Novotny
9c831c7e14 Bug 1287266 - Integer overflow check in WebSocketChannel::ProcessInput, r=mcmanus 2016-07-20 17:15:32 +02:00
Nicholas Nethercote
2e5d18a8ba Bug 1278439 - Adding missing prefs service null checks in netwerk/. r=valentin. 2016-07-14 13:47:44 +10:00
Christoph Kerschbaumer
9707ba1a13 Bug 1282554 - Provide helper function to check if channel can be openen using open2() and asyncOpen2() r=bholly 2016-06-28 19:03:56 +02:00
Christoph Kerschbaumer
4dd7563d92 Bug 1271198 - Convert Websockets to use AsyncOpen2(). r=jduell 2016-05-17 12:04:11 +02:00
Jonas Sicking
a6a228b2c1 Bug 1272100: Websocket changes in preparation of FlyWeb landing. Make websocket code support acting as the server side of a websocket connection. r=michal 2016-06-01 02:35:33 -07:00
Chris Peterson
41c3720394 Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj 2016-05-22 13:31:11 -07:00
Sebastian Hengst
8bc16a6aea Backed out changeset 2292661153e3 (bug 1271198) for web-platform failures. r=backout on a CLOSED TREE 2016-05-19 17:06:04 +02:00
Christoph Kerschbaumer
1545ce5c04 Bug 1271198 - Convert Websockets to use AsyncOpen2() (r=jduell) 2016-05-19 15:42:01 +02:00
Sebastian Hengst
7e88cd47a7 Backed out changeset 854a8df494d3 (bug 1271198) for many assertions at nsHttpChannel.cpp:5204. r=backout on a CLOSED TREE 2016-05-19 14:23:51 +02:00
Christoph Kerschbaumer
dcac96fb7a Bug 1271198 - Convert Websockets to use AsyncOpen2() (r=jduell) 2016-05-19 11:54:02 +02:00
Michal Novotny
5e8cb2252b Bug 1271527 - Crash in mozilla::net::WebSocketChannel::Notify, r=mcmanus 2016-05-12 13:28:50 +02:00
Wes Kocher
cc45769f64 Backed out changeset af74581564bc (bug 711886) for wpt bustage 2016-05-11 10:28:53 -07:00
Jason Duell
f420936ed4 Bug 711886. Fail Websocket if server replies with non-matching subprotocol r=mcmanus 2016-05-11 08:50:13 -07:00
Jed Davis
b29cb4ee1e Bug 1270328 - Fix use-after-forget in WebSocket. r=mcmanus 2016-05-04 19:22:00 -04:00
Kyle Huey
b972c94d0f Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Carsten "Tomcat" Book
aadd508ffe Backed out changeset 85ce8cb0639a (bug 1268313) 2016-04-29 14:21:16 +02:00
Kyle Huey
e62a0823c9 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-04-28 14:08:25 -07:00
Kyle Huey
a9cf047227 Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Kyle Huey
1f6993705a Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj 2016-04-11 11:40:06 -07:00
Wes Kocher
dd9b334d33 Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)

MozReview-Commit-ID: LPEa05QobdQ
2016-04-11 12:50:56 -07:00
Kyle Huey
7a575c886c Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj 2016-04-11 11:40:06 -07:00
Michal Novotny
b2c8e755d2 Bug 1227136 - crash in mozilla::net::WebSocketChannel::StartWebsocketData, r=bagder, r=baku 2016-03-09 17:02:28 +01:00
J. Ryan Stinnett
43eb79b373 Bug 1238160 - Rename nsILoadContext::GetIsInBrowserElement. r=smaug,mayhemer
This change renames nsILoadContext::GetIsInBrowserElement to
GetIsInIsolatedMozBrowserElement.  Other methods that pass these values around
also have name changes.

Tokens such as "isInBrowserElement" have previously been serialized into cache
keys, used as DB column names, stored in app registries, etc.  No changes are
made to any serialization formats.  Only runtime method and variable names are
updated.

No behavior changes are made in this patch, so some renamed methods may have
nonsensical implementations.  These are corrected in subsequent patches
focused on behavior.

MozReview-Commit-ID: CUttXANQjSv
2016-03-02 10:35:56 -06:00
Michal Novotny
17e7126a5b Bug 1247806 - Fix HSTS redirect check in WebSocketChannel, r=mcmanus 2016-02-16 01:19:57 +01:00
Aidin Gharibnavaz
bb0750ec60 Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-10 08:23:00 +01:00
Carsten "Tomcat" Book
498dd069da Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures 2016-02-08 11:17:38 +01:00
Aidin Gharibnavaz
d9bbb0c446 Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-07 10:56:00 +01:00
Ehsan Akhgari
1562744602 Bug 1243942 - Bypass service workers for WebSocket handshake channels; r=bkelly
Without this patch, the presence of a service worker that doesn't
respond to the FetchEvent that we dispatch for the handshake request
causes an internal redirect, which is unacceptable to the handshake
channel, therefore all WebSocket channels break on such pages.

Moreover, the integration of Web Sockets and Service Workers is unclear
yet, so these channels should bypass service workers completely.
2016-01-29 09:31:24 -05:00
Chris Peterson
dab3fbc2f4 Bug 1235298 - Annotate intentional switch fallthroughs to suppress -Wimplicit-fallthrough warnings in netwerk/. r=mcmanus 2015-11-22 21:58:33 -08:00
Nathan Froyd
4ada092d17 Bug 1222867 - part 2 - be smarter about transferring ownership of WebSocketFrame; r=mcmanus
WebSocketFrames are created only to be transferred in to
WebSocketEventService::Frame{Sent,Received}, where a strong reference is
taken to them by a runnable posted to the main thread.  Let's avoid an
extra AddRef/Release cycle by passing through already_AddRefed
structures.
2015-11-08 20:52:27 -05:00
Nathan Froyd
638feef71b Bug 1219910 - make gSocketThread a relaxed atomic variable; r=mcmanus
Many places that (re-)declared gSocketThread already included
nsSocketTransportService2.h; we can delete the declaration for those
places.  For all the other places, we need to include
nsSocketTransportService2.h.
2015-11-06 12:00:37 -05:00
Andrea Marchesini
a98c89a748 Bug 1215092 - WebSocketEventService and WebSocket discovering - part 2 - Unique Serial number for WebSocketChannel in IPC, r=michal 2015-10-28 19:10:42 +00:00
Andrea Marchesini
b8a7c5f9e2 Bug 1215092 - WebSocketEventService and WebSocket discovering - part 1 - Renaming WebSocketFrameService, r=michal 2015-10-28 19:10:20 +00:00
Carsten "Tomcat" Book
bf3efb4f25 Backed out changeset 7393a036ce36 (bug 1215092) for failing on own tests on a CLOSED TREE 2015-10-28 14:28:59 +01:00
Carsten "Tomcat" Book
457126dc02 Backed out changeset 2284c3e8c336 (bug 1215092) 2015-10-28 14:28:37 +01:00
Andrea Marchesini
ffa5134a4e Bug 1215092 - WebSocketEventService and WebSocket discovering - part 2 - Unique Serial number for WebSocketChannel in IPC, r=michal 2015-10-28 11:42:00 +00:00
Andrea Marchesini
4ee2e7603e Bug 1215092 - WebSocketEventService and WebSocket discovering - part 1 - Renaming WebSocketFrameService, r=michal 2015-10-28 11:41:24 +00:00
Andrea Marchesini
1f321121c8 Bug 1203802 - Websocket Frame Listener API for devtool Network Inspector - part 2 - WebSocketFrameService, r=michal 2015-10-26 15:30:11 +00:00