Commit Graph

50 Commits

Author SHA1 Message Date
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Rob Wu
731bc4cb2e Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
- `Array.forEach` becomes for-of loop or `array.forEach`.
- `Array.slice(a)` or `Array.slice(a, 0)` becomes `Array.from(a)`.
- `Array.map` becomes `Array.from`
- `Array` copy + concatenation becomes Array literal + spread syntax.
- All other `Array.X(a, ...)` become `Array.prototype.X.call` or `Array.from(a).X(...)`

Differential Revision: https://phabricator.services.mozilla.com/D27802
2019-04-17 19:03:17 +00:00
Mark Striemer
7d423144d2 Bug 1520068 - Handle more system shortcuts in add-on shortcuts ui r=dao
This centralizes the checks for system shortcuts into ShortcutUtils.jsm, so
they can be checked for in the add-on shortcut assignment UI. It also
introduces a mechanism for skipping the system event handler if it is already
being handled by the shortcuts UI.

Differential Revision: https://phabricator.services.mozilla.com/D17586
2019-03-08 18:32:20 +00:00
Marco Bonardo
a040dd21a3 Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753
2019-02-28 08:39:33 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Dão Gottwald
a53f86f158 Bug 1509488 - Use keydown handler instead of <key> for Shift+Ctrl+Tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D12744
2018-11-26 16:07:07 +00:00
Dão Gottwald
ba5ec66877 Bug 1501699 - Don't consume the Ctrl+Shift+Tab event when not actually handling it. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D11024
2018-11-06 15:19:42 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
2018-08-08 15:22:53 -07:00
Dão Gottwald
f77c592322 Bug 1481321 - Stop eagerly creating thumbnails for the Ctrl+Tab panel. r=jaws 2018-08-07 11:34:42 +02:00
Dave Townsend
7c2cace29b Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489
2018-07-31 19:13:38 +00:00
Dão Gottwald
57b4efa3b3 Bug 1473595 - Enable "Ctrl+Tab cycles through tabs in recently used order" feature by default in new profiles. r=jaws
MozReview-Commit-ID: 5lmOj3k4tFf
2018-07-26 11:13:34 +02:00
Dão Gottwald
5e7ed956cd Bug 1478646 - Ctrl+Tab previews should use the keydown event and addSystemEventListener to match tabbox.xml. r=jaws
MozReview-Commit-ID: HVlLTjrEhpz
2018-07-26 15:20:57 +02:00
Narcis Beleuzu
b814f4ff26 Backed out 1 changesets (bug 1473595) for debug-mochitest-chrome failures on test_key_event_counts.xul and test_htmleditor_keyevent_handling.html. CLOSED TREE
Backed out changeset a3140755de69 (bug 1473595)
2018-07-26 13:58:57 +03:00
Dão Gottwald
7c7e7b13ea Bug 1473595 - Enable "Ctrl+Tab cycles through tabs in recently used order" feature by default in new profiles. r=jaws
MozReview-Commit-ID: 5lmOj3k4tFf
2018-07-26 11:13:34 +02:00
Mark Striemer
fd7bcb67b4 Bug 1473974 - Fix opening all tabs panel with cycle recent tabs r=dao
MozReview-Commit-ID: EGYJo8AAF2K
2018-07-10 13:48:57 -05:00
Paolo Amadini
318889af76 Bug 1462297 - Remove the "ctrlTab-preview" binding. r=bgrins
MozReview-Commit-ID: BPJiakgo3wR
2018-05-18 14:07:00 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Dão Gottwald
556d78a26d Bug 1430153 - Warm up tabs in the Ctrl+Tab panel. r=mconley
MozReview-Commit-ID: IlXLt90MsrB
2018-01-12 17:09:15 +01:00
Florian Quèze
3f662053f3 Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Dão Gottwald
c06cf10ef1 Bug 1425432 - Maintain original thumbnail aspect ratio for Ctrl-Tab previews. r=jaws
MozReview-Commit-ID: F03AHwdplir
2017-12-15 13:32:51 +01:00
Dão Gottwald
9c01e71441 Bug 1415863 - Rename mTabBox to tabbox. r=florian
MozReview-Commit-ID: L2mzJnHHwNu
2017-11-09 13:53:48 +01:00
Dan Banner
69fb4d8501 Bug 1392119 - Enable the ESLint no-caller rule across mozilla-central r=standard8
MozReview-Commit-ID: JOC1330iFnh
2017-08-23 13:38:24 +01:00
Florian Quèze
72c7bf79a4 Bug 1381853 - lazy load browser-ctrlTab.js into the browser window, r=mconley. 2017-07-23 00:17:57 +02:00
Florian Queze
af4b0cb012 Bug 1349761 - uninitialize ctrlTab only if it has been initialized before, r=dao. 2017-03-23 13:00:27 +01:00
Subhdeep Saha
63e2ccca51 Bug 1345773 - Don't call updatePreview for TabAttrModified events for the "select" attribute, r=dao
MozReview-Commit-ID: 9GSnGxJoNne
2017-03-09 21:06:35 +05:30
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
milindl
ef0f32e0c4 Bug 1342025 - reduce calls to ctrlTab.updatePreview. r=dao 2017-03-06 10:03:17 +01:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dão Gottwald
a490537d60 Bug 1322889 - Properly set crop attribute on Ctrl+Tab preview titles. r=gijs 2016-12-13 15:34:32 +01:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dão Gottwald
b32713f125 Bug 1292095 - Implement SSWindowRestored event and use it instead of SSWindowStateReady for the Ctrl+Tab panel. r=mdeboer 2016-08-04 18:58:00 +02:00
Felipe Gomes
e5ea10c3ed Bug 1228627 - Remove #includes from browser.js. r=Gijs 2015-11-30 12:13:57 -02:00
Abdelrhman Ahmed
579a061714 Bug 1142552 - Remove remaining expression closures from browser-ctrlTab.js. r=dao 2015-03-13 13:01:24 +01:00
Abdelrhman Ahmed
d1e1a176bf Bug 1125499 - Use arrow function in allTabs.open. r=dao 2015-01-25 02:04:27 +01:00
Jim Mathies
ac600d7244 Bug 1088203 - e10sify PageThumbs support for checking page security and error state. r=Dao 2015-01-22 07:07:56 -06:00
Vikram Jadhav
45ab7c5e8c Bug 1121471 - Remove use of expression closures from browser-ctrlTab.js. r=dao 2015-01-20 09:31:41 +01:00
Vikram Jadhav
70ef4b1876 Bug 1122430 - Use for..of iteration instead of Array.forEach in ctrlTab.suspendGUI. r=dao 2015-01-16 07:56:00 -05:00
Abdelrhman Ahmed
bd840b977d Bug 1115038 - Ctrl-Tab panel's "Show all X tabs" button should read "List All X Tabs" instead. r=dao 2014-12-26 14:37:32 +01:00
abdelrhman
064933440c Bug 1112556 - Ctrl-Tab previews are oversized with a small number of tabs open. r=dao 2014-12-18 23:31:15 +01:00
Ryan VanderMeulen
c3fe1a8537 Backed out changeset 08d1470a4042 (bug 1112556) for mass test bustage.
CLOSED TREE
2014-12-18 15:52:57 -05:00
abdelrhman
f83d58bee0 Bug 1112556 - Ctrl-Tab previews are oversized with a small number of tabs open. r=dao 2014-12-18 19:38:58 +01:00
Dão Gottwald
4f359c7058 Bug 1107354 - Rename browser-tabPreviews.js to browser-ctrlTab.js. r=jimm 2014-12-16 21:42:43 +01:00