Commit Graph

82 Commits

Author SHA1 Message Date
negin
05fbc8e569 Bug 1930250 - Adds AppMenu configuration and styling for 'row' layout r=omc-reviewers,mconley,emcminn
Adds configuration for row layout design that we'd like to eventually rollout. See [figma](https://www.figma.com/design/qe9yX8x51jjbt6DJYgayg2/Device-Migration--Account-and-Multi-Device-Adoption-?node-id=8208-4895&m=dev)

{F19072665}

{F19072664}

{F19072663}

Differential Revision: https://phabricator.services.mozilla.com/D246145
2025-04-23 19:50:32 +00:00
Butkovits Atila
8c1f64e7a5 Backed out 5 changesets (bug 1936648, bug 1958971, bug 1655503, bug 1739522) for causing mass failures. CLOSED TREE
Backed out changeset 11f55b37b32b (bug 1739522)
Backed out changeset 4d6fea6e4d54 (bug 1958971)
Backed out changeset 0ee8cef5e12f (bug 1936648)
Backed out changeset 3eba4ee39f74 (bug 1936648)
Backed out changeset 0ab023489eaa (bug 1655503)
2025-04-23 00:15:57 +03:00
Tim Giles
e8a495baa0 Bug 1936648 - Replace searchfield-cancel with close-12 icon. r=desktop-theme-reviewers,fxview-reviewers,tabbrowser-reviewers,reusable-components-reviewers,omc-reviewers,emilio,aminomancer,hjones
Replaces the searchfield-cancel icon with the close-12 icon so that we
can style the background-color of the icon as needed.

Since we need close-12.svg to be content accessible, I needed to move
the icon to layout/style/res and add it as a content accessible file.
This resulted in replacing the existing uses of
chrome://global/skin/icons/close-12.svg with the new resource URL,
resource://content-accessible/close-12.svg.

Differential Revision: https://phabricator.services.mozilla.com/D243564
2025-04-22 20:18:48 +00:00
Nathan Barrett
3df69e20a2 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx
Differential Revision: https://phabricator.services.mozilla.com/D240175
2025-03-25 14:34:05 +00:00
Stanca Serban
92c3bbb32a Backed out 4 changesets (bug 1954848, bug 1951426, bug 1951782, bug 1953632) for causing xpcshell failures in test_NewTabMessaging.js. CLOSED TREE
Backed out changeset b2ee50813323 (bug 1954848)
Backed out changeset 211563f87799 (bug 1953632)
Backed out changeset 5003a2a06685 (bug 1951782)
Backed out changeset 4a882623c86d (bug 1951426)
2025-03-24 20:46:17 +02:00
Nathan Barrett
84c498dc3b Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx
Differential Revision: https://phabricator.services.mozilla.com/D240175
2025-03-24 17:42:04 +00:00
Goloman Adrian
ac2cd44a24 Backed out 4 changesets (bug 1953632, bug 1951782, bug 1951426, bug 1954848) for causing build bustages. CLOSED TREE
Backed out changeset 6825e2911771 (bug 1954848)
Backed out changeset 56f68e9e9ab5 (bug 1953632)
Backed out changeset bda4413155d7 (bug 1951782)
Backed out changeset 04623acb0ff2 (bug 1951426)
2025-03-21 20:38:15 +02:00
Nathan Barrett
3957775da8 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D240175
2025-03-21 15:26:34 +00:00
negin
4b16185899 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-02-24 15:21:41 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
2025-02-19 16:19:42 +00:00
Butkovits Atila
91a59f70d0 Backed out changeset aedc669b8499 (bug 1919598) for causing failures at browser_tabnotificationbox_switch_tabs.js. CLOSED TREE 2025-02-14 19:24:24 +02:00
negin
4935d2153f Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-02-14 16:05:20 +00:00
Punam Dahiya
1fd0f99f8e Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D236880
2025-02-10 17:55:34 +00:00
Norisz Fay
29170cefc4 Backed out changeset 5785f202084e (bug 1940816) for causing Bpgo bustage CLOSED TREE 2025-02-11 06:11:10 +02:00
Punam Dahiya
7059cde7b0 Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi
Differential Revision: https://phabricator.services.mozilla.com/D236880
2025-02-10 17:55:34 +00:00
Sarah Chung
00af71e19a Bug 1944079 - land desktop to mobile adoption experiment in tree r=omc-reviewers,emcminn,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D236551
2025-02-06 15:14:36 +00:00
Emily McMinn
efeb1ce68d Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-13 18:48:32 +00:00
Cosmin Sabou
efae93e17d Backed out 2 changesets (bug 1938446, bug 1919598) for causing failures on browser_tabnotificationbox_switch_tabs and conflicts. CLOSED TREE
Backed out changeset be28df34cc76 (bug 1938446)
Backed out changeset ffa630d286bb (bug 1919598)
2025-01-11 01:58:14 +02:00
Emily McMinn
b2b5a8709e Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-10 21:50:48 +00:00
negin
34caedb5e0 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-01-10 21:31:18 +00:00
Punam Dahiya
cf58fbd5e3 Bug 1618001 - Move React vendored libraries to the toolkit to prevent multiple instances r=sylvestre,omc-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,firefox-ai-ml-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232431
2025-01-08 21:08:16 +00:00
Sarah Chung
2ae199b569 Bug 1822664 - update npm packages for asrouter and aboutwelcome r=dmose,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D230561
2024-12-18 19:05:21 +00:00
Punam Dahiya
626a74d9fa Bug 1934668 - Move ASRouter image assets out of newtab r=desktop-theme-reviewers,home-newtab-reviewers,urlbar-reviewers,omc-reviewers,aminomancer,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232130
2024-12-17 01:36:16 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Emilio Cobos Álvarez
ebe0ec0cbc Bug 1388910 - Remove -moz-user-modify property. r=dshin
We successfully unshipped it in bug 1920118.

Differential Revision: https://phabricator.services.mozilla.com/D229530
2024-11-19 19:35:35 +00:00
Emily McMinn
4165938b55 Bug 1904945 - Add Staff Picks callout to moz-central r=omc-reviewers,hanna_a
Differential Revision: https://phabricator.services.mozilla.com/D226345
2024-11-13 15:46:37 +00:00
Emily McMinn
803813abef Bug 1903708 - Enable about:messagepreview to preview private browsing messages r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D220289
2024-10-30 22:10:37 +00:00
Punam Dahiya
8d7c4d95e6 Bug 1927878 - Make Attribution parameters in devtools editable r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227263
2024-10-29 23:26:31 +00:00
Rebecca King
d7e1907648 Bug 1916815 - Replace --in-content-accent-color variable with the --color-accent-primary token r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D224509
2024-10-21 14:50:46 +00:00
Mike Conley
50825d3ded Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
2024-10-19 20:45:50 +00:00
Mike Conley
a52a1d1d9f Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
2024-10-19 03:25:51 +03:00
Mike Conley
51c773a1f0 Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
2024-10-18 20:43:30 +00:00
Mike Conley
53a3f31513 Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-18 20:43:29 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani
Differential Revision: https://phabricator.services.mozilla.com/D222674
2024-10-07 20:15:01 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D224270
2024-10-03 17:16:22 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop
Differential Revision: https://phabricator.services.mozilla.com/D221443
2024-09-12 21:08:44 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
2024-06-24 19:52:53 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
2024-06-19 19:45:03 +00:00
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount
Differential Revision: https://phabricator.services.mozilla.com/D211670
2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
2024-06-19 19:45:01 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
2024-06-17 14:53:04 +00:00
Maxx Crawford
f79515b485 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212952
2024-06-07 20:44:50 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 23:02:05 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D212157
2024-06-04 00:54:00 +00:00