corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
881,089 Commits 1 Branch 0 Tags
a255af1381ab83333e957412b80acc86b4c3acbe
Commit Graph

67 Commits

Author SHA1 Message Date
Dão Gottwald
a255af1381 Bug 1926582 - Rename things related to moving multiselected tabs together to avoid confusion with tab groups. r=dwalker,jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226640
 2024-10-24 14:12:27 +00:00
Florian Quèze
fc2b365faf Bug 1923028 - Migrate scalars to use Glean APIs for browser.ui.interaction.* probes outside of BrowserUsageTelemetry.sys.mjs, r=chutten,mconley. 
Differential Revision: https://phabricator.services.mozilla.com/D226514
 2024-10-24 10:52:57 +00:00
Stanca Serban
33720e7c62 Backed out 2 changesets (bug 1926582, bug 1926394) for causing mochitests failures in browser_preserveTabPipIconOverlay.js. CLOSED TREE 
Backed out changeset 851d64f4461e (bug 1926582)
Backed out changeset 79c92abcd174 (bug 1926394)
 2024-10-23 19:41:00 +03:00
Dão Gottwald
229b55fa59 Bug 1926582 - Rename things related to moving multiselected tabs together to avoid confusion with tab groups. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226640
 2024-10-23 14:26:43 +00:00
Dão Gottwald
4be8b6fec6 Bug 1926359 - Add tab group line to dragged tabs when dragging into a group. r=dwalker,tabbrowser-reviewers 
Ideally the line should cover the whole group, but I don't know that we can do this given our use of display:contents. If someone has ideas we can file a followup on that. As it stands the line will extend under dragged tabs themselves, but left or right from those there can be gaps in the line.

Differential Revision: https://phabricator.services.mozilla.com/D226634
 2024-10-23 14:21:34 +00:00
Tooru Fujisawa
c12ea81355 Bug 1923593 - Ignore the active tab when handling drag and drop for the tab list. r=mak,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225723
 2024-10-23 07:24:39 +00:00
Dão Gottwald
fed3bf0d27 Bug 1926058 - groupDropIndex is an index within all tabs, so use it on this.allTabs to get the tab we're looking for. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226360
 2024-10-21 19:18:01 +00:00
Dão Gottwald
f049ccd8d8 Bug 1925842 - Rename _numPinnedTabs to pinnedTabCount. r=tabbrowser-reviewers,jswinarton,dwalker 
Also move getDuplicateTabsToClose and getAllDuplicateTabsToClose away from essentials at the top, closer to related methods.

Differential Revision: https://phabricator.services.mozilla.com/D226279
 2024-10-21 14:35:06 +00:00
Dão Gottwald
dd1c36f139 Bug 1925843 - Make sure groupDropIndex is in bounds. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226250
 2024-10-21 14:15:39 +00:00
Dão Gottwald
90a5fa39db Bug 1908438 - Drag and drop support for creating a group. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D225799
 2024-10-18 17:59:44 +00:00
Dão Gottwald
c6ec7829ac Bug 1924129 - When moving tabs, calculate the distance tabs need to shift by looking at the first and last moving tab rather than multiplying the size of one tab by the number of moving tabs. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225365
 2024-10-15 05:54:18 +00:00
Dão Gottwald
891bd8ee42 Bug 1924041 - Stop setting the "hashiddentabs" attribute. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D225325
 2024-10-11 14:25:14 +00:00
Dão Gottwald
4268ec21d4 Bug 1923635 - Various MozTabbrowserTabs cleanup. r=dwalker,tabbrowser-reviewers 
Did this while working on drag-and-drop code.

Differential Revision: https://phabricator.services.mozilla.com/D225062
 2024-10-09 14:46:09 +00:00
Nikki Sharpley
39f9b1c3a2 Bug 1921761 - Compute maxTabsPerRow dynamically r=sidebar-reviewers,tabbrowser-reviewers,sfoster,dao 
Since the tabs size and padding has been updated, the max number of tabs
per row is no longer 6. There is also a plan to make the number of tabs per
row dynamic based on an adjustable sidebar main width. Additionally, There
is a proposed patch to pack pinned tabs when expanded - Bug 1921081. Hence,
this patch aims to make the `maxTabsPerRow` variable dynamic too.

Differential Revision: https://phabricator.services.mozilla.com/D224315
 2024-10-08 18:31:28 +00:00
Gregory Pappas
782bd92f4c Bug 1921762 - Fix horizontal tabstrip drop animation r=tabbrowser-reviewers,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D224157
 2024-10-01 13:52:39 +00:00
Gijs Kruitbosch
70debc7c0a Bug 1920319 - add dedicated keypress handler for new tab buttons, r=tabbrowser-reviewers,dao 
Right now, tabbrowser relies on browser-toolbarKeyNav.js for keyboard access to these buttons on macOS.
There's also toolkit handling for space, but not enter, in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/toolkit/content/widgets/button.js#27-34 .
In vertical tabs mode, browser-toolbarKeyNav does not help us as the buttons aren't in the toolbox.
On Nightly, the containers-related code in https://searchfox.org/mozilla-central/rev/9fe73403523732f57cd82d30590ecc272fb0b165/browser/components/tabbrowser/content/tabs.js#1422-1428
adds the buttons to gClickAndHoldListeners, which have their own keypress handling. This happens whenever
containers are enabled. Those are not enabled by default on non-nightly, and so we end up missing a keypress
handler in vertical tabs mode on non-Nightly on macOS.

This is all a big mess and we should probably figure out a better solution. But given this needs beta uplift,
the expedient solution seems to be a dedicated listener and making sure that only 1 listener is invoked.

Differential Revision: https://phabricator.services.mozilla.com/D224094
 2024-09-30 13:15:28 +00:00
Dão Gottwald
97f432dc06 Bug 1920922 - Update hidden tab checks to account for tabs in collapsed groups. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D223469
 2024-09-26 04:18:45 +00:00
Jeremy Swinarton
669e5f193b Bug 1920731: Prevent gBrowser.tabs from returning tab groups r=dwalker,sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D223362
 2024-09-25 17:31:38 +00:00
Dão Gottwald
b05aac4958 Bug 1919790 - Stop returning hidden tabs or tabs from collpased groups in _findTabToBlurTo. r=dwalker,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D223292
 2024-09-25 05:08:37 +00:00
Kelly Cochrane
8cacd1c229 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-20 11:40:04 +00:00
Butkovits Atila
5a9a789f82 Backed out changeset fb2f7f9f6def (bug 1906888) for causing failures at browser_newtabButton.js. CLOSED TREE 2024-09-19 22:04:46 +03:00
Kelly Cochrane
a83714bc93 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-19 15:54:02 +00:00
Dão Gottwald
23da2b3201 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-17 08:21:24 +00:00
Noemi Erli
353976cead Backed out 2 changesets (bug 1918676, bug 1918638) for causing browser chrome failures 
Backed out changeset c36ab1469893 (bug 1918638)
Backed out changeset f973faab6674 (bug 1918676)
 2024-09-17 02:34:41 +03:00
Dão Gottwald
2b53d56022 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D222202
 2024-09-16 19:53:42 +00:00
Kelly Cochrane
16d633fe66 Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219495
 2024-09-13 17:51:03 +00:00
Iulian Moraru
2e1e9ca43c Backed out changeset e6b82ff4e092 (bug 1911889) for causing bc failures on browser_tabIconOverlayPiP.js. CLOSED TREE 2024-09-13 19:14:13 +03:00
Kelly Cochrane
744bb885ad Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219495
 2024-09-13 14:46:04 +00:00
Nikki Sharpley
65bf12da75 Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D221681
 2024-09-11 22:43:59 +00:00
Nikki Sharpley
24fbe2a5b1 Bug 1913971 - Improve drag experience for pinned tabs in expanded vertical tabs r=sidebar-reviewers,sclements,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D221078
 2024-09-11 18:18:36 +00:00
Norisz Fay
9a12f4f7a5 Backed out changeset 870b68c06bd7 (bug 1914438) for causing bc failures on browser_newtabButton.js CLOSED TREE 2024-09-11 19:05:37 +03:00
Nikki Sharpley
98f6dcfb4e Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D221681
 2024-09-11 13:02:32 +00:00
Sarah Clements
00d0b28ceb Bug 1913279 - Fix vertical tabs issue with selected tab not scrolling on overflow r=tabbrowser-reviewers,desktop-theme-reviewers,dao 
* Remove condition in tabs.js that prohibited overflow attribute being added for vertical orientation
* Remove redundant overflow-y:auto for #tabbrowser-arrowscrollbox and set a min-height for vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D221133
 2024-09-09 13:49:26 +00:00
Dão Gottwald
06e952e673 Bug 1916941 - Vertical new tab button cleanup. r=desktop-theme-reviewers,sidebar-reviewers,kcochrane 
Details in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D221117
 2024-09-06 14:04:43 +00:00
Dão Gottwald
ddb9309ce9 Bug 1915599 - Consolidate tabbrowser arrowscrollbox initialization and overflow/overflowing attribute checks. r=extension-reviewers,desktop-theme-reviewers,jswinarton,emilio,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D220594
 2024-09-04 08:18:46 +00:00
Dave Townsend
76fee57fc7 Bug 1915111: Double clicking in the vertical tab strip should open a new tab. r=desktop-theme-reviewers,tabbrowser-reviewers,sclements,dao 
This solves two problems. First we must make the tabbrowser-tabs instance
fill the remaining space in the sidebar while at the moment it is constrained
to the height of the tabs. Then we allow the double click event to be
handled when vertical tabs and tabs in titlebar are enabled.

Differential Revision: https://phabricator.services.mozilla.com/D220269
 2024-08-30 08:20:47 +00:00
Dão Gottwald
fccdffe4bf Bug 345399 - Update scroll buttons' disabled state when the scrollbox width changes. r=emilio,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220153
 2024-08-27 20:19:18 +00:00
DJ
6248ea2cf3 Bug 1908419 - add method to retrieve list of groups from tabContainer. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220142
 2024-08-26 16:59:51 +00:00
Dão Gottwald
b736efa05b Bug 1914779 - Clean up getting the last tab in tabs.js. r=jswinarton,dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D220076
 2024-08-26 14:39:43 +00:00
Dão Gottwald
399c2311b3 Bug 1914703 - Fix up scrolled to end check. r=emilio 
I first tried to fix the disabled property, but this turned into a rabbit hole that seems a bit too risky at this stage. With some luck, this may be the only place accessing these buttons' disabled property. Medium-term we still need to fix the property, ideally by making the disabled attribute a standard boolean one.

Differential Revision: https://phabricator.services.mozilla.com/D220122
 2024-08-26 13:06:21 +00:00
Dão Gottwald
21ba6a69e4 Bug 1914519 - Consolidate vertical mode and rtl checks in tab bar code. r=jswinarton,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D219933
 2024-08-23 20:17:39 +00:00
Emilio Cobos Álvarez
0cfa35c631 Bug 1914544 - Make sure we don't open a new tab for doubleclick on the overflow buttons. 
MANUAL PUSH: Fixes browser_overflowScroll.js on Linux CLOSED TREE.
 2024-08-23 18:47:10 +01:00
Emilio Cobos Álvarez
9cd0c34bd2 Bug 1914544 - Fix tab bar doubleclick check. r=dao,tabbrowser-reviewers 
Make sure that we actually hit our arrowscrollbox (not any random
scrollbox).

Differential Revision: https://phabricator.services.mozilla.com/D219972
 2024-08-23 14:55:27 +00:00
Emilio Cobos Álvarez
b5cc0dcae9 Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-21 12:23:34 +00:00
Cristian Tuns
8914d54c72 Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE 2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
02bec8c38e Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-20 22:31:22 +00:00
Iulian Moraru
cd76550840 Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE 2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
cb06f25a7a Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers 
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.

Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.

Differential Revision: https://phabricator.services.mozilla.com/D219249
 2024-08-20 12:58:16 +00:00
Jeremy Swinarton
1ca50f8860 Bug 1912275: Collapsing tab group changes selected tab r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218888
 2024-08-14 13:56:29 +00:00
Jeremy Swinarton
0d521d1f2b Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D218796
 2024-08-08 16:23:24 +00:00