Commit Graph

77 Commits

Author SHA1 Message Date
Simon Sapin
962aaff124 servo: Merge #9509 - Deduplicate the cocoa crate (from servo:cocoa); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: 9e68285d35a2e7b72c9edfd9e5e37399e724c4e6
2016-02-05 01:26:50 +05:00
Anthony Ramine
46d0b7b4b0 servo: Merge #9473 - Bump clipboard to remove libc 0.1.z dependency (from nox:adieu-libc-1); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: ec06c256d70937e91acb7309d7518b76962ea3a4
2016-02-01 04:08:15 +05:00
Ms2ger
d64019d448 servo: Merge #9394 - Include the wpt lint in test-tidy --faster (from servo:wpt-lint); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 41892d4c93327b43dfe380a4e603789a86193069
2016-01-21 19:21:04 +05:00
Bobby Holley
f46070821b servo: Merge #9284 - Add Partial Implementation of style DOM traits for Gecko, and some basic glue to let Gecko call into Servo (from bholley:bootstrap_stylo); r=SimonSapin
The wrapper stuff is partially-complete, modulo some unimplemented methods. The glue code is just a toy for now. Regardless, I think it's worth getting some of this stuff in-tree to minimize breakage.

Source-Repo: https://github.com/servo/servo
Source-Revision: 77d3fbcca3c6f7e8b4068f89e25b090977fe5672
2016-01-19 13:49:10 +05:00
Ms2ger
4f7c8f61cf servo: Merge #9293 - Remove the legacy reftest framework (from Ms2ger:reftests); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: d28fb42201dd743c470fcc1f43bf2e13f1c8cddc
2016-01-14 14:30:14 +05:00
PythonNut
1a27db03ee servo: Merge #9277 - Call WPT lint directly in tidy, fixes #9189 (from PythonNut:master); r=Wafflespeanut
This should be fairly straightforward. :)

Source-Repo: https://github.com/servo/servo
Source-Revision: 9c8382cbde73a2d5f57c4a8a65d4ae55c03fd990
2016-01-13 12:09:24 +05:00
PythonNut
37f7bf3fff servo: Merge #9243 - Fix literal braces in string formatting in tidy.py, fixes #9151 (from PythonNut:master); r=Wafflespeanut
This should be pretty self-explanatory, it's less than a dozen bytes, after all. :)

Fixes #9151.

Source-Repo: https://github.com/servo/servo
Source-Revision: 4143caaa5796c4e6cfaa6b13d46b409819d822d7
2016-01-11 07:53:45 +05:00
Daan Sprenkels
255e695b50 servo: Merge #9118 - Add 'test-tidy-faster' command to ./mach (from dsprenkels:test-tidy-faster); r=Wafflespeanut
For issue #9088, this adds a `--changes` option to `./mach test-tidy`. If this option is set, `tidy.py` will only check files that have been modified since `FETCH_HEAD`.

Mention: @Wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: 74226836ba27afedebd88cd1269018ef2ba25959
2016-01-08 22:43:00 +05:00
Daan Sprenkels
6c9b67b562 servo: Merge #9073 - tidy.py: remove duplicate code patterns in check_rust(file_name, lines) (from dsprenkels:issue-8733); r=Wafflespeanut
This is an attempt at a reasonable fix for #8733.

Source-Repo: https://github.com/servo/servo
Source-Revision: 9fa56ccfdfb5e9d1c1a6967b28da89c8fab36900
2015-12-31 19:50:27 +05:00
Daan Sprenkels
9661be39e4 servo: Merge #9066 - tidy.py: pass list of lines to each testing function (from dsprenkels:issue-9060); r=Wafflespeanut
instead of whole content buffer

See #9060.

Source-Repo: https://github.com/servo/servo
Source-Revision: d2e7fd82213a6b2df6703dc6f9ace70e49762c5a
2015-12-26 18:14:12 +05:00
Simon Martin
889e26389e servo: Merge #9055 - Issue #9042: Report incorrect number of spaces around => in the style checker (from simartin:issue_9042); r=Wafflespeanut
Fixes https://github.com/servo/servo/issues/9042

Source-Repo: https://github.com/servo/servo
Source-Revision: f77c7928868469ef4f326a269147ae2aee6151ee
2015-12-24 10:25:48 +05:00
Corey Farwell
f4968aa41a servo: Merge #8977 - Print tidy errors as they happen instead of all-at-once (from frewsxcv:immediate-tidy-errors); r=jdm
Related to #8969

Source-Repo: https://github.com/servo/servo
Source-Revision: 8c09154d5969ae628aeb5e5c8bc6ee6174a2efd0
2015-12-17 08:39:59 +05:00
Ms2ger
e29344319b servo: Merge #8893 - Update bincode (from Ms2ger:byteorder); r=frewsxcv
Source-Repo: https://github.com/servo/servo
Source-Revision: f4aa5b42ea3c0ece91018964df88a0b6e86649dd
2015-12-09 01:06:35 +05:00
Ms2ger
0b2e1b8690 servo: Merge #8824 - Rewrite the Cargo.lock tidy check (from Ms2ger:tidy-lock); r=Wafflespeanut
Fixes #8691.

Source-Repo: https://github.com/servo/servo
Source-Revision: cad77d5f1c8458e3b21f3546e8306ab7d5163726
2015-12-08 09:51:55 +05:00
Guillaume Gomez
d7f21ffa4d servo: Merge #8750 - Ensure that tidy follows the same procedure for sorting (from GuillaumeGomez:master); r=Wafflespeanut
Fixes #8734

cc @Wafflespeanut

Source-Repo: https://github.com/servo/servo
Source-Revision: 7d9a6a8397d413ab9e5d7c0fb8409093a45fcb2d
2015-12-06 16:53:43 +05:00
Simon Sapin
dac4e7f3cc servo: Merge #8757 - Use skia and deps from crates.io (from servo:skia); r=mbrubeck
This makes the initial download for skia go from a 300 MB git repository to a 5 MB tarball. This should help with issues like #6132 and #7687.

Fix https://github.com/servo/skia/issues/70

This builds, but the at the moment causes a number of tidy errors for duplicated crates.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8b95d7b8d860ec4c0834192083361a9fb78ddbeb
2015-12-03 12:28:29 +05:00
jmr0
2c2d94c2c6 servo: Merge #8742 - adding wpt lint script to tidy checks (from jmr0:master); r=Ms2ger
Fixes #8285.

Tidy check will fail, however, until we merge the latest https://github.com/w3c/web-platform-tests/blob/master/lint.whitelist

Source-Repo: https://github.com/servo/servo
Source-Revision: a8cbc2864367da09fb31fb5f984a7b2d31b90b93
2015-12-01 21:51:37 +05:00
Guillaume Gomez
7855be6622 servo: Merge #8692 - Ensure crate are alphabetically sorted (from GuillaumeGomez:patch-1); r=Wafflespeanut
cc @nox

Source-Repo: https://github.com/servo/servo
Source-Revision: dbff1ab33636bc7d60a4c97b63f39b59985726ce
2015-11-28 19:04:11 +05:00
Manish Goregaokar
09d3c7ef66 servo: Merge #8446 - Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) (from servo:rustup_20151110); r=SimonSapin+Ms2ger+jdm+Manishearth
<s>DO NOT r+ or try+ this</s>

<s>It causes an OOM (https://github.com/rust-lang/rust/issues/29740) and can crash the OS. Probably will set our CI on fire. </s>

Source-Repo: https://github.com/servo/servo
Source-Revision: f13c72d68e1e7f49e241938bfd6e8a588c68e86b
2015-11-27 10:17:00 +05:00
Josh Matthews
4cdc9c76f9 servo: Merge #8689 - Remove remaining version-conflict exceptions in tidy.py (from jdm:deps); r=frewsxcv
Source-Repo: https://github.com/servo/servo
Source-Revision: bc618b0d535e0e67a7ea845c026678113f000d64
2015-11-27 08:47:54 +05:00
jmr0
f50d4c7652 servo: Merge #8685 - tidy rule to warn against use of &String and refactoring (from jmr0:master); r=Ms2ger
Fixes #8681

Source-Repo: https://github.com/servo/servo
Source-Revision: f96e8ce9e8c0a2c9de9574f538718defdcd93c11
2015-11-27 04:18:38 +05:00
Ms2ger
10c098ea03 servo: Merge #8451 - Ignore sync directories in test-tidy (from Ms2ger:tidy-sync); r=frewsxcv
Source-Repo: https://github.com/servo/servo
Source-Revision: 6772461002637cf4ae174a1c49d4418487f48cb9
2015-11-10 18:14:20 +05:00
Corey Farwell
189ae47701 servo: Merge #8320 - Expand tidy to lint parts of /tests/wpt (from frewsxcv:expand-tidy); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: b098339f92a6d8351786686fb80aaaa76532ccb6
2015-11-04 15:13:28 +05:00
Anthony Ramine
db09beb657 servo: Merge #8041 - Introduce trait Castable (from nox:castable); r=jdm
Removes all those messy FooCast structures in InheritTypes.rs.

Source-Repo: https://github.com/servo/servo
Source-Revision: 674589c370d978f543e71f995d58c5b28e6e9842
2015-10-21 07:57:32 -06:00
Till Schneidereit
951525599f servo: Merge #7415 - Improve implementation of DOMRect and implement DOMRectReadOnly (from tschneidereit:dom-rect); r=nox
Passes most tests from test-css. The remaining ones should pass once we have https://github.com/w3c/csswg-test/pull/834.

r? @Ms2ger

Source-Repo: https://github.com/servo/servo
Source-Revision: 810d28a2574cd288ddfa5737ade417ea53a4b690
2015-10-17 15:17:27 -06:00
Gilles Leblanc
02100f3496 servo: Merge #8044 - Adds a tidy check for single-page HTML specification links (from gilles-leblanc:issue-7998); r=Manishearth
Flags links to the single-page WHATWG specification and suggests the URL
for the multi page one.

Fixes #7998

Source-Repo: https://github.com/servo/servo
Source-Revision: 36998cd5b1ab8da63b6ec82c7d45b5dc08b5d42a
2015-10-15 19:25:53 -06:00
Matt Brubeck
70a47eb053 servo: Merge #7933 - Replace libpng and stb_image with PistonDevelopers/image (from mbrubeck:piston-image); r=glennw
Fixes #3368. r? @glennw

Source-Repo: https://github.com/servo/servo
Source-Revision: 0f597d389052500d9b76b9f9f89e873e6f809ab1
2015-10-12 15:06:31 -06:00
Corey Farwell
921a6d9aa9 servo: Merge #7960 - Replace usage of old-style WHATWG spec links (from frewsxcv:update-spec-links); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 4052a22a1c6826cb18f03de9d2f6aed82d809e71
2015-10-10 10:17:52 -06:00
Pierre Chevalier
ca1dad43cd servo: Merge #7945 - Refactor away unnecessary use of regex (from pierrechevalier83:fix_issue_7914); r=jdm
We don't need regex matching since ": &Vec<" doesn't
contain any special character.

New code reads better.

Fixes #7914.

Source-Repo: https://github.com/servo/servo
Source-Revision: 1192efed505ca19a395f22cd5e5733e8c57a6e82
2015-10-09 21:22:06 -06:00
Jaydeep
c2aab73f0a servo: Merge #7643 - Check for Extra pointer dereferencing (from jdramani:extra_ptr_dref); r=jdm
Solves issue #7640

Source-Repo: https://github.com/servo/servo
Source-Revision: 9523283c14f417014ca6d4fa8179c873bbb8f21f
2015-09-27 08:19:30 -06:00
Mathieu Rheaume
f96adb1667 servo: Merge #7692 - Raise max length error over 120 chars not at 120 chars. python/tidy.py (from ddrmanxbxfr:TidyMaxLineOver120); r=nox
This is a follow up of issue : Tidy has an off-by-one error #7686

It allows to raise the max length error when line is over than 120 not at 120 specifically.

Thanks for looking into it.

Source-Repo: https://github.com/servo/servo
Source-Revision: 8f1469eb08a437bcc6cfb510334be2b6430b4a8f
2015-09-23 04:17:16 -06:00
Brandon Fairchild
704178a0dd servo: Merge #7662 - Check for multiple import blocks separated by whitespace (from nerith:import); r=frewsxcv
Fixes #7381.

Source-Repo: https://github.com/servo/servo
Source-Revision: a0d3c9223f09757124b1520c4f17e94fa8bbe249
2015-09-19 13:34:51 -06:00
Hugo Thiessard
3b07c13b97 servo: Merge #7680 - fixes #7390 : tidy now check the order of mod declarations even whith attribute (from Mylainos:Issue-#7390); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: d1b85de762c0193276010a019f931526c34c04ce
2015-09-18 14:44:48 -06:00
João Oliveira
5e4d06c93a servo: Merge #7570 - ignore length on .lock files on tidy.py, (from jxs:ignore_length_tidy_script); r=Ms2ger
closes #7569

Source-Repo: https://github.com/servo/servo
Source-Revision: 3a97455a65a8eafab313bd583a6b1f811605168f
2015-09-11 03:07:34 -06:00
Corey Farwell
47215b1406 servo: Merge #7568 - Use OS-agnostic filesystem paths in Python (from frewsxcv:os-agnostic-paths); r=jdm
This will eventually need to be done for #1908

Source-Repo: https://github.com/servo/servo
Source-Revision: 83972196600f04e817ddb53fda18142778905307
2015-09-08 22:29:04 -06:00
Brandon Fairchild
998f147071 servo: Merge #7499 - Improve style nit check for space after a comma (from nerith:style); r=metajack
Fixes #7345.

Source-Repo: https://github.com/servo/servo
Source-Revision: 3424e234c8c86e787edfce6dc63ed155617e0e85
2015-09-02 12:05:58 -06:00
Corey Farwell
c118b053c9 servo: Merge #7117 - Reenable "Use one Python virtual environment for all mach commands" (from frewsxcv:python-venv); r=jdm
Address the issues brought up by https://github.com/servo/servo/pull/7103

The revert requires an upgrade to wptrunner (for the mozlog 3.0 compatibility) because the latest wptrunner depends on [this](https://github.com/w3c/wpt-tools/pull/27))

/cc @Ms2ger @metajack

Source-Repo: https://github.com/servo/servo
Source-Revision: 4e6bbe227299b3b8a08cba7e613952806ada4402
2015-09-02 08:44:27 -06:00
Ravi Shankar
bdb861957e servo: Merge #7438 - Tidy can now check for version conflicts (from Wafflespeanut:cargo-tidy); r=jdm
fixes #7133

Source-Repo: https://github.com/servo/servo
Source-Revision: 8b5418f58f5b80e3485ec9eff24d14dc0fbea9f9
2015-09-01 14:38:48 -06:00
erneyja
21488105b6 servo: Merge #7468 - Making test-tidy check that = have space after them (from JoshTheGoldfish:Issue7460); r=jdm
For issue #7460. Need to ensure compatibility with #7390.

Source-Repo: https://github.com/servo/servo
Source-Revision: 15de679f115f06a8ce33625d77e820b049730d4b
2015-09-01 08:33:02 -06:00
Corey Farwell
69e3786287 servo: Merge #7483 - Enforce linking to spec for method implementations via macros (from frewsxcv:macro-spec-links); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 4984aaf8bfca0698a132e10e9f48cef42d1b8302
2015-08-31 21:17:54 -06:00
Corey Farwell
2f6d7fc9db servo: Merge #7478 - Update spec link pattern to reflect impl signature changes (from frewsxcv:spec-link-tidy-fix); r=jdm
Relevant to #7416

Source-Repo: https://github.com/servo/servo
Source-Revision: 7474b295104e75c013849e104704019dc4801c91
2015-08-31 15:48:24 -06:00
wilmoz
b001887fd5 servo: Merge #7475 - Make test-tidy check that braces have spaces before or after them (from wilcus:checkBracesSpaces); r=jdm
https://github.com/servo/servo/issues/7413
Posible future/past bug fixed in components/script/timers.rs

Source-Repo: https://github.com/servo/servo
Source-Revision: 60c72f601c4dd7cfbc8a4a983099a4b323f1516a
2015-08-31 13:18:23 -06:00
Ravi Shankar
25e2af55d8 servo: Merge #7428 - tidy will now show its expectation of uses! (from Wafflespeanut:tidy); r=Ms2ger
closes #7427

(pretty errors "inherited" from rust's type checker) :P

![screenshot](https://cloud.githubusercontent.com/assets/6691262/9543298/8cabfdaa-4d95-11e5-9101-14e62781e74e.png)

Source-Repo: https://github.com/servo/servo
Source-Revision: 18de1f2357144d86ea83cd0cb66922e8a2157597
2015-08-28 03:35:53 -06:00
wilmoz
c4fc74a5ac servo: Merge #7362 - Forbid multiline imports (from wilcus:ForbidMultilineImports); r=jdm
https://github.com/servo/servo/issues/7356

Source-Repo: https://github.com/servo/servo
Source-Revision: 121110a52a549b44e65aa4ba0669bd75702588ea
2015-08-25 11:29:56 -06:00
Corey Farwell
15c59570e2 servo: Merge #7350 - Make tidy search for files recursively again (from frewsxcv:fix-tidy); r=mbrubeck
In #7348 `os.walk` was replaced with `os.listdir`. The latter is not
recursive, which results in only the root directory files getting linted

The changes to `ignored_files` are needed because calling `os.walk(".")`
results in `./` getting prefixed before each path

Source-Repo: https://github.com/servo/servo
Source-Revision: 842112c0f39542a4fb120ade4afad302221609d8
2015-08-24 18:39:22 -06:00
João Oliveira
a18a1f219b servo: Merge #7348 - update tidy.py remove collect_file_names: (from jxs:master); r=jdm
call python os functions inline

Source-Repo: https://github.com/servo/servo
Source-Revision: c790c4d4cd7f6a1babb7f257cfa52e3cd31730fc
2015-08-24 17:19:02 -06:00
Greg Guthe
69d293f275 servo: Merge #7118 - Add tidy check for unused reftest html files (from g-k:tidy-check-unused-html-files); r=jdm
Refs: https://github.com/servo/servo/issues/7078

Sample output:

```
$ time ./mach test-tidy
tests/ref/background_image_a.html not used or commented out in basic.list
tests/ref/background_image_ref.html not used or commented out in basic.list
tests/ref/canvas_linear_gradient_a.html not used or commented out in basic.list
tests/ref/canvas_linear_gradient_ref.html not used or commented out in basic.list
tests/ref/canvas_radial_gradient_a.html not used or commented out in basic.list
tests/ref/canvas_radial_gradient_ref.html not used or commented out in basic.list
tests/ref/inline_border_a.html not used or commented out in basic.list
tests/ref/inline_border_b.html not used or commented out in basic.list
tests/ref/inline_text_align_a.html not used or commented out in basic.list
tests/ref/inline_text_align_b.html not used or commented out in basic.list
tests/ref/link_style_dynamic_addition.html not used or commented out in basic.list
tests/ref/link_style_dynamic_addition_ref.html not used or commented out in basic.list
tests/ref/overflow_position_abs_inside_normal_a.html not used or commented out in basic.list
tests/ref/overflow_position_abs_inside_normal_b.html not used or commented out in basic.list
tests/ref/overflow_position_abs_simple_a.html not used or commented out in basic.list
tests/ref/overflow_position_abs_simple_b.html not used or commented out in basic.list
tests/ref/position_fixed_a.html not used or commented out in basic.list
tests/ref/position_fixed_b.html not used or commented out in basic.list
tests/ref/position_fixed_simple_a.html not used or commented out in basic.list
tests/ref/position_fixed_simple_b.html not used or commented out in basic.list
tests/ref/position_fixed_static_y_a.html not used or commented out in basic.list
tests/ref/position_fixed_static_y_b.html not used or commented out in basic.list
tests/ref/style_is_in_doc.html not used or commented out in basic.list
tests/ref/style_is_in_doc_ref.html not used or commented out in basic.list
tests/ref/table_specified_width_a.html not used or commented out in basic.list
tests/ref/table_specified_width_ref.html not used or commented out in basic.list
tests/ref/text_decoration_propagation_a.html not used or commented out in basic.list
tests/ref/text_decoration_propagation_b.html not used or commented out in basic.list
tests/ref/text_shadow_multiple_shadows_a.html not used or commented out in basic.list
tests/ref/text_shadow_multiple_shadows_ref.html not used or commented out in basic.list
tests/ref/viewport_percentage_vmin_vmax_b.html not used or commented out in basic.list
tests/ref/viewport_percentage_vw_vh_b.html not used or commented out in basic.list
tests/ref/white_space_intrinsic_sizes_a.html not used or commented out in basic.list
tests/ref/white_space_intrinsic_sizes_ref.html not used or commented out in basic.list
tests/ref/fonts/takao-p-gothic/COPYING.html not used or commented out in basic.list
tests/ref/iframe/multiple_external_child.html not used or commented out in basic.list
...
```

I thought it might be helpful to say which files aren't used in `basic.list`.

`./mach test-tidy` is a second or two slower on my laptop.
Not sure if this counts as a warning or an error that should return 1.
Not sure whether unused file output should go before or after the line specific errors.

Source-Repo: https://github.com/servo/servo
Source-Revision: b1f0357fcee0b05bee79399bc96ea327b8b8dac8
2015-08-24 16:03:05 -06:00
OneKorg
4f742268bd servo: Merge #7310 - Mention max length in tidy check_length. Fixes #7309 (from A-deLuna:bug-7309); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: a8c62f0f282321b4e2047c5143c7cbfc3282a09a
2015-08-21 13:01:05 -06:00
Johann Tuffe
25ce9ab4be servo: Merge #7265 - Add alphabetical order check for use statements (from tafia:tidy-use); r=Ms2ger
close #7112

Source-Repo: https://github.com/servo/servo
Source-Revision: a5fbb2f2a6fa79755f975feff2435abb6a5dd0e9
2015-08-20 07:43:56 -06:00
Josh Matthews
d1f1ba555f servo: Merge #7203 - Add automated style nit checks to test-tidy (from jdm:style); r=Ms2ger
Expands on the work by @wilmoz and cleans up the existing errors. Closes #7180. Closes #7111.

Source-Repo: https://github.com/servo/servo
Source-Revision: e74825f9fde8e222f4ba9bb24b2c2a3864c73e5f
2015-08-16 08:37:40 -06:00