Commit Graph

145 Commits

Author SHA1 Message Date
Alexandru Michis
77c2ff629e Backed out changeset 8d8aa8575c1d (bug 1701306) for causing multiple bc failures.
CLOSED TREE
2021-04-06 19:45:27 +03:00
Dão Gottwald
4a29705c86 Bug 1701306 - Remove custom code setting the "open" attribute on panel anchors. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110817
2021-04-06 13:22:50 +00:00
Marco Bonardo
3ce2a2a7ed Bug 1691454 - Hide the Page actions overflow (meatball) menu from the address bar. r=adw
The page actions menu is normally hidden.
When the window is smaller than a threshold, and there's more than one action,
the single actions are hidden while the menu is shown. This allows for a nicer
overflow experience.

This patch introduces a pageActions-proton test folder where we'll move proton
tests temporarily. The head.js file is just a copy of the original one, we'll
clean it up in bug 1700582 after porting the other tests.

Differential Revision: https://phabricator.services.mozilla.com/D109606
2021-03-24 23:19:14 +00:00
Marco Bonardo
987f20fe74 Bug 1700364 - Page action buttons should not be remove-able in Proton. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D109519
2021-03-24 09:48:45 +00:00
Drew Willcoxon
a50430bf55 Bug 1697191 - Remove remaining built-in page actions when Proton is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D107763
2021-03-12 20:48:30 +00:00
Micah Tigley
97e4b64d1e Bug 1690569 - Replace sync's isSendableURI checks with BrowserUtils.isShareableURL. r=markh
Depends on D104558

Differential Revision: https://phabricator.services.mozilla.com/D105640
2021-02-25 02:51:04 +00:00
Dave Townsend
b34b8cb330 Bug 1682593: Remove the site specific browser feature. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D101860
2021-01-15 11:11:19 +00:00
Emma Malysz
2eee89c2e5 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-06 00:40:51 +00:00
Dorel Luca
43bce7e150 Backed out changeset d4c1abcfbba0 (bug 1634042) for Browser-chrome failures in browser/base/content/test/touch/browser_menu_touch.js. CLOSED TREE 2020-10-02 02:50:31 +03:00
Emma Malysz
a3dbc35859 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-01 15:00:55 +00:00
Csoregi Natalia
f3fc97b3bf Backed out changeset 0798aa08c2cb (bug 1634042) for failures on browser_menu_touch.js. CLOSED TREE 2020-09-30 09:47:33 +03:00
Emma Malysz
6737036f67 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-09-29 22:09:09 +00:00
Emma Malysz
fee1a6dc86 Bug 1634042, Part 1: migrate page action titles to fluent. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D87822
2020-09-24 17:29:16 +00:00
Mark Banner
fe19463f0c Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod,geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D89879
2020-09-14 11:08:43 +00:00
Razvan Maries
3cb277cad6 Backed out 2 changesets (bug 863474) for build bustages on search.properties. CLOSED TREE
Backed out changeset 5f00eaaa4e2d (bug 863474)
Backed out changeset 42d66b1f9b82 (bug 863474)
2020-09-12 19:41:12 +03:00
Mark Banner
7f7e992df6 Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod
Differential Revision: https://phabricator.services.mozilla.com/D89879
2020-09-12 14:57:34 +00:00
Mark Banner
7ce8343947 Bug 1632448 - Remove now unused confirm and extensionID parameters for nsISearchService.addEngine, and rename it. r=daleharvey
Renaming to addOpenSearchEngine to make it more explicit about what it is actually doing.

Depends on D82524

Differential Revision: https://phabricator.services.mozilla.com/D82525
2020-07-09 09:56:25 +00:00
Dave Townsend
4b134e74e8 Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00
pbz
90b38095ec Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66448
2020-04-16 14:44:33 +00:00
Csoregi Natalia
a3c8408007 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)
2020-04-10 21:19:15 +03:00
pbz
133fe12174 Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66448
2020-04-10 16:45:12 +00:00
William Durand
c283359ee5 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831
2020-04-08 14:18:53 +00:00
Edgar Chen
24ce8a79f5 Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775
2020-04-06 20:56:14 +00:00
Edgar Chen
56f563fe42 Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384
2020-04-06 20:56:26 +00:00
Cosmin Sabou
2b8f829371 Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)
2020-04-06 23:49:58 +03:00
Edgar Chen
f967e5785e Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775
2020-03-30 12:53:42 +00:00
Edgar Chen
4cbb44142d Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384
2020-03-13 17:42:04 +00:00
Drew Willcoxon
6a4cdb4177 Bug 1619228 - Prevent the context menu from opening on separators in the page action panel. r=Gijs
Separators are technically actions, so we should ignore them when deciding whether to open the context menu.

Differential Revision: https://phabricator.services.mozilla.com/D65050
2020-03-03 13:39:35 +00:00
Marco Bonardo
640c3e2aef Bug 1612653 - Update 'Bookmark This Page' menuitems when the star state changes. r=Standard8
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.

Differential Revision: https://phabricator.services.mozilla.com/D64399
2020-02-27 12:04:15 +00:00
Dave Townsend
d7303f04bf Bug 1602186: Allow installing SSBs and launching them from the command line. r=Gijs
Allows for persisting SSBs to storage for realoading in a later app instance.
Also adds a command line argument to load and open an SSB based on its ID.

Differential Revision: https://phabricator.services.mozilla.com/D56289
2019-12-16 19:49:12 +00:00
Dave Townsend
50a4e32b41 Bug 1603787: Remove the long-expired telemetry logging for page action items. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D57138
2019-12-13 17:26:58 +00:00
Dave Townsend
be7d6bfd37 Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287
2019-12-13 15:49:26 +00:00
Arthur Iakab
df5e3162a0 Backed out 3 changesets (bug 1602176, bug 1602173) for causing browser-chrome failures on browser_ssb_direct.js CLOSED TREE
Backed out changeset c7c2e74ae25c (bug 1602176)
Backed out changeset 8243a0bcfcb1 (bug 1602173)
Backed out changeset 01189bae5706 (bug 1602173)
2019-12-13 02:46:37 +02:00
Dave Townsend
a7dd2a438f Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287
2019-12-12 20:23:10 +00:00
Dave Townsend
02d679362f Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284
2019-12-12 20:23:00 +00:00
Dave Townsend
e3e38a1edc Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283
2019-12-12 20:22:50 +00:00
Brindusan Cristian
d266b82e51 Backed out 2 changesets (bug 1602168, bug 1602123) for turning bug 1336075 into perma. CLOSED TREE
Backed out changeset b892c240d938 (bug 1602168)
Backed out changeset f47c59a4e3d3 (bug 1602123)
2019-12-11 04:44:43 +02:00
Dave Townsend
1cbc4b9bd7 Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284
2019-12-10 22:33:06 +00:00
Dave Townsend
83a4219a43 Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283
2019-12-10 22:33:10 +00:00
Harry Twyford
b44681bd25 Bug 1599123 - Rename instances of "search icon" to "search button". r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54539
2019-11-26 09:38:02 +00:00
Harry Twyford
7dcaab65ef Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D51814
2019-11-05 16:28:13 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Edouard Oger
e916cd4d3a Bug 1579445 - Refresh the FxA device list on Send Tab menu open. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D45189
2019-09-12 22:42:31 +00:00
James Teh
15e8b5b5f0 Bug 1571389: For page actions which show an iframe, focus the iframe when the action is activated. r=jaws
This includes the Save to Pocket action.
Previously, keyboard users had to press f6 twice to focus the iframe.
Worse, screen reader users weren't aware anything popped up at all.

Differential Revision: https://phabricator.services.mozilla.com/D40913
2019-08-07 21:03:42 +00:00
Tim Nguyen
17537bff2f Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39594
2019-07-31 15:22:08 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Andrew Swan
f025578344 Bug 1557871 Fix badged-button leftovers r=dao
In bug 1519577, the badged-button class for toolbarbuttons was replaced
with a "badged" attribute but a few old uses of the class were overlooked.
This patch fixes them.

Differential Revision: https://phabricator.services.mozilla.com/D34438
2019-06-11 14:36:18 +00:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00
Andrew Swan
b1174ccb67 Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
The "add search engine" page action wants to use badged toolbarbuttons,
but it does this by adding the "badged-button" class (which changes the
XBL binding) after the button has already been created and added to
the DOM.  To avoid having to switch between non-badged and badged buttons
when toolbarbutton is converted to custom elements, add a property to
page actions so that the badged status can be determined when the element
is created.

Differential Revision: https://phabricator.services.mozilla.com/D31940
2019-05-14 20:39:38 -07:00