Commit Graph

10 Commits

Author SHA1 Message Date
Kris Maglione
a155d43da2 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX
2018-08-07 14:13:06 -07:00
Sam Foster
16895060f1 Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Andreea Pavel
9639ad59da Backed out changeset d69e19bad6c1 (bug 1477106) for eslint failure at builds/worker/checkouts/gecko/browser/components/payments/content/paymentDialogFrameScript.js 2018-08-02 02:11:57 +03:00
Sam Foster
b82c918c0f Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Mark Banner
76e8f30587 Bug 1478305 - Remove unnecessary imports and fix ESLint warnings about unused variables for browser/. r=jaws
MozReview-Commit-ID: 1vHR6ixePkN
2018-07-30 10:27:36 +01:00
Kris Maglione
76e74e6ca5 Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup. r=MattN
MozReview-Commit-ID: 2bOyTPU9QbX
2018-07-07 17:49:34 -07:00
Matthew Noorenberghe
4dd71f263a Bug 1466720 - Don't reload l10n.js in the PaymentRequest scope on a refresh. r=sfoster
There was an error trying to redefine variables from l10n.js via loadSubScript. We really only need
it loaded once like a frame script but I had to fix the l10n.js code to handle this properly.

MozReview-Commit-ID: EbNrEaRQJbs
2018-06-11 00:03:47 -07:00
Matthew Noorenberghe
b8fd767583 Bug 1463292 - Use form autofill's l10n.js in the PaymentRequest dialog. r=sfoster
MozReview-Commit-ID: GUX3Gia293X
2018-05-22 10:37:54 -07:00
Jared Wein
68ad8c43c2 Bug 1446203 - Basic Payment Request Shipping Address Add/Edit page. r=MattN
MozReview-Commit-ID: 9f0vPciw65V
2018-04-10 11:53:16 -04:00
Matthew Noorenberghe
0c8c81240e Bug 1457287 - Move Payment Request UI code to browser/. r=jaws
MozReview-Commit-ID: LjrRXr1thc8
2018-04-27 07:20:32 -07:00