corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
722,410 Commits 1 Branch 0 Tags
a13bccff29f0adaad5b24ebce13e68422350b51c
Commit Graph

259 Commits

Author SHA1 Message Date
Tooru Fujisawa
9f92967d23 Bug 1740063 - Collect telemetry for hidden browser.link.open_newwindow.restriction preference usage. r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D130887
 2021-11-17 23:29:56 +00:00
Marco Bonardo
58bada86ee Bug 1740987 - Correct typo in BrowserGlue migration. 
Differential Revision: https://phabricator.services.mozilla.com/D131071
 2021-11-13 10:00:47 +00:00
Ed Lee
49ea3357f4 Bug 1740819 - Turn off MR2 onboarding in Fx95 r=pdahiya 
Turn off by default as "Mikal won't want to see us ship another experience devoid of the pin and set to default prompts."

Differential Revision: https://phabricator.services.mozilla.com/D131023
 2021-11-12 04:59:07 +00:00
Ed Lee
129b1a36c1 Bug 1735691 - Quickly clicking "explore colorways" then "keep previous" twice makes upgrade spotlight stuck r=pdahiya 
Remember that advance is busy to cancel other advances.

Differential Revision: https://phabricator.services.mozilla.com/D128432
 2021-10-14 22:31:14 +00:00
Ed Lee
f349dc2560 Bug 1735388 - Keep the variant when changing colorways on upgrade spotlight and about:welcome r=pdahiya 
Rework theme and variant activation to make variants sticky. Reorder Default to show Light then Auto so that Light and Soft are the same index. Also select the initial index based on current dark or light theme. Add transitions for variation children. Compute about:welcome variant index based on active theme instead of specifying both default variants for system and colorways.

Differential Revision: https://phabricator.services.mozilla.com/D128404
 2021-10-14 00:40:23 +00:00
James Teh
ddea713bee Bug 1735454 - Provide a more useful a11y label on the theme variation radio buttons in the upgrade spotlight r=pdahiya 
Wait for fluent-dom to translate the radio button elements to then copy over the text as aria-label.

Differential Revision: https://phabricator.services.mozilla.com/D128330
 2021-10-13 21:31:18 +00:00
Ed Lee
6b3f4e7a6f Bug 1734834 - Show MR2 upgrade dialog on windows 7 r=andreio 
Remove win7 restriction and related helpers and tests.

Differential Revision: https://phabricator.services.mozilla.com/D127953
 2021-10-08 13:32:23 +00:00
Ed Lee
e6345876a7 Bug 1734461 - Also check and reset newtab pref from "Firefox Home" upgrade spotlight checkbox r=pdahiya 
Add newtab pref checks and record events for when checkbox button is handled. Split up trigger tests to own file and share telemetry helpers from head.js.

Differential Revision: https://phabricator.services.mozilla.com/D127722
 2021-10-07 03:59:56 +00:00
Ed Lee
d6e147f358 Bug 1728853 - Update upgrade spotlight for MR2 themes r=pdahiya,fluent-reviewers,flod 
Replace almost all MR1 content with MR2 start, colorway and thank you screens. Reuse confetti from about:welcome. Add variant selection with transitions. Update triggering to show for 94 but not for windows 7.

Differential Revision: https://phabricator.services.mozilla.com/D127252
 2021-10-03 03:56:10 +00:00
Gijs Kruitbosch
1f2779a37d Bug 1732446 - fix multiple tab warning for quit shortcut usage on Windows, r=NeilDeakin,mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D126677
 2021-09-28 10:44:37 +00:00
Geoff Brown
a00c449c2d Bug 1730213 - Explicitly skip tests under browser/ on android; r=ahal 
These tests are excluded from android test runs in moz.build. Including
an explicit annotation in each manifest avoids scheduling confusion.
browser-chrome and plain-chrome tests in browser/ are of no concern,
since those test types are never scheduled on android.

Differential Revision: https://phabricator.services.mozilla.com/D125266
 2021-09-13 15:22:27 +00:00
Neil Deakin
b687da9015 Bug 1726736, test for quit keyboard shortcut opening confirmation dialog, r=mhowell 
Depends on D124223

Differential Revision: https://phabricator.services.mozilla.com/D124856
 2021-09-08 12:32:58 +00:00
Christoph Kerschbaumer
5ee0a6a910 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D119177
 2021-07-28 19:16:16 +00:00
Sandor Molnar
5e383dfda4 Backed out changeset 7eb8945dd8e3 (bug 1719272) for causing bustages in gecko decision task. CLOSED TREE 2021-07-28 19:47:06 +03:00
Christoph Kerschbaumer
8fef13ba13 Bug 1719272: Annotate failing browser/ tests to potentially enable https-first mode in Nightly r=webcompat-reviewers,denschub,webdriver-reviewers,preferences-reviewers,Gijs,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D119177
 2021-07-28 16:08:07 +00:00
Andrei Oprea
4a4f117b68 Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-26 14:48:22 +00:00
Dorel Luca
d152572739 Backed out changeset e7dffca31fa7 (bug 1716736) for Browser-chrome failures in browser/components/shell/test/browser_setDefaultBrowser.js. CLOSED TREE 2021-07-26 14:08:51 +03:00
Andrei Oprea
626914c896 Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-26 09:43:28 +00:00
Sandor Molnar
ce4534f206 Backed out changeset e5cfc59f9063 (bug 1716736) for causing bc failures in browser_setDefaultBrowser. CLOSED TREE 2021-07-26 01:17:51 +03:00
Andrei Oprea
3037ecf02e Bug 1716736 - Add schema validation for experiment enrollments in tests r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118367
 2021-07-25 21:01:16 +00:00
Ed Lee
bd972c2af9 Bug 1714466 - Relax upgrade dialog dependency on unrelated/deprecated prefs, e.g., whatsNewPanel and aboutwelcome r=pdahiya 
Check default pref branch instead of user when looking for enterprise policy changes.

Differential Revision: https://phabricator.services.mozilla.com/D118089
 2021-06-17 22:23:28 +00:00
Emily McMinn
b0b2a2322f Bug 1712869 - Set keyboard focus on the correct button for each screen of the upgrade modal r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D117364
 2021-06-15 17:12:23 +00:00
Ed Lee
5e8f1563a8 Bug 1633883 - TelemetryTestUtils.assertScalar assumes Number (so behaves odd for boolean, strings) r=chutten 
Split assertScalar to assertScalarUnset to allow the former to plain check the value including strings, false and 0.

Differential Revision: https://phabricator.services.mozilla.com/D117457
 2021-06-11 21:06:26 +00:00
Ed Lee
06d1c0878c Bug 1715348 - Add telemetry environment boolean scalar for kept in macOS Dock r=pdahiya 
Add BrowserGlue task and telemetry Scalar matching is_taskbar_pinned but for macOS as is_kept_in_dock.

Differential Revision: https://phabricator.services.mozilla.com/D117346
 2021-06-10 20:58:08 +00:00
Ed Lee
ed2b031c72 Bug 1699842 - Keep Firefox in Dock for macOS where windows would Pin without showing images r=pdahiya,flod 
Update ShellService to also check mac pinned but only from the main process, so have AboutWelcomeChild request pinned for use in getDefaults and prepareContent. Remove windows images and consolidate back to single shared css without spacers and instead use margin: auto with logo that is no longer fixed. Split out pin strings to own screen/section and use PLATFORM. Add macOS default prompt message without touching existing windows one.

Differential Revision: https://phabricator.services.mozilla.com/D115967
 2021-05-28 11:04:22 +00:00
Ed Lee
73ff0e3c14 Bug 1706963 - Close other window modal subdialog before quit/close window prompts r=Gijs 
Allow quit/close dialogs to jump the queue with new method gDialogBox.replaceDialogIfOpen().

Differential Revision: https://phabricator.services.mozilla.com/D114654
 2021-05-21 17:56:20 +00:00
Michelle Goossens
692ff0bb41 Bug 1711497 - Remove browser.proton.enabled checks/setters from tests r=Gijs,marionette-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D115539
 2021-05-20 13:03:51 +00:00
Ed Lee
9b565e102d Bug 1710955 - Also disable welcome in addition to upgrade for whats_new_page test r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D115325
 2021-05-18 04:41:51 +00:00
Ed Lee
7cfdae56eb Bug 1710955 - Change MR1 upgrade onboarding to Pin then Default then Theme screens r=fluent-reviewers,flod,pdahiya,k88hudson 
Copy / migrate strings from onboarding/defaultBrowserNotification. Add updated ltr/rtl images and show them for pin and pin+default. Dynamically adjust steps and record telemetry to identify what was shown. Handle button actions based on string ids. Alias upgradeDialog to aboutwelcome for now. Avoid oddness with scrollbars by hiding horizontal scroll.

Differential Revision: https://phabricator.services.mozilla.com/D115142
 2021-05-18 03:16:34 +00:00
Mike Conley
97ed72f91f Bug 1708056 - Add a dedicated primary button string for the upgrade dialog for Win7. r=Mardak,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D114783
 2021-05-10 23:49:53 +00:00
Ed Lee
8363182baa Bug 1706279 - Tighten up upgrade dialog spacing on short windows to be more usable before showing scrollbar r=pdahiya 
Detect if there's not enough vertical space to switch to compact mode. Use selectors and variables to adjust font-sizes, margins, etc.

Differential Revision: https://phabricator.services.mozilla.com/D114421
 2021-05-06 19:10:48 +00:00
Andrei Oprea
8573ee7fea Bug 1708652 - Add checks to remote defaults helper to ensure proper init r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D113945
 2021-05-05 15:54:57 +00:00
Ed Lee
840011ef5a Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-29 06:30:11 +00:00
Alexandru Michis
ad95115f4d Backed out changeset 48f696159514 (bug 1707141) for causing bc failures in browser_browserGlue_upgradeDialog.js 
CLOSED TREE
 2021-04-29 07:32:43 +03:00
Ed Lee
a8bea67136 Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya 
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
 2021-04-27 23:37:37 +00:00
Andrei Oprea
80ba0dff4d Bug 1681130 - Remove the Set to Default notification bar r=Mardak,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D112350
 2021-04-22 19:27:55 +00:00
Ed Lee
a7d3feaf6f Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 07:42:13 +00:00
smolnar
1d97e06982 Backed out changeset 3ac594597045 (bug 1706489) for causing bc failures in browser_browserGlue_upgradeDialog. CLOSED TREE 2021-04-21 09:10:07 +03:00
Ed Lee
6af6ea1386 Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj 
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
 2021-04-21 01:38:46 +00:00
Ed Lee
320f970bf9 Bug 1705334 - Dismiss upgrade dialog on quit to allow quit window modal prompt to show r=andreio 
Observe "quit-application-requested" to close the dialog. Use TelemetryTestUtils.assertEvents to check all events.

Differential Revision: https://phabricator.services.mozilla.com/D112303
 2021-04-16 13:39:49 +00:00
Andrei Oprea
92f4335606 Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 19:50:39 +00:00
Csoregi Natalia
db0b28082b Backed out changeset 90163e505c3f (bug 1701948) for failures on browser_remotesettingsexperimentloader_remote_defaults.js. CLOSED TREE 2021-04-15 21:58:41 +03:00
Andrei Oprea
a079750568 Bug 1701948 - Early startup cache should work for Nimbus remote defaults r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D111320
 2021-04-15 17:28:14 +00:00
Andrei Oprea
c9bdc2839c Bug 1702004 - Add Firefox logo to the default browser prompt title r=Gijs 
Check for headerIconURL in asyncConfirmEx to show a custom icon.

Differential Revision: https://phabricator.services.mozilla.com/D111233
 2021-04-14 20:08:45 +00:00
Andrei Oprea
11fa928338 Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 15:09:34 +00:00
smolnar
05e21e1d85 Backed out changeset d39717cd014e (bug 1702000) for causing mochitest bc failures in browser_aboutNewTab_defaultBrowserNotification. CLOSED TREE 2021-04-14 15:27:51 +03:00
Andrei Oprea
6a90939695 Bug 1702000 - Add pin to taskbar action to the primary button r=andreio 
Share needPin and pin methods from ShellService and reuse from default prompt, upgrade dialog and special message actions. Use these to show "primary" vs "default" in the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D111244
 2021-04-14 10:24:19 +00:00
Ed Lee
4f6ed79897 Bug 1701867 - Change set to default prompt from an infobar to a modal r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D111969
 2021-04-14 09:26:00 +00:00
Andrei Oprea
5dfc6e86df Bug 1701998 - Change the checkbox behavior for the default browser prompt r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D111104
 2021-04-13 15:45:48 +00:00
Ed Lee
bb13089f2c Bug 1697222 - Record telemetry events for various upgrade dialog interactions. r=nanj 
Add new Events.yaml upgrade_dialog category and use various methods/objects to record behaviors.

Differential Revision: https://phabricator.services.mozilla.com/D111295
 2021-04-13 00:04:30 +00:00