Commit Graph

349 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
51cd1c622d Bug 1674135 - Update test expectations since we changed the overlay inline style.
MANUAL PUSH: orange in a CLOSED TREE
2020-11-02 21:35:02 +01:00
Mark Banner
15c660fd7c Bug 1625963 - Remove the warning for the default search engine being 'controlled' by an extension as it isn't useful for users. r=jaws,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94863
2020-10-29 03:18:32 +00:00
Nihanth Subramanya
477a5cbd58 Bug 1645924 - Test whether we use the right strings if the MVP UI is enabled or not. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D94406
2020-10-22 13:01:50 +00:00
julianwels
0c80a84d5b Bug 1671122 - Fixed bug where second click on HTTPS-Only Mode enable-checkbox disables it again. r=ckerschb,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D93519
2020-10-15 19:54:31 +00:00
alwu
8ea5bd039b Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D92872
2020-10-15 05:11:40 +00:00
alwu
7803553ce1 Bug 1667454 - part1 : add a toggle button in preference page for media control. r=preferences-reviewers,fluent-reviewers,Gijs
Add a toggle button to allow user enable/disable media control feature, and here is the UX doc [1].

[1] https://docs.google.com/document/d/1Faayu4_PnIxTDScIiOI3tu20_A5av3kryCRy26J2WyQ/edit

Differential Revision: https://phabricator.services.mozilla.com/D91871
2020-10-14 20:04:41 +00:00
Razvan Maries
1143731a3c Backed out 4 changesets (bug 1667454, bug 1668139) for perma failures on browser_media_control.js. CLOSED TREE
Backed out changeset 302032fe6d64 (bug 1668139)
Backed out changeset 859ee72e9e57 (bug 1668139)
Backed out changeset fe7de882fcbf (bug 1667454)
Backed out changeset dfd0308f5ab7 (bug 1667454)
2020-10-14 22:59:00 +03:00
alwu
aae2d6a936 Bug 1667454 - part2 : add telemetry probe to record the number of times a user changes media control setting. r=preferences-reviewers,mossop,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D92872
2020-10-14 15:27:46 +00:00
alwu
31e22f61d3 Bug 1667454 - part1 : add a toggle button in preference page for media control. r=preferences-reviewers,fluent-reviewers,Gijs
Add a toggle button to allow user enable/disable media control feature, and here is the UX doc [1].

[1] https://docs.google.com/document/d/1Faayu4_PnIxTDScIiOI3tu20_A5av3kryCRy26J2WyQ/edit

Differential Revision: https://phabricator.services.mozilla.com/D91871
2020-10-12 13:34:36 +00:00
pbz
88bc39f3be Bug 1667781 - Refactored siteDataSettings dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92267
2020-10-07 18:42:49 +00:00
pbz
ac98c07787 Bug 1667781 - Refactored permission preferences dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92263
2020-10-07 18:41:35 +00:00
pbz
39968c39c4 Bug 1667781 - Refactored container preferences dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92262
2020-10-07 18:39:20 +00:00
pbz
5d73532885 Bug 1667781 - Refactored ClearSiteData dialog to use dialog element. r=Gijs,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D92261
2020-10-07 18:37:57 +00:00
Nihanth Subramanya
57e1b450bd Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 18:06:37 +00:00
Razvan Maries
c141744ed8 Backed out changeset bb81093f7e32 (bug 1662430) for perma failures on browser_rollback.js, browser_connection_dnsoverhttps.js and browser_policyOverride.js. CLOSED TREE 2020-09-24 20:57:28 +03:00
Nihanth Subramanya
e77ebbcea4 Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 12:09:52 +00:00
Dorel Luca
f6e46379cc Backed out changeset fccbbed6fc57 (bug 1662430) for Browser-chrome failures in preferences/tests/browser_connection_dnsoverhttps.js. CLOSED TREE 2020-09-24 15:04:39 +03:00
Nihanth Subramanya
2e9c8604a0 Bug 1662430 - Allow a pref to toggle whether to clear doh-rollout.mode at shutdown. r=valentin,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90856
2020-09-24 09:10:11 +00:00
Joel Maher
daf650ac83 Bug 1664497 - Adjust test expectations for OSX with no EDID dongle. r=bc,preferences-reviewers,marionette-reviewers,whimboo,Gijs
Adjust test expectations for OSX with no EDID dongle.

Differential Revision: https://phabricator.services.mozilla.com/D89934
2020-09-12 10:12:58 +00:00
pbz
9684cdfd60 Bug 1661030 - Refactor SubDialog and TabDialogBox to support passing multiple window arguments. r=Gijs,preferences-reviewers
This also updates the behavior of the allowDuplicates check:
Instead of only checking if the top dialog is a duplicate, it will now check the whole stack and
skip the dialog open if a duplicate URL is found.
This fixes an issue where callers could alternate between dialogs to bypass the check.

Differential Revision: https://phabricator.services.mozilla.com/D88422
2020-09-02 14:24:47 +00:00
Dale Harvey
299368891b Bug 1658713 - Show internal aliases in about:preferences r=preferences-reviewers,harry,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D87922
2020-08-28 08:41:48 +00:00
Gijs Kruitbosch
701b6d99eb Bug 1651131 - fix automated test interaction with experimental feature gates to not get in the way of adding/removing experiments, r=jaws,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D87383
2020-08-18 17:16:57 +00:00
Adam Gashlin
53c0887b8f Bug 1639067 part 4 - Generalize internal handlers in the Applications list. r=Gijs,preferences-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86653
2020-08-17 21:24:47 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00
Adam Gashlin
aa98afcafd Bug 1639067 part 4 - Generalize internal handlers in the Applications list. r=Gijs,preferences-reviewers,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D86653
2020-08-17 20:13:27 +00:00
pbz
29efc4cbbb Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-17 10:26:22 +00:00
Bogdan Tara
2d98b068bc Backed out 7 changesets (bug 1650795, bug 1651958) for test_master_password.html failures CLOSED TREE
Backed out changeset 4812945bfaf2 (bug 1651958)
Backed out changeset a3f28fadcdf3 (bug 1651958)
Backed out changeset 70a61c971427 (bug 1651958)
Backed out changeset e7194e7e7ecc (bug 1651958)
Backed out changeset 7e66e5431ef7 (bug 1651958)
Backed out changeset a6c58935e1d8 (bug 1650795)
Backed out changeset b79f254df4cb (bug 1650795)
2020-08-14 23:29:33 +03:00
pbz
c15f35c088 Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-14 11:31:04 +00:00
Csoregi Natalia
ba5782273e Backed out 7 changesets (bug 1650795, bug 1651958) for failures on test_modal_prompts.html . CLOSED TREE
Backed out changeset 505f46d2cd97 (bug 1651958)
Backed out changeset f7893f4dc092 (bug 1651958)
Backed out changeset 54ea7a160e0d (bug 1651958)
Backed out changeset c2bc9c8d2e97 (bug 1651958)
Backed out changeset 247880941893 (bug 1651958)
Backed out changeset c8945eb14177 (bug 1650795)
Backed out changeset fc4dcfaf3938 (bug 1650795)
2020-08-14 00:02:08 +03:00
pbz
45a4997b5b Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-13 18:43:49 +00:00
Tim Giles
50342e1a5d Bug 1620753 - Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension. r=mstriemer,fluent-reviewers,preferences-reviewers,flod,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D85629
2020-08-12 18:06:30 +00:00
Jared Wein
bb5c52efa7 Bug 1582740 - Default the 'Always check' checkbox to disabled until we load the default browser state to prevent accidental user changes. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D62479
2020-08-07 22:19:06 +00:00
Jared Wein
8fc0a49fc9 Bug 1649250 - Display the experimental features in sorted alphabetical ordering. r=mstriemer,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D81649
2020-08-04 20:17:06 +00:00
Sebastian Streich
6cb146ba8c Bug 1633710 - Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin
Differential Revision: https://phabricator.services.mozilla.com/D82911
2020-08-04 11:10:41 +00:00
Noemi Erli
b84c1e22d7 Backed out changeset 4ed7b13fb7a5 (bug 1633710) for causing failures in browser_amosigned_url.js CLOSED TREE 2020-07-29 22:34:42 +03:00
Sebastian Streich
11a5d7dd9f Bug 1633710 - Move uri.spec calls to nsIPrincipal r=necko-reviewers,geckoview-reviewers,preferences-reviewers,ckerschb,ntim,snorp,valentin
Differential Revision: https://phabricator.services.mozilla.com/D82911
2020-07-29 17:33:10 +00:00
Joel Maher
b5ff176f81 Bug 1654553 - fix browser chrome tests to support Object.is instead of ==. r=gbrown,preferences-reviewers,Gijs,rpl
fix browser chrome tests to support Object.is instead of ==

Differential Revision: https://phabricator.services.mozilla.com/D84539
2020-07-27 17:02:35 +00:00
Mark Banner
4488cd8d7d Bug 1654246 - When cloning search engines for preferences, clone the hidden property as well to ensure restore default engines works correctly. r=daleharvey,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D84520
2020-07-23 12:04:04 +00:00
Paul Bone
9e9cd5d1ba Bug 1626507 - pt 5. Remove duplicate call to openPreferences r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83872
2020-07-17 09:37:43 +00:00
Paul Bone
e893f4d432 Bug 1626507 - pt 4. Fix openPreferencesViaOpenPreferencesAPI r=preferences-reviewers,jaws
Due to changes in about:newtab somehow the preferences code is getting
initialised before the call to openPreferencesViaOpenPreferencesAPI().
Update this code to work when preferences is already initialised.

Differential Revision: https://phabricator.services.mozilla.com/D81067
2020-07-16 08:27:24 +00:00
Paul Bone
7599c1ddfd Bug 1626507 - pt 3. Rename a test to make it distinct from other tests r=preferences-reviewers,jaws
Two tests in this file had the same name, give this one a more specific name
so that console output is easier to follow.

Differential Revision: https://phabricator.services.mozilla.com/D81066
2020-07-16 05:30:46 +00:00
Sebastian Streich
9a30e9e484 Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-13 18:35:01 +00:00
Christoph Kerschbaumer
889819491b Bug 1651976: Update test browser_bug731866.js and browser_bug795764_cachedisabled.js to work correctly based on whether HTTPS-Only Mode preference if flipped to true of false. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83106
2020-07-10 23:08:54 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Nihanth Subramanya
f863745241 Bug 1603779 - Part 5: Make browser_connection_dnsoverhttps.js properly reset DoHController state between tests. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82127
2020-07-10 15:15:53 +00:00
pbz
6de58ad5a1 Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82405
2020-07-10 00:01:50 +00:00
Gijs Kruitbosch
10f16df091 Bug 1650931 - don't use hidden attribute to hide the containers category item, so switching to it works correctly, r=preferences-reviewers,mstriemer
In bug 1648222, the `gotoPref` helper that switches between different
preference panes was altered to disallow switching to hidden categories, so
that if there were no experimental pref entries, we don't show the
'Firefox experiments' category in the prefs.

Unfortunately, the containers category is always hidden, and only accessible
from the 'settings' button for containers and the URL (ie
`about:preferences#containers`), but the added requirement for categories to
not have the `hidden` attribute broke showing this category.

This patch fixes this by hiding the category using CSS instead. It also
cleans up some other use of the hidden attribute.

Note that the sync category is also hidden by default, but shown at
https://searchfox.org/mozilla-central/rev/91d82d7cbf05a71954dfa49d0e43824c7c973e62/browser/components/preferences/preferences.js#97-103

Differential Revision: https://phabricator.services.mozilla.com/D82505
2020-07-07 16:02:29 +00:00
Mike Conley
59eab37e13 Bug 1650790 - Add the about:home startup cache to the about:preferences experiments section. r=Gijs,fluent-reviewers
The cache is still disabled by default, but it would be good to collect more bugs and feedback early.

Differential Revision: https://phabricator.services.mozilla.com/D82394
2020-07-07 15:53:21 +00:00
Razvan Maries
c96b27a6b3 Backed out changeset bf22c292ae5c (bug 1650790) for bc failures on browser_search_subdialogs_within_preferences_site_data. CLOSED TREE 2020-07-07 00:49:04 +03:00
Mike Conley
d109a92380 Bug 1650790 - Add the about:home startup cache to the about:preferences experiments section. r=Gijs,fluent-reviewers
The cache is still disabled by default, but it would be good to collect more bugs and feedback early.

Differential Revision: https://phabricator.services.mozilla.com/D82394
2020-07-06 19:25:50 +00:00