Commit Graph

78 Commits

Author SHA1 Message Date
Andrei Oprea
02d7dc18a9 Bug 1740718 - Switch Messaging System to use the NimbusFeatures API r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D131241
2021-11-26 11:34:50 +00:00
Andrei Oprea
49cbf77a8d Bug 1732471 - Add action to turn on Total Cookie Protection r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D126707
2021-09-30 11:52:02 +00:00
Andrei Oprea
c91a2f77af Bug 1694163 - Remove assets associated with the ETP doorhangers r=emcminn,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D113956
2021-05-31 08:25:41 +00:00
Brindusan Cristian
463d89a6d5 Backed out changeset 62e8b689cf19 (bug 1694163) for causing bc failures in browser_all_files_referenced.js. CLOSED TREE 2021-05-26 15:57:04 +03:00
Andrei Oprea
36aee89414 Bug 1694163 - Remove assets associated with the ETP doorhangers r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D113956
2021-05-26 11:08:42 +00:00
Csoregi Natalia
80023edfc5 Backed out changeset 219f70869aaa (bug 1694163) for failures on browser_asrouter_cfr.js. CLOSED TREE 2021-05-26 00:16:30 +03:00
Andrei Oprea
326d9f1f9b Bug 1694163 - Remove assets associated with the ETP doorhangers r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D113956
2021-05-25 20:35:18 +00:00
Andrei Oprea
559f418e53 Bug 1708681 - Remove assets associated with the addon recommendation CFRs r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D113964
2021-05-10 17:24:52 +00:00
Mike Conley
a222b60f01 Bug 1705321 - Update some of our permission icons, batch 2 r=sfoster,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D112673
2021-04-20 14:56:11 +00:00
Andrei Oprea
70fefe1843 Bug 1702117 - Remove CFR strings using -sync-brand-short-name r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110907
2021-04-09 13:21:37 +00:00
Tim Nguyen
92c23d7b82 Bug 1699183 - Rename & clean up lock icons. r=preferences-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D108815
2021-03-18 20:10:22 +00:00
Tim Nguyen
5b2a70f55f Bug 1698041 - Use a different naming scheme category icons in preferences. r=Itiel
This is consistent with about:addons (toolkit/themes/shared/extensions).

Differential Revision: https://phabricator.services.mozilla.com/D108176
2021-03-12 14:44:09 +00:00
Andrei Oprea
d89d9b996b Bug 1695320 - Update copy on DoH PopupNotification r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D107606
2021-03-09 15:51:08 +00:00
Andrei Oprea
70fb96e27c Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 22:01:52 +00:00
Butkovits Atila
dd685ab77d Backed out changeset 9464e66648e3 (bug 1685525) for node failures. CLOSED TREE 2021-02-01 23:24:42 +02:00
Andrei Oprea
ecf44dcdb5 Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 19:36:47 +00:00
Butkovits Atila
a14ac2049d Backed out changeset 57c61d78ae53 (bug 1685525) for causing failures on browser_asrouter_trigger_docs.js. 2021-02-01 20:24:40 +02:00
Andrei Oprea
d4bb44e5df Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 16:14:45 +00:00
emcminn
07b483ddc3 Bug 1687910 - Move date calculation to Fluent for Milestone CFR r=andreio,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D103179
2021-01-29 09:15:20 +00:00
Andrei Oprea
fe21f6f79e Bug 1684455 - The fingerprint protection CFR is not triggered r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D100650
2021-01-05 09:15:44 +00:00
Andrei Oprea
1a3b18c1c4 Bug 1682821 - Fix content blocking milestone message test and trigger r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D99891
2020-12-17 17:58:43 +00:00
Butkovits Atila
cabc21f56f Backed out changeset 60e886fcc3db (bug 1682821) for causing failures on browser_asrouter_trigger_listeners.js. CLOSED TREE 2020-12-17 19:02:52 +02:00
Andrei Oprea
79a616cf40 Bug 1682821 - Fix content blocking milestone message test and trigger r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D99891
2020-12-16 16:09:04 +00:00
Bernard Igiri
1252c9d1fa Bug 1614465 - Replacing ASRouter calls to MessageChannel with JSWindowActors to eliminate ASRouterFeed r=k88hudson
Patch by Bernard Igiri <bigiri@mozilla.com>

Replacing async events with async method calls that use JSWindowActors to communicate with the parent process.
This will simplify these calls, bring the relevant code into local scope, and eliminate the need for MessageChannel.
Eliminating the MessageChannel dependency allows us to move the ASRouter initialization out of ASRouterFeed and into
JSWindowActors.

Differential Revision: https://phabricator.services.mozilla.com/D71796
2020-10-21 20:04:13 +00:00
Andrei Oprea
fd94cddcbb Bug 1664750 - Redirect users to about:home after they opt in to restore default settings r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D90129
2020-09-14 19:49:21 +00:00
Christoph Kerschbaumer
5c88af74c7 Bug 1654258: Package all activity-stream css files and load them using the internal chrome: protocol. r=mconley,k88hudson,perftest-reviewers,zombie,sparky
Differential Revision: https://phabricator.services.mozilla.com/D85022
2020-09-09 16:11:28 +00:00
Andrei Oprea
995dc11470 Bug 1648179 - Add schema test coverage for CFRMessageProvider messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D80922
2020-07-07 21:57:48 +00:00
Andrei Oprea
d027cd6afa Bug 1648465 - Make CFR doorhangers persistent through message configuration r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D81859
2020-07-01 15:45:34 +00:00
Andrei Oprea
7a03f2b27c Bug 1643651 - Add actions to support DOH CFR r=nhnt11,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78491
2020-06-22 17:55:45 +00:00
Brindusan Cristian
c1a019550b Backed out changeset 89da43b8e31a (bug 1643651) for node-newtab-unit-tests failures. CLOSED TREE 2020-06-22 20:37:08 +03:00
Andrei Oprea
52d886d956 Bug 1643651 - Add actions to support DOH CFR r=nhnt11,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78491
2020-06-22 09:04:18 +00:00
jayati
6b63ce105d Bug 1612125 - Add close button and delay for milestone message. r=ewright,fluent-reviewers,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D71068
2020-06-19 08:54:07 +00:00
Matthew Noorenberghe
21ce03825d Bug 1615685 - Trigger Sync CFR when a non-FxA user updates a saved password from doorhanger r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D65034
2020-04-07 06:27:06 +00:00
Andrei Oprea
ab0a1a770a Bug 1619422 - Provide a CFR action to open about:preferences#sync with an entrypoint query parameter r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D67001
2020-03-18 13:59:34 +00:00
Andrei Oprea
aa130ecb24 Bug 1622211 - No click event telemetry for CFR urlbar button r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D66747
2020-03-17 14:11:27 +00:00
Brindusan Cristian
47a039ed82 Backed out changeset 1d24a858dd6e (bug 1622211) for bc failures at browser_asrouter_trigger_listeners.js. CLOSED TREE 2020-03-17 14:34:14 +02:00
Andrei Oprea
f66219a762 Bug 1622211 - No click event telemetry for CFR urlbar button r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D66747
2020-03-16 15:28:00 +00:00
Andrei Oprea
ee4dca0cf4 Bug 1620313 - CFR Experiment for Link to Existing Heartbeat Survey r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D65763
2020-03-12 14:29:51 +00:00
Andrei Oprea
e3d4557897 Bug 1604563 - Rename trackingProtection trigger event to contentBlocking r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D57628
2019-12-20 16:25:51 +00:00
Liang-Heng Chen
d4ed053698 Bug 1589509 - add option to disable all feature promotions; r=fluent-reviewers,flod,andreio
Differential Revision: https://phabricator.services.mozilla.com/D49965
2019-10-29 13:11:39 +00:00
Liang-Heng Chen
2b4126a6c5 Bug 1588706 - merge content blocking events and set doorhanger priority; r=johannh
cfr doorhangers supports priority field, but it doen't work if we receive content blocking event separtely.
Therefore we should fire an event contains all events and let cfr priority decides the order.

Differential Revision: https://phabricator.services.mozilla.com/D49771
2019-10-25 10:44:29 +00:00
Liang-Heng Chen
0e5804d03b Bug 1590659 - remove double "&&" in the targeting description; r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D50172
2019-10-23 12:17:43 +00:00
James Teh
fa295edb29 Bug 1587809: Give the CFR address bar button a more descriptive tooltip/a11y label. Announce its appearance to screen reader users. r=andreio,fluent-reviewers,flod
1. Previously, the label and tooltip for all recommendations was just "Recommendation", even though the icon was different for extension and feature recommendations.
  Because users might not be able to see the icon and/or determine its meaning, it is important that this is communicated in the tooltip and a11y label.
2. Screen reader users won't know this has appeared, even though this attracts some attention visually.
  Therefore, provide a specific announcement for screen reader users when the recommendation appears.

Differential Revision: https://phabricator.services.mozilla.com/D47718
2019-10-21 07:13:14 +00:00
Liang-Heng Chen
c9805dc81c Bug 1585615 - check content blocking event parameter bitwisely; r=johannh
content blocking event should be checked bitwisely to see if targeted bits are all matched.

Differential Revision: https://phabricator.services.mozilla.com/D48170
2019-10-18 13:01:16 +00:00
Bogdan Tara
907a400a75 Backed out changeset cbafd2e6cf53 (bug 1587809) for browser_asrouter_cfr.js failures CLOSED TREE 2019-10-17 13:31:33 +03:00
James Teh
8995df5857 Bug 1587809: Give the CFR address bar button a more descriptive tooltip/a11y label. Announce its appearance to screen reader users. r=andreio,fluent-reviewers,flod
1. Previously, the label and tooltip for all recommendations was just "Recommendation", even though the icon was different for extension and feature recommendations.
  Because users might not be able to see the icon and/or determine its meaning, it is important that this is communicated in the tooltip and a11y label.
2. Screen reader users won't know this has appeared, even though this attracts some attention visually.
  Therefore, provide a specific announcement for screen reader users when the recommendation appears.

Differential Revision: https://phabricator.services.mozilla.com/D47718
2019-10-17 09:27:12 +00:00
Erica Wright
d89f3d213f Bug 1579974 - Add celebrating milestone toast when certain numbers of trackers are blocked. r=k88hudson,johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D47512
2019-10-15 19:30:11 +00:00
Cosmin Sabou
221e6003b0 Backed out changeset adbcc583862c (bug 1579974) for browser chrome failures on browser_asrouter_trigger_listeners.js 2019-10-15 00:12:26 +03:00
Erica Wright
1cd0490369 Bug 1579974 - Add celebrating milestone toast when certain numbers of trackers are blocked. r=k88hudson,johannh,fluent-reviewers,flod
test with:
`./mach run --temp-profile --setpref browser.newtabpage.activity-stream.asrouter.providers.cfr="{\"id\":\"cfr\",\"enabled\":true,\"type\":\"local\",\"localProvider\":\"CFRMessageProvider\",\"frequency\":{\"custom\":[{\"period\":\"daily\",\"cap\":10}]},\"categories\":[\"cfrAddons\",\"cfrFeatures\"],\"updateCycleInMs\":3600000}"`

for testing: Change `browser/components/newtab/lib/CFRPageActions.jsm` line 136, to `if (false)` instead of `if (resource)` or comment out that block. This is to force using the local ftl file.


  - you can use the newtab devtools, set `browser.newtabpage.activity-stream.asrouter.devtoolsEnabled=true`
 - change the pref `privacy.trackingprotection.cfr-milestone.milestone-achieved=1` and `privacy.trackingprotection.cfr-milestone.milestones="1, 5000, 10000, 25000, 50000, 100000, 500000"`
 - ensure at least one tracker has been saved in the database by visiting a tracking page and refreshing (this is so we can get the date it was saved from the database).
- open a new tab and click the wrench to the top right.
- change provider to "cfr" scroll down to find the milestone_message and click "show"
- I've now added a 24 hour timeout in `toolkit/components/antitracking/TrackingDBService.jsm` line 270 - you'll want to comment this out in order to see the popup.

Differential Revision: https://phabricator.services.mozilla.com/D47512
2019-10-14 20:06:41 +00:00
Liang-Heng Chen
860b1986ed Bug 1570631 - Part 3: implement doorhangers using CFR; r=k88hudson
#   add `OPEN_PROTECTION_PANEL` command
  #   add `type` trigger matching
  #   add `trackingProtection` trigger listener
  #   add socialtracker/fingerprinter/cryptominer doorhangers

Differential Revision: https://phabricator.services.mozilla.com/D43084
2019-09-11 09:16:49 +00:00