Commit Graph

3136 Commits

Author SHA1 Message Date
Richa Sharma
dec5980775 Bug 1683058 - Remove unused isPrivate from ext-browser.js. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D104055
2021-04-20 12:59:26 +00:00
Richa Sharma
9eed107905 Bug 1683058 - Change tabs API internals to support container access. r=robwu,rpl
Differential Revision: https://phabricator.services.mozilla.com/D100232
2021-04-20 12:59:26 +00:00
Florian Quèze
5f252c4411 Bug 1703583 - fix tests that keep waitForEvent or topicObserved promises pending, r=Gijs,zombie.
Differential Revision: https://phabricator.services.mozilla.com/D111116
2021-04-19 21:56:05 +00:00
Mark Striemer
f7abc5c252 Bug 1701691 - -moz-toolbar-prefers-color-scheme for dark theme detection r=desktop-theme-reviewers,emilio,harry
This adds a new @media query -moz-toolbar-prefers-color-scheme which works like
prefers-color-scheme but is set based on the browser theme rather than the OS
theme. The background colour of the toolbar is used to determine the theme
dark/light preference. This will be used for in-content common.css pages and
other UI elements that include that stylesheet in the browser-chrome through
shadow DOM.

The end result is that about: pages, infobars, and modals will now "match" the
browser theme (just light/dark mode, not LWT theming support).

Differential Revision: https://phabricator.services.mozilla.com/D111486
2021-04-18 22:22:49 +00:00
Emilio Cobos Álvarez
0e55bca38f Bug 1705757 - Move FrameLoader.print to BrowsingContext.print. r=nika,remote-protocol-reviewers,marionette-reviewers,extension-reviewers,zombie
This makes it trivial to choose the right BrowserParent to print a
browsing context, by removing the OuterWindowID / FrameLoader
indirections.

Differential Revision: https://phabricator.services.mozilla.com/D112412
2021-04-17 18:41:11 +00:00
Tomislav Jovanovic
9feb88f6ce Bug 1704772 - Fix extension context menu checkbox items and vertical alignment r=Gijs
1) Stop setting the image attribute for extension menu checkbox items.  They
don't work with the new custom chekbox appearance CSS, and not shown anyway.

2) When gutter is visible, stop padding menu items with an icon outside of it,
and use the gutter as a place for said icons.

3) Adjust margin for menu items with icons to align the text with the rest of
the menu items when the gutter is visible.

Differential Revision: https://phabricator.services.mozilla.com/D112267
2021-04-16 21:05:53 +00:00
Noemi Erli
069b9f637c Backed out changeset 1c9943dacbdb (bug 1701691) for causing failures in browser_toolbar_prefers_color_scheme.js CLOSED TREE 2021-04-16 05:29:10 +03:00
Mark Striemer
b41b10a8db Bug 1701691 - -moz-toolbar-prefers-color-scheme for dark theme detection r=desktop-theme-reviewers,emilio,harry
This adds a new @media query -moz-toolbar-prefers-color-scheme which works like
prefers-color-scheme but is set based on the browser theme rather than the OS
theme. The background colour of the toolbar is used to determine the theme
dark/light preference. This will be used for in-content common.css pages and
other UI elements that include that stylesheet in the browser-chrome through
shadow DOM.

The end result is that about: pages, infobars, and modals will now "match" the
browser theme (just light/dark mode, not LWT theming support).

Differential Revision: https://phabricator.services.mozilla.com/D111486
2021-04-16 00:43:46 +00:00
Csoregi Natalia
e7c2f99111 Backed out changeset 79c1392f7c43 (bug 1701691) for failures on browser_toolbar_prefers_color_scheme.js. CLOSED TREE 2021-04-15 22:18:09 +03:00
Mark Striemer
3c9f5fb249 Bug 1701691 - -moz-toolbar-prefers-color-scheme for dark theme detection r=desktop-theme-reviewers,emilio,harry
This adds a new @media query -moz-toolbar-prefers-color-scheme which works like
prefers-color-scheme but is set based on the browser theme rather than the OS
theme. The background colour of the toolbar is used to determine the theme
dark/light preference. This will be used for in-content common.css pages and
other UI elements that include that stylesheet in the browser-chrome through
shadow DOM.

The end result is that about: pages, infobars, and modals will now "match" the
browser theme (just light/dark mode, not LWT theming support).

Differential Revision: https://phabricator.services.mozilla.com/D111486
2021-04-15 18:17:07 +00:00
Mark Banner
c9be59b5ad Bug 1702454 - Re-enabling an add-on that overrides search engine parameters shouldn't cause a prompt. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D110562
2021-04-15 15:57:41 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
28db8aa186 Bug 1705216 - Use activateItem in browser/components/extensions/test/browser/browser_ext_tabs_executeScript_good.js. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D112097
2021-04-14 22:36:07 +00:00
Markus Stange
1ad1d61abd Bug 1704879 - Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu
Depends on D111979

Differential Revision: https://phabricator.services.mozilla.com/D111980
2021-04-14 22:24:31 +00:00
Markus Stange
07f0db0247 Bug 1704948 - Forward mouse button to menuitem command event. r=smaug,robwu
Differential Revision: https://phabricator.services.mozilla.com/D111956
2021-04-14 21:23:28 +00:00
Markus Stange
3ff223f072 Bug 1704875 - For now, keep synthesizing events on menus if a mouse button is set. r=robwu
This capability is used by browser_ext_menus_capture_secondary_click.js, which
checks that the mouse button is correctly propagated when clicking menu items.
Once bug 1704879 is fixed and activateItem supports specifying a mouse button,
we can revert this patch again.

Differential Revision: https://phabricator.services.mozilla.com/D111901
2021-04-13 20:22:39 +00:00
Markus Stange
8f4930ace0 Bug 1704875 - Don't synthesize events on menus in browser/components/extensions/test/browser/head.js. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D111673
2021-04-13 20:22:38 +00:00
Markus Stange
17abcf7c75 Bug 1704870 - Don't synthesize events on menus in browser/components/extensions/test/browser/browser_ext_user_events.js. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D111889
2021-04-13 17:54:07 +00:00
Mike Conley
9d603a717d Bug 1686315 - Fix up some tests to pass with content prompt subdialogs enabled or disabled. r=Gijs
Batch 1 of 2.

Differential Revision: https://phabricator.services.mozilla.com/D110342
2021-04-13 15:51:48 +00:00
Harry Twyford
d397578af3 Bug 1704474 - Remove pin/unpin page action context menu items. r=adw,fluent-reviewers,extension-reviewers,flod,zombie
The bug calls for these items to be hidden with JS, but they were going to be removed anyways post-Proton. The removal of some subtests in browser/base/content/test/pageActions tests is consistent with [this comment](https://searchfox.org/mozilla-central/rev/d9f6cded535d202a9ade4a530e653e659bcb5bbd/browser/base/content/test/pageActions/browser.ini#7), which says that were are removing that test coverage post-Proton anyways.

Differential Revision: https://phabricator.services.mozilla.com/D111713
2021-04-13 13:24:59 +00:00
Shane Caraveo
f259d96a14 Bug 1698619 fix updating homepage setting on updates and for localization r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D110717
2021-04-12 18:58:27 +00:00
Luca Greco
e61fdb8e1b Bug 1703889 - Ensure hidden extension pageAction are not visible in the urlbar overflow menu on Proton. r=mixedpuppy,mak
Differential Revision: https://phabricator.services.mozilla.com/D111423
2021-04-12 12:06:59 +00:00
Alexandre Poirot
347b511b9e Bug 1696374 - [devtools] Migrate from targetList to targetCommand in WebExt codebase. r=rpl,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D110389
2021-04-12 07:59:53 +00:00
Mark Striemer
52f4ff9a99 Bug 1702330 - Fix browser_ext_slow_script.js proton infobars r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D111357
2021-04-10 19:56:12 +00:00
Dorel Luca
275bea067f Backed out 9 changesets (bug 1702330) for Mochitest failures in toolkit/components/url-classifier/tests/mochitest/test_reporturl.html. CLOSED TREE
Backed out changeset f84605e6fc8b (bug 1702330)
Backed out changeset 79c63bf11b29 (bug 1702330)
Backed out changeset 5425a2312f6e (bug 1702330)
Backed out changeset d76516e0d07d (bug 1702330)
Backed out changeset 3b75ffae171a (bug 1702330)
Backed out changeset 4bb6ceb6adb3 (bug 1702330)
Backed out changeset 607be325b4e8 (bug 1702330)
Backed out changeset 4b345ea924cc (bug 1702330)
Backed out changeset c7f0de372b21 (bug 1702330)
2021-04-10 07:48:08 +03:00
Mark Striemer
a0e19e1c22 Bug 1702330 - Fix browser_ext_slow_script.js proton infobars r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D111357
2021-04-10 00:30:41 +00:00
Marco Bonardo
3977844bfa Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
Differential Revision: https://phabricator.services.mozilla.com/D110998
2021-04-09 18:20:21 +00:00
Dorel Luca
b2afaf19c1 Backed out 8 changesets (bug 1702330)for Browser-chrome failures in est/popups/browser_popup_blocker.js. CLOSED TREE
Backed out changeset b81511f8e157 (bug 1702330)
Backed out changeset 15f60f1d3f14 (bug 1702330)
Backed out changeset 809af1f94b4b (bug 1702330)
Backed out changeset 63cec3eadb4f (bug 1702330)
Backed out changeset b9964fb4dd70 (bug 1702330)
Backed out changeset 1e5ccb47056e (bug 1702330)
Backed out changeset 65faaeeb2339 (bug 1702330)
Backed out changeset e72fb8b52609 (bug 1702330)
2021-04-09 20:21:35 +03:00
Mark Striemer
d21a16de83 Bug 1702330 - Fix browser_ext_slow_script.js proton infobars r=mconley
Depends on D111356

Differential Revision: https://phabricator.services.mozilla.com/D111357
2021-04-09 15:26:27 +00:00
Cosmin Sabou
3063be1402 Backed out changeset bd396182f84a (bug 1703274) for causing wpt failures on shape-outside-shape-arguments-000.html. CLOSED TREE 2021-04-09 17:51:48 +03:00
Marco Bonardo
d5fff0d93b Bug 1703274 - Enable Proton Urlbar. r=jaws,extension-reviewers,zombie,rpl
Differential Revision: https://phabricator.services.mozilla.com/D110998
2021-04-09 11:05:17 +00:00
Luz De La Rosa
554e151b36 Bug 1703626 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser_ext_openPanel.js. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D111284
2021-04-08 19:55:15 +00:00
Marco Bonardo
42e690070d Bug 1703378 - Fix browser_ext_menus.js for proton urlbar. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D111271
2021-04-08 18:57:28 +00:00
Emma Malysz
3342351c34 Bug 1703379, fix failures in browser_ext_pageAction_click_types.js for proton urlbar pref r=mak,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D111172
2021-04-08 18:24:22 +00:00
Edgar Chen
6c7d23a661 Bug 1677334 - Part 3: Remove Mac-specific check for click event; r=Gijs
Now we won't dispatch click event at all when ctrl key is pressed on Mac, so we
don't need those Mac-specific checks.

This patch reverts part of https://hg.mozilla.org/mozilla-central/rev/69785d2dfbf2
and revise the tests accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D110609
2021-04-07 11:23:46 +00:00
Edgar Chen
261679ba79 Bug 1677334 - Part 2: Remove Mac-specific check for click event on xul frame; r=NeilDeakin
Now we won't dispatch click event at all when ctrl key is pressed on Mac, so we
don't need those Mac-specific checks.

This patch reverts part of https://hg.mozilla.org/mozilla-central/rev/d8726d18021e
and revise the tests accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D110608
2021-04-07 11:23:45 +00:00
Emilio Cobos Álvarez
82bda9ae67 Bug 1698132 - Convert proton pref checks from @supports rules to media features. r=Gijs
This means that dynamic changes will be handled correctly, we can use
StaticPrefs, etc.

Differential Revision: https://phabricator.services.mozilla.com/D110816
2021-04-05 20:48:05 +00:00
Luca Greco
79ea5f90e7 Bug 1702059 - Use PromptParent.openContentPrompt for about:addons options page modals. r=mconley,mixedpuppy
This is likely the low risky option:

- in this patch: identify the modal prompts triggered by extensions options page embedded in about:addons and use the openContenPrompt
  for them

- in a separate follow up issue (to be files), once we are ready to rip off the content prompt code
  (and the related about:config pref):
  - stop using openContentPrompt
  - remove the stack XUL element currently used in about:addons to host the content prompts
  - adapt the test case to the new prompts (e.g. using PromptTestUtils to wait for the modal prompt),

Differential Revision: https://phabricator.services.mozilla.com/D110530
2021-04-01 18:31:16 +00:00
Alexandru Michis
e7aca0ae80 Backed out changeset dfa41bd4757e (bug 1702059) for causing bc failures in browser_library_warnOnOpen.js
CLOSED TREE
2021-04-01 19:09:46 +03:00
Luca Greco
490de2d7e1 Bug 1702059 - Use PromptParent.openContentPrompt for about:addons options page modals. r=mconley,mixedpuppy
This is likely the low risky option:

- in this patch: identify the modal prompts triggered by extensions options page embedded in about:addons and use the openContenPrompt
  for them

- in a separate follow up issue (to be files), once we are ready to rip off the content prompt code
  (and the related about:config pref):
  - stop using openContentPrompt
  - remove the stack XUL element currently used in about:addons to host the content prompts
  - adapt the test case to the new prompts (e.g. using PromptTestUtils to wait for the modal prompt),

Differential Revision: https://phabricator.services.mozilla.com/D110530
2021-04-01 15:07:01 +00:00
Alexandre Poirot
d9628fcd91 Bug 1699493 - [devtools] Migrate WebExtInspectedWindow front to a command. r=nchevobbe,rpl
- implement the new "inspected-window" command
- move WebExtensionInspectedWindowFront implement to the command, making the front empty
- migrate tests to use the commands instead of front
- stop maintaining the current top level target in ExtensionParent.jsm, no longer have to use watchTargets
- stop creating a new descriptor on each new target
- instead only pull one new dedicated "commands" for WebExt (still in ExtensionParent.jsm)
- remove TabDescriptor isDevToolsExtensionContext as we no longer need anything special in the descriptor
- remove now unused methods on DevToolsShims (createWebExtensionInspectedWindowFront, createDescriptorForTabForWebExtension)
- remove the now unused TabDescriptorFactory.createDescriptorForTab's "forceCreationForWebextension" option, as CommandsFactory.forTab always instantiate a brand new commands
- migrate webext to use the command instead of front

Differential Revision: https://phabricator.services.mozilla.com/D108994
2021-04-01 10:31:43 +00:00
Shane Caraveo
b46aa07a7d Bug 1646338 ask to set as default again when enabling a search addon r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D107132
2021-03-29 15:42:23 +00:00
Rob Wu
f1d1a8b43f Bug 1695346 - Skip tabs amidst restoration in tabs.onUpdated r=Gijs,rpl
`swapBrowsersAndCloseOther` calls `SessionStore.setTabState`, but the
latter may trigger several tab events before the tab has fully been
restored. This results in duplicate tabs.onUpdated events and in
unexpected access to properties of the tab/browser (which in turn
triggers the reported bug).

Fix this specific case by ignoring events that happen while the tab is
amidst a restoration.

Differential Revision: https://phabricator.services.mozilla.com/D108259
2021-03-26 19:51:14 +00:00
Gijs Kruitbosch
600a3f1790 Bug 1701257 - fix panel radius on webextension browser and body with proton enabled, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D109909
2021-03-26 18:54:10 +00:00
Drew Willcoxon
36ed201877 Bug 1699227 - Support negative suggestedIndex values to allow indexes to be specified from the end of the list of urlbar results. r=mak
Given the result span problem described in bug 1699211 and bug 1699607,
currently there's no way for quick suggest to accurately specify the last index
as its suggested index.

Differential Revision: https://phabricator.services.mozilla.com/D109571
2021-03-25 20:32:52 +00:00
Kris Maglione
3dc8cdca3a Bug 1581859: Part 4f - Migrate to the native WebNavigation implementation. r=zombie
This migrates WebNavigation.jsm to use messages from PExtensionsParent
generated by the native WebNavigationContent class, and removes the now-unused
WebNavigationContent.js frame script.

Differential Revision: https://phabricator.services.mozilla.com/D103217
2021-03-25 19:47:04 +00:00
Csoregi Natalia
38f6ebd14b Backed out 10 changesets (bug 1581859) for causing hazard failures. CLOSED TREE
Backed out changeset 93fe6801a5e2 (bug 1581859)
Backed out changeset 0a33cb185fb3 (bug 1581859)
Backed out changeset 9ceaad6dab5b (bug 1581859)
Backed out changeset ee611f0839ca (bug 1581859)
Backed out changeset 4199963fe477 (bug 1581859)
Backed out changeset b4c5ace21b9e (bug 1581859)
Backed out changeset 6003469dc449 (bug 1581859)
Backed out changeset 826c62b783c0 (bug 1581859)
Backed out changeset e1d7851295fd (bug 1581859)
Backed out changeset 9796577af27a (bug 1581859)
2021-03-24 08:48:00 +02:00
Kris Maglione
456b0083c5 Bug 1581859: Part 4f - Migrate to the native WebNavigation implementation. r=zombie
This migrates WebNavigation.jsm to use messages from PExtensionsParent
generated by the native WebNavigationContent class, and removes the now-unused
WebNavigationContent.js frame script.

Differential Revision: https://phabricator.services.mozilla.com/D103217
2021-03-23 23:57:13 +00:00
Gijs Kruitbosch
caed5fb330 Bug 1699828 - put extension items at the top of the content menu on macOS, r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D109367
2021-03-23 11:40:24 +00:00
Cosmin Sabou
7493b9124d Backed out 10 changesets (bug 1581859) for causing hazard failures on ExtensionsParent.cpp.
Backed out changeset 6020ec7d7f32 (bug 1581859)
Backed out changeset 07901e457839 (bug 1581859)
Backed out changeset e23389fc98b5 (bug 1581859)
Backed out changeset 4287eebc2c77 (bug 1581859)
Backed out changeset eeff6f501cfc (bug 1581859)
Backed out changeset 22db36f7d16d (bug 1581859)
Backed out changeset 16831d45d0ed (bug 1581859)
Backed out changeset 816643de7694 (bug 1581859)
Backed out changeset 6fd5aa7895e3 (bug 1581859)
Backed out changeset 2b68d2eee18e (bug 1581859)
2021-03-23 05:48:27 +02:00