Commit Graph

2344 Commits

Author SHA1 Message Date
Kris Maglione
c1116675db Bug 1594572: Schedule worker deletion when primary runnable fails. r=asuth
If we try to start a worker too close to shutdown, the main runnable for its
thread runs after shutdown has begun, bails out early trying to create a
BackgroundChild for its thread. Unlike bail-outs in WorkerPrivate::DoRunLoop,
though, nothing winds up scheduling the deletion of the worker after it
returns, and afterwards the worker is stuck forever in a pending state.
Attempts to shut it down from the main thread just dispatch an impotent
notification to be processed by the workers main event loop (which, of course,
will not ever happen).

This patch fixes the behavior of WorkerThreadPrimaryRunnable to always call
ScheduleDeletion when it exits, rather than only doing so when it succeeds
in entering the worker's main loop.

Differential Revision: https://phabricator.services.mozilla.com/D73134
2020-04-30 03:52:56 +00:00
Daniel Varga
b2d89104a2 Backed out changeset 8a0b81f6263e (bug 1606862) for causing devtools failures at devtools/client/framework/test/browser_toolbox_toolbar_reorder_with_extension.js
CLOSED TREE
2020-04-30 06:05:20 +03:00
Shane Caraveo
f19f5b74d5 Bug 1606862 support devtools as an optional extension permission r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D71829
2020-04-30 01:50:34 +00:00
Dorel Luca
047d3a2819 Backed out changeset 74dce6390e5e (bug 1606862) for Xpcshell failures in extensions/test/xpcshell/test_ext_startup_perf.js. CLOSED TREE 2020-04-30 04:17:57 +03:00
Shane Caraveo
12de1703e2 Bug 1606862 support devtools as an optional extension permission r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D71829
2020-04-29 23:28:27 +00:00
aarushivij
265661a324 Bug 1634013 - Remove the browser.tabs.multiselect pref r=dao
Differential Revision: https://phabricator.services.mozilla.com/D73074
2020-04-29 20:52:32 +00:00
Andrew McCreight
47d70400e1 Bug 1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70076
2020-04-28 20:11:27 +00:00
Narcis Beleuzu
584fd4ea26 Bug 1498706 - Fix disable patch. CLOSED TREE 2020-04-28 21:16:25 +03:00
Andreea Pavel
eeb9e6755d Bug 1498706 - temporarily disable browser_ext_port_disconnect_on_crash.js on win10 64bits debug r=gsvelto,egao
Differential Revision: https://phabricator.services.mozilla.com/D72769
2020-04-28 07:08:23 +00:00
Tom Schuster
1ed87ac06e Bug 1632990 - Allow WebExtensions to clear ServiceWorkers by hostname. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D72451
2020-04-28 13:30:17 +00:00
Tom Schuster
9798be9ddc Bug 1551301 - Allow WebExtensions to clear IndexedDB by hostname. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D72450
2020-04-28 13:30:09 +00:00
Jean-Yves Avenard
73124de02c Bug 1633319 - Wait for load before resolving promise. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D72593
2020-04-27 22:42:25 +00:00
Shane Caraveo
7a6b1c9aa1 Bug 1444294 implement browser.permissions onAdded/Removed r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D71231
2020-04-27 16:20:12 +00:00
Atique Ahmed Ziad
6291a5d771 Bug 1603796 - support tabs.goForward and tabs.goBack r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D62964
2020-04-26 11:24:47 +00:00
Matt Woodrow
571e578bb0 Bug 1602318 - Fix race in browser_ext_tabs_onUpdated by installing the listener before adding the new tab. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D70622
2020-04-26 00:51:25 +00:00
Emilio Cobos Álvarez
028c627b91 Bug 1632641 - Fix flakyness in browser_ext_tabs_zoom.js r=aswan
This test was already a bit flaky it seems, see bug 1630399 for example.

But it has become much worse with my Fission zoom changes in bug 1612068, which
made the FullZoomChange events that this API relies on more async.

Properly wait for an event for the right tab instead of assuming that the last
zoom event was for the tab we happen to be waiting on.

Differential Revision: https://phabricator.services.mozilla.com/D72209
2020-04-24 14:10:37 +00:00
Cosmin Sabou
2312f42a0c Backed out 20 changesets (bug 1602318) for causing multiple types of failures. CLOSED TREE
Backed out changeset f71e3eff7a8c (bug 1602318)
Backed out changeset 0e0bdebf223b (bug 1602318)
Backed out changeset 44e82f4339a1 (bug 1602318)
Backed out changeset 5f341ebd8591 (bug 1602318)
Backed out changeset 088ea9d20617 (bug 1602318)
Backed out changeset 5de6321939f2 (bug 1602318)
Backed out changeset f5742e84912b (bug 1602318)
Backed out changeset 13bec3079540 (bug 1602318)
Backed out changeset 6c24ba022911 (bug 1602318)
Backed out changeset 5d0fc0102a7f (bug 1602318)
Backed out changeset fc4efd11e643 (bug 1602318)
Backed out changeset 028bd63e710d (bug 1602318)
Backed out changeset 21ad350f9617 (bug 1602318)
Backed out changeset 8f27319f2c34 (bug 1602318)
Backed out changeset db2832973382 (bug 1602318)
Backed out changeset 1756c7584491 (bug 1602318)
Backed out changeset 983e5a9abe02 (bug 1602318)
Backed out changeset a1b9429b3298 (bug 1602318)
Backed out changeset 7d1c0d968a09 (bug 1602318)
Backed out changeset a3b056ec6be3 (bug 1602318)
2020-04-24 11:15:12 +03:00
Matt Woodrow
590555fedb Bug 1602318 - Fix race in browser_ext_tabs_onUpdated by installing the listener before adding the new tab. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D70622
2020-04-24 06:57:50 +00:00
Daisuke Akatsuka
1a114dd5b6 Bug 1604211: Add test of target-switching for inspectedWindow. r=rpl
Depends on D67438

Differential Revision: https://phabricator.services.mozilla.com/D67439
2020-04-24 04:37:05 +00:00
Harry Twyford
c2c94fda74 Bug 1626946 - Remove search suggestions that dupe a search history result. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D71094
2020-04-22 17:41:00 +00:00
Noemi Erli
9244d47cbd Backed out 19 changesets (bug 1602318) for causing multiple failures
Backed out changeset 4b3345b2e33b (bug 1602318)
Backed out changeset 7240b27afe28 (bug 1602318)
Backed out changeset a7091729d8c9 (bug 1602318)
Backed out changeset e496ab6c0857 (bug 1602318)
Backed out changeset 184da6309f0c (bug 1602318)
Backed out changeset 79b540f8619d (bug 1602318)
Backed out changeset b298015ee960 (bug 1602318)
Backed out changeset 6d0783cd5e01 (bug 1602318)
Backed out changeset cbc308486b17 (bug 1602318)
Backed out changeset 94142944fb54 (bug 1602318)
Backed out changeset 7c1eeb299b78 (bug 1602318)
Backed out changeset 0fc27502503a (bug 1602318)
Backed out changeset 0fc27c2e09d9 (bug 1602318)
Backed out changeset b5e2aa4741b2 (bug 1602318)
Backed out changeset 57d568114c5a (bug 1602318)
Backed out changeset 8f7360d827dc (bug 1602318)
Backed out changeset 78930a97c2df (bug 1602318)
Backed out changeset 8015780587cd (bug 1602318)
Backed out changeset bc9da03cb3a3 (bug 1602318)
2020-04-21 03:46:41 +03:00
Matt Woodrow
576a5741bc Bug 1602318 - Fix race in browser_ext_tabs_onUpdated by installing the listener before adding the new tab. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D70622
2020-04-20 23:01:09 +00:00
Ciure Andrei
af8a055d98 Backed out changeset 894ebe92bdae (bug 1628052) for causing failure increase in bug 1358898 CLOSED TREE 2020-04-17 07:20:16 +03:00
William Durand
9280636ffa Bug 1613796 - Add test case to verify that browser.permissions.request() resolves in the expected order. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D69226
2020-04-16 19:37:44 +00:00
shweta
8b76762c98 Bug 1578710 Bug - 1578710 Don't show persistent storage permission on moz-extension pages. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D67780
2020-04-14 07:35:09 +00:00
Andrew McCreight
9a393dc4ee Bug 1628052 - Remove uses of dom.ipc.keepProcessesAlive.webIsolated.perOrigin to fix leaks. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D70076
2020-04-13 20:11:50 +00:00
Brindusan Cristian
adf8f81967 Backed out changeset 4fd31338db03 (bug 1603796) for mochitest failures at test_ext_all_apis.html. CLOSED TREE 2020-04-13 20:36:19 +03:00
Atique Ahmed Ziad
8f7dc814e2 Bug 1603796 - support tabs.goForward and tabs.goBack r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D62964
2020-04-13 15:43:53 +00:00
Dão Gottwald
3961c7018e Bug 1627988 - Remove the browser.urlbar.update1.view.stripHttps pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70208
2020-04-09 13:54:19 +00:00
William Durand
c283359ee5 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831
2020-04-08 14:18:53 +00:00
Edgar Chen
c03523ed23 Bug 1615732 - Don't dispatch xul command event on Mac if it is from mouse event with ctrl key is pressed; r=Gijs,NeilDeakin
Depends on D68775

Differential Revision: https://phabricator.services.mozilla.com/D68735
2020-04-06 23:59:53 +00:00
Cosmin Sabou
2b8f829371 Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)
2020-04-06 23:49:58 +03:00
Edgar Chen
47744efb00 Bug 1615732 - Don't dispatch xul command event on Mac if it is from mouse event with ctrl key is pressed; r=Gijs,NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D68735
2020-04-06 13:15:30 +00:00
Narcis Beleuzu
6a406d8d46 Backed out changeset a315e85c5376 (bug 1613796) for bc failures on browser_file_xpi_no_process_switch.js . CLOSED TREE 2020-04-04 05:38:34 +03:00
William Durand
e8684f1fce Bug 1613796 - Return false when browser.permissions.request isn't called on the active tab. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D69226
2020-04-03 12:36:01 +00:00
Henri Sivonen
c427b1f0aa Bug 1613590 - Re-enable browser_ext_search.js for Fission. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D67309
2020-03-18 17:44:17 +00:00
Julian Descottes
edb7e1459b Bug 1625495 - Remove devtools/shared/client folder r=daisuke,ochameau,nchevobbe
Depends on D68599

This changeset moves devtools-client.js and constants.js to devtools/client and removes devtools/shared/client

Differential Revision: https://phabricator.services.mozilla.com/D68600
2020-03-31 08:36:29 +00:00
Drew Willcoxon
dc8efc33d5 Bug 1616752 - Part 2: Add payload schemas for each result type and validate payloads against them. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D64300
2020-03-26 15:27:12 +00:00
ajitesh
4e0a0fa3dd Bug 1421039 - Remove duplicate extension icons r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D63288
2020-03-23 15:24:24 +00:00
Tomislav Jovanovic
ccd6137102 Bug 1624124 - Port.sender should include a frameId r=aswan
Regressions from bug 1316748.  We had tests for sender.frameId, but they
were all for runtime.sendMessage() and friends.  Unfortunatelly, bug 1316748
was split to only deal with Ports, so I sdded some tests to cover this case
as well.

Differential Revision: https://phabricator.services.mozilla.com/D67743
2020-03-21 18:05:13 +00:00
Shane Caraveo
46b6dd47a6 Bug 1622104 prevent addon content script compilation in parent process r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D66672
2020-03-20 20:14:43 +00:00
Christoph Kerschbaumer
b96b600470 Bug 1188538: Ensure every protocol handler sets a valid security flag. r=bholley,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D67496
2020-03-20 08:25:18 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Dão Gottwald
ef321fc334 Bug 1539838 - Move SetPageProxyState into UrlbarInput. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D66288
2020-03-12 18:15:58 +00:00
Harry Twyford
ea7e69a8fa Bug 1617333 - Show appropriately-sized favicons in the Urlbar for Top Sites with history visits. r=mak,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D64653
2020-03-12 13:31:19 +00:00
Mike Conley
527cf6e02a Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 03:10:29 +00:00
Dorel Luca
e6edb45133 Backed out changeset 9160f18bc24e (bug 1619992) for XPCshell failures in newtab/test/xpcshell/test_AboutNewTab.js 2020-03-11 04:20:31 +02:00
Mike Conley
f431383314 Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 01:25:31 +00:00
Daniel Varga
8e71e79267 Backed out changeset 52947d2e8692 (bug 1617333) for causing xpcshell failures at gre/modules/NewTabUtils.jsm
CLOSED TREE
2020-03-10 23:04:49 +02:00
Harry Twyford
5d904fb2a6 Bug 1617333 - Show appropriately-sized favicons in the Urlbar for Top Sites with history visits. r=mak,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D64653
2020-03-10 14:17:16 +00:00