corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
722,410 Commits 1 Branch 0 Tags
a13bccff29f0adaad5b24ebce13e68422350b51c
Commit Graph

110 Commits

Author SHA1 Message Date
Katherine Patenio
7e91fcdaf6 Bug 1740840 - use mimeinfo content type to fix downloads intermittent alwaysOpenSimilarFiles. r=Gijs,mtigley 
Patch addresses intermittent issue with the context menu item alwaysOpenSimilarFiles for the Downloads Panel by using the content type provided by MimeService, rather than relying on download instance. Not only does this ensure that content type exists, but it happens to also have the benefit of making alwaysOpenSimilarFiles available to more file types that can be supported. browser_downloads_panel_context_menu.js was modified to register mimeInfo and add more test cases for visibility with application/octet-stream.

Differential Revision: https://phabricator.services.mozilla.com/D131881
 2021-12-01 17:40:00 +00:00
Ava Katushka ava8katushka
69c0056122 Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D123943
 2021-11-23 17:13:39 +00:00
Narcis Beleuzu
b8863df7b0 Backed out changeset a9a15832f816 (bug 1725354) for bc failures on browser_download_privatebrowsing.js 2021-11-05 23:22:42 +02:00
Ava Katushka ava8katushka
cc523e31bb Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D123943
 2021-11-05 20:12:43 +00:00
Cristian Tuns
a4c3a9bab0 Backed out changeset b855af57f71a (bug 1725354) for causing mochitest failures on test_third_party_iframes.html CLOSED TREE 2021-11-03 12:45:48 -04:00
Ava Katushka ava8katushka
3ed44717ab Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D123943
 2021-11-03 15:31:13 +00:00
Katherine Patenio
78d2b57bcc Bug 1731086 - Add a new context menu item for setting the mimetype entry from about:preferences. r=mtigley,fluent-reviewers,jaws,flod 
Differential Revision: https://phabricator.services.mozilla.com/D127592
 2021-10-21 16:28:42 +00:00
Lebar
52049fd53d Bug 1729447 - Changed downloads context menu string for non-Mac from "Open Containing Folder" to "Show in Folder" to align terminology. r=mak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D128538
 2021-10-19 15:15:26 +00:00
Gijs Kruitbosch
4d8cc3825a Bug 1715001 - rehash downloads markup and tighten up spacing inside downloads item, r=mhowell 
This addresses a few things:

- it doesn't really make sense to have 2 different badge implementations
  for the library and the panel. Just use the panel one for the library.
- remove the old badge itself
- remove a bunch of old CSS to do with the old badge
- rename the 'new' badge now it isn't new anymore
- share the badge styling between the 'all downloads' view (about:downloads
  and the library) and the downloads panel
- use the downloadMainArea for hover styling of the non-button bit, and
  update the JS to set the downloadHoveringButton class appropriately for
  this new reality.
- tighten up hover styles so we don't get a weird double hover for the
  blocked download case
- tighten up margins of the button, badge and progress meter (see also
  https://bugzilla.mozilla.org/show_bug.cgi?id=1725837). This is also
  helped by the fact that the renaming means we now properly hide the
  badge image when the download isn't blocked; the CSS at
  https://searchfox.org/mozilla-central/rev/a1ab92e0b16631465a946b300493e75be0eacc37/browser/components/downloads/content/downloads.css#44-47
  didn't apply to this badge pre-patch.

Differential Revision: https://phabricator.services.mozilla.com/D123169
 2021-09-02 09:18:12 +00:00
Ava Katushka ava8katushka
f034da9cb3 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D118328
 2021-07-09 13:20:29 +00:00
Csoregi Natalia
4db31d3804 Backed out changeset a81a827f54fb (bug 1711053) for failures on browser_download_opens_on_click.js. CLOSED TREE 2021-07-07 13:20:05 +03:00
Ava Katushka ava8katushka
688250a426 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D118328
 2021-07-07 09:13:28 +00:00
Alexandru Michis
fbed18af9a Backed out changeset c204c9f05b2e (bug 1711053) for causing failures in browser_download_opens_on_click.js 
CLOSED TREE
 2021-07-05 19:22:36 +03:00
Ava Katushka ava8katushka
8dd4aee5b2 Bug 1711053 - Open file after download if user clicked on downloading file. r=mtigley,flod,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D118328
 2021-07-05 14:32:01 +00:00
julianwels
af07a2b28d Bug 1708278 - Remove verdict-attribute from unblocked downloads and prevent verdict to re-appear after restart. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D113871
 2021-04-30 16:04:01 +00:00
Gijs Kruitbosch
57fa00aa52 Bug 1707652 - fix display of download context menu items with macOS native menus, r=mstange 
Differential Revision: https://phabricator.services.mozilla.com/D113544
 2021-04-27 19:37:14 +00:00
prathikshaprasadsuman
d6b3cb734a Bug 1703014 - Update badge placement and icons in the downloads panel to match proton styles. r=mconley,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D111409
 2021-04-13 18:48:13 +00:00
prathikshaprasadsuman
4a2e4e5004 Bug 1703014 - Update layout in the downloads panel main view to match proton styles. r=mconley,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D111132
 2021-04-13 18:48:11 +00:00
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 18:11:18 +00:00
Sebastian Streich
ef9e395b00 Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs 
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
 2020-12-18 15:30:33 +00:00
Butkovits Atila
8480457d60 Backed out changeset 234ae5cb0ff8 (bug 1676221) for causing leaks. CLOSED TREE 2020-12-17 10:54:31 +02:00
Sebastian Streich
0515cda67b Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs 
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
 2020-12-16 22:55:12 +00:00
Noemi Erli
772a084918 Bug 1660969 - Lint failure fix r=fix CLOSED TREE 2020-11-04 15:59:59 +02:00
Sebastian Streich
ef9a64d45d Bug 1660969 - Enable unblock UI for mixed-content-blocked Downloads r=Gijs,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D88721
 2020-11-04 13:21:36 +00:00
Dorel Luca
10c14ee19b Backed out changeset 5ea7a34f266c (bug 1660969) for Browser-chrome failures in browser_test_mixed_content_download.js. CLOSED TREE 2020-10-29 18:37:39 +02:00
Sebastian Streich
64d4bb7213 Bug 1660969 - Enable unblock UI for mixed-content-blocked Downloads r=Gijs,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D88721
 2020-10-29 15:21:46 +00:00
Mihai Alexandru Michis
707be0a6dc Backed out changeset 673e27ce5abb (bug 1660969) for causing bc failures in browser_test_mixed_content_download.js 
CLOSED TREE
DONTBUILD
 2020-10-28 21:14:25 +02:00
Sebastian Streich
a46ed77ac1 Bug 1660969 - Enable unblock UI for mixed-content-blocked Downloads r=Gijs,ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D88721
 2020-10-28 17:07:59 +00:00
Gijs Kruitbosch
3c3ddc0269 Bug 827010 - avoid main-thread IO from DownloadsViewUI.jsm and use IOUtils to get file size and existence, r=florian 
Differential Revision: https://phabricator.services.mozilla.com/D91068
 2020-09-28 23:35:43 +00:00
Sebastian Streich
ab0ade1b55 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs 
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
 2020-08-24 15:29:23 +00:00
Cosmin Sabou
91b9b823f3 Backed out changeset 388c153da388 (bug 1656296) for causing default process leaks. CLOSED TREE 2020-08-19 21:58:03 +03:00
Sebastian Streich
e4d6eb9fbd Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs 
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
 2020-08-19 17:58:57 +00:00
Narcis Beleuzu
54eb459a55 Backed out changeset 1b7eb33c8ec9 (bug 1656296) for bc failure on browser_test_mixed_content_download.js . CLOSED TREE 2020-08-19 16:39:33 +03:00
Sebastian Streich
8fbbb0aa80 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs 
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
 2020-08-19 12:45:55 +00:00
Adam Gashlin
349bf16d98 Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D86652
 2020-08-17 21:24:45 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE 
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
 2020-08-18 00:18:32 +03:00
Adam Gashlin
fcc30dab7f Bug 1639067 part 3 - Extend "Open In System Viewer" from PDF to all viewable internally. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D86652
 2020-08-17 19:14:00 +00:00
Sam Foster
efccb3cc42 Bug 1657796 - Ensure downloads requested to open with system viewer always do. r=Gijs 
* Check both the useSystemViewer flag and the preferredAction for that mime-type when deciding to not open PDFs into pdf.js
* Don't set alwaysAskBeforeHandling to true when toggling off the "Always open in system viewer" context menu item.

Differential Revision: https://phabricator.services.mozilla.com/D86992
 2020-08-14 09:13:05 +00:00
Gijs Kruitbosch
b47b4d62d7 Bug 1641487, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D86761
 2020-08-12 16:50:31 +00:00
Sam Foster
7a6bf11a8c Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D81767
 2020-07-01 22:27:51 +00:00
Sam Foster
19f6f1121e Bug 1639069 - Add download context menu items to 'Use' and 'Always use' the system viewer to open the download. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D79396
 2020-06-25 22:19:37 +00:00
Sam Foster
89f45f13cf Bug 1642431 - Default to using a new tab when opening downloaded PDFs in the browser. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D79951
 2020-06-18 15:39:37 +00:00
Sam Foster
dbcd872d8e Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D75870
 2020-05-29 07:16:54 +00:00
Razvan Maries
030be31f02 Backed out 2 changesets (bug 1638156) for perma failures on browser_pdfjs_preview.js. CLOSED TREE 
Backed out changeset c5c3da72080f (bug 1638156)
Backed out changeset da0e27f7f17a (bug 1638156)
 2020-05-28 05:01:13 +03:00
Sam Foster
0becf30a8f Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D75870
 2020-05-28 01:13:19 +00:00
Sam Foster
0af6b6c35b Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D75435
 2020-05-18 17:30:00 +00:00
Noemi Erli
80613259fb Backed out 3 changesets (bug 1191591) for causing newtab failures 
Backed out changeset bd59c10af492 (bug 1191591)
Backed out changeset 3ff8cc8dd4b7 (bug 1191591)
Backed out changeset c6b3783367f6 (bug 1191591)
 2020-05-16 01:57:34 +03:00
Sam Foster
48546bf4cf Bug 1191591 - Consolidate download opening to use download.launch() via a DownloadsCommon.openDownload helper. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D75435
 2020-05-15 20:42:03 +00:00