Commit Graph

425 Commits

Author SHA1 Message Date
Jared Wein
09cc1da1b4 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D96763
2020-11-12 21:23:52 +00:00
emcminn
068da3c345 Bug 1669483 - Restore keyboard navigation to WhatsNewPanel footer r=Jamie,andreio
`oncommand` has been replaced with `onclick` for the checkbox in the WhatsNewPanel footer. `oncommand` was
causing the checkbox state to get out of sync with the pref when the keyboard was used. Since PanelMultiView treats
'enter' and 'space' presses as click events, using `onclick` gives us keyboard navigation while keeping the
pref in sync.

Differential Revision: https://phabricator.services.mozilla.com/D94454
2020-11-02 18:42:38 +00:00
Micah Tigley
a9a0aa5aea Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93698
2020-10-28 22:37:51 +00:00
Kartikaya Gupta
89b226f97b Bug 1660054 - Hook up the zoom-reset action to also reset APZ/scaling zoom. r=Gijs,nika,botond
The goal here is to hook up the ctrl+0 keyboard shortcut to reset the scaling
zoom applied by pinch gestures (on touchscreen or trackpad), in addition to
resetting the reflow zoom (aka full zoom). This patch also makes other mechanisms
to reset the reflow zoom (e.g. clicking on the "100%" label in the hamburger menu)
also reset scaling zoom, which I think makes sense for consistency.

Most of this patch is just plumbing, but I'm unfamiliar with these codepaths
so requesting review from relevant owners to make sure it's sane.

Differential Revision: https://phabricator.services.mozilla.com/D94624
2020-10-28 22:48:57 +00:00
Mihai Alexandru Michis
b7b44e485f Backed out changeset 952da6bff887 (bug 1660054) for causing bc failures in browser_test_reset_scaling_zoom.js
CLOSED TREE
2020-10-28 23:00:15 +02:00
Kartikaya Gupta
f91467938d Bug 1660054 - Hook up the zoom-reset action to also reset APZ/scaling zoom. r=Gijs,nika,botond
The goal here is to hook up the ctrl+0 keyboard shortcut to reset the scaling
zoom applied by pinch gestures (on touchscreen or trackpad), in addition to
resetting the reflow zoom (aka full zoom). This patch also makes other mechanisms
to reset the reflow zoom (e.g. clicking on the "100%" label in the hamburger menu)
also reset scaling zoom, which I think makes sense for consistency.

Most of this patch is just plumbing, but I'm unfamiliar with these codepaths
so requesting review from relevant owners to make sure it's sane.

Differential Revision: https://phabricator.services.mozilla.com/D94624
2020-10-28 19:14:18 +00:00
Gijs Kruitbosch
b3b0b65d9e Bug 1673388 - use keepbroadcastattributeswhencustomizing for the print button to make it behave better wrt customize mode, r=mconley
Embarrassingly, I forgot I added this in bug 1388990 when we had similar issues
with the back/forward buttons. It's a more straightforward solution for this
problem.

Differential Revision: https://phabricator.services.mozilla.com/D94751
2020-10-26 20:51:04 +00:00
Dorel Luca
b959dcf2b1 Backed out 2 changesets (bug 1664053) for Browser-chrome failures. CLOSED TREE
Backed out changeset 7ead316c420d (bug 1664053)
Backed out changeset 7ae93e1c8b86 (bug 1664053)
2020-10-26 20:08:38 +02:00
Micah Tigley
2171053b5c Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93698
2020-10-22 02:04:24 +00:00
Jared Wein
64176c986d Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-26 02:32:07 +00:00
Robert Helmer
6965fc86bc Bug 1659692 - add tooltip to Ion icon r=maxxcrawford,flod
Differential Revision: https://phabricator.services.mozilla.com/D94511
2020-10-23 18:39:44 +00:00
Mihai Alexandru Michis
dc6c624799 Backed out changeset ba261cf25651 (bug 727668) for causing marionette failures in test_screenshot.py
CLOSED TREE
2020-10-22 06:13:54 +03:00
Jared Wein
8debd64190 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-21 19:20:20 +00:00
Gijs Kruitbosch
005c43d234 Bug 1665442 - show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D93618
2020-10-20 15:29:30 +00:00
Narcis Beleuzu
8c2c851d6a Backed out 1 changesets (bug 727668) for bc failures on browser_aboutNewTab_bookmarksToolbar.js . CLOSED TREE
Backed out changeset 5b6a14b4e16e (bug 727668)
2020-10-19 21:19:17 +03:00
Jared Wein
dae078ac27 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-19 16:38:17 +00:00
Emilio Cobos Álvarez
442128cc7c Bug 1670410 - Bookmarks popup should have type="arrow" so that it receives popuppositioned events. r=Gijs
Otherwise it won't position its arrow properly.

Differential Revision: https://phabricator.services.mozilla.com/D93199
2020-10-12 11:06:11 +00:00
Michael Kaply
a8789bb2df Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-10-06 20:13:00 +00:00
Emma Malysz
2eee89c2e5 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-06 00:40:51 +00:00
Dorel Luca
43bce7e150 Backed out changeset d4c1abcfbba0 (bug 1634042) for Browser-chrome failures in browser/base/content/test/touch/browser_menu_touch.js. CLOSED TREE 2020-10-02 02:50:31 +03:00
Emma Malysz
a3dbc35859 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-01 15:00:55 +00:00
Csoregi Natalia
f3fc97b3bf Backed out changeset 0798aa08c2cb (bug 1634042) for failures on browser_menu_touch.js. CLOSED TREE 2020-09-30 09:47:33 +03:00
Emma Malysz
6737036f67 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-09-29 22:09:09 +00:00
Razvan Maries
363e32f089 Backed out changeset 2b2e72856dc1 (bug 1665237) for perma failures on browser_popupNode.js. CLOSED TREE 2020-09-25 06:03:12 +03:00
Michael Kaply
b7150182a5 Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-09-22 20:08:17 +00:00
Emma Malysz
fee1a6dc86 Bug 1634042, Part 1: migrate page action titles to fluent. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D87822
2020-09-24 17:29:16 +00:00
Robert Helmer
f8ab94d122 Bug 1665957 - rename Pioneer to Ion r=maxxcrawford,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D90749
2020-09-23 22:10:16 +00:00
Narcis Beleuzu
f4ece98227 Backed out changeset 8dab8ca19839 (bug 1665957) for bc failures on browser_ion_ui.js . CLOSED TREE 2020-09-23 09:00:43 +03:00
Robert Helmer
29afb33994 Bug 1665957 - rename Pioneer to Ion r=maxxcrawford,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D90749
2020-09-22 18:26:16 +00:00
Csoregi Natalia
eabe4b0ac6 Backed out changeset 034825cf1c71 (bug 1665237) for multiple failures e.g. browser_1007336_lwthemes_in_customize_mode.js. CLOSED TREE 2020-09-22 21:48:53 +03:00
Michael Kaply
45173ac187 Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-09-22 15:51:42 +00:00
Gijs Kruitbosch
ff8194eb68 Bug 1663879 - migrate fullscreen and pointer lock warnings to fluent, r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D89675
2020-09-12 20:09:26 +00:00
Michael Kaply
2cf31c0507 Bug 1498688 - Add ManagedBookmarks policy. r=fluent-reviewers,emalysz,Standard8,flod
Differential Revision: https://phabricator.services.mozilla.com/D76009
2020-09-08 20:09:35 +00:00
Bryce Seager van Dyk
572fa719bf Bug 1649532 - Port DecoderDoctor notifications to fission. r=Gijs
Port handling of DecoderDoctor notifications for fission. This is done by moving
the observing of 'decoder-doctor-notification' from browser-media.js to fission
friendly actors.

As browser-media.js had only code related to this patch left it is removed along
with references to it. Same with ContentObservers.js.

Differential Revision: https://phabricator.services.mozilla.com/D88322
2020-08-28 18:34:24 +00:00
Emma Malysz
5418842e99 Bug 1661618, update shortcut in app menu and toolbar tip for the toolbarbutton r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D88521
2020-08-31 19:14:11 +00:00
James Teh
1ec28fb5df Bug 1660365: Fix a11y dialog role placement for the Print modal. r=Gijs
Previously, the browser dialogTemplate contained role="dialog" and the Print modal body had no role.
This caused screen readers to extraneously report "dialog, Print grouping".
Dialogs presented with commonDialog.xhtml (e.g. using Services.prompt.alertBC) did have the dialog role on the body, so screen readers would report "dialog, {dialogTitle} dialog".

To fix this, remove role="dialog" from dialogTemplate.
Instead, SubDialog now sets role="dialog" on the dialog document when it loads.
Now, screen readers report just "Print dialog" and "{dialogTitle} dialog", respectively.

Differential Revision: https://phabricator.services.mozilla.com/D87977
2020-08-24 12:07:50 +00:00
Mark Striemer
a1e4f2c59e Bug 1654962 - Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Differential Revision: https://phabricator.services.mozilla.com/D86037
2020-08-24 21:00:36 +00:00
Mihai Alexandru Michis
62de909fbe Backed out changeset 80e6be24260d (bug 1654962) for causing bc failures in browser_modal_print.js
CLOSED TREE
2020-08-21 17:47:07 +03:00
Mark Striemer
a7a11db244 Bug 1654962 - Size tab modal print UI to available window size r=Gijs,sfoster,emalysz,pbz
Differential Revision: https://phabricator.services.mozilla.com/D86037
2020-08-21 13:55:15 +00:00
Mark Striemer
556163b570 Bug 1653317 - Use TabDialogBox for tab modal print UI r=Gijs,pbz
Differential Revision: https://phabricator.services.mozilla.com/D86597
2020-08-19 20:04:52 +00:00
pbz
29efc4cbbb Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-17 10:26:22 +00:00
Bogdan Tara
2d98b068bc Backed out 7 changesets (bug 1650795, bug 1651958) for test_master_password.html failures CLOSED TREE
Backed out changeset 4812945bfaf2 (bug 1651958)
Backed out changeset a3f28fadcdf3 (bug 1651958)
Backed out changeset 70a61c971427 (bug 1651958)
Backed out changeset e7194e7e7ecc (bug 1651958)
Backed out changeset 7e66e5431ef7 (bug 1651958)
Backed out changeset a6c58935e1d8 (bug 1650795)
Backed out changeset b79f254df4cb (bug 1650795)
2020-08-14 23:29:33 +03:00
pbz
c15f35c088 Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-14 11:31:04 +00:00
Csoregi Natalia
ba5782273e Backed out 7 changesets (bug 1650795, bug 1651958) for failures on test_modal_prompts.html . CLOSED TREE
Backed out changeset 505f46d2cd97 (bug 1651958)
Backed out changeset f7893f4dc092 (bug 1651958)
Backed out changeset 54ea7a160e0d (bug 1651958)
Backed out changeset c2bc9c8d2e97 (bug 1651958)
Backed out changeset 247880941893 (bug 1651958)
Backed out changeset c8945eb14177 (bug 1650795)
Backed out changeset fc4dcfaf3938 (bug 1650795)
2020-08-14 00:02:08 +03:00
Emma Malysz
e6daef241d Bug 1653323: show print preview progress in the print preview browser when preview is being rendered. r=fluent-reviewers,flod,jaws
Differential Revision: https://phabricator.services.mozilla.com/D86116
2020-08-13 18:12:04 +00:00
pbz
45a4997b5b Bug 1650795 - Implemented TabDialogBox to show chrome dialogs embedded on tab level. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D83631
2020-08-13 18:43:49 +00:00
Rob Wu
e27ed45f5c Bug 1657992 - Handle middle-click on long-press backForwardMenu only once + tests r=dao
Differential Revision: https://phabricator.services.mozilla.com/D86784
2020-08-12 14:50:42 +00:00
Emma Malysz
81a83433a7 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-10 17:09:55 +00:00
Butkovits Atila
9360ff6a6c Backed out changeset e71e10688704 (bug 1634030) for failure at browser_shim_disable_devtools.js CLOSED TREE 2020-08-08 03:46:14 +03:00
Emma Malysz
974077d255 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-07 22:02:32 +00:00