Commit Graph

25276 Commits

Author SHA1 Message Date
Gijs Kruitbosch
8e978de919 Bug 1701394 - fix tab text moving when tab label direction doesn't match UI direction, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D132580
2021-12-01 17:45:48 +00:00
Gijs Kruitbosch
1810d7b871 Bug 1736701 - fix display of error reporting checkbox on x-frame-options:deny pages, r=pbz,desktop-theme-reviewers
#overrideWeakCryptoPanel was removed in bug 1321778, so the CSS is dead and I removed it.
Otherwise I'm dragging the 2 advanced panel bits into using .hidden instead of
inline CSS, and using the single 'advanced-panel' class to handle more of their styling,
with the box background/border moving to an ID selector to keep it specific to the
bad cert bits.

Differential Revision: https://phabricator.services.mozilla.com/D129027
2021-12-01 14:59:42 +00:00
Narcis Beleuzu
6e9d812757 Backed out 12 changesets (bug 1721217) for bc failures on browser_TopLevelNavigationDelegate.js
Backed out changeset 5fe3c617d521 (bug 1721217)
Backed out changeset c131e4a6d9d5 (bug 1721217)
Backed out changeset a59210a5b400 (bug 1721217)
Backed out changeset 74362b0c39c0 (bug 1721217)
Backed out changeset c8075b91d660 (bug 1721217)
Backed out changeset 46512deaf0e5 (bug 1721217)
Backed out changeset b38bc569d227 (bug 1721217)
Backed out changeset ee9bd012fda8 (bug 1721217)
Backed out changeset 7aa2726a0982 (bug 1721217)
Backed out changeset 885ced5f4bb4 (bug 1721217)
Backed out changeset 7d3f99ca3f44 (bug 1721217)
Backed out changeset 2f5a0164679a (bug 1721217)
2021-12-01 03:38:10 +02:00
Mark Banner
4aaadc5fa2 Bug 1743568 - Add functionality to tabbrowser to allow running the beforeunload handler separate to the removing tabs call. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D132462
2021-11-30 22:01:37 +00:00
Tim Giles
b3a6350a15 Bug 1739390 - Remove Lockwise branding in about:logins. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D131862
2021-11-30 18:44:14 +00:00
Anny Gakhokidze
45acd46f45 Bug 1721217 - Part 5: Change the error code when we cancel loads due to another one starting, r=nika
This allows us to move away from using IsNavigating field in parent-controlled
paths.  Use a new distinct error code in cases when we cancel loads in
Canonical BC due to another load starting. This way, we know to not reset the
urlbar if we are doing another load.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1721217#c10 for longer
explanation of what is going on here.

Differential Revision: https://phabricator.services.mozilla.com/D126845
2021-11-30 16:31:36 +00:00
Anny Gakhokidze
259a6bf8c6 Bug 1721217 - Part 4: Fix search tests to wait for a stop event a bit longer, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D126844
2021-11-30 16:31:35 +00:00
Makoto Kato
39ea02ab99 Bug 1659780 - Remove discovery support for second-screen devices. r=Gijs,geckoview-reviewers,agi
"Send Video to Device" feature is gone in desktop and mobile, and also,
we removed Presentation API implementation, so this is unnecessary now.

Differential Revision: https://phabricator.services.mozilla.com/D132330
2021-11-30 03:12:06 +00:00
Tim Huang
01b56a2f66 Bug 1742582 - Add 'URLQueryStrippingListService.jsm' into browser_startup_content.js and browser_startup_content_subframe.js. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D132227
2021-11-29 22:26:01 +00:00
Alexandru Michis
f210f5d40e Backed out 3 changesets (bug 1742582) for causing bc failures in browser_startup_content_subframe.js
CLOSED TREE

Backed out changeset a9e341a38fae (bug 1742582)
Backed out changeset a9ba4a859295 (bug 1742582)
Backed out changeset bd9307118864 (bug 1742582)
2021-11-29 18:45:04 +02:00
Tim Huang
13ec4c8cc8 Bug 1742582 - Add 'URLQueryStrippingListService.jsm' into browser_startup_content.js. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D132227
2021-11-29 14:57:20 +00:00
Gijs Kruitbosch
17c9c06a19 Bug 1742801 - do not consume the user gesture from ClickHandlerChild if ClickHandlerParent will ignore the click anyway, r=edgar
This commit does a couple of things:
- move whereToOpenLink and getRootEvent implementations into BrowserUtils,
  so they can be used from the child process.
- forward callers in utilityOverlay.js to the BrowserUtils ones
  (bug 1742889 will get rid of the forwarding and update all the callers;
   we might be able to get this and bug 1739929 into beta if risk is low
   enough, and touching a bunch of extra files really doesn't help with
   that)
- move the lazy-load of BrowserUtils from browser.js to utilityOverlay.js
  This is safe because everywhere that loads browser.js also loads
  utilityOverlay.js. It's needed because there are some places that use
  utilityOverlay.js but not browser.js, and so now they need access to
  BrowserUtils.jsm.
- use whereToOpenLink to determine if we should avoid consuming the transient
  user gesture activation in the child click handling code.
- add an automated test based on the testcase in the bug.

When working on this, I initially put the check using whereToOpenLink in
the toplevel of the function, and then when I ran places test to check that
I hadn't broken any places consumers of whereToOpenLink or getRootEvent,
realized that I had broken `browser_markPageAsFollowedLink.js`, because it
relies on "normal" (ie no modifier key, left button) link clicks making it
to ClickHandlerParent.jsm . I filed bug 1742894 about this. I've not tried
to fix that here, instead I've tried to ensure that paths through this
function are as untouched as possible while still fixing bug 1739929 and
bug 1742801.

Differential Revision: https://phabricator.services.mozilla.com/D132102
2021-11-25 22:49:00 +00:00
Marian-Vasile Laza
00e5585606 Bug 502258 - lint fix r=fix CLOSED TREE 2021-11-26 02:23:17 +02:00
Narcis Beleuzu
96c4882d22 Backed out 11 changesets (bug 1721217) for bc failures on browser_scrollPositions.js . CLOSED TREE
Backed out changeset 750f4a84b30e (bug 1721217)
Backed out changeset c4eb4ad769ad (bug 1721217)
Backed out changeset 81af11d67439 (bug 1721217)
Backed out changeset 548f2441b7c6 (bug 1721217)
Backed out changeset cd584129321a (bug 1721217)
Backed out changeset f5f5291d1da8 (bug 1721217)
Backed out changeset 9ad66ceec1e2 (bug 1721217)
Backed out changeset 10b53a21bb23 (bug 1721217)
Backed out changeset 3755cfbe22fe (bug 1721217)
Backed out changeset 71436dc6c4c4 (bug 1721217)
Backed out changeset ecf33b73ae60 (bug 1721217)
2021-11-26 01:51:03 +02:00
Emilio Cobos Álvarez
89a56c2178 Bug 502258 - Don't enable the pref explicitly in context menu test.
Since there's accesskey conflicts with every single letter of the word,
which cause test failures.

MANUAL PUSH: Orange fix CLOSED TREE
2021-11-26 00:50:18 +01:00
Emilio Cobos Alvarez
d388fbd1f1 Bug 1742696 - Opt-in a bunch of about:pages to dark system colors / form controls. r=Gijs,preferences-reviewers,webcompat-reviewers,twisniewski
Privileged pages do this automatically via:

  https://searchfox.org/mozilla-central/rev/aa8c75b83f636948f708986173965c84cae8c25f/widget/nsXPLookAndFeel.cpp#1179-1183

So this makes everything more consistent. Known exceptions:

 * Pocket panels (as those don't seem to support dark mode)
 * about:reader (because it has its own dark mode handling)

Differential Revision: https://phabricator.services.mozilla.com/D132019
2021-11-25 21:24:43 +00:00
Anny Gakhokidze
a81e51b3a2 Bug 1721217 - Part 5: Change the error code when we cancel loads due to another one starting, r=nika
This allows us to move away from using IsNavigating field in parent-controlled
paths.  Use a new distinct error code in cases when we cancel loads in
Canonical BC due to another load starting. This way, we know to not reset the
urlbar if we are doing another load.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1721217#c10 for longer
explanation of what is going on here.

Differential Revision: https://phabricator.services.mozilla.com/D126845
2021-11-25 20:40:58 +00:00
Anny Gakhokidze
03175760b4 Bug 1721217 - Part 4: Fix search tests to wait for a stop event a bit longer, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D126844
2021-11-25 20:40:58 +00:00
Emilio Cobos Álvarez
54e796f48d Bug 502258 - Add a Show Password button to <input type=password> controls. r=Gijs
It's controlled by the pref:
layout.forms.input-type-show-password-button.enabled

Differential Revision: https://phabricator.services.mozilla.com/D130407
2021-11-25 20:12:05 +00:00
Benjamin VanderSloot
1793417017 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 18:25:58 +00:00
Marian-Vasile Laza
88f9e0defb Backed out 3 changesets (bug 1731739) for causing build bustages on PermissionManager.cpp.
Backed out changeset 2f723b6e625b (bug 1731739)
Backed out changeset 7b053cfeab3e (bug 1731739)
Backed out changeset c4a31c29c441 (bug 1731739)
2021-11-23 19:06:14 +02:00
Benjamin VanderSloot
5ad5689e47 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 16:18:42 +00:00
lamoure6
6ef1e5005d Bug 1719938 - Removed remaining (non-negated) -moz-proton media queries. r=mhowell,mtigley,emilio
Differential Revision: https://phabricator.services.mozilla.com/D125328
2021-11-22 22:10:33 +00:00
Chris H-C
cf1dbf4350 Bug 1741674 - Advise in each metrics.yaml that we have docs for adding metrics r=TravisLong,nalexander
Depends on D131639

Differential Revision: https://phabricator.services.mozilla.com/D131640
2021-11-22 20:07:38 +00:00
Tom Ritter
ff76928a07 Bug 1742116: Remove a test for dead functionality r=dao
Differential Revision: https://phabricator.services.mozilla.com/D131636
2021-11-22 16:12:21 +00:00
Paul Zuehlcke
0ca511ff0f Bug 1739091, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131268
2021-11-22 16:11:45 +00:00
Christoph Kerschbaumer
c78a87d7c0 Bug 1742351: Update more browser/ tests to be compliant with https-first mode r=extension-reviewers,Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D131773
2021-11-22 14:26:32 +00:00
Iulian Moraru
43773e005d Backed out changeset 7d9cd61d95ce (bug 1742351) for causing bc failures on browser_paste_event_at_middle_click_on_link.js. CLOSED TREE 2021-11-22 14:14:16 +02:00
Christoph Kerschbaumer
5c4ef2e2bd Bug 1742351: Update more browser/ tests to be compliant with https-first mode r=extension-reviewers,Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D131773
2021-11-22 10:49:45 +00:00
Butkovits Atila
64c919921c Backed out changeset 8c47ea741114 (bug 1742111) for causing Bug 1742237. a=backout 2021-11-21 12:15:20 +02:00
Tomislav Jovanovic
7ffa93f7fd Bug 1708193 - Remove mozapps/extensions/internal/Content.js r=rpl
Use Extension:FlushJarCache listener in ExtensionProcessScript.jsm instead,
it's already loaded everywhere and early enough from AddonManager.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D129952
2021-11-20 13:10:58 +00:00
Dão Gottwald
5a92660e3d Bug 1742111 - Rename internal accentcolor and textcolor properties to be more consistent with the webext theme API. r=harry
Differential Revision: https://phabricator.services.mozilla.com/D131634
2021-11-19 20:00:07 +00:00
Dão Gottwald
8e2dd34f81 Bug 1734835 - Remove the arrow and arrowbox elements from "arrow" panels. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131616
2021-11-19 19:58:50 +00:00
Paul Zuehlcke
bedab23a94 Bug 1740232 - Add telemetry for the privacy.restrict3rdpartystorage.rollout.enabledByDefault pref. r=anti-tracking-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D130740
2021-11-18 20:21:29 +00:00
Norisz Fay
4fadf4570f Backed out changeset 32aba4f911e2 (bug 1740232) for causing build bustages on TelemetryScalarData.h CLOSED TREE 2021-11-18 20:24:18 +02:00
Paul Zuehlcke
da06768d88 Bug 1740232 - Add telemetry for the privacy.restrict3rdpartystorage.rollout.enabledByDefault pref. r=anti-tracking-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D130740
2021-11-18 18:05:52 +00:00
Hannah Peuckmann
eaa83bea9a Bug 1702983 - Display WebAuthn Attestation body of text in non bold. r=pbz,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D131049
2021-11-18 17:13:51 +00:00
Emilio Cobos Álvarez
8064f0a229 Bug 1741666 - Don't rely on global look-and-feel-changed notification in ToolbarIconColor. r=Gijs
It might fire before styles are invalidated, so it might cache the wrong
styles.

Instead, fire an event on the window once everything in that window has
been invalidated, not just the global theme.

This is causing failures with the patch in bug 1740089, since after that
patch `browser_ext_browserAction_theme_icons` trigger the theme changes
when switching from dark to default mode or similar.

Differential Revision: https://phabricator.services.mozilla.com/D131396
2021-11-17 18:03:09 +00:00
Julian Descottes
62d7925d62 Bug 1741369 - [devtools] Update paths to loader files outside devtools/ r=perftest-reviewers,preferences-reviewers,sparky,Gijs
Depends on D131217

Differential Revision: https://phabricator.services.mozilla.com/D131218
2021-11-17 12:43:27 +00:00
Niklas Goegge
4e4ae334a9 Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-17 11:04:34 +00:00
criss
350a48be09 Backed out 2 changesets (bug 1617611) for causing mochitest failures on storageAccessWithDynamicFpi.js. CLOSED TREE
Backed out changeset fdb2c6bfc0c6 (bug 1617611)
Backed out changeset c3352f4b3681 (bug 1617611)
2021-11-16 13:02:05 +02:00
Niklas Goegge
76c2b4259c Bug 1617611: Annotate each failing test individually. r=webdriver-reviewers,necko-reviewers,ckerschb,whimboo,valentin
Annotating each test individually lets us avoid introducing new failing tests
while we go through the backlog of failing tests.

Depends on D129162

Differential Revision: https://phabricator.services.mozilla.com/D129163
2021-11-16 10:15:45 +00:00
Niklas Baumgardner
806a8c9ab1 Bug 1704383 - Remove light strip at bottom of about dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D130663
2021-11-11 19:51:10 +00:00
Emilio Cobos Álvarez
92f83cf19e Bug 1739539 - Rename titlebar pref and add migration from old pref. r=mconley
Something like this ought to do?

Differential Revision: https://phabricator.services.mozilla.com/D130858
2021-11-10 21:17:32 +00:00
Harry Twyford
aa8b2ad9a9 Bug 1740300 - Do not send handoff from Private Browsing Mode. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D130772
2021-11-10 16:26:36 +00:00
Dave Townsend
1e602d5571 Bug 1739379: Collect page data in the new schema. r=Standard8,mak
Note that this includes an uplift from MR2-839.

Differential Revision: https://phabricator.services.mozilla.com/D130360
2021-11-09 11:36:58 +00:00
Dave Townsend
cb52d2509a Bug 1739377: Add JSON schemas for page data. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130358
2021-11-09 09:06:06 +00:00
Narcis Beleuzu
071fd29a18 Backed out 2 changesets (bug 1733540, bug 1703357) for causing Bug 1736189
Backed out changeset a4c999428d86 (bug 1703357)
Backed out changeset 0eaa9ccaaf77 (bug 1733540)
2021-11-08 16:23:53 +02:00
Paul Zuehlcke
1621cfe926 Bug 1739619 - Set study prefs for TCP rollout on opt in/out. r=Mardak,anti-tracking-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D130466
2021-11-08 13:11:15 +00:00
raquelvargas
5fa50e2698 Bug 1738245 - Remove OS.File usage from various browser/ tests. r=Standard8,robwu
Differential Revision: https://phabricator.services.mozilla.com/D129972
2021-11-05 16:49:48 +00:00