corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
895,813 Commits 1 Branch 0 Tags
a0b1928d27ddb95f276ace69b1627577b198558d
Commit Graph

132 Commits

Author SHA1 Message Date
Dão Gottwald
5c9f9cced1 Bug 1945463 - [tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237287
 2025-02-10 14:45:16 +00:00
Emilio Cobos Álvarez
81c4d6a66f Bug 1946016 - Remove macOS special case too. r=dao,tabbrowser-reviewers 
Just tested, doesn't change behavior.

Differential Revision: https://phabricator.services.mozilla.com/D236871
 2025-02-05 20:42:47 +00:00
Emilio Cobos Álvarez
f592072c68 Bug 1946016 - Don't be explicit about window size when detaching tabs on Linux. r=dao,tabbrowser-reviewers 
Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.

The reason for the behavior change here is because `outerWidth` before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.

It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.

Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.

Differential Revision: https://phabricator.services.mozilla.com/D236867
 2025-02-05 17:02:24 +00:00
Dão Gottwald
ae8e1343e4 Bug 1945440 - Fix tab drag and drop in RTL mode. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236512
 2025-02-03 14:21:52 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236318
 2025-02-03 10:15:25 +00:00
Dão Gottwald
0093579918 Bug 1945118 - Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236343
 2025-01-31 14:22:14 +00:00
Dão Gottwald
89a390256e Bug 1944844 - Set dropElement before returning early. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D236159
 2025-01-30 14:44:07 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234804
 2025-01-29 18:37:29 +00:00
Emilio Cobos Álvarez
77261b9adc Bug 1943301 - Simplify tab throbber animation syncing. r=dao,tabbrowser-reviewers 
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.

Differential Revision: https://phabricator.services.mozilla.com/D235300
 2025-01-23 15:02:01 +00:00
Dão Gottwald
c4a94bbaa7 Bug 1942176 - Handle context menu key for tab group labels, r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234668
 2025-01-20 15:25:23 +00:00
Dão Gottwald
602f317a6a Bug 1941645 - Stop scrolling to the selected tab when collapsing/expanding a group. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234326
 2025-01-17 11:48:38 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-15 23:07:45 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-13 17:55:32 +00:00
Dão Gottwald
a5e0177580 Bug 1940444 - Uncaught TypeError: can't access property "pinned", middleTab is undefined when attemtping to drag multiple discontinuous tabs while there's a collapsed tab group. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233495
 2025-01-08 16:22:11 +00:00
Dão Gottwald
048a7a56f8 Bug 1940041 - Fix typo. r=tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D233271
 2025-01-06 19:27:45 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers 
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
 2025-01-06 17:08:03 +00:00
Mauro B
35bae9ed07 Bug 1921951 - Fixed linter errors. r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233208
 2025-01-04 12:48:45 +00:00
Mauro B
dea2dbc861 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233205
 2025-01-04 12:48:45 +00:00
Narcis Beleuzu
884122ae28 Backed out changeset 5ddfa4c882b5 (bug 1921951) for lint failures on tabs.js . CLOSED TREE 2025-01-04 02:05:03 +02:00
Mauro B
1cae811100 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233205
 2025-01-03 23:24:54 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers 
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
 2024-12-31 20:03:05 +00:00
Dão Gottwald
8b91d8e6b9 Bug 1935956 - Include group labels in scrollable elements. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232517
 2024-12-19 15:32:48 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-12 12:57:41 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2024-12-11 14:37:38 +00:00
Dão Gottwald
5536b67d3f Bug 1933775 - When you collapse all tab groups on tab strip, open a New tab. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231295
 2024-12-05 20:28:19 +00:00
Nikki Sharpley
6d6ad18210 Bug 1934957 - Remove unnecessary additional shift for expanded vertical pinned tabs drag over r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D230987
 2024-12-04 14:33:35 +00:00
Stephen Thompson
2623aa98bb Bug 1933210 - maintain tab ordering on drop group creation r=dao,tabbrowser-reviewers 
- when creating a group from the front edge of a target tab, the target tab should be the last tab in the group
- when creating a group from the back end of a target tab, the target tab should be the first tab in the group
- the tab group should be created at the position of the target tab

Differential Revision: https://phabricator.services.mozilla.com/D230283
 2024-12-04 02:35:49 +00:00
Nikki Sharpley
9afc398378 Bug 1935026 - Ensure we are using the right scroll position for vertical pinned tabs r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D231017
 2024-12-03 21:27:51 +00:00
Dão Gottwald
db518f5774 Bug 1934296 - Adding a tab to a collapsed group should expand the group. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D230982
 2024-12-03 18:15:28 +00:00
Nikki Sharpley
cb461afb42 Bug 1930929 - Fix vertical pinned tabs drag animation on scroll overflow r=tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D230425
 2024-11-28 15:06:35 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley 
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
 2024-11-28 12:12:51 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE 
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
 2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley 
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
 2024-11-28 03:26:50 +00:00
Dão Gottwald
3245dd9a52 Bug 1928189 - Let Firefox View show tabs from collapsed groups. r=sthompson,fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D229896
 2024-11-26 16:45:56 +00:00
Dão Gottwald
8f56f70b33 Bug 1933258 - Add pref for when to move other tabs out of the way during drag and drop. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D230142
 2024-11-26 16:20:26 +00:00
Dão Gottwald
dceb0661a7 Bug 1932425 - When dragging tabs, move other tabs over when hitting 70% instead of 50% of their width. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D229756
 2024-11-22 10:14:51 +00:00
Adi
ba7e26bf67 Backed out changeset 44fc1ca324c1 (bug 1932425) for causing bc failures @browser_multiselect_tabs_reorder.js. 2024-11-21 21:23:36 +02:00
Dão Gottwald
7cf50a4d97 Bug 1932425 - When dragging tabs, move other tabs over when hitting 70% instead of 50% of their width. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D229756
 2024-11-21 16:52:27 +00:00
Nikki Sharpley
c52bf125ff Bug 1926831 - Remove animation of tab when dropped in blank tab space r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D228722
 2024-11-20 14:34:36 +00:00
Narcis Beleuzu
a680adff4f Backed out changeset 31fba99f4d2d (bug 1926831) for lint failure on tabs.js . CLOSED TREE 2024-11-20 01:17:04 +02:00
Nikki Sharpley
9719411374 Bug 1926831 - Remove animation of tab when dropped in blank tab space r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D228722
 2024-11-19 22:09:07 +00:00
Stephen Thompson
35bab3b13c Bug 1927540 - drop tab into/out of end of tab groups r=dao,tabbrowser-reviewers 
When all tabs are inside of tab groups, this patch allows the user to drag a tab to become a standalone tab at the end of the tab stirp. The user also has the ability to drop the tab into the end of the tab group at the end of the tab strip if the tab is dropped closer to the tab group.

Differential Revision: https://phabricator.services.mozilla.com/D229440
 2024-11-19 20:26:31 +00:00
Dão Gottwald
f537dbd899 Bug 1926382 - Shift group labels along with the group's first tab. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D229122
 2024-11-15 16:30:38 +00:00
Gijs Kruitbosch
a50c45946e Bug 1927094 - optimize lineScrollAmount so it doesn't iterate over all tabs, r=mconley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D226907
 2024-11-14 17:14:50 +00:00
Dão Gottwald
c40a1cb421 Bug 1929898 - Implement pause on drag and drop to create tab group. r=sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D228570
 2024-11-12 16:54:20 +00:00