corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
819,049 Commits 1 Branch 0 Tags
a02f6a1df58f1132b19d9c7c8a6aaba6cf11a620
Commit Graph

100 Commits

Author SHA1 Message Date
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D202255
 2024-02-27 18:52:20 +00:00
Shane Hughes
9c7d018917 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn 
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
 2024-02-27 03:29:29 +00:00
Mark Banner
aefd647018 Bug 1881265 - Enable ESLint recommended rule getter-return. r=mossop,extension-reviewers,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D202318
 2024-02-26 11:35:40 +00:00
Mark Banner
1d4856edef Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers 
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
 2024-02-24 12:21:20 +00:00
Mark Banner
d1f4ef701d Bug 1881573 - Drop use of ESLint rule max-depth from newtab/asrouter/aboutwelcome. r=pdahiya,thecount,Gijs,devtools-reviewers,omc-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D202474
 2024-02-24 10:04:46 +00:00
Mark Banner
55dda230bd Bug 1881817 - Move all asrouter/content-src/*.js files which are modules to use .mjs extensions. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202622
 2024-02-24 10:00:59 +00:00
Mark Banner
3eb6faa5a1 Bug 1881819 - Remove now redundant inject-loader from asrouter/aboutwelcome/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202621
 2024-02-24 10:00:58 +00:00
Mark Banner
3f16c53851 Bug 1881818 - Remove various modules from asrouter/aboutwelcome/newtab as they are now unused. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D202620
 2024-02-24 10:00:58 +00:00
Mike Conley
a72977c483 Bug 1878783 - Retire babel-jsm-to-commonjs since browser JSMs are gone now. r=Standard8,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D201828
 2024-02-15 21:30:05 +00:00
Nick Alexander
8de77add68 Bug 1868676 - Part 1: Allow snapshots of multiple contexts. r=barret,omc-reviewers,aminomancer 
`ASRouterTargeting` does _not_ include the experiment details that
supply `activeExperiments`, `activeRollouts`, etc.  Those are combined
from additional contexts.  This patch makes it easy to do that
combination.

N.b.: the use of `Proxy` instances makes iteration tricky, so we avoid
it entirely.

Differential Revision: https://phabricator.services.mozilla.com/D200124
 2024-02-14 21:31:19 +00:00
Jason Prickett
374892962b Bug 1879390 - Add screen ID to fox doodle r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D201750
 2024-02-14 01:13:23 +00:00
Shane Hughes
47c064fec9 Bug 1877995 - Move feature callout dismiss button so the tab order makes more sense. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D200714
 2024-02-13 23:26:16 +00:00
Mike Conley
587f39ba06 Bug 1878731 - Make it so that ResourceUriPlugin can do multiple path replacements. r=Standard8,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D201139
 2024-02-12 18:49:38 +00:00
Mike Conley
6227d37b2c Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D201138
 2024-02-12 18:49:38 +00:00
Mike Conley
c22c73b7ab Bug 1878731 - Convert ASRouterPreferences to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201134
 2024-02-12 18:49:37 +00:00
Mike Conley
419fa8c4b8 Bug 1878731 - Convert ASRouterTargeting to an ESM. r=emcminn,application-update-reviewers,omc-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D201133
 2024-02-12 18:49:37 +00:00
Mike Conley
bac643012b Bug 1878731 - Convert ASRouterTriggerListeners to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201129
 2024-02-12 18:49:36 +00:00
Mike Conley
92d05e3eef Bug 1878731 - Convert ASRouterDefaultConfig to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201128
 2024-02-12 18:49:36 +00:00
Mike Conley
2f152b878f Bug 1878731 - Convert ASRouterParentProcessMessageHandler to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201127
 2024-02-12 18:49:36 +00:00
Mike Conley
0cd6316b40 Bug 1878731 - Convert CFRPageActions to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201126
 2024-02-12 18:49:35 +00:00
Mike Conley
d322adbf27 Bug 1878731 - Convert OnboardingMessageProvider to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201125
 2024-02-12 18:49:35 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201124
 2024-02-12 18:49:34 +00:00
Mike Conley
af147ef4b2 Bug 1878731 - Convert ToolbarBadgeHub to an ESM. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201123
 2024-02-12 18:49:34 +00:00
Mike Conley
cbeae19a3b Bug 1878281 - Stub out NEWTAB_MESSAGE_REQUEST handling for legacy privileged addons. r=mkaply,omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D201094
 2024-02-09 21:29:46 +00:00
Shane Hughes
d26f937678 Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Fix feature callout teardown while a tour is still ongoing.
Add an option to space out the CTA buttons.
Add dynamic disabling of secondary_button.
Add randomization for the MultiSelect component, mainly for surveys.
Improve test coverage.
Add documentation for the above changes plus some missing things.

Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 22:48:27 +00:00
pstanciu
e5fa393947 Backed out changeset 7aee47be18bf (bug 1879220) for causing node newtab failures at aboutwelcome. CLOSED TREE 2024-02-08 17:55:42 +02:00
Shane Hughes
ebe66ac58f Bug 1879220 - Adjust feature callout surface to handle panel surveys. r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201027
 2024-02-08 12:30:25 +00:00
Mark Banner
b3b56aa2eb Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-07 08:55:33 +00:00
Mark Banner
12a8012f22 Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-07 08:55:32 +00:00
Mark Banner
cd218db908 Bug 1878554 - Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
These rules are node specific and not really useful in mozilla central:
handle-callback-err, no-buffer-constructor, no-path-concat, no-process-exit
These rules are not useful as require is only used in configurations:
no-new-require, no-mixed-requires
Prettier already enforces max-statements-per-line
lines-between-class-members isn't handled separately, but if we want to do that we should decide on it globally.

Differential Revision: https://phabricator.services.mozilla.com/D200588
 2024-02-07 08:55:31 +00:00
Mark Banner
8ce0ecbf74 Bug 1878554 - Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
We decided not to use the rule in bug 1381030.

Differential Revision: https://phabricator.services.mozilla.com/D200587
 2024-02-07 08:55:31 +00:00
Mark Banner
97359cbfd0 Bug 1878554 - Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
It is already enabled as a recommended rule.

Differential Revision: https://phabricator.services.mozilla.com/D200586
 2024-02-07 08:55:31 +00:00
Mark Banner
257b6d2dc7 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-07 08:55:30 +00:00
Mark Banner
120bc96610 Bug 1878554 - Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers 
The parser option was added globally for jsx files in bug 1878009.

Differential Revision: https://phabricator.services.mozilla.com/D200584
 2024-02-07 08:55:30 +00:00
Mark Banner
c4f2b2d3ac Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-07 08:55:29 +00:00
Mark Banner
b516bcb516 Bug 1878553 - For ESLint, expect all jsx files to be ES modules. r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200581
 2024-02-07 08:55:29 +00:00
Cristian Tuns
8829a8d6c5 Backed out 11 changesets (bug 1878554, bug 1878553, bug 1878556) for causing node failures in aboutwelcome CLOSED TREE 
Backed out changeset 425f70fa7e5a (bug 1878556)
Backed out changeset 2ab3a28f5c04 (bug 1878556)
Backed out changeset fb2e02682c8c (bug 1878556)
Backed out changeset 2fc5e630568e (bug 1878554)
Backed out changeset 78839d5841b4 (bug 1878554)
Backed out changeset e0ab31d2de1b (bug 1878554)
Backed out changeset 4eb59e4ebafa (bug 1878554)
Backed out changeset ab1e077d3f84 (bug 1878554)
Backed out changeset ef999f293e3e (bug 1878553)
Backed out changeset cf49920cb1ad (bug 1878553)
Backed out changeset 95f0fce63726 (bug 1878553)
 2024-02-07 01:26:39 -05:00
Mark Banner
f15c9c508b Bug 1878556 - Remove unused asrouter/content-src/template-utils.js. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200591
 2024-02-06 22:32:55 +00:00
Mark Banner
ed1bb292be Bug 1878556 - Move addUtmParams.js to aboutwelcome and rename to .mjs. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200590
 2024-02-06 22:32:54 +00:00
Mark Banner
c19488bd61 Bug 1878554 - Remove deprecated ESLint rules from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
These rules are node specific and not really useful in mozilla central:
handle-callback-err, no-buffer-constructor, no-path-concat, no-process-exit
These rules are not useful as require is only used in configurations:
no-new-require, no-mixed-requires
Prettier already enforces max-statements-per-line
lines-between-class-members isn't handled separately, but if we want to do that we should decide on it globally.

Differential Revision: https://phabricator.services.mozilla.com/D200588
 2024-02-06 22:32:53 +00:00
Mark Banner
41bdb28228 Bug 1878554 - Remove ESLint rule require-await for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
We decided not to use the rule in bug 1381030.

Differential Revision: https://phabricator.services.mozilla.com/D200587
 2024-02-06 22:32:53 +00:00
Mark Banner
f68e745450 Bug 1878554 - Remove ESLint rule for-direction reference from aboutwelcome/asrouter/newtab configs. r=aminomancer,omc-reviewers 
It is already enabled as a recommended rule.

Differential Revision: https://phabricator.services.mozilla.com/D200586
 2024-02-06 22:32:52 +00:00
Mark Banner
617d0bb8f5 Bug 1878554 - Simplify react/jsx-no-bind definition for aboutwelcome/asrouter/newtab code. r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200585
 2024-02-06 22:32:52 +00:00
Mark Banner
b5d681b88e Bug 1878554 - Remove now unnecessary jsx features setting for ESLint for aboutwelcome/asrouter/newtab. r=aminomancer,omc-reviewers 
The parser option was added globally for jsx files in bug 1878009.

Differential Revision: https://phabricator.services.mozilla.com/D200584
 2024-02-06 22:32:52 +00:00
Mark Banner
7fdf48bc1f Bug 1878553 - Define *.config.(m)js files as node based for ESLint. r=mossop,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200582
 2024-02-06 22:32:51 +00:00
Mark Banner
832805759a Bug 1878553 - For ESLint, expect all jsx files to be ES modules. r=mossop,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200581
 2024-02-06 22:32:50 +00:00
Mike Conley
b27d0377c8 Bug 1877196 - Move PageEventManager.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200515
 2024-02-05 22:03:16 +00:00
Mike Conley
65ab386408 Bug 1877196 - Move FeatureCallout modules and styles to browser/components/asrouter. r=fxview-reviewers,omc-reviewers,sclements,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D200514
 2024-02-05 22:03:16 +00:00
Mike Conley
02fbf941fd Bug 1877196 - Move ActorConstants.sys.mjs to browser/components/asrouter. r=pdahiya,omc-reviewers 
We import the ActorConstants into the ASRouter unit-entry.js script because
ASRouterChild.sys.mjs loads ActorConstants.sys.mjs, and the ResourceUriPlugin
that does the rewriting for the Karma tests doesn't understand how to do
remapping outside of the newtab folder.

So instead of trying to hack that capability into ResourceUriPlugin, we
just import the ActorConstants into the Karma global scope.

Differential Revision: https://phabricator.services.mozilla.com/D200087
 2024-02-05 22:03:15 +00:00
Mike Conley
12a99679c5 Bug 1877196 - Move browser_asrouter tests to browser/components/asrouter. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200086
 2024-02-05 22:03:15 +00:00